[GitHub] spark pull request #14332: [SPARK-16694] [CORE] Use for/foreach rather than ...

2016-07-24 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14332#discussion_r72009839 --- Diff: examples/src/main/scala/org/apache/spark/examples/ml/DataFrameExample.scala --- @@ -54,14 +54,13 @@ object DataFrameExample { }

[GitHub] spark pull request #14132: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

2016-07-24 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14132#discussion_r72010521 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1774,6 +1775,49 @@ class Analyzer( }

[GitHub] spark pull request #14331: [SPARK-16691][SQL] move BucketSpec to catalyst mo...

2016-07-24 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14331#discussion_r72010784 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala --- @@ -173,8 +190,18 @@ case class CatalogTable(

[GitHub] spark issue #14334: [SPARK-16703][SQL] Fixes window specification SQL format

2016-07-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14334 **[Test build #62797 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62797/consoleFull)** for PR 14334 at commit

[GitHub] spark issue #14297: [SPARK-16660][SQL] CreateViewCommand should not take Cat...

2016-07-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14297 **[Test build #62786 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62786/consoleFull)** for PR 14297 at commit

[GitHub] spark pull request #14132: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

2016-07-24 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14132#discussion_r72011394 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1774,6 +1775,49 @@ class Analyzer( }

[GitHub] spark issue #14333: [SPARK-16696][ML][MLLib] destroy KMeans bcNewCenters whe...

2016-07-24 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14333 I don't understand the last change. As far as I can see it can be destroyed inside the loop iteration. It's also possible to reuse the broadcast (declare outside the loop), and unpersist each

[GitHub] spark pull request #14335: [SPARK-16697][ML][MLLib] improve LDA submitMiniBa...

2016-07-24 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14335#discussion_r72011821 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala --- @@ -472,12 +473,13 @@ final class OnlineLDAOptimizer extends

[GitHub] spark pull request #14283: [SPARK-16645][SQL] rename CatalogStorageFormat.se...

2016-07-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14283 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #14338: Make parameters configurable in BlockManager

2016-07-24 Thread lovexi
GitHub user lovexi opened a pull request: https://github.com/apache/spark/pull/14338 Make parameters configurable in BlockManager ## What changes were proposed in this pull request? Make parameters configurable in BlockManager class, such as max_attempts and sleep_time

[GitHub] spark issue #14331: [SPARK-16691][SQL] move BucketSpec to catalyst module an...

2016-07-24 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14331 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #14333: [SPARK-16696][ML][MLLib] unused broadcast variables do d...

2016-07-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14333 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62778/ Test FAILed. ---

[GitHub] spark issue #14333: [SPARK-16696][ML][MLLib] unused broadcast variables do d...

2016-07-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14333 **[Test build #62778 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62778/consoleFull)** for PR 14333 at commit

[GitHub] spark issue #14333: [SPARK-16696][ML][MLLib] unused broadcast variables do d...

2016-07-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14333 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13738: [SPARK-11227][CORE] UnknownHostException can be thrown w...

2016-07-24 Thread sarutak
Github user sarutak commented on the issue: https://github.com/apache/spark/pull/13738 Sorry for the late response. I'll try it the way you mentioned. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #14333: [SPARK-16696][ML][MLLib] unused broadcast variables do d...

2016-07-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14333 **[Test build #62778 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62778/consoleFull)** for PR 14333 at commit

[GitHub] spark issue #14333: [SPARK-16696][ML][MLLib] unused broadcast variables do d...

2016-07-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14333 **[Test build #62779 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62779/consoleFull)** for PR 14333 at commit

[GitHub] spark pull request #14339: [SPARK-16698][SQL] Field names having dots should...

2016-07-24 Thread HyukjinKwon
GitHub user HyukjinKwon opened a pull request: https://github.com/apache/spark/pull/14339 [SPARK-16698][SQL] Field names having dots should be allowed for datasources based on FileFormat ## What changes were proposed in this pull request? It seems this is a regression

[GitHub] spark issue #13382: [SPARK-5581][Core] When writing sorted map output file, ...

2016-07-24 Thread JoshRosen
Github user JoshRosen commented on the issue: https://github.com/apache/spark/pull/13382 LGTM as well, so I'm going to merge this into master for inclusion in Spark 2.1.0. Thanks @dafrista for writing this and to @ericl for helping with review. --- If your project is set up for it,

[GitHub] spark issue #13077: [SPARK-10748] [Mesos] Log error instead of crashing Spar...

2016-07-24 Thread tnachen
Github user tnachen commented on the issue: https://github.com/apache/spark/pull/13077 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark pull request #14340: [SPARK-16534][Streaming][Kafka] Add Python API su...

2016-07-24 Thread jerryshao
GitHub user jerryshao opened a pull request: https://github.com/apache/spark/pull/14340 [SPARK-16534][Streaming][Kafka] Add Python API support for Kafka 0.10 connector ## What changes were proposed in this pull request? This PR adds the support of Python API for Spark

[GitHub] spark issue #14339: [SPARK-16698][SQL] Field names having dots should be all...

2016-07-24 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/14339 can we test it in `SQLQuerySuite` or something? I think `FileSourceStrategySuite` should be used to test the strategy. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request #14313: [SPARK-16674][SQL] Avoid per-record type dispatch...

2016-07-24 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14313#discussion_r72005309 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -322,46 +322,135 @@ private[sql] class JDBCRDD(

[GitHub] spark issue #14331: [SPARK-16691][SQL] move BucketSpec to catalyst module an...

2016-07-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14331 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14327: [SPARK-16686][SQL] Project shouldn't be pushed down thro...

2016-07-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14327 **[Test build #62788 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62788/consoleFull)** for PR 14327 at commit

[GitHub] spark issue #14327: [SPARK-16686][SQL] Project shouldn't be pushed down thro...

2016-07-24 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/14327 Besides, according to the JIRA, this may need to be backported to 1.6. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark issue #14313: [SPARK-16674][SQL] Avoid per-record type dispatch in JDB...

2016-07-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14313 **[Test build #62789 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62789/consoleFull)** for PR 14313 at commit

[GitHub] spark issue #14313: [SPARK-16674][SQL] Avoid per-record type dispatch in JDB...

2016-07-24 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14313 @cloud-fan I just addressed your comments. I added another argument in `JDBCConversion` for `MutableRow` so that we can avoid type-boxing. --- If your project is set up for it, you can reply

[GitHub] spark pull request #14313: [SPARK-16674][SQL] Avoid per-record type dispatch...

2016-07-24 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14313#discussion_r72008447 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -322,46 +322,133 @@ private[sql] class JDBCRDD(

[GitHub] spark pull request #14341: [Minor][Doc][SQL] Fix two documents regarding siz...

2016-07-24 Thread viirya
GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/14341 [Minor][Doc][SQL] Fix two documents regarding size in bytes ## What changes were proposed in this pull request? Fix two places in SQLConf documents regarding size in bytes and statistics.

[GitHub] spark pull request #14313: [SPARK-16674][SQL] Avoid per-record type dispatch...

2016-07-24 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14313#discussion_r72008403 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -322,46 +322,133 @@ private[sql] class JDBCRDD(

[GitHub] spark issue #14341: [Minor][Doc][SQL] Fix two documents regarding size in by...

2016-07-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14341 **[Test build #62790 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62790/consoleFull)** for PR 14341 at commit

[GitHub] spark pull request #14339: [SPARK-16698][SQL] Field names having dots should...

2016-07-24 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14339#discussion_r72008560 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -2982,4 +2982,19 @@ class SQLQuerySuite extends QueryTest with

[GitHub] spark pull request #14327: [SPARK-16686][SQL] Project shouldn't be pushed do...

2016-07-24 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/14327#discussion_r72008576 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -150,11 +150,13 @@ class SimpleTestOptimizer extends

[GitHub] spark issue #14339: [SPARK-16698][SQL] Field names having dots should be all...

2016-07-24 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/14339 LGTM, cc @liancheng to take another look --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #14337: [SPARK-16699][SQL] Fix performance bug in hash ag...

2016-07-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14337 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #14337: [SPARK-16699][SQL] Fix performance bug in hash aggregate...

2016-07-24 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14337 @ooq next time please open a pull request against master branch rather than 2.0. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark issue #13077: [SPARK-10748] [Mesos] Log error instead of crashing Spar...

2016-07-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13077 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13077: [SPARK-10748] [Mesos] Log error instead of crashing Spar...

2016-07-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13077 **[Test build #62783 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62783/consoleFull)** for PR 13077 at commit

[GitHub] spark issue #14313: [SPARK-16674][SQL] Avoid per-record type dispatch in JDB...

2016-07-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14313 **[Test build #62792 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62792/consoleFull)** for PR 14313 at commit

[GitHub] spark issue #14339: [SPARK-16698][SQL] Field names having dots should be all...

2016-07-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14339 **[Test build #62785 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62785/consoleFull)** for PR 14339 at commit

[GitHub] spark pull request #14327: [SPARK-16686][SQL] Project shouldn't be pushed do...

2016-07-24 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/14327#discussion_r72009385 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -150,11 +150,13 @@ class SimpleTestOptimizer extends

[GitHub] spark issue #14339: [SPARK-16698][SQL] Field names having dots should be all...

2016-07-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14339 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14339: [SPARK-16698][SQL] Field names having dots should be all...

2016-07-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14339 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62785/ Test PASSed. ---

[GitHub] spark pull request #14332: [SPARK-16694] [CORE] Use for/foreach rather than ...

2016-07-24 Thread markhamstra
Github user markhamstra commented on a diff in the pull request: https://github.com/apache/spark/pull/14332#discussion_r7120 --- Diff: examples/src/main/scala/org/apache/spark/examples/ml/DataFrameExample.scala --- @@ -54,14 +54,13 @@ object DataFrameExample { }

[GitHub] spark issue #14297: [SPARK-16660][SQL] CreateViewCommand should not take Cat...

2016-07-24 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/14297 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #14297: [SPARK-16660][SQL] CreateViewCommand should not take Cat...

2016-07-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14297 **[Test build #62775 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62775/consoleFull)** for PR 14297 at commit

[GitHub] spark pull request #14302: [SPARK-16663][SQL] desc table should be consisten...

2016-07-24 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14302#discussion_r72001037 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala --- @@ -520,7 +522,7 @@ case class DescribeTableCommand(table:

[GitHub] spark issue #14204: [SPARK-16520] [WEBUI] Link executors to corresponding wo...

2016-07-24 Thread nblintao
Github user nblintao commented on the issue: https://github.com/apache/spark/pull/14204 @yhuai Does the column exist? Are all of the cells in the column blank? That's weird. It was OK when I committed. I'll check it out later. --- If your project is set up for it, you can reply

[GitHub] spark issue #14331: [SPARK-16691][SQL] move BucketSpec to catalyst module an...

2016-07-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14331 **[Test build #62776 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62776/consoleFull)** for PR 14331 at commit

[GitHub] spark pull request #14327: [SPARK-16686][SQL] Project shouldn't be pushed do...

2016-07-24 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/14327#discussion_r72002405 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala --- @@ -422,6 +422,32 @@ class DatasetSuite extends QueryTest with

[GitHub] spark issue #13051: [SPARK-15271] [MESOS] Allow force pulling executor docke...

2016-07-24 Thread tnachen
Github user tnachen commented on the issue: https://github.com/apache/spark/pull/13051 @srowen Or if you could help :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #14327: [SPARK-16686][SQL] Project shouldn't be pushed down thro...

2016-07-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14327 **[Test build #62782 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62782/consoleFull)** for PR 14327 at commit

[GitHub] spark issue #13382: [SPARK-5581][Core] When writing sorted map output file, ...

2016-07-24 Thread dafrista
Github user dafrista commented on the issue: https://github.com/apache/spark/pull/13382 Great. Thanks @JoshRosen my JIRA username is chobrian. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request #14335: [SPARK-16697][ML][MLLib] improve LDA submitMiniBa...

2016-07-24 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/14335#discussion_r72003627 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala --- @@ -472,12 +473,13 @@ final class OnlineLDAOptimizer extends

[GitHub] spark issue #13382: [SPARK-5581][Core] When writing sorted map output file, ...

2016-07-24 Thread JoshRosen
Github user JoshRosen commented on the issue: https://github.com/apache/spark/pull/13382 Assigned. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #36: Added a unit test for PairRDDFunctions.lookup

2016-07-24 Thread databricks-jenkins
Github user databricks-jenkins commented on the issue: https://github.com/apache/spark/pull/36 **[Test build #60 has started](https://jenkins.test.databricks.com/job/spark-pull-request-builder/60/consoleFull)** for PR 36 at commit

[GitHub] spark issue #36: Added a unit test for PairRDDFunctions.lookup

2016-07-24 Thread databricks-jenkins
Github user databricks-jenkins commented on the issue: https://github.com/apache/spark/pull/36 **[Test build #60 has finished](https://jenkins.test.databricks.com/job/spark-pull-request-builder/60/consoleFull)** for PR 36 at commit

[GitHub] spark pull request #14339: [SPARK-16698][SQL] Field names having dots should...

2016-07-24 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/14339#discussion_r72004263 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategySuite.scala --- @@ -242,6 +242,22 @@ class

[GitHub] spark issue #14339: [SPARK-16698][SQL] Field names having dots should be all...

2016-07-24 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14339 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark pull request #14313: [SPARK-16674][SQL] Avoid per-record type dispatch...

2016-07-24 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14313#discussion_r72005085 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -322,46 +322,135 @@ private[sql] class JDBCRDD(

[GitHub] spark issue #14297: [SPARK-16660][SQL] CreateViewCommand should not take Cat...

2016-07-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14297 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62775/ Test PASSed. ---

[GitHub] spark pull request #14313: [SPARK-16674][SQL] Avoid per-record type dispatch...

2016-07-24 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14313#discussion_r72005471 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -407,84 +496,8 @@ private[sql] class JDBCRDD(

[GitHub] spark pull request #14313: [SPARK-16674][SQL] Avoid per-record type dispatch...

2016-07-24 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14313#discussion_r72005487 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -322,46 +322,135 @@ private[sql] class JDBCRDD(

[GitHub] spark issue #14339: [SPARK-16698][SQL] Field names having dots should be all...

2016-07-24 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14339 Sure! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #14297: [SPARK-16660][SQL] CreateViewCommand should not take Cat...

2016-07-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14297 **[Test build #62775 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62775/consoleFull)** for PR 14297 at commit

[GitHub] spark issue #14297: [SPARK-16660][SQL] CreateViewCommand should not take Cat...

2016-07-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14297 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #14313: [SPARK-16674][SQL] Avoid per-record type dispatch...

2016-07-24 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14313#discussion_r72005398 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -322,46 +322,135 @@ private[sql] class JDBCRDD(

[GitHub] spark issue #14331: [SPARK-16691][SQL] move BucketSpec to catalyst module an...

2016-07-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14331 **[Test build #62776 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62776/consoleFull)** for PR 14331 at commit

[GitHub] spark issue #14333: [SPARK-16696][ML][MLLib] destroy KMeans bcNewCenters whe...

2016-07-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14333 **[Test build #62793 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62793/consoleFull)** for PR 14333 at commit

[GitHub] spark pull request #13620: [SPARK-15590] [WEBUI] Paginate Job Table in Jobs ...

2016-07-24 Thread nblintao
Github user nblintao commented on a diff in the pull request: https://github.com/apache/spark/pull/13620#discussion_r71999178 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala --- @@ -369,3 +375,246 @@ private[ui] class AllJobsPage(parent: JobsTab) extends

[GitHub] spark issue #14337: [SPARK-16699][SQL] Fix performance bug in hash aggregate...

2016-07-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14337 **[Test build #62774 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62774/consoleFull)** for PR 14337 at commit

[GitHub] spark issue #14337: [SPARK-16699][SQL] Fix performance bug in hash aggregate...

2016-07-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14337 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62774/ Test PASSed. ---

[GitHub] spark issue #14283: [SPARK-16645][SQL] rename CatalogStorageFormat.serdeProp...

2016-07-24 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/14283 thanks for the review, merging to master! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #14334: [MINOR][SQL] Fixes window specification SQL format

2016-07-24 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14334 Hi, @liancheng . The failure is due to `LogicalPlanToSQLSuite`. It verifies the generated SQLs. Please use the following command to update the generated SQL answer sets. ```bash

[GitHub] spark issue #14338: [SPARK-16701] Make parameters configurable in BlockManag...

2016-07-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14338 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #14333: [SPARK-16696][ML][MLLib] unused broadcast variables do d...

2016-07-24 Thread WeichenXu123
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/14333 @srowen The `bcNewCenters` in `KMeans` has some problem. Check the code logic in detail, we can find that in each loop, it should destroy the broadcast var `bcNewCenters` generated in

[GitHub] spark pull request #14335: [SPARK-16697][ML][MLLib] improve LDA submitMiniBa...

2016-07-24 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/14335#discussion_r72003530 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala --- @@ -472,12 +473,13 @@ final class OnlineLDAOptimizer extends

[GitHub] spark issue #14340: [SPARK-16534][Streaming][Kafka] Add Python API support f...

2016-07-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14340 **[Test build #62784 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62784/consoleFull)** for PR 14340 at commit

[GitHub] spark issue #14339: [SPARK-16698][SQL] Field names having dots should be all...

2016-07-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14339 **[Test build #62785 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62785/consoleFull)** for PR 14339 at commit

[GitHub] spark pull request #14313: [SPARK-16674][SQL] Avoid per-record type dispatch...

2016-07-24 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/14313#discussion_r72005232 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -407,84 +496,8 @@ private[sql] class JDBCRDD(

[GitHub] spark issue #14333: [SPARK-16696][ML][MLLib] fix KMeans bcNewCenters unpersi...

2016-07-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14333 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14333: [SPARK-16696][ML][MLLib] fix KMeans bcNewCenters unpersi...

2016-07-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14333 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62779/ Test PASSed. ---

[GitHub] spark pull request #14313: [SPARK-16674][SQL] Avoid per-record type dispatch...

2016-07-24 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14313#discussion_r72005172 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -407,84 +496,8 @@ private[sql] class JDBCRDD(

[GitHub] spark issue #14333: [SPARK-16696][ML][MLLib] fix KMeans bcNewCenters unpersi...

2016-07-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14333 **[Test build #62779 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62779/consoleFull)** for PR 14333 at commit

[GitHub] spark issue #14331: [SPARK-16691][SQL] move BucketSpec to catalyst module an...

2016-07-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14331 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62776/ Test PASSed. ---

[GitHub] spark issue #14331: [SPARK-16691][SQL] move BucketSpec to catalyst module an...

2016-07-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14331 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62777/ Test PASSed. ---

[GitHub] spark issue #14331: [SPARK-16691][SQL] move BucketSpec to catalyst module an...

2016-07-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14331 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14331: [SPARK-16691][SQL] move BucketSpec to catalyst module an...

2016-07-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14331 **[Test build #62777 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62777/consoleFull)** for PR 14331 at commit

[GitHub] spark issue #14327: [SPARK-16686][SQL] Project shouldn't be pushed down thro...

2016-07-24 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/14327 cc @cloud-fan @liancheng @yhuai Please review this change. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request #14313: [SPARK-16674][SQL] Avoid per-record type dispatch...

2016-07-24 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/14313#discussion_r72007301 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -407,84 +496,8 @@ private[sql] class JDBCRDD(

[GitHub] spark issue #14327: [SPARK-16686][SQL] Project shouldn't be pushed down thro...

2016-07-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14327 **[Test build #62782 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62782/consoleFull)** for PR 14327 at commit

[GitHub] spark pull request #14132: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

2016-07-24 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14132#discussion_r72008134 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1774,6 +1775,49 @@ class Analyzer( }

[GitHub] spark issue #14340: [SPARK-16534][Streaming][Kafka] Add Python API support f...

2016-07-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14340 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14340: [SPARK-16534][Streaming][Kafka] Add Python API support f...

2016-07-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14340 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62784/ Test FAILed. ---

[GitHub] spark issue #14340: [SPARK-16534][Streaming][Kafka] Add Python API support f...

2016-07-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14340 **[Test build #62784 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62784/consoleFull)** for PR 14340 at commit

[GitHub] spark pull request #14327: [SPARK-16686][SQL] Project shouldn't be pushed do...

2016-07-24 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14327#discussion_r72008673 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -150,11 +150,13 @@ class SimpleTestOptimizer extends

[GitHub] spark issue #14341: [Minor][Doc][SQL] Fix two documents regarding size in by...

2016-07-24 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/14341 cc @cloud-fan @liancheng Just minor document changes. Please review if this change is proper. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request #14296: [SPARK-16639][SQL] The query with having conditio...

2016-07-24 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14296#discussion_r72009599 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -46,6 +46,14 @@ class SQLQuerySuite extends QueryTest with

[GitHub] spark pull request #14342: [SPARK-16685] Remove audit-release scripts.

2016-07-24 Thread rxin
GitHub user rxin opened a pull request: https://github.com/apache/spark/pull/14342 [SPARK-16685] Remove audit-release scripts. ## What changes were proposed in this pull request? This patch removes dev/audit-release. It was initially created to do basic release auditing, but we

  1   2   3   >