[GitHub] spark issue #18804: [SPARK-21599][SQL] Collecting column statistics for data...

2017-08-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18804 **[Test build #80192 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80192/testReport)** for PR 18804 at commit

[GitHub] spark issue #18804: [SPARK-21599][SQL] Collecting column statistics for data...

2017-08-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18804 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80192/ Test FAILed. ---

[GitHub] spark issue #18804: [SPARK-21599][SQL] Collecting column statistics for data...

2017-08-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18804 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18779: [SPARK-21580][SQL]Integers in aggregation expressions ar...

2017-08-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18779 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18779: [SPARK-21580][SQL]Integers in aggregation expressions ar...

2017-08-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18779 **[Test build #80191 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80191/testReport)** for PR 18779 at commit

[GitHub] spark issue #18538: [SPARK-14516][ML] Adding ClusteringEvaluator with the im...

2017-08-03 Thread yanboliang
Github user yanboliang commented on the issue: https://github.com/apache/spark/pull/18538 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark issue #18628: [SPARK-18061][ThriftServer] Add spnego auth support for ...

2017-08-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18628 **[Test build #80193 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80193/testReport)** for PR 18628 at commit

[GitHub] spark pull request #18831: [SPARK-21622][ML][SparkR] Support offset in Spark...

2017-08-03 Thread actuaryzhang
GitHub user actuaryzhang opened a pull request: https://github.com/apache/spark/pull/18831 [SPARK-21622][ML][SparkR] Support offset in SparkR GLM ## What changes were proposed in this pull request? Support offset in SparkR GLM #16699 You can merge this pull request into a Git

[GitHub] spark issue #18828: [SPARK-21619][SQL] Fail the execution of canonicalized p...

2017-08-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18828 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18828: [SPARK-21619][SQL] Fail the execution of canonicalized p...

2017-08-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18828 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80187/ Test FAILed. ---

[GitHub] spark issue #18828: [SPARK-21619][SQL] Fail the execution of canonicalized p...

2017-08-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18828 **[Test build #80187 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80187/testReport)** for PR 18828 at commit

[GitHub] spark issue #18413: [SPARK-21205][SQL] pmod(number, 0) should be null.

2017-08-03 Thread wangyum
Github user wangyum commented on the issue: https://github.com/apache/spark/pull/18413 @HyukjinKwon Could you help review this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18809: [SPARK-21602][R] Add map_keys and map_values functions t...

2017-08-03 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18809 Thank you @felixcheung and @actuaryzhang. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #18668: [SPARK-21451][SQL]get `spark.hadoop.*` properties from s...

2017-08-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18668 **[Test build #80186 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80186/testReport)** for PR 18668 at commit

[GitHub] spark issue #18779: [SPARK-21580][SQL]Integers in aggregation expressions ar...

2017-08-03 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18779 Our Dataset APIs support `conf.groupByOrdinal`? If so, this might surprise me. `conf.groupByOrdinal` was introduced for SQL APIs only. --- If your project is set up for it, you can reply to

[GitHub] spark issue #18779: [SPARK-21580][SQL]Integers in aggregation expressions ar...

2017-08-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18779 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80191/ Test FAILed. ---

[GitHub] spark issue #18830: [SPARK-21621][Core] Reset numRecordsWritten after DiskBl...

2017-08-03 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/18830 Nice catch, looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #18828: [SPARK-21619][SQL] Fail the execution of canonicalized p...

2017-08-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18828 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18828: [SPARK-21619][SQL] Fail the execution of canonicalized p...

2017-08-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18828 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80190/ Test FAILed. ---

[GitHub] spark issue #18828: [SPARK-21619][SQL] Fail the execution of canonicalized p...

2017-08-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18828 **[Test build #80190 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80190/testReport)** for PR 18828 at commit

[GitHub] spark pull request #18668: [SPARK-21451][SQL]get `spark.hadoop.*` properties...

2017-08-03 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18668#discussion_r131060237 --- Diff: docs/configuration.md --- @@ -2335,5 +2335,59 @@ The location of these configuration files varies across Hadoop versions, but a common

[GitHub] spark issue #18749: [SPARK-21485][FOLLOWUP][SQL][DOCS] Describes examples an...

2017-08-03 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/18749 It is documented: http://spark.apache.org/contributing.html It's been the convention forever and it's also good to use one way rather than multiple, so I'd prefer us just using that ... until

[GitHub] spark issue #18668: [SPARK-21451][SQL]get `spark.hadoop.*` properties from s...

2017-08-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18668 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18668: [SPARK-21451][SQL]get `spark.hadoop.*` properties from s...

2017-08-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18668 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80186/ Test PASSed. ---

[GitHub] spark issue #18628: [SPARK-18061][ThriftServer] Add spnego auth support for ...

2017-08-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18628 **[Test build #80193 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80193/testReport)** for PR 18628 at commit

[GitHub] spark issue #18628: [SPARK-18061][ThriftServer] Add spnego auth support for ...

2017-08-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18628 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18628: [SPARK-18061][ThriftServer] Add spnego auth support for ...

2017-08-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18628 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80193/ Test PASSed. ---

[GitHub] spark pull request #18830: [SPARK-21621][Core] Reset numRecordsWritten after...

2017-08-03 Thread ConeyLiu
GitHub user ConeyLiu opened a pull request: https://github.com/apache/spark/pull/18830 [SPARK-21621][Core] Reset numRecordsWritten after DiskBlockObjectWriter.commitAndGet called ## What changes were proposed in this pull request? We should reset numRecordsWritten to zero

[GitHub] spark pull request #18668: [SPARK-21451][SQL]get `spark.hadoop.*` properties...

2017-08-03 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18668#discussion_r131059429 --- Diff: docs/configuration.md --- @@ -2335,5 +2335,59 @@ The location of these configuration files varies across Hadoop versions, but a common

[GitHub] spark issue #18830: [SPARK-21621][Core] Reset numRecordsWritten after DiskBl...

2017-08-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18830 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #18749: [SPARK-21485][FOLLOWUP][SQL][DOCS] Describes examples an...

2017-08-03 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18749 I think we should rather make https://spark-prs.appspot.com recognising the github approval as well .. I considered github approval as an approval for this patch. BTW, for now, is it

[GitHub] spark pull request #18628: [SPARK-18061][ThriftServer] Add spnego auth suppo...

2017-08-03 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/18628#discussion_r131059886 --- Diff: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIService.scala --- @@ -57,6 +59,19 @@ private[hive]

[GitHub] spark issue #18830: [SPARK-21621][Core] Reset numRecordsWritten after DiskBl...

2017-08-03 Thread ConeyLiu
Github user ConeyLiu commented on the issue: https://github.com/apache/spark/pull/18830 @cloud-fan @vanzin Would you mind take a look? Thanks a lot. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request #18668: [SPARK-21451][SQL]get `spark.hadoop.*` properties...

2017-08-03 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18668#discussion_r131059952 --- Diff: docs/configuration.md --- @@ -2335,5 +2335,59 @@ The location of these configuration files varies across Hadoop versions, but a common

[GitHub] spark issue #18809: [SPARK-21602][R] Add map_keys and map_values functions t...

2017-08-03 Thread actuaryzhang
Github user actuaryzhang commented on the issue: https://github.com/apache/spark/pull/18809 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #18668: [SPARK-21451][SQL]get `spark.hadoop.*` properties from s...

2017-08-03 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18668 @vanzin @zhzhan @tejasapatil Could you also help review the documentation and the fix? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request #18824: [SPARK-21617][SQL] Store correct metadata in Hive...

2017-08-03 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18824#discussion_r131059637 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala --- @@ -413,7 +414,10 @@ private[hive] class HiveClientImpl(

[GitHub] spark pull request #18668: [SPARK-21451][SQL]get `spark.hadoop.*` properties...

2017-08-03 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18668#discussion_r131059673 --- Diff: docs/configuration.md --- @@ -2335,5 +2335,59 @@ The location of these configuration files varies across Hadoop versions, but a common

[GitHub] spark issue #18830: [SPARK-21621][Core] Reset numRecordsWritten after DiskBl...

2017-08-03 Thread ConeyLiu
Github user ConeyLiu commented on the issue: https://github.com/apache/spark/pull/18830 You can see here [L208](https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/storage/DiskBlockObjectWriter.scala#L208), when we called 'revertPartialWritesAndClose',

[GitHub] spark issue #18779: [SPARK-21580][SQL]Integers in aggregation expressions ar...

2017-08-03 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18779 @gatorsmile scala> df.groupBy(lit(2)).agg(col("a")).queryExecution.logical res6: org.apache.spark.sql.catalyst.plans.logical.LogicalPlan = 'Aggregate [2], [2 AS 2#51,

[GitHub] spark issue #18749: [SPARK-21485][FOLLOWUP][SQL][DOCS] Describes examples an...

2017-08-03 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18749 Hm, do you mean this line? > Reviewers can indicate that a change looks suitable for merging with a comment such as: “I think this patch looks good”. Spark uses the LGTM convention

[GitHub] spark issue #18831: [SPARK-21622][ML][SparkR] Support offset in SparkR GLM

2017-08-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18831 **[Test build #80194 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80194/testReport)** for PR 18831 at commit

[GitHub] spark issue #18804: [SPARK-21599][SQL] Collecting column statistics for data...

2017-08-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18804 **[Test build #80195 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80195/testReport)** for PR 18804 at commit

[GitHub] spark issue #18828: [SPARK-21619][SQL] Fail the execution of canonicalized p...

2017-08-03 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/18828 Still looking into it, but the failure is related to reuse exchange and caching. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark issue #18804: [SPARK-21599][SQL] Collecting column statistics for data...

2017-08-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18804 **[Test build #80195 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80195/testReport)** for PR 18804 at commit

[GitHub] spark issue #18831: [SPARK-21622][ML][SparkR] Support offset in SparkR GLM

2017-08-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18831 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80194/ Test FAILed. ---

[GitHub] spark issue #18831: [SPARK-21622][ML][SparkR] Support offset in SparkR GLM

2017-08-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18831 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18749: [SPARK-21485][FOLLOWUP][SQL][DOCS] Describes examples an...

2017-08-03 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18749 I was wondering if other methods such as SGTM or a Github approval aa an approval for a patch are not allowed by rule. I usually say based on documentation or references to other guys and I

[GitHub] spark issue #18749: [SPARK-21485][FOLLOWUP][SQL][DOCS] Describes examples an...

2017-08-03 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/18749 Ah OK. That's what we are discussing here. In the past it has always been an explicit "LGTM". That was defined before github had even the approval feature. Now most committers are actually not ASF

[GitHub] spark issue #18749: [SPARK-21485][FOLLOWUP][SQL][DOCS] Describes examples an...

2017-08-03 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18749 RTC means a vote happens for each change: https://www.apache.org/foundation/glossary.html#ReviewThenCommit That's not what we do. What debate are you referring to? --- If your project is set up

[GitHub] spark issue #18749: [SPARK-21485][FOLLOWUP][SQL][DOCS] Describes examples an...

2017-08-03 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/18749 @HyukjinKwon you weren't a committer before :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #18749: [SPARK-21485][FOLLOWUP][SQL][DOCS] Describes examples an...

2017-08-03 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/18749 @srowen search for "RTC vs CTR (was: Concerning Sentry...)" From Todd Lipcon: ``` I don't have incubator stats... nor do I have a good way to measure "most active" or "most

[GitHub] spark issue #18821: [SPARK-21615][ML][MLlib][DOCS] Fix broken redirect in co...

2017-08-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18821 **[Test build #3875 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3875/testReport)** for PR 18821 at commit

[GitHub] spark issue #18815: [SPARK-21609][WEB-UI]In the Master ui add "log directory...

2017-08-03 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18815 This won't necessarily be available to people viewing the UI? it could be an HDFS location --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark issue #18832: [SPARK-21623][ML]fix RF doc

2017-08-03 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18832 @sethah --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark pull request #18821: [SPARK-21615][ML][MLlib][DOCS] Fix broken redirec...

2017-08-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18821 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #18779: [SPARK-21580][SQL]Integers in aggregation expressions ar...

2017-08-03 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/18779 @gatorsmile @viirya I looked into why it applied some analyzer rules into already-analyzed plans and I noticed that some rules used `transform/transformUp` instead of `resolveOperators` in `apply`.

[GitHub] spark issue #18811: [SPARK-21604][SQL] if the object extends Logging, i sugg...

2017-08-03 Thread zuotingbing
Github user zuotingbing commented on the issue: https://github.com/apache/spark/pull/18811 ok, have done. Thanks @srowen . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18779: [SPARK-21580][SQL]Integers in aggregation expressions ar...

2017-08-03 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18779 @maropu I have a PR before to solve that. Due to some reasons it will be merged on 2.3. I am out of laptop, will refer it once I can access laptop. On Aug 3, 2017 5:07 PM,

[GitHub] spark issue #18811: [SPARK-21604][SQL] if the object extends Logging, i sugg...

2017-08-03 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18811 merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark pull request #18668: [SPARK-21451][SQL]get `spark.hadoop.*` properties...

2017-08-03 Thread yaooqinn
Github user yaooqinn commented on a diff in the pull request: https://github.com/apache/spark/pull/18668#discussion_r131068575 --- Diff: docs/configuration.md --- @@ -2335,5 +2335,59 @@ The location of these configuration files varies across Hadoop versions, but a common

[GitHub] spark pull request #18668: [SPARK-21451][SQL]get `spark.hadoop.*` properties...

2017-08-03 Thread yaooqinn
Github user yaooqinn commented on a diff in the pull request: https://github.com/apache/spark/pull/18668#discussion_r131068501 --- Diff: docs/configuration.md --- @@ -2335,5 +2335,59 @@ The location of these configuration files varies across Hadoop versions, but a common

[GitHub] spark issue #18821: [SPARK-21615][ML][MLlib][DOCS] Fix broken redirect in co...

2017-08-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18821 **[Test build #3875 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3875/testReport)** for PR 18821 at commit

[GitHub] spark pull request #18833: [SPARK-21625][SQL] sqrt(negative number) should b...

2017-08-03 Thread wangyum
GitHub user wangyum opened a pull request: https://github.com/apache/spark/pull/18833 [SPARK-21625][SQL] sqrt(negative number) should be null. ## What changes were proposed in this pull request? This PR makes `sqrt(negative number)` to null, same as Hive and MySQL.

[GitHub] spark issue #18804: [SPARK-21599][SQL] Collecting column statistics for data...

2017-08-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18804 **[Test build #80192 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80192/testReport)** for PR 18804 at commit

[GitHub] spark issue #18779: [SPARK-21580][SQL]Integers in aggregation expressions ar...

2017-08-03 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18779 When using Dataset groupBy API, if you use int literals as grouping expressions, do we filter this case out for substituting `UnresolvedOrdinals`? Seems there is no related logic to prevent it.

[GitHub] spark issue #18749: [SPARK-21485][FOLLOWUP][SQL][DOCS] Describes examples an...

2017-08-03 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/18749 Yes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #18749: [SPARK-21485][FOLLOWUP][SQL][DOCS] Describes examples an...

2017-08-03 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/18749 What's your point? You should be able to merge PR without anybody reviewing? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #18804: [SPARK-21599][SQL] Collecting column statistics for data...

2017-08-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18804 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80195/ Test FAILed. ---

[GitHub] spark issue #18831: [SPARK-21622][ML][SparkR] Support offset in SparkR GLM

2017-08-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18831 **[Test build #80194 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80194/testReport)** for PR 18831 at commit

[GitHub] spark issue #18804: [SPARK-21599][SQL] Collecting column statistics for data...

2017-08-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18804 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18779: [SPARK-21580][SQL]Integers in aggregation expressions ar...

2017-08-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18779 **[Test build #80197 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80197/testReport)** for PR 18779 at commit

[GitHub] spark issue #18749: [SPARK-21485][FOLLOWUP][SQL][DOCS] Describes examples an...

2017-08-03 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18749 I see. Thanks for the details and explanation. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #18749: [SPARK-21485][FOLLOWUP][SQL][DOCS] Describes examples an...

2017-08-03 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/18749 Actually Sean I disagree. Spark has always been review then commit from the days before it entered ASF. In a huge debate last year within the ASF on RTC vs CTR, Spark was cited as a prominent example.

[GitHub] spark pull request #18668: [SPARK-21451][SQL]get `spark.hadoop.*` properties...

2017-08-03 Thread yaooqinn
Github user yaooqinn commented on a diff in the pull request: https://github.com/apache/spark/pull/18668#discussion_r131074348 --- Diff: docs/configuration.md --- @@ -2335,5 +2335,59 @@ The location of these configuration files varies across Hadoop versions, but a common

[GitHub] spark issue #18808: [SPARK-21605][BUILD] Let IntelliJ IDEA correctly detect ...

2017-08-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18808 **[Test build #3874 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3874/testReport)** for PR 18808 at commit

[GitHub] spark issue #18668: [SPARK-21451][SQL]get `spark.hadoop.*` properties from s...

2017-08-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18668 **[Test build #80198 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80198/testReport)** for PR 18668 at commit

[GitHub] spark issue #18832: [SPARK-21623][ML]fix RF doc

2017-08-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18832 **[Test build #80199 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80199/testReport)** for PR 18832 at commit

[GitHub] spark issue #18749: [SPARK-21485][FOLLOWUP][SQL][DOCS] Describes examples an...

2017-08-03 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18749 I understood Spark have used LGTM as convention and it is a good way to show an approval as a sign-off but I meant, is "LGTM", not any other methods, required before merging it? --- If your

[GitHub] spark issue #18804: [SPARK-21599][SQL] Collecting column statistics for data...

2017-08-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18804 **[Test build #80196 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80196/testReport)** for PR 18804 at commit

[GitHub] spark issue #18804: [SPARK-21599][SQL] Collecting column statistics for data...

2017-08-03 Thread dilipbiswal
Github user dilipbiswal commented on the issue: https://github.com/apache/spark/pull/18804 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #18749: [SPARK-21485][FOLLOWUP][SQL][DOCS] Describes examples an...

2017-08-03 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18749 Formally, our model is "Commit Then Review". No approval or vote is required for any change, but changes can be retroactively vetoed. https://www.apache.org/foundation/glossary.html#CommitThenReview

[GitHub] spark issue #18749: [SPARK-21485][FOLLOWUP][SQL][DOCS] Describes examples an...

2017-08-03 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18749 (BTW, just for clarification, I think anyone can use that approve feature. I did it before - `https://github.com/apache/spark/pull/17734`) --- If your project is set up for it, you can reply

[GitHub] spark issue #18749: [SPARK-21485][FOLLOWUP][SQL][DOCS] Describes examples an...

2017-08-03 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18749 Yes, this isn't RTC. It isn't even RTC with 1-vote consensus, because you rightly say that you could merge with no other votes if it were obviously not required. But whatever. We can pick the

[GitHub] spark issue #18811: [SPARK-21604][SQL] if the object extends Logging, i sugg...

2017-08-03 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18811 Ah, I'm sorry I misled you a bit here @zuotingbing . Yes you found another unused variable, but, it's in code that is copied directly from Hive. I think we should leave HiveSessionImplwithUGI

[GitHub] spark issue #18808: [SPARK-21605][BUILD] Let IntelliJ IDEA correctly detect ...

2017-08-03 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18808 I hit the same issue! Thanks for fixing it! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #18832: [SPARK-21623][ML]fix RF doc

2017-08-03 Thread mpjlu
GitHub user mpjlu opened a pull request: https://github.com/apache/spark/pull/18832 [SPARK-21623][ML]fix RF doc ## What changes were proposed in this pull request? comments of parentStats in RF are wrong. parentStats is not only used for the first iteration, it is used

[GitHub] spark issue #18833: [SPARK-21625][SQL] sqrt(negative number) should be null.

2017-08-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18833 **[Test build #80200 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80200/testReport)** for PR 18833 at commit

[GitHub] spark issue #18607: [SPARK-21362][SQL][Adding Apache Drill JDBC Dialect]

2017-08-03 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18607 @radford1 Have you added the test as suggested by @gatorsmile? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #18745: [SPARK-21544][DEPLOY] Tests jar of some module should no...

2017-08-03 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18745 Ping @caneGuy -- adding `[test-maven]` will let us also verify this passes the Maven build --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark issue #18833: [SPARK-21625][SQL] sqrt(negative number) should be null.

2017-08-03 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/18833 Pg does not accept this query; ``` postgres=# select sqrt(3); sqrt -- 1.73205080756888 (1 row) postgres=# select sqrt(-1); ERROR:

[GitHub] spark pull request #18811: [SPARK-21604][SQL] if the object extends Logging,...

2017-08-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18811 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #18815: [SPARK-21609][WEB-UI]In the Master ui add "log directory...

2017-08-03 Thread guoxiaolongzte
Github user guoxiaolongzte commented on the issue: https://github.com/apache/spark/pull/18815 @srowen Are you sure that the master and worker logs can be stored in hdfs? Spark's master and worker logs are generated by log4j. --- If your project is set up for it, you can

[GitHub] spark pull request #18668: [SPARK-21451][SQL]get `spark.hadoop.*` properties...

2017-08-03 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/18668#discussion_r131093892 --- Diff: docs/configuration.md --- @@ -2335,5 +2335,61 @@ The location of these configuration files varies across Hadoop versions, but a common

[GitHub] spark issue #18628: [SPARK-18061][ThriftServer] Add spnego auth support for ...

2017-08-03 Thread steveloughran
Github user steveloughran commented on the issue: https://github.com/apache/spark/pull/18628 Thanks for making sure this is consistent with other uses of Configuration.get(); consistency is critical here --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark issue #18832: [SPARK-21623][ML]fix RF doc

2017-08-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18832 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18816: [SPARK-21611][SQL]Error class name for log in several cl...

2017-08-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18816 **[Test build #3876 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3876/testReport)** for PR 18816 at commit

[GitHub] spark issue #18832: [SPARK-21623][ML]fix RF doc

2017-08-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18832 **[Test build #80199 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80199/testReport)** for PR 18832 at commit

[GitHub] spark issue #18832: [SPARK-21623][ML]fix RF doc

2017-08-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18832 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80199/ Test PASSed. ---

[GitHub] spark issue #18815: [SPARK-21609][WEB-UI]In the Master ui add "log directory...

2017-08-03 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18815 It's not an http URI though right? it's a path. I'm missing why this is browseable. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

  1   2   3   4   5   >