[GitHub] spark issue #19711: [SPARK-22471][SQL] SQLListener consumes much memory caus...

2017-11-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19711 **[Test build #83680 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83680/testReport)** for PR 19711 at commit

[GitHub] spark issue #19712: [SPARK-22487][SQL][Hive]Remove the unused HIVE_EXECUTION...

2017-11-10 Thread yaooqinn
Github user yaooqinn commented on the issue: https://github.com/apache/spark/pull/19712 @cloud-fan referenced --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19712: [SPARK-22487][SQL][Hive]Remove the unused HIVE_EXECUTION...

2017-11-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19712 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19712: [SPARK-22487][SQL][Hive]Remove the unused HIVE_EXECUTION...

2017-11-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19712 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83675/ Test PASSed. ---

[GitHub] spark issue #19711: [SPARK-22471][SQL] SQLListener consumes much memory caus...

2017-11-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19711 **[Test build #83682 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83682/testReport)** for PR 19711 at commit

[GitHub] spark issue #19712: [SPARK-22487][SQL][Hive]Remove the unused HIVE_EXECUTION...

2017-11-10 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19712 LGTM, merging to master! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19713: [SPARK-22488] [SQL] Fix the view resolution issue in the...

2017-11-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19713 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83674/ Test FAILed. ---

[GitHub] spark issue #19713: [SPARK-22488] [SQL] Fix the view resolution issue in the...

2017-11-10 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19713 it's a valid failure ``` Failed - 1. Failure: test cache, uncache and clearCache (@test_sparkSQL.R#735)

[GitHub] spark issue #19651: [SPARK-20682][SPARK-15474][SPARK-21791] Add new ORCFileF...

2017-11-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19651 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19651: [SPARK-20682][SPARK-15474][SPARK-21791] Add new ORCFileF...

2017-11-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19651 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83677/ Test PASSed. ---

[GitHub] spark issue #19661: [SPARK-22450][Core][Mllib]safely register class for mlli...

2017-11-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19661 **[Test build #83676 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83676/testReport)** for PR 19661 at commit

[GitHub] spark issue #19661: [SPARK-22450][Core][Mllib]safely register class for mlli...

2017-11-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19661 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19661: [SPARK-22450][Core][Mllib]safely register class for mlli...

2017-11-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19661 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83676/ Test PASSed. ---

[GitHub] spark pull request #19661: [SPARK-22450][Core][Mllib]safely register class f...

2017-11-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19661 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19563: [SPARK-22284][SQL] Fix 64KB JVM bytecode limit pr...

2017-11-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19563#discussion_r150224414 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/HashExpressionsSuite.scala --- @@ -639,6 +639,53 @@ class

[GitHub] spark issue #19563: [SPARK-22284][SQL] Fix 64KB JVM bytecode limit problem i...

2017-11-10 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19563 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #19651: [SPARK-20682][SPARK-15474][SPARK-21791] Add new O...

2017-11-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19651#discussion_r150201109 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFilters.scala --- @@ -0,0 +1,180 @@ +/* + * Licensed to the

[GitHub] spark issue #19711: [SPARK-22471][SQL] SQLListener consumes much memory caus...

2017-11-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19711 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19711: [SPARK-22471][SQL] SQLListener consumes much memory caus...

2017-11-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19711 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83682/ Test FAILed. ---

[GitHub] spark issue #19340: [SPARK-22119][ML] Add cosine distance to KMeans

2017-11-10 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/19340 kindly pinging @yanboliang --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19668: [SPARK-22440][ML] Add Calinski-Harabasz index to Cluster...

2017-11-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19668 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19439: [SPARK-21866][ML][PySpark] Adding spark image reader

2017-11-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19439 **[Test build #83679 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83679/testReport)** for PR 19439 at commit

[GitHub] spark issue #19668: [SPARK-22440][ML] Add Calinski-Harabasz index to Cluster...

2017-11-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19668 **[Test build #83684 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83684/testReport)** for PR 19668 at commit

[GitHub] spark issue #19715: [SPARK-22397][ML]add multiple columns support to Quantil...

2017-11-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19715 **[Test build #83685 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83685/testReport)** for PR 19715 at commit

[GitHub] spark issue #19715: [SPARK-22397][ML]add multiple columns support to Quantil...

2017-11-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19715 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83685/ Test FAILed. ---

[GitHub] spark issue #19715: [SPARK-22397][ML]add multiple columns support to Quantil...

2017-11-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19715 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19693: [MINOR][CORE] Improved statistical shuffle write time

2017-11-10 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19693 Whether shuffle write time should include the file open/close time is debatable, also we don't know whether the actual open action is lazy or not (depends on OS). But one downside of this change

[GitHub] spark pull request #19651: [SPARK-20682][SPARK-15474][SPARK-21791] Add new O...

2017-11-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19651#discussion_r150205818 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcUtils.scala --- @@ -0,0 +1,131 @@ +/* + * Licensed to the

[GitHub] spark issue #19702: [SPARK-10365][SQL] Support Parquet logical type TIMESTAM...

2017-11-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19702 **[Test build #83673 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83673/testReport)** for PR 19702 at commit

[GitHub] spark issue #19713: [SPARK-22488] [SQL] Fix the view resolution issue in the...

2017-11-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19713 **[Test build #83678 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83678/testReport)** for PR 19713 at commit

[GitHub] spark issue #19713: [SPARK-22488] [SQL] Fix the view resolution issue in the...

2017-11-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19713 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83678/ Test FAILed. ---

[GitHub] spark issue #19713: [SPARK-22488] [SQL] Fix the view resolution issue in the...

2017-11-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19713 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19693: [MINOR][CORE] Improved statistical shuffle write time

2017-11-10 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/19693 Seems it's better to keep the previous behavior. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #19711: [SPARK-22471][SQL] SQLListener consumes much memory caus...

2017-11-10 Thread tashoyan
Github user tashoyan commented on the issue: https://github.com/apache/spark/pull/19711 Retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #19700: [SPARK-22471][SQL] SQLListener consumes much memo...

2017-11-10 Thread tashoyan
Github user tashoyan closed the pull request at: https://github.com/apache/spark/pull/19700 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19518: [SPARK-18016][SQL][CATALYST] Code Generation: Constant P...

2017-11-10 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/19518 @bdrillard since my PR and other get merged now there are some conflicts, may you please fix them? Thanks. --- - To

[GitHub] spark issue #19713: [SPARK-22488] [SQL] Fix the view resolution issue in the...

2017-11-10 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19713 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19714: [SPARK-22489][SQL] Shouldn't change broadcast join build...

2017-11-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19714 **[Test build #83681 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83681/testReport)** for PR 19714 at commit

[GitHub] spark pull request #19479: [SPARK-17074] [SQL] Generate equi-height histogra...

2017-11-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19479#discussion_r150192871 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -1034,11 +1034,18 @@ private[spark] class

[GitHub] spark pull request #19716: [SPARK-18755][WIP][ML] Random search implementati...

2017-11-10 Thread gnsiva
GitHub user gnsiva opened a pull request: https://github.com/apache/spark/pull/19716 [SPARK-18755][WIP][ML] Random search implementation using RandomParamGridBuilder ## What changes were proposed in this pull request? Python `sklearn` has an implementation of random search

[GitHub] spark issue #19712: [SPARK-22487][SQL][Hive]Remove the unused HIVE_EXECUTION...

2017-11-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19712 **[Test build #83675 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83675/testReport)** for PR 19712 at commit

[GitHub] spark pull request #19651: [SPARK-20682][SPARK-15474][SPARK-21791] Add new O...

2017-11-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19651#discussion_r150201579 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFilters.scala --- @@ -0,0 +1,180 @@ +/* + * Licensed to the

[GitHub] spark issue #19651: [SPARK-20682][SPARK-15474][SPARK-21791] Add new ORCFileF...

2017-11-10 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19651 I'd like to still keep the old orc implementation in this PR. The new implementation should only be used when users specify full class name, e.g. `org.apache.sparkOrcFileFormat`. Then we add

[GitHub] spark issue #18118: [SPARK-20199][ML] : Provided featureSubsetStrategy to GB...

2017-11-10 Thread MLnick
Github user MLnick commented on the issue: https://github.com/apache/spark/pull/18118 LGTM, merged to master. Thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #19714: [SPARK-22489][SQL] Shouldn't change broadcast join build...

2017-11-10 Thread wangyum
Github user wangyum commented on the issue: https://github.com/apache/spark/pull/19714 retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #16964: [SPARK-19534][TESTS] Convert Java tests to use lambdas, ...

2017-11-10 Thread dahaian
Github user dahaian commented on the issue: https://github.com/apache/spark/pull/16964 @zzcclp I tried, failed. Any suggestions? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19711: [SPARK-22471][SQL] SQLListener consumes much memory caus...

2017-11-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19711 **[Test build #83680 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83680/testReport)** for PR 19711 at commit

[GitHub] spark issue #19716: [SPARK-18755][WIP][ML] Random search implementation usin...

2017-11-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19716 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #19651: [SPARK-20682][SPARK-15474][SPARK-21791] Add new O...

2017-11-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19651#discussion_r150202038 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFilters.scala --- @@ -0,0 +1,180 @@ +/* + * Licensed to the

[GitHub] spark issue #19702: [SPARK-10365][SQL] Support Parquet logical type TIMESTAM...

2017-11-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19702 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83673/ Test PASSed. ---

[GitHub] spark issue #19702: [SPARK-10365][SQL] Support Parquet logical type TIMESTAM...

2017-11-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19702 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #19689: [SPARK-22462][SQL] Make rdd-based actions in Data...

2017-11-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19689#discussion_r150209023 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -2579,8 +2579,15 @@ class Dataset[T] private[sql]( * @group action

[GitHub] spark pull request #18118: [SPARK-20199][ML] : Provided featureSubsetStrateg...

2017-11-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18118 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18972: [SPARK-21720][SQL] Fix 64KB JVM bytecode limit pr...

2017-11-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18972#discussion_r150223463 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala --- @@ -2081,10 +2081,8 @@ class DataFrameSuite extends QueryTest with

[GitHub] spark pull request #18972: [SPARK-21720][SQL] Fix 64KB JVM bytecode limit pr...

2017-11-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18972#discussion_r150222142 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -809,6 +809,36 @@ class

[GitHub] spark pull request #18972: [SPARK-21720][SQL] Fix 64KB JVM bytecode limit pr...

2017-11-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18972#discussion_r150222364 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -809,6 +809,36 @@ class

[GitHub] spark issue #19543: [SPARK-19606][MESOS] Support constraints in spark-dispat...

2017-11-10 Thread pmackles
Github user pmackles commented on the issue: https://github.com/apache/spark/pull/19543 @susanxhuynh, @ttashi-rms, @ArtRand - thanks for the feedback. I was able to make all of the suggested changes. --- - To

[GitHub] spark pull request #19651: [SPARK-20682][SPARK-15474][SPARK-21791] Add new O...

2017-11-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19651#discussion_r150203178 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcSerializer.scala --- @@ -0,0 +1,163 @@ +/* + * Licensed to

[GitHub] spark issue #19651: [SPARK-20682][SPARK-15474][SPARK-21791] Add new ORCFileF...

2017-11-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19651 **[Test build #83677 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83677/testReport)** for PR 19651 at commit

[GitHub] spark issue #19713: [SPARK-22488] [SQL] Fix the view resolution issue in the...

2017-11-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19713 **[Test build #83674 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83674/testReport)** for PR 19713 at commit

[GitHub] spark issue #19713: [SPARK-22488] [SQL] Fix the view resolution issue in the...

2017-11-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19713 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19668: [SPARK-22440][ML] Add Calinski-Harabasz index to Cluster...

2017-11-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19668 **[Test build #83683 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83683/testReport)** for PR 19668 at commit

[GitHub] spark issue #19668: [SPARK-22440][ML] Add Calinski-Harabasz index to Cluster...

2017-11-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19668 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83683/ Test FAILed. ---

[GitHub] spark pull request #19518: [SPARK-18016][SQL][CATALYST] Code Generation: Con...

2017-11-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19518#discussion_r150220400 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala --- @@ -801,12 +801,12 @@ case class Cast(child: Expression,

[GitHub] spark pull request #18853: [SPARK-21646][SQL] Add new type coercion to compa...

2017-11-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18853#discussion_r150227062 --- Diff: docs/sql-programming-guide.md --- @@ -1460,6 +1460,13 @@ that these options will be deprecated in future release as more optimizations ar

[GitHub] spark issue #19711: [SPARK-22471][SQL] SQLListener consumes much memory caus...

2017-11-10 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/19711 Retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19711: [SPARK-22471][SQL] SQLListener consumes much memory caus...

2017-11-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19711 **[Test build #83682 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83682/testReport)** for PR 19711 at commit

[GitHub] spark pull request #19651: [SPARK-20682][SPARK-15474][SPARK-21791] Add new O...

2017-11-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19651#discussion_r150199939 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcDeserializer.scala --- @@ -0,0 +1,167 @@ +/* + * Licensed to

[GitHub] spark pull request #19651: [SPARK-20682][SPARK-15474][SPARK-21791] Add new O...

2017-11-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19651#discussion_r150206340 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcUtils.scala --- @@ -0,0 +1,131 @@ +/* + * Licensed to the

[GitHub] spark issue #19668: [SPARK-22440][ML] Add Calinski-Harabasz index to Cluster...

2017-11-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19668 **[Test build #83683 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83683/testReport)** for PR 19668 at commit

[GitHub] spark issue #19661: [SPARK-22450][Core][Mllib]safely register class for mlli...

2017-11-10 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19661 thanks, merging to master! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19714: [SPARK-22489][SQL] Shouldn't change broadcast join build...

2017-11-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19714 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19714: [SPARK-22489][SQL] Shouldn't change broadcast join build...

2017-11-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19714 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83681/ Test PASSed. ---

[GitHub] spark issue #19715: [SPARK-22397][ML]add multiple columns support to Quantil...

2017-11-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19715 **[Test build #83685 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83685/testReport)** for PR 19715 at commit

[GitHub] spark issue #19439: [SPARK-21866][ML][PySpark] Adding spark image reader

2017-11-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19439 **[Test build #83679 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83679/testReport)** for PR 19439 at commit

[GitHub] spark issue #19711: [SPARK-22471][SQL] SQLListener consumes much memory caus...

2017-11-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19711 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19711: [SPARK-22471][SQL] SQLListener consumes much memory caus...

2017-11-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19711 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83680/ Test FAILed. ---

[GitHub] spark pull request #19651: [SPARK-20682][SPARK-15474][SPARK-21791] Add new O...

2017-11-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19651#discussion_r150199773 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcDeserializer.scala --- @@ -0,0 +1,167 @@ +/* + * Licensed to

[GitHub] spark issue #19715: [SPARK-22397][ML]add multiple columns support to Quantil...

2017-11-10 Thread MLnick
Github user MLnick commented on the issue: https://github.com/apache/spark/pull/19715 Jenkins add to whitelist --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #19651: [SPARK-20682][SPARK-15474][SPARK-21791] Add new O...

2017-11-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19651#discussion_r150200482 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFileFormat.scala --- @@ -39,3 +58,120 @@ private[sql] object

[GitHub] spark pull request #19712: [SPARK-22487][SQL][Hive]Remove the unused HIVE_EX...

2017-11-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19712 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19676: [SPARK-14516][FOLLOWUP] Adding ClusteringEvaluator to ex...

2017-11-10 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/19676 sorry for pinging you, what do you think about adding `ClusteringEvaluator` to the examples @yanboliang ? Thanks. --- - To

[GitHub] spark issue #19668: [SPARK-22440][ML] Add Calinski-Harabasz index to Cluster...

2017-11-10 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/19668 cc @yanboliang --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19439: [SPARK-21866][ML][PySpark] Adding spark image reader

2017-11-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19439 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83679/ Test PASSed. ---

[GitHub] spark issue #19439: [SPARK-21866][ML][PySpark] Adding spark image reader

2017-11-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19439 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19714: [SPARK-22489][SQL] Shouldn't change broadcast join build...

2017-11-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19714 **[Test build #83681 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83681/testReport)** for PR 19714 at commit

[GitHub] spark issue #19711: [SPARK-22471][SQL] SQLListener consumes much memory caus...

2017-11-10 Thread tashoyan
Github user tashoyan commented on the issue: https://github.com/apache/spark/pull/19711 Corrupted build node? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #19459: [SPARK-20791][PYSPARK] Use Arrow to create Spark ...

2017-11-10 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19459#discussion_r150206108 --- Diff: python/pyspark/serializers.py --- @@ -225,11 +232,11 @@ def _create_batch(series): # If a nullable integer series has been promoted

[GitHub] spark pull request #19459: [SPARK-20791][PYSPARK] Use Arrow to create Spark ...

2017-11-10 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19459#discussion_r150229941 --- Diff: python/pyspark/sql/tests.py --- @@ -3180,6 +3185,58 @@ def test_filtered_frame(self): self.assertEqual(pdf.columns[0], "i")

[GitHub] spark pull request #19459: [SPARK-20791][PYSPARK] Use Arrow to create Spark ...

2017-11-10 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19459#discussion_r150227714 --- Diff: python/pyspark/sql/session.py --- @@ -454,13 +454,60 @@ def _convert_from_pandas(self, pdf, schema): # Check if any columns

[GitHub] spark pull request #19459: [SPARK-20791][PYSPARK] Use Arrow to create Spark ...

2017-11-10 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19459#discussion_r150228512 --- Diff: python/pyspark/sql/session.py --- @@ -454,13 +454,60 @@ def _convert_from_pandas(self, pdf, schema): # Check if any columns

[GitHub] spark issue #19077: [SPARK-21860][core]Improve memory reuse for heap memory ...

2017-11-10 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19077 shall we always do word alignment for page allocation? cc @kiszk too --- - To unsubscribe, e-mail:

[GitHub] spark issue #19689: [SPARK-22462][SQL] Make rdd-based actions in Dataset tra...

2017-11-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19689 **[Test build #83688 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83688/testReport)** for PR 19689 at commit

[GitHub] spark pull request #19459: [SPARK-20791][PYSPARK] Use Arrow to create Spark ...

2017-11-10 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19459#discussion_r150229857 --- Diff: python/pyspark/sql/tests.py --- @@ -3180,6 +3185,58 @@ def test_filtered_frame(self): self.assertEqual(pdf.columns[0], "i")

[GitHub] spark pull request #19459: [SPARK-20791][PYSPARK] Use Arrow to create Spark ...

2017-11-10 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19459#discussion_r150228738 --- Diff: python/pyspark/sql/session.py --- @@ -454,13 +454,60 @@ def _convert_from_pandas(self, pdf, schema): # Check if any columns

[GitHub] spark pull request #19077: [SPARK-21860][core]Improve memory reuse for heap ...

2017-11-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19077#discussion_r150240149 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/array/ByteArrayMethods.java --- @@ -31,8 +31,8 @@ public static long nextPowerOf2(long

[GitHub] spark pull request #19439: [SPARK-21866][ML][PySpark] Adding spark image rea...

2017-11-10 Thread thunterdb
Github user thunterdb commented on a diff in the pull request: https://github.com/apache/spark/pull/19439#discussion_r150250118 --- Diff: mllib/src/main/scala/org/apache/spark/ml/image/HadoopUtils.scala --- @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #19714: [SPARK-22489][SQL] Shouldn't change broadcast joi...

2017-11-10 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/19714#discussion_r150255560 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala --- @@ -154,12 +158,12 @@ abstract class SparkStrategies extends

[GitHub] spark pull request #18624: [SPARK-21389][ML][MLLIB] Optimize ALS recommendFo...

2017-11-10 Thread mpjlu
Github user mpjlu commented on a diff in the pull request: https://github.com/apache/spark/pull/18624#discussion_r150269984 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/recommendation/MatrixFactorizationModel.scala --- @@ -286,40 +288,119 @@ object

[GitHub] spark issue #19601: [SPARK-22383][SQL] Generate code to directly get value o...

2017-11-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19601 **[Test build #83689 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83689/testReport)** for PR 19601 at commit

  1   2   3   4   5   >