[GitHub] spark issue #19792: [SPARK-22566][PYTHON] Better error message for `_merge_t...

2017-11-21 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/19792 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19792: [SPARK-22566][PYTHON] Better error message for `_merge_t...

2017-11-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19792 **[Test build #84095 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84095/testReport)** for PR 19792 at commit

[GitHub] spark pull request #19779: [SPARK-17920][SPARK-19580][SPARK-19878][SQL] Supp...

2017-11-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19779 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19792: [SPARK-22566][PYTHON] Better error message for `_...

2017-11-21 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/19792#discussion_r152478594 --- Diff: python/pyspark/sql/types.py --- @@ -1108,19 +1109,22 @@ def _has_nulltype(dt): return isinstance(dt, NullType) -def

[GitHub] spark issue #19767: [SPARK-22543][SQL] fix java 64kb compile error for deepl...

2017-11-21 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19767 LGTM except the above comments. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #19792: [SPARK-22566][PYTHON] Better error message for `_merge_t...

2017-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19792 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19792: [SPARK-22566][PYTHON] Better error message for `_merge_t...

2017-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19792 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84095/ Test PASSed. ---

[GitHub] spark issue #19792: [SPARK-22566][PYTHON] Better error message for `_merge_t...

2017-11-21 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/19792 What if `ArrayType` or `MapType`, or deeply nested `StructType`? --- - To unsubscribe, e-mail:

[GitHub] spark issue #19792: [SPARK-22566][PYTHON] Better error message for `_merge_t...

2017-11-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19792 **[Test build #84095 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84095/testReport)** for PR 19792 at commit

[GitHub] spark pull request #19767: [SPARK-22543][SQL] fix java 64kb compile error fo...

2017-11-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19767#discussion_r152489116 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala --- @@ -105,6 +105,36 @@ abstract class Expression

[GitHub] spark issue #19651: [SPARK-20682][SPARK-15474][SPARK-21791] Add new ORCFileF...

2017-11-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19651 **[Test build #84097 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84097/testReport)** for PR 19651 at commit

[GitHub] spark issue #19082: [SPARK-21870][SQL] Split aggregation code into small fun...

2017-11-21 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/19082 ya, enjoy! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19082: [SPARK-21870][SQL] Split aggregation code into small fun...

2017-11-21 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19082 Will review it carefully after I finish my vacation. Thanks! --- - To unsubscribe, e-mail:

[GitHub] spark pull request #19651: [SPARK-20682][SPARK-15474][SPARK-21791] Add new O...

2017-11-21 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19651#discussion_r152479902 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcDeserializer.scala --- @@ -0,0 +1,216 @@ +/* + *

[GitHub] spark issue #19779: [SPARK-17920][SPARK-19580][SPARK-19878][SQL] Support wri...

2017-11-21 Thread vinodkc
Github user vinodkc commented on the issue: https://github.com/apache/spark/pull/19779 @gatorsmile , @cloud-fan and @dongjoon-hyun Thanks for the review comments and guidence Sure, I'll submit a separate PR for backporting it to 2.2 ---

[GitHub] spark pull request #19651: [SPARK-20682][SPARK-15474][SPARK-21791] Add new O...

2017-11-21 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19651#discussion_r152482492 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcDeserializer.scala --- @@ -0,0 +1,216 @@ +/* + *

[GitHub] spark pull request #19752: [SPARK-22520][SQL] Support code generation for la...

2017-11-21 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19752#discussion_r152482401 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -211,111 +231,61 @@ abstract class

[GitHub] spark pull request #19257: [SPARK-22042] [SQL] ReorderJoinPredicates can bre...

2017-11-21 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19257#discussion_r152484490 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/EnsureRequirements.scala --- @@ -265,6 +268,7 @@ case class

[GitHub] spark pull request #19257: [SPARK-22042] [SQL] ReorderJoinPredicates can bre...

2017-11-21 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19257#discussion_r152484440 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/EnsureRequirements.scala --- @@ -265,6 +268,7 @@ case class

[GitHub] spark issue #19779: [SPARK-17920][SPARK-19580][SPARK-19878][SQL] Support wri...

2017-11-21 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19779 Thanks! Merged to master. @vinodkc Could you submit a separate PR for backporting it to 2.2? --- - To unsubscribe,

[GitHub] spark issue #19468: [SPARK-18278] [Scheduler] Spark on Kubernetes - Basic Sc...

2017-11-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19468 **[Test build #84096 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84096/testReport)** for PR 19468 at commit

[GitHub] spark pull request #19773: [SPARK-22546][SQL] Supporting for changing column...

2017-11-21 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19773#discussion_r152480007 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -318,16 +318,26 @@ case class AlterTableChangeColumnCommand(

[GitHub] spark issue #19779: [SPARK-17920][SPARK-19580][SPARK-19878][SQL] Support wri...

2017-11-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19779 **[Test build #84094 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84094/testReport)** for PR 19779 at commit

[GitHub] spark issue #19779: [SPARK-17920][SPARK-19580][SPARK-19878][SQL] Support wri...

2017-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19779 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #19767: [SPARK-22543][SQL] fix java 64kb compile error fo...

2017-11-21 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19767#discussion_r152477535 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala --- @@ -105,6 +105,36 @@ abstract class Expression

[GitHub] spark pull request #19767: [SPARK-22543][SQL] fix java 64kb compile error fo...

2017-11-21 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19767#discussion_r152470168 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala --- @@ -105,6 +105,36 @@ abstract class Expression

[GitHub] spark pull request #19767: [SPARK-22543][SQL] fix java 64kb compile error fo...

2017-11-21 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19767#discussion_r152476972 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala --- @@ -105,6 +105,36 @@ abstract class Expression

[GitHub] spark pull request #19651: [SPARK-20682][SPARK-15474][SPARK-21791] Add new O...

2017-11-21 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19651#discussion_r152480591 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcDeserializer.scala --- @@ -0,0 +1,216 @@ +/* + *

[GitHub] spark pull request #19257: [SPARK-22042] [SQL] ReorderJoinPredicates can bre...

2017-11-21 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19257#discussion_r152484350 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/EnsureRequirements.scala --- @@ -31,6 +32,8 @@ import

[GitHub] spark issue #19779: [SPARK-17920][SPARK-19580][SPARK-19878][SQL] Support wri...

2017-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19779 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84094/ Test PASSed. ---

[GitHub] spark pull request #19776: [SPARK-22548][SQL] Incorrect nested AND expressio...

2017-11-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19776#discussion_r152200166 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategySuite.scala --- @@ -0,0 +1,302 @@ +/* + *

[GitHub] spark pull request #19776: [SPARK-22548][SQL] Incorrect nested AND expressio...

2017-11-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19776#discussion_r152200310 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategySuite.scala --- @@ -0,0 +1,302 @@ +/* + *

[GitHub] spark pull request #19776: [SPARK-22548][SQL] Incorrect nested AND expressio...

2017-11-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19776#discussion_r152200223 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategySuite.scala --- @@ -0,0 +1,302 @@ +/* + *

[GitHub] spark pull request #19776: [SPARK-22548][SQL] Incorrect nested AND expressio...

2017-11-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19776#discussion_r152200130 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategySuite.scala --- @@ -0,0 +1,302 @@ +/* + *

[GitHub] spark issue #19790: [SPARK-22569] [SQL] Clean usage of addMutableState and s...

2017-11-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19790 **[Test build #84057 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84057/testReport)** for PR 19790 at commit

[GitHub] spark issue #19737: [SPARK-22508][SQL] Fix 64KB JVM bytecode limit problem w...

2017-11-21 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19737 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19787: [SPARK-22541][SQL] Explicitly claim that Python udfs can...

2017-11-21 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19787 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19389: [SPARK-22165][SQL] Fixes type conflicts between double, ...

2017-11-21 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19389 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19787: [SPARK-22541][SQL] Explicitly claim that Python udfs can...

2017-11-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19787 **[Test build #84058 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84058/testReport)** for PR 19787 at commit

[GitHub] spark issue #19389: [SPARK-22165][SQL] Fixes type conflicts between double, ...

2017-11-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19389 **[Test build #84059 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84059/testReport)** for PR 19389 at commit

[GitHub] spark issue #19737: [SPARK-22508][SQL] Fix 64KB JVM bytecode limit problem w...

2017-11-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19737 **[Test build #84061 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84061/testReport)** for PR 19737 at commit

[GitHub] spark issue #19778: [SPARK-22550][SQL] Fix 64KB JVM bytecode limit problem w...

2017-11-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19778 **[Test build #84060 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84060/testReport)** for PR 19778 at commit

[GitHub] spark issue #19776: [SPARK-22548][SQL] Incorrect nested AND expression pushe...

2017-11-21 Thread jliwork
Github user jliwork commented on the issue: https://github.com/apache/spark/pull/19776 @cloud-fan Thank you for your comments! I have updated the test cases as you suggested. --- - To unsubscribe, e-mail:

[GitHub] spark issue #19787: [SPARK-22541][SQL] Explicitly claim that Python udfs can...

2017-11-21 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19787 thanks, merging to master! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #19776: [SPARK-22548][SQL] Incorrect nested AND expressio...

2017-11-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19776#discussion_r152200090 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategySuite.scala --- @@ -0,0 +1,302 @@ +/* + *

[GitHub] spark pull request #19776: [SPARK-22548][SQL] Incorrect nested AND expressio...

2017-11-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19776#discussion_r152200107 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategySuite.scala --- @@ -0,0 +1,302 @@ +/* + *

[GitHub] spark issue #19755: [SPARK-22524][SQL] Subquery shows reused on UI SQL tab e...

2017-11-21 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19755 can you give a simple example to convince people that un-reused subqueries should be displayed separately? the TPC-DS example is really hard to read. ---

[GitHub] spark pull request #19607: [WIP][SPARK-22395][SQL][PYTHON] Fix the behavior ...

2017-11-21 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/19607#discussion_r152201452 --- Diff: python/pyspark/sql/types.py --- @@ -1678,37 +1678,105 @@ def from_arrow_schema(arrow_schema): for field in arrow_schema])

[GitHub] spark issue #19607: [WIP][SPARK-22395][SQL][PYTHON] Fix the behavior of time...

2017-11-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19607 **[Test build #84062 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84062/testReport)** for PR 19607 at commit

[GitHub] spark issue #19776: [SPARK-22548][SQL] Incorrect nested AND expression pushe...

2017-11-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19776 **[Test build #84063 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84063/testReport)** for PR 19776 at commit

[GitHub] spark pull request #19787: [SPARK-22541][SQL] Explicitly claim that Python u...

2017-11-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19787 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19776: [SPARK-22548][SQL] Incorrect nested AND expressio...

2017-11-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19776#discussion_r152206765 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategySuite.scala --- @@ -0,0 +1,307 @@ +/* + *

[GitHub] spark pull request #19607: [WIP][SPARK-22395][SQL][PYTHON] Fix the behavior ...

2017-11-21 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19607#discussion_r152199700 --- Diff: python/pyspark/sql/types.py --- @@ -1678,37 +1678,105 @@ def from_arrow_schema(arrow_schema): for field in arrow_schema])

[GitHub] spark issue #19787: [SPARK-22541][SQL] Explicitly claim that Python udfs can...

2017-11-21 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19787 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19776: [SPARK-22548][SQL] Incorrect nested AND expression pushe...

2017-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19776 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19389: [SPARK-22165][SQL] Fixes type conflicts between double, ...

2017-11-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19389 **[Test build #84051 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84051/testReport)** for PR 19389 at commit

[GitHub] spark issue #19778: [SPARK-22550][SQL] Fix 64KB JVM bytecode limit problem w...

2017-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19778 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19778: [SPARK-22550][SQL] Fix 64KB JVM bytecode limit problem w...

2017-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19778 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84052/ Test FAILed. ---

[GitHub] spark issue #19787: [SPARK-22541][SQL] Explicitly claim that Python udfs can...

2017-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19787 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19778: [SPARK-22550][SQL] Fix 64KB JVM bytecode limit problem w...

2017-11-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19778 **[Test build #84052 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84052/testReport)** for PR 19778 at commit

[GitHub] spark issue #19787: [SPARK-22541][SQL] Explicitly claim that Python udfs can...

2017-11-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19787 **[Test build #84056 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84056/testReport)** for PR 19787 at commit

[GitHub] spark issue #19787: [SPARK-22541][SQL] Explicitly claim that Python udfs can...

2017-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19787 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84056/ Test FAILed. ---

[GitHub] spark issue #19607: [WIP][SPARK-22395][SQL][PYTHON] Fix the behavior of time...

2017-11-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19607 **[Test build #84048 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84048/testReport)** for PR 19607 at commit

[GitHub] spark issue #19776: [SPARK-22548][SQL] Incorrect nested AND expression pushe...

2017-11-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19776 **[Test build #84055 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84055/testReport)** for PR 19776 at commit

[GitHub] spark issue #19737: [SPARK-22508][SQL] Fix 64KB JVM bytecode limit problem w...

2017-11-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19737 **[Test build #84054 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84054/testReport)** for PR 19737 at commit

[GitHub] spark issue #19389: [SPARK-22165][SQL] Fixes type conflicts between double, ...

2017-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19389 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19607: [WIP][SPARK-22395][SQL][PYTHON] Fix the behavior of time...

2017-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19607 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84048/ Test FAILed. ---

[GitHub] spark issue #19607: [WIP][SPARK-22395][SQL][PYTHON] Fix the behavior of time...

2017-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19607 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19389: [SPARK-22165][SQL] Fixes type conflicts between double, ...

2017-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19389 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19778: [SPARK-22550][SQL] Fix 64KB JVM bytecode limit problem w...

2017-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19778 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19776: [SPARK-22548][SQL] Incorrect nested AND expression pushe...

2017-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19776 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84055/ Test FAILed. ---

[GitHub] spark issue #19389: [SPARK-22165][SQL] Fixes type conflicts between double, ...

2017-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19389 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84051/ Test FAILed. ---

[GitHub] spark issue #19776: [SPARK-22548][SQL] Incorrect nested AND expression pushe...

2017-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19776 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84053/ Test FAILed. ---

[GitHub] spark issue #19737: [SPARK-22508][SQL] Fix 64KB JVM bytecode limit problem w...

2017-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19737 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19776: [SPARK-22548][SQL] Incorrect nested AND expression pushe...

2017-11-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19776 **[Test build #84053 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84053/testReport)** for PR 19776 at commit

[GitHub] spark issue #19778: [SPARK-22550][SQL] Fix 64KB JVM bytecode limit problem w...

2017-11-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19778 **[Test build #84050 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84050/testReport)** for PR 19778 at commit

[GitHub] spark issue #19746: [SPARK-22346][ML] VectorSizeHint Transformer for using V...

2017-11-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19746 **[Test build #84046 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84046/testReport)** for PR 19746 at commit

[GitHub] spark issue #19776: [SPARK-22548][SQL] Incorrect nested AND expression pushe...

2017-11-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19776 **[Test build #84047 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84047/testReport)** for PR 19776 at commit

[GitHub] spark issue #19746: [SPARK-22346][ML] VectorSizeHint Transformer for using V...

2017-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19746 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19389: [SPARK-22165][SQL] Fixes type conflicts between double, ...

2017-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19389 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84049/ Test FAILed. ---

[GitHub] spark issue #19737: [SPARK-22508][SQL] Fix 64KB JVM bytecode limit problem w...

2017-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19737 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84054/ Test FAILed. ---

[GitHub] spark issue #19778: [SPARK-22550][SQL] Fix 64KB JVM bytecode limit problem w...

2017-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19778 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84050/ Test FAILed. ---

[GitHub] spark issue #19776: [SPARK-22548][SQL] Incorrect nested AND expression pushe...

2017-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19776 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19776: [SPARK-22548][SQL] Incorrect nested AND expression pushe...

2017-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19776 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19776: [SPARK-22548][SQL] Incorrect nested AND expression pushe...

2017-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19776 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84047/ Test FAILed. ---

[GitHub] spark issue #19389: [SPARK-22165][SQL] Fixes type conflicts between double, ...

2017-11-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19389 **[Test build #84049 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84049/testReport)** for PR 19389 at commit

[GitHub] spark pull request #19776: [SPARK-22548][SQL] Incorrect nested AND expressio...

2017-11-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19776#discussion_r152200656 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala --- @@ -296,8 +296,33 @@ class JDBCSuite extends SparkFunSuite //

[GitHub] spark issue #19787: [SPARK-22541][SQL] Explicitly claim that Python udfs can...

2017-11-21 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19787 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19778: [SPARK-22550][SQL] Fix 64KB JVM bytecode limit problem w...

2017-11-21 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19778 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19746: [SPARK-22346][ML] VectorSizeHint Transformer for using V...

2017-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19746 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84046/ Test FAILed. ---

[GitHub] spark issue #19776: [SPARK-22548][SQL] Incorrect nested AND expression pushe...

2017-11-21 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19776 LGTM except a few minor comments --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #19790: [SPARK-22569] [SQL] Clean usage of addMutableStat...

2017-11-21 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19790#discussion_r152200760 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -205,27 +209,32 @@ case class

[GitHub] spark issue #19787: [SPARK-22541][SQL] Explicitly claim that Python udfs can...

2017-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19787 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84058/ Test PASSed. ---

[GitHub] spark issue #19787: [SPARK-22541][SQL] Explicitly claim that Python udfs can...

2017-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19787 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19730: [SPARK-22500][SQL] Fix 64KB JVM bytecode limit problem w...

2017-11-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19730 **[Test build #84064 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84064/testReport)** for PR 19730 at commit

[GitHub] spark issue #19790: [SPARK-22569] [SQL] Clean usage of addMutableState and s...

2017-11-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19790 **[Test build #84057 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84057/testReport)** for PR 19790 at commit

[GitHub] spark issue #19621: [SPARK-11215][ML] Add multiple columns support to String...

2017-11-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19621 **[Test build #84066 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84066/testReport)** for PR 19621 at commit

[GitHub] spark issue #19790: [SPARK-22569] [SQL] Clean usage of addMutableState and s...

2017-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19790 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19607: [WIP][SPARK-22395][SQL][PYTHON] Fix the behavior of time...

2017-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19607 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19790: [SPARK-22569] [SQL] Clean usage of addMutableState and s...

2017-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19790 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84057/ Test PASSed. ---

  1   2   3   4   >