[GitHub] spark issue #19916: [SPARK-22716][SQL] Replace addReferenceObj to reduce the...

2017-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19916 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84575/ Test PASSed. ---

[GitHub] spark issue #19916: [SPARK-22716][SQL] Replace addReferenceObj to reduce the...

2017-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19916 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19893: [SPARK-16139][TEST] Add logging functionality for leaked...

2017-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19893 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84574/ Test PASSed. ---

[GitHub] spark pull request #19912: [SPARK-22719][SQL]Refactor ConstantPropagation

2017-12-06 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19912#discussion_r155412840 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala --- @@ -64,50 +64,91 @@ object ConstantFolding extends

[GitHub] spark issue #19893: [SPARK-16139][TEST] Add logging functionality for leaked...

2017-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19893 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19902: [SPARK-22452][SQL]Add getInt, getLong, getBoolean to Dat...

2017-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19902 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19902: [SPARK-22452][SQL]Add getInt, getLong, getBoolean to Dat...

2017-12-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19902 **[Test build #84582 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84582/testReport)** for PR 19902 at commit

[GitHub] spark issue #19902: [SPARK-22452][SQL]Add getInt, getLong, getBoolean to Dat...

2017-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19902 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84582/ Test PASSed. ---

[GitHub] spark issue #19222: [SPARK-10399][CORE][SQL] Introduce multiple MemoryBlocks...

2017-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19222 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19222: [SPARK-10399][CORE][SQL] Introduce multiple MemoryBlocks...

2017-12-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19222 **[Test build #84586 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84586/testReport)** for PR 19222 at commit

[GitHub] spark issue #19222: [SPARK-10399][CORE][SQL] Introduce multiple MemoryBlocks...

2017-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19222 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84586/ Test PASSed. ---

[GitHub] spark issue #19916: [SPARK-22716][SQL] Replace addReferenceObj to reduce the...

2017-12-06 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/19916 https://github.com/apache/spark/blob/e98f9647f44d1071a6b070db070841b8cda6bd7a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala#L1123 ---

[GitHub] spark issue #19885: [SPARK-22587] Spark job fails if fs.defaultFS and applic...

2017-12-06 Thread merlintang
Github user merlintang commented on the issue: https://github.com/apache/spark/pull/19885 I have added this test case for the URI comparing based on Steve's comments. I have tested this in my local vm, it pass the test. meanwhile, for the hdfs://namenode1/path1

[GitHub] spark issue #19912: [SPARK-22719][SQL]Refactor ConstantPropagation

2017-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19912 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19917: [SPARK-22725][SQL] Add failing test for select with a sp...

2017-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19917 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19917: [SPARK-22725][SQL] Add failing test for select with a sp...

2017-12-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19917 **[Test build #84590 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84590/testReport)** for PR 19917 at commit

[GitHub] spark issue #19917: [SPARK-22725][SQL] Add failing test for select with a sp...

2017-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19917 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84590/ Test FAILed. ---

[GitHub] spark issue #19916: [SPARK-22716][SQL] Replace addReferenceObj to reduce the...

2017-12-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19916 **[Test build #84575 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84575/testReport)** for PR 19916 at commit

[GitHub] spark issue #19854: [SPARK-22660][BUILD] Use position() and limit() to fix a...

2017-12-06 Thread kellyzly
Github user kellyzly commented on the issue: https://github.com/apache/spark/pull/19854 thanks @HyukjinKwon ,@srowen, @viirya 's review --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #19893: [SPARK-16139][TEST] Add logging functionality for leaked...

2017-12-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19893 **[Test build #84574 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84574/testReport)** for PR 19893 at commit

[GitHub] spark pull request #19792: [SPARK-22566][PYTHON] Better error message for `_...

2017-12-06 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19792#discussion_r155424467 --- Diff: python/pyspark/sql/session.py --- @@ -405,14 +401,9 @@ def _createFromLocal(self, data, schema): data = list(data)

[GitHub] spark pull request #19882: [SPARK-22672][SQL][TEST] Refactor ORC Tests

2017-12-06 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19882#discussion_r155429024 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcFilterSuite.scala --- @@ -0,0 +1,368 @@ +/* + * Licensed

[GitHub] spark issue #19882: [SPARK-22672][SQL][TEST] Refactor ORC Tests

2017-12-06 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19882 I actually suggested similarly before: ``` org.apache.spark.sql.execution.datasources.csv.InferSchema org.apache.spark.sql.execution.datasources.json.InferSchema ```

[GitHub] spark issue #19683: [SPARK-21657][SQL] optimize explode quadratic memory con...

2017-12-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19683 **[Test build #84595 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84595/testReport)** for PR 19683 at commit

[GitHub] spark issue #19912: [SPARK-22719][SQL]Refactor ConstantPropagation

2017-12-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19912 **[Test build #84593 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84593/testReport)** for PR 19912 at commit

[GitHub] spark issue #19912: [SPARK-22719][SQL]Refactor ConstantPropagation

2017-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19912 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84593/ Test FAILed. ---

[GitHub] spark issue #19902: [SPARK-22452][SQL]Add getInt, getLong, getBoolean to Dat...

2017-12-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19902 **[Test build #84578 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84578/testReport)** for PR 19902 at commit

[GitHub] spark issue #19499: [SPARK-22279][SQL] Turn on spark.sql.hive.convertMetasto...

2017-12-06 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/19499 Good. The failures are expected ones and handled by #19882 . - org.apache.spark.sql.hive.orc.OrcQuerySuite.SPARK-8501: Avoids discovery schema from empty ORC files - The test case

[GitHub] spark issue #19912: [SPARK-22719][SQL]Refactor ConstantPropagation

2017-12-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19912 **[Test build #84596 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84596/testReport)** for PR 19912 at commit

[GitHub] spark pull request #19912: [SPARK-22719][SQL]Refactor ConstantPropagation

2017-12-06 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19912#discussion_r155415232 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala --- @@ -64,50 +64,91 @@ object ConstantFolding extends

[GitHub] spark issue #19893: [SPARK-16139][TEST] Add logging functionality for leaked...

2017-12-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19893 **[Test build #84580 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84580/testReport)** for PR 19893 at commit

[GitHub] spark issue #19882: [SPARK-22672][SQL][TEST] Refactor ORC Tests

2017-12-06 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19882 I meant in https://github.com/apache/spark/pull/19882#pullrequestreview-81708676, I liked this `Hive` prefix here so wondered if we could do the same thing for the main codes too. Since this

[GitHub] spark issue #19912: [SPARK-22719][SQL]Refactor ConstantPropagation

2017-12-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19912 **[Test build #84593 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84593/testReport)** for PR 19912 at commit

[GitHub] spark issue #19917: Add failing test for select with a splatted stream

2017-12-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19917 **[Test build #84592 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84592/testReport)** for PR 19917 at commit

[GitHub] spark issue #19885: [SPARK-22587] Spark job fails if fs.defaultFS and applic...

2017-12-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19885 **[Test build #84594 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84594/testReport)** for PR 19885 at commit

[GitHub] spark issue #19717: [SPARK-22646] [Submission] Spark on Kubernetes - basic s...

2017-12-06 Thread liyinan926
Github user liyinan926 commented on the issue: https://github.com/apache/spark/pull/19717 @vanzin @jerryshao @felixcheung @viirya @mridulm @ueshin @jiangxb1987 Really appreciate your time reviewing this! Do you have more comments? Given that we have at least one more PR (most likely

[GitHub] spark issue #19882: [SPARK-22672][SQL][TEST] Refactor ORC Tests

2017-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19882 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19882: [SPARK-22672][SQL][TEST] Refactor ORC Tests

2017-12-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19882 **[Test build #84581 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84581/testReport)** for PR 19882 at commit

[GitHub] spark issue #19882: [SPARK-22672][SQL][TEST] Refactor ORC Tests

2017-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19882 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84581/ Test PASSed. ---

[GitHub] spark issue #19893: [SPARK-16139][TEST] Add logging functionality for leaked...

2017-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19893 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19893: [SPARK-16139][TEST] Add logging functionality for leaked...

2017-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19893 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84580/ Test PASSed. ---

[GitHub] spark issue #19882: [SPARK-22672][SQL][TEST] Refactor ORC Tests

2017-12-06 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/19882 @HyukjinKwon . The PR code and description is updated. - Update comments - Rename back to the originals The main reason I used prefix `Hive` is for naming consistency, but now

[GitHub] spark issue #19364: [SPARK-22144][SQL] ExchangeCoordinator combine the parti...

2017-12-06 Thread liutang123
Github user liutang123 commented on the issue: https://github.com/apache/spark/pull/19364 @cloud-fan Would you please look at this when you have time? --- - To unsubscribe, e-mail:

[GitHub] spark issue #19917: [SPARK-22725][SQL] Add failing test for select with a sp...

2017-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19917 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19917: [SPARK-22725][SQL] Add failing test for select with a sp...

2017-12-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19917 **[Test build #84592 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84592/testReport)** for PR 19917 at commit

[GitHub] spark issue #19912: [SPARK-22719][SQL]Refactor ConstantPropagation

2017-12-06 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/19912 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19917: [SPARK-22725][SQL] Add failing test for select with a sp...

2017-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19917 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84592/ Test FAILed. ---

[GitHub] spark issue #19901: [SPARK-22705][SQL] Case, Coalesce, and In use less globa...

2017-12-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19901 **[Test build #84588 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84588/testReport)** for PR 19901 at commit

[GitHub] spark issue #19882: [SPARK-22672][SQL][TEST] Refactor ORC Tests

2017-12-06 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19882 LGTM BTW. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #19882: [SPARK-22672][SQL][TEST] Refactor ORC Tests

2017-12-06 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19882#discussion_r155410507 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcFilterSuite.scala --- @@ -0,0 +1,368 @@ +/* + * Licensed

[GitHub] spark issue #19676: [SPARK-14516][FOLLOWUP] Adding ClusteringEvaluator to ex...

2017-12-06 Thread yanboliang
Github user yanboliang commented on the issue: https://github.com/apache/spark/pull/19676 It's good to have this, sorry for late response, I will make a pass tomorrow. Thanks. --- - To unsubscribe, e-mail:

[GitHub] spark pull request #19882: [SPARK-22672][SQL][TEST] Refactor ORC Tests

2017-12-06 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19882#discussion_r155428391 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcFilterSuite.scala --- @@ -0,0 +1,368 @@ +/* + * Licensed

[GitHub] spark issue #19882: [SPARK-22672][SQL][TEST] Refactor ORC Tests

2017-12-06 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/19882 Thank you so much, @HyukjinKwon ! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #19917: Add failing test for select with a splatted strea...

2017-12-06 Thread ash211
GitHub user ash211 opened a pull request: https://github.com/apache/spark/pull/19917 Add failing test for select with a splatted stream ## What changes were proposed in this pull request? Add additional test. ## How was this patch tested? Additional test.

[GitHub] spark issue #19882: [SPARK-22672][SQL][TEST] Refactor ORC Tests

2017-12-06 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19882 Yup but I actually received an advise before. I suggested: ``` ``` ``` org.apache.spark.sql.execution.datasources.csv.CSVInferSchema

[GitHub] spark issue #19917: Add failing test for select with a splatted stream

2017-12-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19917 **[Test build #84590 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84590/testReport)** for PR 19917 at commit

[GitHub] spark issue #19882: [SPARK-22672][SQL][TEST] Refactor ORC Tests

2017-12-06 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/19882 Definitely, my bad. For the main code, we can do later in a separate PR if needed. I hope this PR contains tests only. ---

[GitHub] spark issue #19882: [SPARK-22672][SQL][TEST] Refactor ORC Tests

2017-12-06 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19882 I am sorry, I had to clarify this ahead .. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19911: [SPARK-22717][SQL] Correct cascade default for postgres

2017-12-06 Thread danielvdende
Github user danielvdende commented on the issue: https://github.com/apache/spark/pull/19911 Sure, I'll make the changes :). I'll use this PR, seems to make sense, as it would fix truncate for postgres --- - To

[GitHub] spark issue #19911: [SPARK-22717][SQL] Correct cascade default for postgres

2017-12-06 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/19911 Great! I'm looking forward your new PR, @danielvdende . I can help you a little bit during review. :) --- - To

[GitHub] spark issue #19885: [SPARK-22587] Spark job fails if fs.defaultFS and applic...

2017-12-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19885 **[Test build #84594 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84594/testReport)** for PR 19885 at commit

[GitHub] spark issue #19885: [SPARK-22587] Spark job fails if fs.defaultFS and applic...

2017-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19885 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84594/ Test PASSed. ---

[GitHub] spark issue #19885: [SPARK-22587] Spark job fails if fs.defaultFS and applic...

2017-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19885 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19902: [SPARK-22452][SQL]Add getInt, getLong, getBoolean to Dat...

2017-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19902 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84578/ Test PASSed. ---

[GitHub] spark pull request #19912: [SPARK-22719][SQL]Refactor ConstantPropagation

2017-12-06 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19912#discussion_r155411680 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala --- @@ -64,50 +64,91 @@ object ConstantFolding extends

[GitHub] spark issue #19499: [SPARK-22279][SQL] Turn on spark.sql.hive.convertMetasto...

2017-12-06 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/19499 I'll retrigger after merging #19882 . --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19902: [SPARK-22452][SQL]Add getInt, getLong, getBoolean to Dat...

2017-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19902 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19902: [SPARK-22452][SQL]Add getInt, getLong, getBoolean to Dat...

2017-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19902 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84579/ Test PASSed. ---

[GitHub] spark pull request #19525: [SPARK-22289] [ML] Add JSON support for Matrix pa...

2017-12-06 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/19525#discussion_r155414954 --- Diff: mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala --- @@ -2769,6 +2769,20 @@ class

[GitHub] spark pull request #19525: [SPARK-22289] [ML] Add JSON support for Matrix pa...

2017-12-06 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/19525#discussion_r155413347 --- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala --- @@ -122,17 +124,33 @@ private[ml] object Param { /** Decodes a

[GitHub] spark pull request #19525: [SPARK-22289] [ML] Add JSON support for Matrix pa...

2017-12-06 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/19525#discussion_r155411609 --- Diff: mllib/src/main/scala/org/apache/spark/ml/linalg/JsonMatrixConverter.scala --- @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #19525: [SPARK-22289] [ML] Add JSON support for Matrix pa...

2017-12-06 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/19525#discussion_r155412287 --- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala --- @@ -122,17 +124,33 @@ private[ml] object Param { /** Decodes a

[GitHub] spark pull request #19912: [SPARK-22719][SQL]Refactor ConstantPropagation

2017-12-06 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19912#discussion_r155414906 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala --- @@ -64,50 +64,91 @@ object ConstantFolding extends

[GitHub] spark issue #19912: [SPARK-22719][SQL]Refactor ConstantPropagation

2017-12-06 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/19912 New algorithm looks correct and good. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #19525: [SPARK-22289] [ML] Add JSON support for Matrix pa...

2017-12-06 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/19525#discussion_r155414284 --- Diff: mllib-local/src/main/scala/org/apache/spark/ml/linalg/Matrices.scala --- @@ -476,6 +476,10 @@ class DenseMatrix @Since("2.0.0") (

[GitHub] spark issue #19901: [SPARK-22705][SQL] Case, Coalesce, and In use less globa...

2017-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19901 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84588/ Test PASSed. ---

[GitHub] spark issue #19901: [SPARK-22705][SQL] Case, Coalesce, and In use less globa...

2017-12-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19901 **[Test build #84588 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84588/testReport)** for PR 19901 at commit

[GitHub] spark issue #19901: [SPARK-22705][SQL] Case, Coalesce, and In use less globa...

2017-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19901 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19882: [SPARK-22672][SQL][TEST] Refactor ORC Tests

2017-12-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19882 **[Test build #84589 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84589/testReport)** for PR 19882 at commit

[GitHub] spark issue #19882: [SPARK-22672][SQL][TEST] Refactor ORC Tests

2017-12-06 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/19882 Oh. I'll bring back. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19813: [SPARK-22600][SQL] Fix 64kb limit for deeply nested expr...

2017-12-06 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/19813 LGTM, good job! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19882: [SPARK-22672][SQL][TEST] Refactor ORC Tests

2017-12-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19882 **[Test build #84589 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84589/testReport)** for PR 19882 at commit

[GitHub] spark issue #19882: [SPARK-22672][SQL][TEST] Refactor ORC Tests

2017-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19882 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19882: [SPARK-22672][SQL][TEST] Refactor ORC Tests

2017-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19882 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84589/ Test PASSed. ---

[GitHub] spark issue #19902: [SPARK-22452][SQL]Add getInt, getLong, getBoolean to Dat...

2017-12-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19902 **[Test build #84579 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84579/testReport)** for PR 19902 at commit

[GitHub] spark issue #19902: [SPARK-22452][SQL]Add getInt, getLong, getBoolean to Dat...

2017-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19902 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #19882: [SPARK-22672][SQL][TEST] Refactor ORC Tests

2017-12-06 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19882#discussion_r155398123 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcFilterSuite.scala --- @@ -0,0 +1,370 @@ +/* + * Licensed

[GitHub] spark pull request #19912: [SPARK-22719][SQL]Refactor ConstantPropagation

2017-12-06 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19912#discussion_r155413508 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala --- @@ -64,50 +64,91 @@ object ConstantFolding extends

[GitHub] spark issue #19901: [SPARK-22705][SQL] Case, Coalesce, and In use less globa...

2017-12-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19901 **[Test build #84584 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84584/testReport)** for PR 19901 at commit

[GitHub] spark issue #19901: [SPARK-22705][SQL] Case, Coalesce, and In use less globa...

2017-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19901 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19901: [SPARK-22705][SQL] Case, Coalesce, and In use less globa...

2017-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19901 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84584/ Test PASSed. ---

[GitHub] spark issue #19041: [SPARK-21097][CORE] Add option to recover cached data

2017-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19041 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84585/ Test FAILed. ---

[GitHub] spark issue #19041: [SPARK-21097][CORE] Add option to recover cached data

2017-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19041 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19041: [SPARK-21097][CORE] Add option to recover cached data

2017-12-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19041 **[Test build #84585 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84585/testReport)** for PR 19041 at commit

[GitHub] spark issue #19882: [SPARK-22672][SQL][TEST] Refactor ORC Tests

2017-12-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19882 **[Test build #84591 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84591/testReport)** for PR 19882 at commit

[GitHub] spark issue #19912: [SPARK-22719][SQL]Refactor ConstantPropagation

2017-12-06 Thread gengliangwang
Github user gengliangwang commented on the issue: https://github.com/apache/spark/pull/19912 @gatorsmile @viirya thanks for reviewing! I have addressed your comments. --- - To unsubscribe, e-mail:

[GitHub] spark issue #19905: [SPARK-22710] ConfigBuilder.fallbackConf should trigger ...

2017-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19905 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84551/ Test PASSed. ---

[GitHub] spark issue #19905: [SPARK-22710] ConfigBuilder.fallbackConf should trigger ...

2017-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19905 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19893: [SPARK-16139][TEST] Add logging functionality for leaked...

2017-12-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19893 **[Test build #4006 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4006/testReport)** for PR 19893 at commit

[GitHub] spark issue #19911: [SPARK-22717][SQL] Correct cascade default for postgres

2017-12-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19911 **[Test build #4005 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4005/testReport)** for PR 19911 at commit

  1   2   3   4   5   6   7   >