[GitHub] spark issue #20138: [SPARK-20664][core] Delete stale application data from S...

2018-01-16 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/20138 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19872: [SPARK-22274][PYTHON][SQL] User-defined aggregation func...

2018-01-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19872 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86187/ Test FAILed. ---

[GitHub] spark pull request #20284: [SPARK-23103][core] Ensure correct sort order for...

2018-01-16 Thread vanzin
GitHub user vanzin opened a pull request: https://github.com/apache/spark/pull/20284 [SPARK-23103][core] Ensure correct sort order for negative values in LevelDB. The code was sorting "0" as "less than" negative values, which is a little wrong. Fix is simple, most of the

[GitHub] spark issue #20279: [SPARK-23092][SQL] Migrate MemoryStream to DataSourceV2 ...

2018-01-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20279 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86190/ Test FAILed. ---

[GitHub] spark issue #20279: [SPARK-23092][SQL] Migrate MemoryStream to DataSourceV2 ...

2018-01-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20279 Build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #20168: [SPARK-22730][ML] Add ImageSchema support for all OpenCv...

2018-01-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20168 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20168: [SPARK-22730][ML] Add ImageSchema support for all OpenCv...

2018-01-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20168 **[Test build #86207 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86207/testReport)** for PR 20168 at commit

[GitHub] spark issue #20168: [SPARK-22730][ML] Add ImageSchema support for all OpenCv...

2018-01-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20168 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86207/ Test PASSed. ---

[GitHub] spark pull request #20243: [SPARK-23052][SS] Migrate ConsoleSink to data sou...

2018-01-16 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/20243#discussion_r161926178 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/console.scala --- @@ -17,58 +17,36 @@ package

[GitHub] spark pull request #20138: [SPARK-20664][core] Delete stale application data...

2018-01-16 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20138#discussion_r161880321 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala --- @@ -405,49 +404,70 @@ private[history] class

[GitHub] spark issue #20282: [SPARK-23093][SS] Don't change run id when reconfiguring...

2018-01-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20282 **[Test build #86198 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86198/testReport)** for PR 20282 at commit

[GitHub] spark issue #20265: [SPARK-21783][SQL] Turn on ORC filter push-down by defau...

2018-01-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20265 **[Test build #86200 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86200/testReport)** for PR 20265 at commit

[GitHub] spark issue #20023: [SPARK-22036][SQL] Decimal multiplication with high prec...

2018-01-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20023 **[Test build #86182 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86182/testReport)** for PR 20023 at commit

[GitHub] spark issue #20283: [SPARK-23095][SQL] Decorrelation of scalar subquery fail...

2018-01-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20283 **[Test build #86201 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86201/testReport)** for PR 20283 at commit

[GitHub] spark issue #20282: [SPARK-23093][SS] Don't change run id when reconfiguring...

2018-01-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20282 **[Test build #86203 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86203/testReport)** for PR 20282 at commit

[GitHub] spark issue #20280: [SPARK-22232][PYTHON][SQL] Fixed Row pickling to include...

2018-01-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20280 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86204/ Test FAILed. ---

[GitHub] spark issue #20280: [SPARK-22232][PYTHON][SQL] Fixed Row pickling to include...

2018-01-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20280 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20243: [SPARK-23052][SS] Migrate ConsoleSink to data sou...

2018-01-16 Thread jose-torres
Github user jose-torres commented on a diff in the pull request: https://github.com/apache/spark/pull/20243#discussion_r161908335 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/console.scala --- @@ -17,58 +17,36 @@ package

[GitHub] spark issue #20019: [SPARK-22361][SQL][TEST] Add unit test for Window Frames

2018-01-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20019 **[Test build #86191 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86191/testReport)** for PR 20019 at commit

[GitHub] spark issue #20284: [SPARK-23103][core] Ensure correct sort order for negati...

2018-01-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20284 **[Test build #86210 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86210/testReport)** for PR 20284 at commit

[GitHub] spark issue #20280: [SPARK-22232][PYTHON][SQL] Fixed Row pickling to include...

2018-01-16 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20280 Ahh. @zero323 too if you are available because I think we had a talk about this somewhere long time ago. Yea, I am aware of the issue itself. Will take a look soon. ---

[GitHub] spark issue #20243: [SPARK-23052][SS] Migrate ConsoleSink to data source V2 ...

2018-01-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20243 **[Test build #86212 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86212/testReport)** for PR 20243 at commit

[GitHub] spark issue #20236: [SPARK-23044] Error handling for jira assignment

2018-01-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20236 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20255: [SPARK-23064][DOCS][SS] Added documentation for stream-s...

2018-01-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20255 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86214/ Test PASSed. ---

[GitHub] spark issue #20255: [SPARK-23064][DOCS][SS] Added documentation for stream-s...

2018-01-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20255 **[Test build #86214 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86214/testReport)** for PR 20255 at commit

[GitHub] spark issue #20236: [SPARK-23044] Error handling for jira assignment

2018-01-16 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/20236 Merging to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20138: [SPARK-20664][core] Delete stale application data from S...

2018-01-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20138 **[Test build #86199 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86199/testReport)** for PR 20138 at commit

[GitHub] spark issue #20266: [SPARK-23072][SQL][TEST] Add a Unicode schema test for f...

2018-01-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20266 **[Test build #86184 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86184/testReport)** for PR 20266 at commit

[GitHub] spark issue #19872: [SPARK-22274][PYTHON][SQL] User-defined aggregation func...

2018-01-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19872 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86196/ Test PASSed. ---

[GitHub] spark issue #19872: [SPARK-22274][PYTHON][SQL] User-defined aggregation func...

2018-01-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19872 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20255: [SPARK-23064][DOCS][SS] Added documentation for stream-s...

2018-01-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20255 **[Test build #86215 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86215/testReport)** for PR 20255 at commit

[GitHub] spark issue #19872: [SPARK-22274][PYTHON][SQL] User-defined aggregation func...

2018-01-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19872 **[Test build #86196 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86196/testReport)** for PR 19872 at commit

[GitHub] spark issue #20236: [SPARK-23044] Error handling for jira assignment

2018-01-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20236 **[Test build #86197 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86197/testReport)** for PR 20236 at commit

[GitHub] spark issue #20282: [SPARK-23093][SS] Don't change run id when reconfiguring...

2018-01-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20282 **[Test build #86198 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86198/testReport)** for PR 20282 at commit

[GitHub] spark issue #20282: [SPARK-23093][SS] Don't change run id when reconfiguring...

2018-01-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20282 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86198/ Test FAILed. ---

[GitHub] spark issue #20282: [SPARK-23093][SS] Don't change run id when reconfiguring...

2018-01-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20282 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20279: [SPARK-23092][SQL] Migrate MemoryStream to DataSourceV2 ...

2018-01-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20279 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86192/ Test FAILed. ---

[GitHub] spark issue #20279: [SPARK-23092][SQL] Migrate MemoryStream to DataSourceV2 ...

2018-01-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20279 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20266: [SPARK-23072][SQL][TEST] Add a Unicode schema test for f...

2018-01-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20266 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20266: [SPARK-23072][SQL][TEST] Add a Unicode schema test for f...

2018-01-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20266 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86184/ Test PASSed. ---

[GitHub] spark issue #19872: [SPARK-22274][PYTHON][SQL] User-defined aggregation func...

2018-01-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19872 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20168: [SPARK-22730][ML] Add ImageSchema support for all...

2018-01-16 Thread tomasatdatabricks
Github user tomasatdatabricks commented on a diff in the pull request: https://github.com/apache/spark/pull/20168#discussion_r161903575 --- Diff: mllib/src/main/scala/org/apache/spark/ml/image/ImageSchema.scala --- @@ -37,20 +37,67 @@ import org.apache.spark.sql.types._

[GitHub] spark issue #19872: [SPARK-22274][PYTHON][SQL] User-defined aggregation func...

2018-01-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19872 **[Test build #86189 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86189/testReport)** for PR 19872 at commit

[GitHub] spark issue #20280: [SPARK-22232][PYTHON][SQL] Fixed Row pickling to include...

2018-01-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20280 **[Test build #86205 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86205/testReport)** for PR 20280 at commit

[GitHub] spark issue #20203: [SPARK-22577] [core] executor page blacklist status shou...

2018-01-16 Thread ajbozarth
Github user ajbozarth commented on the issue: https://github.com/apache/spark/pull/20203 @squito thanks, I missed the img link and misread ExecutorTable as ExecutorPage. On that note the UI portion of this change LGTM. ---

[GitHub] spark pull request #20138: [SPARK-20664][core] Delete stale application data...

2018-01-16 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20138#discussion_r161882635 --- Diff: core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala --- @@ -663,6 +665,95 @@ class FsHistoryProviderSuite extends

[GitHub] spark pull request #20229: [SPARK-23045][ML][SparkR] Update RFormula to use ...

2018-01-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20229 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20282: [SPARK-23093][SS] Don't change run id when reconf...

2018-01-16 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/20282#discussion_r161884338 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/continuous/ContinuousExecution.scala --- @@ -210,15 +214,17 @@ class

[GitHub] spark issue #20265: [SPARK-21783][SQL] Turn on ORC filter push-down by defau...

2018-01-16 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/20265 I updated the PR (except one RowGroupSize/OrcStripeSize part). --- - To unsubscribe, e-mail:

[GitHub] spark issue #19872: [SPARK-22274][PYTHON][SQL] User-defined aggregation func...

2018-01-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19872 **[Test build #86188 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86188/testReport)** for PR 19872 at commit

[GitHub] spark pull request #20168: [SPARK-22730][ML] Add ImageSchema support for all...

2018-01-16 Thread tomasatdatabricks
Github user tomasatdatabricks commented on a diff in the pull request: https://github.com/apache/spark/pull/20168#discussion_r161904121 --- Diff: python/pyspark/ml/tests.py --- @@ -1843,6 +1844,28 @@ def tearDown(self): class ImageReaderTest(SparkSessionTestCase):

[GitHub] spark issue #20019: [SPARK-22361][SQL][TEST] Add unit test for Window Frames

2018-01-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20019 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20019: [SPARK-22361][SQL][TEST] Add unit test for Window Frames

2018-01-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20019 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86191/ Test PASSed. ---

[GitHub] spark pull request #20243: [SPARK-23052][SS] Migrate ConsoleSink to data sou...

2018-01-16 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/20243#discussion_r161926404 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/console.scala --- @@ -17,58 +17,36 @@ package

[GitHub] spark pull request #20203: [SPARK-22577] [core] executor page blacklist stat...

2018-01-16 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/20203#discussion_r161884194 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetBlacklist.scala --- @@ -36,7 +36,9 @@ import org.apache.spark.util.Clock *

[GitHub] spark pull request #20253: [SPARK-22908][SS] Roll forward continuous process...

2018-01-16 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/20253#discussion_r161901653 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaContinuousTest.scala --- @@ -0,0 +1,91 @@ +/* + * Licensed to the

[GitHub] spark pull request #20253: [SPARK-22908][SS] Roll forward continuous process...

2018-01-16 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/20253#discussion_r161901683 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaContinuousTest.scala --- @@ -0,0 +1,91 @@ +/* + * Licensed to the

[GitHub] spark issue #19872: [SPARK-22274][PYTHON][SQL] User-defined aggregation func...

2018-01-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19872 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86188/ Test FAILed. ---

[GitHub] spark issue #19872: [SPARK-22274][PYTHON][SQL] User-defined aggregation func...

2018-01-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19872 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20253: [SPARK-22908][SS] Roll forward continuous processing Kaf...

2018-01-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20253 **[Test build #86208 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86208/testReport)** for PR 20253 at commit

[GitHub] spark issue #20203: [SPARK-22577] [core] executor page blacklist status shou...

2018-01-16 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20203 attila attached some screenshots to the jira (showing both what happens with stage blacklisting and full application blacklisting). The only change here is to the page for a specific stage,

[GitHub] spark pull request #20255: [SPARK-23064][DOCS][SS] Added documentation for s...

2018-01-16 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/20255#discussion_r161925337 --- Diff: docs/structured-streaming-programming-guide.md --- @@ -2142,6 +2452,7 @@ write.stream(aggDF, "memory", outputMode = "complete", checkpointLocation =

[GitHub] spark issue #20280: [SPARK-22232][PYTHON][SQL] Fixed Row pickling to include...

2018-01-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20280 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20266: [SPARK-23072][SQL][TEST] Add a Unicode schema test for f...

2018-01-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20266 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20203: [SPARK-22577] [core] executor page blacklist stat...

2018-01-16 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/20203#discussion_r161884916 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetBlacklist.scala --- @@ -128,13 +130,17 @@ private[scheduler] class TaskSetBlacklist(val

[GitHub] spark pull request #20203: [SPARK-22577] [core] executor page blacklist stat...

2018-01-16 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/20203#discussion_r161885726 --- Diff: core/src/test/resources/HistoryServerExpectations/stage_blacklisting_for_stage_expectation.json --- @@ -0,0 +1,639 @@ +{ --- End diff --

[GitHub] spark pull request #20203: [SPARK-22577] [core] executor page blacklist stat...

2018-01-16 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/20203#discussion_r161885207 --- Diff: core/src/main/scala/org/apache/spark/status/AppStatusListener.scala --- @@ -211,6 +211,11 @@ private[spark] class AppStatusListener(

[GitHub] spark issue #20023: [SPARK-22036][SQL] Decimal multiplication with high prec...

2018-01-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20023 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86182/ Test PASSed. ---

[GitHub] spark issue #20203: [SPARK-22577] [core] executor page blacklist status shou...

2018-01-16 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20203 @ajbozarth maybe you have some thoughts on the UI, and whether it makes sense to put anything on the executors page? @CodingCat you also often have good UI suggestions :) thanks

[GitHub] spark issue #20023: [SPARK-22036][SQL] Decimal multiplication with high prec...

2018-01-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20023 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20282: [SPARK-23093][SS] Don't change run id when reconfiguring...

2018-01-16 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/20282 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20280: [SPARK-22232][PYTHON][SQL] Fixed Row pickling to include...

2018-01-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20280 **[Test build #86204 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86204/testReport)** for PR 20280 at commit

[GitHub] spark issue #20266: [SPARK-23072][SQL][TEST] Add a Unicode schema test for f...

2018-01-16 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/20266 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20279: [SPARK-23092][SQL] Migrate MemoryStream to DataSourceV2 ...

2018-01-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20279 **[Test build #86206 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86206/testReport)** for PR 20279 at commit

[GitHub] spark issue #20274: [SPARK-20120][SQL][FOLLOW-UP] Better way to support spar...

2018-01-16 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/20274 How is the silent mode broken? Could you elaborate on that? --- - To unsubscribe, e-mail:

[GitHub] spark pull request #19247: [Spark-21996][SQL] read files with space in name ...

2018-01-16 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/19247#discussion_r161907322 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/FileStreamSourceSuite.scala --- @@ -408,6 +420,18 @@ class FileStreamSourceSuite extends

[GitHub] spark issue #20243: [SPARK-23052][SS] Migrate ConsoleSink to data source V2 ...

2018-01-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20243 **[Test build #86209 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86209/testReport)** for PR 20243 at commit

[GitHub] spark issue #20019: [SPARK-22361][SQL][TEST] Add unit test for Window Frames

2018-01-16 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/20019 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #20243: [SPARK-23052][SS] Migrate ConsoleSink to data sou...

2018-01-16 Thread jose-torres
Github user jose-torres commented on a diff in the pull request: https://github.com/apache/spark/pull/20243#discussion_r161910857 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/ConsoleWriter.scala --- @@ -0,0 +1,56 @@ +/* + * Licensed

[GitHub] spark issue #20255: [SPARK-23064][DOCS][SS] Added documentation for stream-s...

2018-01-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20255 **[Test build #86214 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86214/testReport)** for PR 20255 at commit

[GitHub] spark pull request #20282: [SPARK-23093][SS] Don't change run id when reconf...

2018-01-16 Thread jose-torres
GitHub user jose-torres opened a pull request: https://github.com/apache/spark/pull/20282 [SPARK-23093][SS] Don't change run id when reconfiguring a continuous processing query. ## What changes were proposed in this pull request? Keep the run ID static, using a different

[GitHub] spark issue #20266: [SPARK-23072][SQL][TEST] Add a Unicode schema test for f...

2018-01-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20266 **[Test build #86183 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86183/testReport)** for PR 20266 at commit

[GitHub] spark pull request #20283: [SPARK-23095][SQL] Decorrelation of scalar subque...

2018-01-16 Thread dilipbiswal
GitHub user dilipbiswal opened a pull request: https://github.com/apache/spark/pull/20283 [SPARK-23095][SQL] Decorrelation of scalar subquery fails with java.util.NoSuchElementException ## What changes were proposed in this pull request? The following SQL involving scalar

[GitHub] spark pull request #19247: [Spark-21996][SQL] read files with space in name ...

2018-01-16 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/19247#discussion_r161893771 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/FileStreamSourceSuite.scala --- @@ -408,6 +420,18 @@ class FileStreamSourceSuite extends

[GitHub] spark issue #20091: [SPARK-22465][FOLLOWUP] Update the number of partitions ...

2018-01-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20091 **[Test build #86202 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86202/testReport)** for PR 20091 at commit

[GitHub] spark issue #20280: [SPARK-22232][PYTHON][SQL] Fixed Row pickling to include...

2018-01-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20280 **[Test build #86204 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86204/testReport)** for PR 20280 at commit

[GitHub] spark pull request #20253: [SPARK-22908][SS] Roll forward continuous process...

2018-01-16 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/20253#discussion_r161901973 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaContinuousTest.scala --- @@ -0,0 +1,91 @@ +/* + * Licensed to the

[GitHub] spark pull request #20253: [SPARK-22908][SS] Roll forward continuous process...

2018-01-16 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/20253#discussion_r161901930 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaContinuousTest.scala --- @@ -0,0 +1,91 @@ +/* + * Licensed to the

[GitHub] spark issue #19872: [SPARK-22274][PYTHON][SQL] User-defined aggregation func...

2018-01-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19872 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86189/ Test FAILed. ---

[GitHub] spark pull request #20168: [SPARK-22730][ML] Add ImageSchema support for all...

2018-01-16 Thread tomasatdatabricks
Github user tomasatdatabricks commented on a diff in the pull request: https://github.com/apache/spark/pull/20168#discussion_r161904044 --- Diff: mllib/src/test/scala/org/apache/spark/ml/image/ImageSchemaSuite.scala --- @@ -83,7 +83,8 @@ class ImageSchemaSuite extends

[GitHub] spark issue #19872: [SPARK-22274][PYTHON][SQL] User-defined aggregation func...

2018-01-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19872 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20280: [SPARK-22232][PYTHON][SQL] Fixed Row pickling to include...

2018-01-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20280 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86205/ Test PASSed. ---

[GitHub] spark pull request #19247: [Spark-21996][SQL] read files with space in name ...

2018-01-16 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/19247#discussion_r161906360 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/FileStreamSourceSuite.scala --- @@ -408,6 +420,18 @@ class FileStreamSourceSuite extends

[GitHub] spark issue #20280: [SPARK-22232][PYTHON][SQL] Fixed Row pickling to include...

2018-01-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20280 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20279: [SPARK-23092][SQL] Migrate MemoryStream to DataSourceV2 ...

2018-01-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20279 **[Test build #86190 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86190/testReport)** for PR 20279 at commit

[GitHub] spark issue #20280: [SPARK-22232][PYTHON][SQL] Fixed Row pickling to include...

2018-01-16 Thread MrBago
Github user MrBago commented on the issue: https://github.com/apache/spark/pull/20280 I think we should raise an error if `__from_dict__` is set and the user tries to index using a position or a slice. Indexing by field name takes the same code path for Rows that are and are

[GitHub] spark issue #20253: [SPARK-22908][SS] Roll forward continuous processing Kaf...

2018-01-16 Thread tdas
Github user tdas commented on the issue: https://github.com/apache/spark/pull/20253 LGTM, assuming tests pass. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20254: [SPARK-23062][SQL] Improve EXCEPT documentation

2018-01-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20254 **[Test build #86211 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86211/testReport)** for PR 20254 at commit

[GitHub] spark issue #20280: [SPARK-22232][PYTHON][SQL] Fixed Row pickling to include...

2018-01-16 Thread MrBago
Github user MrBago commented on the issue: https://github.com/apache/spark/pull/20280 BTW the performance issue is orthogonal to the serialization issue raised in this jira/PR. Maybe we should avoid scope creep in this thread. ---

[GitHub] spark issue #20153: [SPARK-22392][SQL] data source v2 columnar batch reader

2018-01-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20153 **[Test build #86163 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86163/testReport)** for PR 20153 at commit

  1   2   3   4   5   6   7   >