[GitHub] spark pull request #21126: [SPARK-24050][SS] Calculate input / processing ra...

2018-04-23 Thread tdas
GitHub user tdas opened a pull request: https://github.com/apache/spark/pull/21126 [SPARK-24050][SS] Calculate input / processing rates correctly for DataSourceV2 streaming sources ## What changes were proposed in this pull request? In some streaming queries, the input and

[GitHub] spark issue #21083: [SPARK-23564][SQL] infer additional filters from constra...

2018-04-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21083 **[Test build #89701 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89701/testReport)** for PR 21083 at commit

[GitHub] spark issue #21100: [SPARK-24012][SQL] Union of map and other compatible col...

2018-04-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21100 **[Test build #89696 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89696/testReport)** for PR 21100 at commit

[GitHub] spark issue #20940: [SPARK-23429][CORE] Add executor memory metrics to heart...

2018-04-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20940 **[Test build #89697 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89697/testReport)** for PR 20940 at commit

[GitHub] spark issue #20980: [SPARK-23589][SQL] ExternalMapToCatalyst should support ...

2018-04-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20980 **[Test build #89698 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89698/testReport)** for PR 20980 at commit

[GitHub] spark issue #21100: [SPARK-24012][SQL] Union of map and other compatible col...

2018-04-23 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/21100 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21111: [SPARK-23877][SQL][followup] use PhysicalOperation to si...

2018-04-23 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/2 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21120: [SPARK-22448][ML] Added sum function to Summerizer and M...

2018-04-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21120 **[Test build #89703 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89703/testReport)** for PR 21120 at commit

[GitHub] spark issue #21120: [SPARK-22448][ML] Added sum function to Summerizer and M...

2018-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21120 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89703/ Test FAILed. ---

[GitHub] spark issue #21120: [SPARK-22448][ML] Added sum function to Summerizer and M...

2018-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21120 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21083: [SPARK-23564][SQL] infer additional filters from constra...

2018-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21083 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #21083: [SPARK-23564][SQL] infer additional filters from ...

2018-04-23 Thread gengliangwang
Github user gengliangwang commented on a diff in the pull request: https://github.com/apache/spark/pull/21083#discussion_r183295844 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -664,53 +662,52 @@ object

[GitHub] spark issue #21083: [SPARK-23564][SQL] infer additional filters from constra...

2018-04-23 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/21083 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21083: [SPARK-23564][SQL] infer additional filters from constra...

2018-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21083 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2574/

[GitHub] spark issue #21126: [SPARK-24050][SS] Calculate input / processing rates cor...

2018-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21126 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2573/

[GitHub] spark issue #21126: [SPARK-24050][SS] Calculate input / processing rates cor...

2018-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21126 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21120: [SPARK-22448][ML] Added sum function to Summerizer and M...

2018-04-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21120 **[Test build #89703 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89703/testReport)** for PR 21120 at commit

[GitHub] spark pull request #21100: [SPARK-24012][SQL] Union of map and other compati...

2018-04-23 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21100#discussion_r183295681 --- Diff: sql/core/src/test/resources/sql-tests/inputs/union.sql --- @@ -35,6 +35,11 @@ FROM (SELECT col AS col SELECT col

[GitHub] spark pull request #21100: [SPARK-24012][SQL] Union of map and other compati...

2018-04-23 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21100#discussion_r183295566 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -111,6 +111,14 @@ object TypeCoercion {

[GitHub] spark pull request #21083: [SPARK-23564][SQL] infer additional filters from ...

2018-04-23 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21083#discussion_r183299130 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -664,53 +662,52 @@ object

[GitHub] spark pull request #21125: [Spark-24024] Fix poisson deviance calculations i...

2018-04-23 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/21125#discussion_r183282075 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala --- @@ -782,8 +782,12 @@ object GeneralizedLinearRegression

[GitHub] spark pull request #21125: [Spark-24024] Fix poisson deviance calculations i...

2018-04-23 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/21125#discussion_r183283116 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/GeneralizedLinearRegressionSuite.scala --- @@ -495,8 +495,8 @@ class

[GitHub] spark pull request #21125: [Spark-24024] Fix poisson deviance calculations i...

2018-04-23 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/21125#discussion_r183282476 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/GeneralizedLinearRegressionSuite.scala --- @@ -495,8 +495,8 @@ class

[GitHub] spark issue #21120: [SPARK-22448][ML] Added sum function to Summerizer and M...

2018-04-23 Thread dbtsai
Github user dbtsai commented on the issue: https://github.com/apache/spark/pull/21120 Why do you want to add this? Once we have mean, it's easy to compute sum. --- - To unsubscribe, e-mail:

[GitHub] spark issue #21111: [SPARK-23877][SQL][followup] use PhysicalOperation to si...

2018-04-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/2 **[Test build #89706 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89706/testReport)** for PR 2 at commit

[GitHub] spark pull request #21125: [Spark-24024] Fix poisson deviance calculations i...

2018-04-23 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/21125#discussion_r183283144 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/GeneralizedLinearRegressionSuite.scala --- @@ -507,7 +507,8 @@ class

[GitHub] spark issue #21118: SPARK-23325: Use InternalRow when reading with DataSourc...

2018-04-23 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/21118 @rdblue . Could you fix the remaining `KafkaMicroBatchSourceSuite.scala`, too? ```scala [error]

[GitHub] spark pull request #21018: [SPARK-23880][SQL] Do not trigger any jobs for ca...

2018-04-23 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21018#discussion_r183288666 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala --- @@ -794,4 +794,17 @@ class CachedTableSuite extends QueryTest with

[GitHub] spark pull request #21018: [SPARK-23880][SQL] Do not trigger any jobs for ca...

2018-04-23 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21018#discussion_r183288749 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryRelation.scala --- @@ -55,56 +42,38 @@ object InMemoryRelation {

[GitHub] spark issue #21126: [SPARK-24050][SS] Calculate input / processing rates cor...

2018-04-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21126 **[Test build #89702 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89702/testReport)** for PR 21126 at commit

[GitHub] spark issue #21100: [SPARK-24012][SQL] Union of map and other compatible col...

2018-04-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21100 **[Test build #89700 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89700/testReport)** for PR 21100 at commit

[GitHub] spark issue #20980: [SPARK-23589][SQL] ExternalMapToCatalyst should support ...

2018-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20980 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89698/ Test FAILed. ---

[GitHub] spark issue #20940: [SPARK-23429][CORE] Add executor memory metrics to heart...

2018-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20940 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89697/ Test FAILed. ---

[GitHub] spark issue #21083: [SPARK-23564][SQL] infer additional filters from constra...

2018-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21083 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20940: [SPARK-23429][CORE] Add executor memory metrics to heart...

2018-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20940 Build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #21100: [SPARK-24012][SQL] Union of map and other compatible col...

2018-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21100 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89696/ Test FAILed. ---

[GitHub] spark issue #21100: [SPARK-24012][SQL] Union of map and other compatible col...

2018-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21100 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89700/ Test FAILed. ---

[GitHub] spark issue #21111: [SPARK-23877][SQL][followup] use PhysicalOperation to si...

2018-04-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/2 **[Test build #89695 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89695/testReport)** for PR 2 at commit

[GitHub] spark issue #21083: [SPARK-23564][SQL] infer additional filters from constra...

2018-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21083 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89701/ Test FAILed. ---

[GitHub] spark issue #21126: [SPARK-24050][SS] Calculate input / processing rates cor...

2018-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21126 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89702/ Test FAILed. ---

[GitHub] spark issue #21100: [SPARK-24012][SQL] Union of map and other compatible col...

2018-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21100 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21126: [SPARK-24050][SS] Calculate input / processing rates cor...

2018-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21126 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21100: [SPARK-24012][SQL] Union of map and other compatible col...

2018-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21100 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20980: [SPARK-23589][SQL] ExternalMapToCatalyst should support ...

2018-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20980 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21111: [SPARK-23877][SQL][followup] use PhysicalOperation to si...

2018-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/2 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21111: [SPARK-23877][SQL][followup] use PhysicalOperation to si...

2018-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/2 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89695/ Test FAILed. ---

[GitHub] spark issue #21126: [SPARK-24050][SS] Calculate input / processing rates cor...

2018-04-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21126 **[Test build #89702 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89702/testReport)** for PR 21126 at commit

[GitHub] spark issue #19222: [SPARK-10399][SPARK-23879][CORE][SQL] Introduce multiple...

2018-04-23 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/19222 I think that one memory block in each iteration is more representative with having possibility of megamorphism. This is because in the typicalusages in Spark, a data structure is actually dominated

[GitHub] spark issue #21100: [SPARK-24012][SQL] Union of map and other compatible col...

2018-04-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21100 **[Test build #89704 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89704/testReport)** for PR 21100 at commit

[GitHub] spark issue #21083: [SPARK-23564][SQL] infer additional filters from constra...

2018-04-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21083 **[Test build #89705 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89705/testReport)** for PR 21083 at commit

[GitHub] spark issue #21100: [SPARK-24012][SQL] Union of map and other compatible col...

2018-04-23 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/21100 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #21100: [SPARK-24012][SQL] Union of map and other compati...

2018-04-23 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21100#discussion_r183296378 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -111,6 +111,14 @@ object TypeCoercion {

[GitHub] spark issue #21111: [SPARK-23877][SQL][followup] use PhysicalOperation to si...

2018-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/2 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2575/

[GitHub] spark issue #21111: [SPARK-23877][SQL][followup] use PhysicalOperation to si...

2018-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/2 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20933: [SPARK-23817][SQL]Migrate ORC file format read path to d...

2018-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20933 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2577/

[GitHub] spark issue #21018: [SPARK-23880][SQL] Do not trigger any jobs for caching d...

2018-04-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21018 **[Test build #89710 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89710/testReport)** for PR 21018 at commit

[GitHub] spark pull request #21123: [SPARK-24045][SQL]Create base class for file data...

2018-04-23 Thread gengliangwang
Github user gengliangwang commented on a diff in the pull request: https://github.com/apache/spark/pull/21123#discussion_r183318856 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -89,8 +91,13 @@ case class DataSource(

[GitHub] spark pull request #21123: [SPARK-24045][SQL]Create base class for file data...

2018-04-23 Thread gengliangwang
Github user gengliangwang commented on a diff in the pull request: https://github.com/apache/spark/pull/21123#discussion_r183318946 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/FileDataSourceV2.scala --- @@ -0,0 +1,43 @@ +/* + * Licensed

[GitHub] spark pull request #21123: [SPARK-24045][SQL]Create base class for file data...

2018-04-23 Thread gengliangwang
Github user gengliangwang commented on a diff in the pull request: https://github.com/apache/spark/pull/21123#discussion_r183318881 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala --- @@ -213,6 +215,25 @@ case class

[GitHub] spark issue #21018: [SPARK-23880][SQL] Do not trigger any jobs for caching d...

2018-04-23 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/21018 Don't forget to update PR description too. :) --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20146: [SPARK-11215][ML] Add multiple columns support to...

2018-04-23 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20146#discussion_r183336177 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala --- @@ -217,33 +295,32 @@ class StringIndexerModel ( @Since("1.4.0")

[GitHub] spark issue #21083: [SPARK-23564][SQL] infer additional filters from constra...

2018-04-23 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/21083 lgtm --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21123: [SPARK-24045][SQL]Create base class for file data source...

2018-04-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21123 **[Test build #89711 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89711/testReport)** for PR 21123 at commit

[GitHub] spark issue #20907: [SPARK-11237][ML] Add pmml export for k-means in Spark M...

2018-04-23 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20907 One question I have is, how do users know if a model (e.g. KMeansModel after this change) supports pmml & internal formats? I did a search on the current docs, but didn't find any info. ---

[GitHub] spark issue #21087: [SPARK-23997][SQL] Configurable maximum number of bucket...

2018-04-23 Thread ferdonline
Github user ferdonline commented on the issue: https://github.com/apache/spark/pull/21087 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21126: [SPARK-24050][SS] Calculate input / processing rates cor...

2018-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21126 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21126: [SPARK-24050][SS] Calculate input / processing rates cor...

2018-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21126 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2576/

[GitHub] spark issue #20933: [SPARK-23817][SQL]Migrate ORC file format read path to d...

2018-04-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20933 **[Test build #89708 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89708/testReport)** for PR 20933 at commit

[GitHub] spark issue #20980: [SPARK-23589][SQL] ExternalMapToCatalyst should support ...

2018-04-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20980 **[Test build #89709 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89709/testReport)** for PR 20980 at commit

[GitHub] spark issue #21120: [SPARK-22448][ML] Added sum function to Summerizer and M...

2018-04-23 Thread dedunumax
Github user dedunumax commented on the issue: https://github.com/apache/spark/pull/21120 Having sum as a basic statistic will make the API user-friendly. I'm thinking about implementing other functions as well. Do you think it is not worth to implement this? ---

[GitHub] spark issue #21083: [SPARK-23564][SQL] infer additional filters from constra...

2018-04-23 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/21083 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20980: [SPARK-23589][SQL] ExternalMapToCatalyst should support ...

2018-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20980 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21126: [SPARK-24050][SS] Calculate input / processing rates cor...

2018-04-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21126 **[Test build #89707 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89707/testReport)** for PR 21126 at commit

[GitHub] spark issue #21063: [SPARK-23886][Structured Streaming] Update query status ...

2018-04-23 Thread efimpoberezkin
Github user efimpoberezkin commented on the issue: https://github.com/apache/spark/pull/21063 @jose-torres Hi Jose, could you review and tell me if we need more tests or a single one will do? Also is it fine to assert status after every stream action? ---

[GitHub] spark issue #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to handle...

2018-04-23 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20345 ping --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21018: [SPARK-23880][SQL] Do not trigger any jobs for caching d...

2018-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21018 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21018: [SPARK-23880][SQL] Do not trigger any jobs for caching d...

2018-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21018 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2579/

[GitHub] spark issue #20907: [SPARK-11237][ML] Add pmml export for k-means in Spark M...

2018-04-23 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20907 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #21018: [SPARK-23880][SQL] Do not trigger any jobs for ca...

2018-04-23 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21018#discussion_r183322924 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryRelation.scala --- @@ -155,31 +125,76 @@ case class InMemoryRelation(

[GitHub] spark issue #21123: [SPARK-24045][SQL]Create base class for file data source...

2018-04-23 Thread gengliangwang
Github user gengliangwang commented on the issue: https://github.com/apache/spark/pull/21123 @rdblue --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #20146: [SPARK-11215][ML] Add multiple columns support to...

2018-04-23 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20146#discussion_r183334835 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala --- @@ -79,26 +80,56 @@ private[feature] trait StringIndexerBase extends

[GitHub] spark issue #21126: [SPARK-24050][SS] Calculate input / processing rates cor...

2018-04-23 Thread tdas
Github user tdas commented on the issue: https://github.com/apache/spark/pull/21126 jenkins retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #21072: [SPARK-23973][SQL] Remove consecutive Sorts

2018-04-23 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/21072#discussion_r183311275 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -736,12 +736,22 @@ object EliminateSorts extends

[GitHub] spark issue #20933: [SPARK-23817][SQL]Migrate ORC file format read path to d...

2018-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20933 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20980: [SPARK-23589][SQL] ExternalMapToCatalyst should support ...

2018-04-23 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20980 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20980: [SPARK-23589][SQL] ExternalMapToCatalyst should support ...

2018-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20980 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2578/

[GitHub] spark issue #21123: [SPARK-24045][SQL]Create base class for file data source...

2018-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21123 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21123: [SPARK-24045][SQL]Create base class for file data source...

2018-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21123 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2580/

[GitHub] spark pull request #21018: [SPARK-23880][SQL] Do not trigger any jobs for ca...

2018-04-23 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21018#discussion_r183325713 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryRelation.scala --- @@ -55,56 +42,39 @@ object InMemoryRelation {

[GitHub] spark pull request #20146: [SPARK-11215][ML] Add multiple columns support to...

2018-04-23 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20146#discussion_r18752 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala --- @@ -79,26 +80,56 @@ private[feature] trait StringIndexerBase extends

[GitHub] spark pull request #19881: [SPARK-22683][CORE] Add a executorAllocationRatio...

2018-04-23 Thread jcuquemelle
Github user jcuquemelle commented on a diff in the pull request: https://github.com/apache/spark/pull/19881#discussion_r183337131 --- Diff: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala --- @@ -26,7 +26,10 @@ import scala.util.control.{ControlThrowable,

[GitHub] spark issue #21125: [Spark-24024] Fix poisson deviance calculations in GLM t...

2018-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21125 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21125: [Spark-24024] Fix poisson deviance calculations in GLM t...

2018-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21125 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89699/ Test PASSed. ---

[GitHub] spark issue #21125: [Spark-24024] Fix poisson deviance calculations in GLM t...

2018-04-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21125 **[Test build #89699 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89699/testReport)** for PR 21125 at commit

[GitHub] spark issue #21120: [SPARK-22448][ML] Added sum function to Summerizer and M...

2018-04-23 Thread dbtsai
Github user dbtsai commented on the issue: https://github.com/apache/spark/pull/21120 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20933: [SPARK-23817][SQL]Migrate ORC file format read path to d...

2018-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20933 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89708/ Test FAILed. ---

[GitHub] spark issue #20933: [SPARK-23817][SQL]Migrate ORC file format read path to d...

2018-04-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20933 **[Test build #89708 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89708/testReport)** for PR 20933 at commit

[GitHub] spark issue #20933: [SPARK-23817][SQL]Migrate ORC file format read path to d...

2018-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20933 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21128: [SPARK-24053][CORE] Support add subdirectory named as us...

2018-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21128 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20980: [SPARK-23589][SQL] ExternalMapToCatalyst should s...

2018-04-23 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/20980#discussion_r183374589 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -1255,8 +1255,64 @@ case class

  1   2   3   4   5   6   >