Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21537
I think we can set up a place (mailling list or JIRA) to discuss the
further thing about IR design, as suggested by @HyukjinKwon. This can be a
co-work from interesting parties.
---
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/20637
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20637
**[Test build #94878 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94878/testReport)**
for PR 20637 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/22119
@tgravescs @dongjoon-hyun Thanks for the explanation. We should add a
configuration instead of reverting.
---
-
To
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22123
**[Test build #94875 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94875/testReport)**
for PR 22123 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20637
**[Test build #94878 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94878/testReport)**
for PR 20637 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94878/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22130
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94877/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22130
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22123
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22130
**[Test build #94877 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94877/testReport)**
for PR 22130 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21950
**[Test build #94874 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94874/testReport)**
for PR 21950 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22123
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94875/
Test FAILed.
---
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21732
From the above, I think the aggregator encoder for `Option[Product]` might
be a bit tricky to use for users, since they might need to know the difference
between `topLevel = true` and `topLevel =
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21950
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21950
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94874/
Test FAILed.
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22130
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/21584
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20637
**[Test build #94881 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94881/testReport)**
for PR 20637 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22124
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22124
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22124
can you explain how this bug happens and what's the root cause?
---
-
To unsubscribe, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21732
if we can totally hide the `topLevel` parameter from users, it should be
fine. Generally I think the behavior is consistent, now `Option[Product]` is
always a struct type column. But we need to
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/22105#discussion_r210842394
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/protocol/MessageWithHeader.java
---
@@ -140,8 +140,24 @@ private int
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22131
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/22131
cc @mn-mikke @mgaido91
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22131
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20232
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20232
**[Test build #94880 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94880/testReport)**
for PR 20232 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20232
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/20637
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22124
**[Test build #94882 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94882/testReport)**
for PR 22124 at commit
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/22124#discussion_r210832045
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala
---
@@ -490,7 +490,8 @@ object DDLPreprocessingUtils {
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21732
The only tricky thing is, `Product` is handled specially in the top level,
being flattened into multiple columns.
---
-
To
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21950#discussion_r210841402
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PruneFileSourcePartitions.scala
---
@@ -76,4 +78,16 @@ private[sql] object
GitHub user ueshin opened a pull request:
https://github.com/apache/spark/pull/22131
[SPARK-25141][SQL][TEST] Modify tests for higher-order functions to check
bind method.
## What changes were proposed in this pull request?
We should also check `HigherOrderFunction.bind`
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22124
Thanks @cloud-fan I updated it in description.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22130
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22130
**[Test build #94879 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94879/testReport)**
for PR 22130 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22130
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22107
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/22107
merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20232
ping @dbtsai do you have time to review this too?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22107
Thank you very much @HyukjinKwon @felixcheung
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22108
Thank you very much @gatorsmile
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/22124#discussion_r210831619
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -901,6 +901,12 @@ class Analyzer(
// If the
Github user priyankagargnitk commented on the issue:
https://github.com/apache/spark/pull/22054
PLease review this PR.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user sujith71955 commented on the issue:
https://github.com/apache/spark/pull/20611
Working fine with latest code. Thanks !!!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user sujith71955 commented on the issue:
https://github.com/apache/spark/pull/20611
Did some testing in my cluster with updated code for verifying the load
command with hdfs paths, please find the test results. Local path testing is
already covered in my UT.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22131
**[Test build #94883 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94883/testReport)**
for PR 22131 at commit
Github user habren commented on a diff in the pull request:
https://github.com/apache/spark/pull/21868#discussion_r210871055
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
---
@@ -425,12 +426,44 @@ case class FileSourceScanExec(
GitHub user ueshin opened a pull request:
https://github.com/apache/spark/pull/22132
[SPARK-25142][PYSPARK] Add error messages when Python worker could not open
socket in `_load_from_socket`.
## What changes were proposed in this pull request?
Sometimes Python worker can't
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22132
**[Test build #94884 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94884/testReport)**
for PR 22132 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22132
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22132
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/22132
cc @HyukjinKwon
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
GitHub user gengliangwang opened a pull request:
https://github.com/apache/spark/pull/22133
[SPARK-25129][SQL]Make the mapping of com.databricks.spark.avro to built-in
module configurable
## What changes were proposed in this pull request?
In
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22133
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22133
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22133
**[Test build #94885 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94885/testReport)**
for PR 22133 at commit
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/22119
Close this one and open #22133
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user gengliangwang closed the pull request at:
https://github.com/apache/spark/pull/22119
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20637
**[Test build #94881 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94881/testReport)**
for PR 20637 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94881/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/22133#discussion_r210873839
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -637,6 +638,17 @@ object DataSource extends
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22121
**[Test build #94886 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94886/testReport)**
for PR 22121 at commit
Github user habren commented on a diff in the pull request:
https://github.com/apache/spark/pull/21868#discussion_r210876154
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -459,6 +460,29 @@ object SQLConf {
.intConf
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/22133
@tgravescs @dongjoon-hyun @HyukjinKwon @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22121
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22121
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/22131
I see now, thanks. The only thing which I am a bit concerned about is the
complexity introduced by this change, in the sense that it is relying very much
on the `bind` implementation of each
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22133
**[Test build #94885 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94885/testReport)**
for PR 22133 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22133
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22133
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94885/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20232
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20232
**[Test build #94880 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94880/testReport)**
for PR 20232 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20232
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94880/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22121
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94886/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22121
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22121
**[Test build #94886 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94886/testReport)**
for PR 22121 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22132
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94884/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22132
**[Test build #94884 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94884/testReport)**
for PR 22132 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22132
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22124
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22124
**[Test build #94882 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94882/testReport)**
for PR 22124 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22124
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94882/
Test FAILed.
---
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/22131
I am not sure about this. I think that the `bind` method itself is tested
with the end-to-end tests which have been added. This complicates quite this
part which is meant only to test the
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20611
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/22131
Actually one of my motivations is to prevent a mistake like #22126. To
create a test, we needed to do the same thing in `bind`. The other is I wanted
to check the exact values each function passes
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22133#discussion_r210880791
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -1474,6 +1474,12 @@ object SQLConf {
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22130
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94879/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22130
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22130
**[Test build #94879 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94879/testReport)**
for PR 22130 at commit
Github user habren commented on a diff in the pull request:
https://github.com/apache/spark/pull/21868#discussion_r210886442
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -25,17 +25,16 @@ import java.util.zip.Deflater
import
1 - 100 of 413 matches
Mail list logo
