[GitHub] [spark] viirya opened a new pull request #24557: [SPARK-27653][SQL] Add max_by() SQL aggregate function

2019-05-08 Thread GitBox
viirya opened a new pull request #24557: [SPARK-27653][SQL] Add max_by() SQL aggregate function URL: https://github.com/apache/spark/pull/24557 ## What changes were proposed in this pull request? This PR goes to add `max_by()` SQL aggregate function. Quoting from the [Presto

[GitHub] [spark] qb-tarushg commented on issue #24543: [SPARK-27540][MLlib] Add 'meanAveragePrecision_at_k' metric to RankingMetrics

2019-05-08 Thread GitBox
qb-tarushg commented on issue #24543: [SPARK-27540][MLlib] Add 'meanAveragePrecision_at_k' metric to RankingMetrics URL: https://github.com/apache/spark/pull/24543#issuecomment-490527383 @srowen Can we start again the test build?

[GitHub] [spark] arkguil commented on issue #22696: [SPARK-25708][SQL] HAVING without GROUP BY means global aggregate

2019-05-08 Thread GitBox
arkguil commented on issue #22696: [SPARK-25708][SQL] HAVING without GROUP BY means global aggregate URL: https://github.com/apache/spark/pull/22696#issuecomment-490529740 Indeed. Postgresql fails with `ERROR: column "t.id" must appear in the GROUP BY clause or be used in an aggregate

[GitHub] [spark] sujith71955 opened a new pull request #24558: [SPARK-27617][SQL] Support creating managed table on user specified location

2019-05-08 Thread GitBox
sujith71955 opened a new pull request #24558: [SPARK-27617][SQL] Support creating managed table on user specified location URL: https://github.com/apache/spark/pull/24558 ## What changes were proposed in this pull request? ``` CREATE TABLE IF NOT EXISTS ext2 (name STRING) LOCATION

[GitHub] [spark] SparkQA commented on issue #24548: [MINOR][SS][DOC] Added missing config `maxFileAge` in file streaming source

2019-05-08 Thread GitBox
SparkQA commented on issue #24548: [MINOR][SS][DOC] Added missing config `maxFileAge` in file streaming source URL: https://github.com/apache/spark/pull/24548#issuecomment-490536605 **[Test build #105259 has

[GitHub] [spark] AmplabJenkins commented on issue #24548: [MINOR][SS][DOC] Added missing config `maxFileAge` in file streaming source

2019-05-08 Thread GitBox
AmplabJenkins commented on issue #24548: [MINOR][SS][DOC] Added missing config `maxFileAge` in file streaming source URL: https://github.com/apache/spark/pull/24548#issuecomment-490536787 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #24548: [MINOR][SS][DOC] Added missing config `maxFileAge` in file streaming source

2019-05-08 Thread GitBox
AmplabJenkins commented on issue #24548: [MINOR][SS][DOC] Added missing config `maxFileAge` in file streaming source URL: https://github.com/apache/spark/pull/24548#issuecomment-490536780 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA commented on issue #24558: [SPARK-27617][SQL] Support creating managed table on user specified location

2019-05-08 Thread GitBox
SparkQA commented on issue #24558: [SPARK-27617][SQL] Support creating managed table on user specified location URL: https://github.com/apache/spark/pull/24558#issuecomment-490538791 **[Test build #105260 has

[GitHub] [spark] rdblue commented on issue #24246: [SPARK-24252][SQL] Add TableCatalog API

2019-05-08 Thread GitBox
rdblue commented on issue #24246: [SPARK-24252][SQL] Add TableCatalog API URL: https://github.com/apache/spark/pull/24246#issuecomment-490542120 Thanks @cloud-fan! This is an automated message from the Apache Git Service. To

[GitHub] [spark] JoshRosen commented on issue #24557: [SPARK-27653][SQL] Add max_by() SQL aggregate function

2019-05-08 Thread GitBox
JoshRosen commented on issue #24557: [SPARK-27653][SQL] Add max_by() SQL aggregate function URL: https://github.com/apache/spark/pull/24557#issuecomment-490549494 Hi @viirya, Thanks for working on this! I had a few quick questions: - Could you also implement

[GitHub] [spark] giamo commented on a change in pull request #24405: [SPARK-27506][SQL] Allow deserialization of Avro data using compatible schemas

2019-05-08 Thread GitBox
giamo commented on a change in pull request #24405: [SPARK-27506][SQL] Allow deserialization of Avro data using compatible schemas URL: https://github.com/apache/spark/pull/24405#discussion_r282146360 ## File path:

[GitHub] [spark] SparkQA commented on issue #24221: [SPARK-27248][SQL] `refreshTable` should recreate cache with same cache name and storage level

2019-05-08 Thread GitBox
SparkQA commented on issue #24221: [SPARK-27248][SQL] `refreshTable` should recreate cache with same cache name and storage level URL: https://github.com/apache/spark/pull/24221#issuecomment-490556825 **[Test build #105261 has

[GitHub] [spark] SparkQA commented on issue #24499: [SPARK-25888][Core] Serve local disk persisted blocks by the external service after releasing executor by dynamic allocation

2019-05-08 Thread GitBox
SparkQA commented on issue #24499: [SPARK-25888][Core] Serve local disk persisted blocks by the external service after releasing executor by dynamic allocation URL: https://github.com/apache/spark/pull/24499#issuecomment-490559596 **[Test build #105262 has

[GitHub] [spark] attilapiros commented on issue #24499: [SPARK-25888][Core] Serve local disk persisted blocks by the external service after releasing executor by dynamic allocation

2019-05-08 Thread GitBox
attilapiros commented on issue #24499: [SPARK-25888][Core] Serve local disk persisted blocks by the external service after releasing executor by dynamic allocation URL: https://github.com/apache/spark/pull/24499#issuecomment-490562212 I think it is important to mention why in the previous

[GitHub] [spark] SparkQA commented on issue #24558: [SPARK-27617][SQL] Support creating managed table on user specified location

2019-05-08 Thread GitBox
SparkQA commented on issue #24558: [SPARK-27617][SQL] Support creating managed table on user specified location URL: https://github.com/apache/spark/pull/24558#issuecomment-490569731 **[Test build #105260 has

[GitHub] [spark] pgandhi999 commented on issue #24149: [SPARK-27207][SQL] : Ensure aggregate buffers are initialized again for So…

2019-05-08 Thread GitBox
pgandhi999 commented on issue #24149: [SPARK-27207][SQL] : Ensure aggregate buffers are initialized again for So… URL: https://github.com/apache/spark/pull/24149#issuecomment-490586252 test this please. This is an automated

[GitHub] [spark] SparkQA commented on issue #24560: [SPARK-27661][SQL] Add SupportsNamespaces API

2019-05-08 Thread GitBox
SparkQA commented on issue #24560: [SPARK-27661][SQL] Add SupportsNamespaces API URL: https://github.com/apache/spark/pull/24560#issuecomment-490586311 **[Test build #105264 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/105264/testReport)** for PR 24560

[GitHub] [spark] rdblue commented on issue #24560: [SPARK-27661][SQL] Add SupportsNamespaces API

2019-05-08 Thread GitBox
rdblue commented on issue #24560: [SPARK-27661][SQL] Add SupportsNamespaces API URL: https://github.com/apache/spark/pull/24560#issuecomment-490589684 @mccheah, @jzhuge, @cloud-fan, and @marmbrus, it would be great to get feedback on this early prototype of the namespace API. I

[GitHub] [spark] dongjoon-hyun closed pull request #24550: [MINOR][SS] Rename `secondLatestBatchId` to `secondLatestOffsets`

2019-05-08 Thread GitBox
dongjoon-hyun closed pull request #24550: [MINOR][SS] Rename `secondLatestBatchId` to `secondLatestOffsets` URL: https://github.com/apache/spark/pull/24550 This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA commented on issue #24552: [SPARK-25139][SPARK-18406][CORE][2.4] Avoid NonFatals to kill the Executor in PythonRunner

2019-05-08 Thread GitBox
SparkQA commented on issue #24552: [SPARK-25139][SPARK-18406][CORE][2.4] Avoid NonFatals to kill the Executor in PythonRunner URL: https://github.com/apache/spark/pull/24552#issuecomment-490531366 **[Test build #105252 has

[GitHub] [spark] szhem commented on a change in pull request #24556: [SPARK-27641][CORE] Fix MetricsSystem to remove unregistered source correctly

2019-05-08 Thread GitBox
szhem commented on a change in pull request #24556: [SPARK-27641][CORE] Fix MetricsSystem to remove unregistered source correctly URL: https://github.com/apache/spark/pull/24556#discussion_r282112030 ## File path: core/src/main/scala/org/apache/spark/metrics/MetricsSystem.scala

[GitHub] [spark] arkguil removed a comment on issue #22696: [SPARK-25708][SQL] HAVING without GROUP BY means global aggregate

2019-05-08 Thread GitBox
arkguil removed a comment on issue #22696: [SPARK-25708][SQL] HAVING without GROUP BY means global aggregate URL: https://github.com/apache/spark/pull/22696#issuecomment-490529740 Indeed. Postgresql fails with `ERROR: column "t.id" must appear in the GROUP BY clause or be used in an

[GitHub] [spark] szhem commented on a change in pull request #24556: [SPARK-27641][CORE] Fix MetricsSystem to remove unregistered source correctly

2019-05-08 Thread GitBox
szhem commented on a change in pull request #24556: [SPARK-27641][CORE] Fix MetricsSystem to remove unregistered source correctly URL: https://github.com/apache/spark/pull/24556#discussion_r282118028 ## File path:

[GitHub] [spark] AmplabJenkins commented on issue #24548: [MINOR][SS][DOC] Added missing config `maxFileAge` in file streaming source

2019-05-08 Thread GitBox
AmplabJenkins commented on issue #24548: [MINOR][SS][DOC] Added missing config `maxFileAge` in file streaming source URL: https://github.com/apache/spark/pull/24548#issuecomment-490534526 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] srowen commented on a change in pull request #24548: [MINOR][SS][DOC] Added missing config `maxFileAge` in file streaming source

2019-05-08 Thread GitBox
srowen commented on a change in pull request #24548: [MINOR][SS][DOC] Added missing config `maxFileAge` in file streaming source URL: https://github.com/apache/spark/pull/24548#discussion_r282146909 ## File path: docs/structured-streaming-programming-guide.md ## @@ -510,7

[GitHub] [spark] JoshRosen commented on a change in pull request #24557: [SPARK-27653][SQL] Add max_by() SQL aggregate function

2019-05-08 Thread GitBox
JoshRosen commented on a change in pull request #24557: [SPARK-27653][SQL] Add max_by() SQL aggregate function URL: https://github.com/apache/spark/pull/24557#discussion_r282149868 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala ##

[GitHub] [spark] William1104 commented on a change in pull request #24221: [SPARK-27248][SQL] `refreshTable` should recreate cache with same cache name and storage level

2019-05-08 Thread GitBox
William1104 commented on a change in pull request #24221: [SPARK-27248][SQL] `refreshTable` should recreate cache with same cache name and storage level URL: https://github.com/apache/spark/pull/24221#discussion_r282153000 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #24552: [SPARK-25139][SPARK-18406][CORE][2.4] Avoid NonFatals to kill the Executor in PythonRunner

2019-05-08 Thread GitBox
AmplabJenkins removed a comment on issue #24552: [SPARK-25139][SPARK-18406][CORE][2.4] Avoid NonFatals to kill the Executor in PythonRunner URL: https://github.com/apache/spark/pull/24552#issuecomment-490532013 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #24552: [SPARK-25139][SPARK-18406][CORE][2.4] Avoid NonFatals to kill the Executor in PythonRunner

2019-05-08 Thread GitBox
AmplabJenkins removed a comment on issue #24552: [SPARK-25139][SPARK-18406][CORE][2.4] Avoid NonFatals to kill the Executor in PythonRunner URL: https://github.com/apache/spark/pull/24552#issuecomment-490532028 Test PASSed. Refer to this link for build results (access rights to CI

[GitHub] [spark] SparkQA removed a comment on issue #24552: [SPARK-25139][SPARK-18406][CORE][2.4] Avoid NonFatals to kill the Executor in PythonRunner

2019-05-08 Thread GitBox
SparkQA removed a comment on issue #24552: [SPARK-25139][SPARK-18406][CORE][2.4] Avoid NonFatals to kill the Executor in PythonRunner URL: https://github.com/apache/spark/pull/24552#issuecomment-490438732 **[Test build #105252 has

[GitHub] [spark] rdblue opened a new pull request #24559: [SPARK-27658][SQL] Add FunctionCatalog API

2019-05-08 Thread GitBox
rdblue opened a new pull request #24559: [SPARK-27658][SQL] Add FunctionCatalog API URL: https://github.com/apache/spark/pull/24559 ## What changes were proposed in this pull request? This adds a new API for catalog plugins that exposes functions to Spark. The API can list and load

[GitHub] [spark] SparkQA commented on issue #24543: [SPARK-27540][MLlib] Add 'meanAveragePrecision_at_k' metric to RankingMetrics

2019-05-08 Thread GitBox
SparkQA commented on issue #24543: [SPARK-27540][MLlib] Add 'meanAveragePrecision_at_k' metric to RankingMetrics URL: https://github.com/apache/spark/pull/24543#issuecomment-490582537 **[Test build #4779 has

[GitHub] [spark] AmplabJenkins commented on issue #24559: [SPARK-27658][SQL] Add FunctionCatalog API

2019-05-08 Thread GitBox
AmplabJenkins commented on issue #24559: [SPARK-27658][SQL] Add FunctionCatalog API URL: https://github.com/apache/spark/pull/24559#issuecomment-490582850 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #24559: [SPARK-27658][SQL] Add FunctionCatalog API

2019-05-08 Thread GitBox
AmplabJenkins commented on issue #24559: [SPARK-27658][SQL] Add FunctionCatalog API URL: https://github.com/apache/spark/pull/24559#issuecomment-490582840 Merged build finished. Test PASSed. This is an automated message from

[GitHub] [spark] dongjoon-hyun edited a comment on issue #24221: [SPARK-27248][SQL] `refreshTable` should recreate cache with same cache name and storage level

2019-05-08 Thread GitBox
dongjoon-hyun edited a comment on issue #24221: [SPARK-27248][SQL] `refreshTable` should recreate cache with same cache name and storage level URL: https://github.com/apache/spark/pull/24221#issuecomment-490591510 New test case in `hive` module fails. Could you take a look? :) ```

[GitHub] [spark] AmplabJenkins commented on issue #24557: [SPARK-27653][SQL] Add max_by() SQL aggregate function

2019-05-08 Thread GitBox
AmplabJenkins commented on issue #24557: [SPARK-27653][SQL] Add max_by() SQL aggregate function URL: https://github.com/apache/spark/pull/24557#issuecomment-490527970 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #24557: [SPARK-27653][SQL] Add max_by() SQL aggregate function

2019-05-08 Thread GitBox
AmplabJenkins commented on issue #24557: [SPARK-27653][SQL] Add max_by() SQL aggregate function URL: https://github.com/apache/spark/pull/24557#issuecomment-490527962 Merged build finished. Test PASSed. This is an automated

[GitHub] [spark] AmplabJenkins commented on issue #24558: [SPARK-27617][SQL] Support creating managed table on user specified location

2019-05-08 Thread GitBox
AmplabJenkins commented on issue #24558: [SPARK-27617][SQL] Support creating managed table on user specified location URL: https://github.com/apache/spark/pull/24558#issuecomment-490537959 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #24558: [SPARK-27617][SQL] Support creating managed table on user specified location

2019-05-08 Thread GitBox
AmplabJenkins commented on issue #24558: [SPARK-27617][SQL] Support creating managed table on user specified location URL: https://github.com/apache/spark/pull/24558#issuecomment-490537948 Merged build finished. Test PASSed.

[GitHub] [spark] JoshRosen commented on a change in pull request #24557: [SPARK-27653][SQL] Add max_by() SQL aggregate function

2019-05-08 Thread GitBox
JoshRosen commented on a change in pull request #24557: [SPARK-27653][SQL] Add max_by() SQL aggregate function URL: https://github.com/apache/spark/pull/24557#discussion_r282149868 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala ##

[GitHub] [spark] dongjoon-hyun edited a comment on issue #24221: [SPARK-27248][SQL] `refreshTable` should recreate cache with same cache name and storage level

2019-05-08 Thread GitBox
dongjoon-hyun edited a comment on issue #24221: [SPARK-27248][SQL] `refreshTable` should recreate cache with same cache name and storage level URL: https://github.com/apache/spark/pull/24221#issuecomment-490591510 New test case in `hive` module fails. Could you take a look? :) ```

[GitHub] [spark] AmplabJenkins commented on issue #24558: [SPARK-27617][SQL] Support creating managed table on user specified location

2019-05-08 Thread GitBox
AmplabJenkins commented on issue #24558: [SPARK-27617][SQL] Support creating managed table on user specified location URL: https://github.com/apache/spark/pull/24558#issuecomment-490537494 Can one of the admins verify this patch?

[GitHub] [spark] sujith71955 commented on issue #24558: [SPARK-27617][SQL] Support creating managed table on user specified location

2019-05-08 Thread GitBox
sujith71955 commented on issue #24558: [SPARK-27617][SQL] Support creating managed table on user specified location URL: https://github.com/apache/spark/pull/24558#issuecomment-490537266 cc @dongjoon-hyun @HyukjinKwon This

[GitHub] [spark] sujith71955 edited a comment on issue #24558: [SPARK-27617][SQL] Support creating managed table on user specified location

2019-05-08 Thread GitBox
sujith71955 edited a comment on issue #24558: [SPARK-27617][SQL] Support creating managed table on user specified location URL: https://github.com/apache/spark/pull/24558#issuecomment-490537266 cc @dongjoon-hyun @HyukjinKwon Please review and revert me for any clarifications . Very

[GitHub] [spark] giamo commented on a change in pull request #24405: [SPARK-27506][SQL] Allow deserialization of Avro data using compatible schemas

2019-05-08 Thread GitBox
giamo commented on a change in pull request #24405: [SPARK-27506][SQL] Allow deserialization of Avro data using compatible schemas URL: https://github.com/apache/spark/pull/24405#discussion_r282145261 ## File path:

[GitHub] [spark] SparkQA commented on issue #24149: [SPARK-27207][SQL] : Ensure aggregate buffers are initialized again for So…

2019-05-08 Thread GitBox
SparkQA commented on issue #24149: [SPARK-27207][SQL] : Ensure aggregate buffers are initialized again for So… URL: https://github.com/apache/spark/pull/24149#issuecomment-490569775 **[Test build #105257 has

[GitHub] [spark] AmplabJenkins commented on issue #24558: [SPARK-27617][SQL] Support creating managed table on user specified location

2019-05-08 Thread GitBox
AmplabJenkins commented on issue #24558: [SPARK-27617][SQL] Support creating managed table on user specified location URL: https://github.com/apache/spark/pull/24558#issuecomment-490569948 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #24558: [SPARK-27617][SQL] Support creating managed table on user specified location

2019-05-08 Thread GitBox
AmplabJenkins commented on issue #24558: [SPARK-27617][SQL] Support creating managed table on user specified location URL: https://github.com/apache/spark/pull/24558#issuecomment-490569935 Merged build finished. Test FAILed.

[GitHub] [spark] AmplabJenkins commented on issue #24149: [SPARK-27207][SQL] : Ensure aggregate buffers are initialized again for So…

2019-05-08 Thread GitBox
AmplabJenkins commented on issue #24149: [SPARK-27207][SQL] : Ensure aggregate buffers are initialized again for So… URL: https://github.com/apache/spark/pull/24149#issuecomment-490570083 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #24149: [SPARK-27207][SQL] : Ensure aggregate buffers are initialized again for So…

2019-05-08 Thread GitBox
AmplabJenkins commented on issue #24149: [SPARK-27207][SQL] : Ensure aggregate buffers are initialized again for So… URL: https://github.com/apache/spark/pull/24149#issuecomment-490570074 Merged build finished. Test FAILed.

[GitHub] [spark] rdblue edited a comment on issue #24559: [SPARK-27658][SQL] Add FunctionCatalog API

2019-05-08 Thread GitBox
rdblue edited a comment on issue #24559: [SPARK-27658][SQL] Add FunctionCatalog API URL: https://github.com/apache/spark/pull/24559#issuecomment-490581961 @jzhuge, @mccheah, @cloud-fan, and @marmbrus, this PR adds a `FunctionCatalog` interface so you might be interested. It is low

[GitHub] [spark] BryanCutler commented on issue #24070: [SPARK-23961][SPARK-27548][PYTHON] Fix error when toLocalIterator goes out of scope and properly raise errors from worker

2019-05-08 Thread GitBox
BryanCutler commented on issue #24070: [SPARK-23961][SPARK-27548][PYTHON] Fix error when toLocalIterator goes out of scope and properly raise errors from worker URL: https://github.com/apache/spark/pull/24070#issuecomment-490582472 I made https://issues.apache.org/jira/browse/SPARK-27660

[GitHub] [spark] rdblue commented on issue #24559: [SPARK-27658][SQL] Add FunctionCatalog API

2019-05-08 Thread GitBox
rdblue commented on issue #24559: [SPARK-27658][SQL] Add FunctionCatalog API URL: https://github.com/apache/spark/pull/24559#issuecomment-490581961 @jzhuge, @mccheah, @cloud-fan, and @marmbrus, this PR adds a `FunctionCatalog` interface so you might be interested. It is low priority, but

[GitHub] [spark] squito commented on issue #24499: [SPARK-25888][Core] Serve local disk persisted blocks by the external service after releasing executor by dynamic allocation

2019-05-08 Thread GitBox
squito commented on issue #24499: [SPARK-25888][Core] Serve local disk persisted blocks by the external service after releasing executor by dynamic allocation URL: https://github.com/apache/spark/pull/24499#issuecomment-490582020 moving the discussion about file deletion and null buffers

[GitHub] [spark] AmplabJenkins commented on issue #24560: [SPARK-27661][SQL] Add SupportsNamespaces API

2019-05-08 Thread GitBox
AmplabJenkins commented on issue #24560: [SPARK-27661][SQL] Add SupportsNamespaces API URL: https://github.com/apache/spark/pull/24560#issuecomment-490585583 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #24560: [SPARK-27661][SQL] Add SupportsNamespaces API

2019-05-08 Thread GitBox
AmplabJenkins commented on issue #24560: [SPARK-27661][SQL] Add SupportsNamespaces API URL: https://github.com/apache/spark/pull/24560#issuecomment-490585571 Merged build finished. Test PASSed. This is an automated message

[GitHub] [spark] SparkQA commented on issue #24557: [SPARK-27653][SQL] Add max_by() SQL aggregate function

2019-05-08 Thread GitBox
SparkQA commented on issue #24557: [SPARK-27653][SQL] Add max_by() SQL aggregate function URL: https://github.com/apache/spark/pull/24557#issuecomment-490528827 **[Test build #105258 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/105258/testReport)** for

[GitHub] [spark] szhem commented on a change in pull request #24556: [SPARK-27641][CORE] Fix MetricsSystem to remove unregistered source correctly

2019-05-08 Thread GitBox
szhem commented on a change in pull request #24556: [SPARK-27641][CORE] Fix MetricsSystem to remove unregistered source correctly URL: https://github.com/apache/spark/pull/24556#discussion_r282115385 ## File path: core/src/main/scala/org/apache/spark/metrics/MetricsSystem.scala

[GitHub] [spark] arkguil commented on issue #22696: [SPARK-25708][SQL] HAVING without GROUP BY means global aggregate

2019-05-08 Thread GitBox
arkguil commented on issue #22696: [SPARK-25708][SQL] HAVING without GROUP BY means global aggregate URL: https://github.com/apache/spark/pull/22696#issuecomment-490531403 Weird, the 2 previous comments are actually in the Future...

[GitHub] [spark] szhem commented on a change in pull request #24556: [SPARK-27641][CORE] Fix MetricsSystem to remove unregistered source correctly

2019-05-08 Thread GitBox
szhem commented on a change in pull request #24556: [SPARK-27641][CORE] Fix MetricsSystem to remove unregistered source correctly URL: https://github.com/apache/spark/pull/24556#discussion_r282115385 ## File path: core/src/main/scala/org/apache/spark/metrics/MetricsSystem.scala

[GitHub] [spark] arkguil commented on issue #22696: [SPARK-25708][SQL] HAVING without GROUP BY means global aggregate

2019-05-08 Thread GitBox
arkguil commented on issue #22696: [SPARK-25708][SQL] HAVING without GROUP BY means global aggregate URL: https://github.com/apache/spark/pull/22696#issuecomment-490530838 Indeed. The following query fails in Postgresql: `select id from (select 1 as id) t having id > 0` `ERROR:

[GitHub] [spark] AmplabJenkins commented on issue #24552: [SPARK-25139][SPARK-18406][CORE][2.4] Avoid NonFatals to kill the Executor in PythonRunner

2019-05-08 Thread GitBox
AmplabJenkins commented on issue #24552: [SPARK-25139][SPARK-18406][CORE][2.4] Avoid NonFatals to kill the Executor in PythonRunner URL: https://github.com/apache/spark/pull/24552#issuecomment-490532013 Merged build finished. Test PASSed.

[GitHub] [spark] linehrr commented on issue #24548: [MINOR][SS][DOC] Added missing config `maxFileAge` in file streaming source

2019-05-08 Thread GitBox
linehrr commented on issue #24548: [MINOR][SS][DOC] Added missing config `maxFileAge` in file streaming source URL: https://github.com/apache/spark/pull/24548#issuecomment-490533318 Fixed the font. This is an automated

[GitHub] [spark] AmplabJenkins commented on issue #24548: [MINOR][SS][DOC] Added missing config `maxFileAge` in file streaming source

2019-05-08 Thread GitBox
AmplabJenkins commented on issue #24548: [MINOR][SS][DOC] Added missing config `maxFileAge` in file streaming source URL: https://github.com/apache/spark/pull/24548#issuecomment-490534505 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA commented on issue #24548: [MINOR][SS][DOC] Added missing config `maxFileAge` in file streaming source

2019-05-08 Thread GitBox
SparkQA commented on issue #24548: [MINOR][SS][DOC] Added missing config `maxFileAge` in file streaming source URL: https://github.com/apache/spark/pull/24548#issuecomment-490532002 **[Test build #105259 has

[GitHub] [spark] AmplabJenkins commented on issue #24552: [SPARK-25139][SPARK-18406][CORE][2.4] Avoid NonFatals to kill the Executor in PythonRunner

2019-05-08 Thread GitBox
AmplabJenkins commented on issue #24552: [SPARK-25139][SPARK-18406][CORE][2.4] Avoid NonFatals to kill the Executor in PythonRunner URL: https://github.com/apache/spark/pull/24552#issuecomment-490532028 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] szhem commented on a change in pull request #24556: [SPARK-27641][CORE] Fix MetricsSystem to remove unregistered source correctly

2019-05-08 Thread GitBox
szhem commented on a change in pull request #24556: [SPARK-27641][CORE] Fix MetricsSystem to remove unregistered source correctly URL: https://github.com/apache/spark/pull/24556#discussion_r282115385 ## File path: core/src/main/scala/org/apache/spark/metrics/MetricsSystem.scala

[GitHub] [spark] attilapiros commented on a change in pull request #24499: [SPARK-25888][Core] Serve local disk persisted blocks by the external service after releasing executor by dynamic allocation

2019-05-08 Thread GitBox
attilapiros commented on a change in pull request #24499: [SPARK-25888][Core] Serve local disk persisted blocks by the external service after releasing executor by dynamic allocation URL: https://github.com/apache/spark/pull/24499#discussion_r282145524 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #24499: [SPARK-25888][Core] Serve local disk persisted blocks by the external service after releasing executor by dynamic allocation

2019-05-08 Thread GitBox
AmplabJenkins removed a comment on issue #24499: [SPARK-25888][Core] Serve local disk persisted blocks by the external service after releasing executor by dynamic allocation URL: https://github.com/apache/spark/pull/24499#issuecomment-490558752 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #24548: [MINOR][SS][DOC] Added missing config `maxFileAge` in file streaming source

2019-05-08 Thread GitBox
AmplabJenkins removed a comment on issue #24548: [MINOR][SS][DOC] Added missing config `maxFileAge` in file streaming source URL: https://github.com/apache/spark/pull/24548#issuecomment-490534505 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #24548: [MINOR][SS][DOC] Added missing config `maxFileAge` in file streaming source

2019-05-08 Thread GitBox
AmplabJenkins removed a comment on issue #24548: [MINOR][SS][DOC] Added missing config `maxFileAge` in file streaming source URL: https://github.com/apache/spark/pull/24548#issuecomment-490536787 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #24546: [SPARK-27650][SQL] separate the row iterator functionality from ColumnarBatch

2019-05-08 Thread GitBox
AmplabJenkins removed a comment on issue #24546: [SPARK-27650][SQL] separate the row iterator functionality from ColumnarBatch URL: https://github.com/apache/spark/pull/24546#issuecomment-490511129 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #24548: [MINOR][SS][DOC] Added missing config `maxFileAge` in file streaming source

2019-05-08 Thread GitBox
AmplabJenkins removed a comment on issue #24548: [MINOR][SS][DOC] Added missing config `maxFileAge` in file streaming source URL: https://github.com/apache/spark/pull/24548#issuecomment-490536780 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA removed a comment on issue #24548: [MINOR][SS][DOC] Added missing config `maxFileAge` in file streaming source

2019-05-08 Thread GitBox
SparkQA removed a comment on issue #24548: [MINOR][SS][DOC] Added missing config `maxFileAge` in file streaming source URL: https://github.com/apache/spark/pull/24548#issuecomment-490532002 **[Test build #105259 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #24546: [SPARK-27650][SQL] separate the row iterator functionality from ColumnarBatch

2019-05-08 Thread GitBox
AmplabJenkins removed a comment on issue #24546: [SPARK-27650][SQL] separate the row iterator functionality from ColumnarBatch URL: https://github.com/apache/spark/pull/24546#issuecomment-490511151 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on issue #24546: [SPARK-27650][SQL] separate the row iterator functionality from ColumnarBatch

2019-05-08 Thread GitBox
SparkQA removed a comment on issue #24546: [SPARK-27650][SQL] separate the row iterator functionality from ColumnarBatch URL: https://github.com/apache/spark/pull/24546#issuecomment-490466360 **[Test build #105256 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #24548: [MINOR][SS][DOC] Added missing config `maxFileAge` in file streaming source

2019-05-08 Thread GitBox
AmplabJenkins removed a comment on issue #24548: [MINOR][SS][DOC] Added missing config `maxFileAge` in file streaming source URL: https://github.com/apache/spark/pull/24548#issuecomment-490534526 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #24499: [SPARK-25888][Core] Serve local disk persisted blocks by the external service after releasing executor by dynamic allocation

2019-05-08 Thread GitBox
AmplabJenkins removed a comment on issue #24499: [SPARK-25888][Core] Serve local disk persisted blocks by the external service after releasing executor by dynamic allocation URL: https://github.com/apache/spark/pull/24499#issuecomment-490558765 Test PASSed. Refer to this link for build

[GitHub] [spark] dongjoon-hyun edited a comment on issue #24221: [SPARK-27248][SQL] `refreshTable` should recreate cache with same cache name and storage level

2019-05-08 Thread GitBox
dongjoon-hyun edited a comment on issue #24221: [SPARK-27248][SQL] `refreshTable` should recreate cache with same cache name and storage level URL: https://github.com/apache/spark/pull/24221#issuecomment-490591510 New test case in `hive` module fails. Could you fix it? :) ```

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24221: [SPARK-27248][SQL] `refreshTable` should recreate cache with same cache name and storage level

2019-05-08 Thread GitBox
dongjoon-hyun commented on a change in pull request #24221: [SPARK-27248][SQL] `refreshTable` should recreate cache with same cache name and storage level URL: https://github.com/apache/spark/pull/24221#discussion_r282185831 ## File path:

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24555: [SPARK-27656][GraphX][WIP] Safely register class for GraphX

2019-05-08 Thread GitBox
dongjoon-hyun commented on a change in pull request #24555: [SPARK-27656][GraphX][WIP] Safely register class for GraphX URL: https://github.com/apache/spark/pull/24555#discussion_r282188237 ## File path:

[GitHub] [spark] SparkQA commented on issue #24561: [SPARK-26130] : Change Event Timeline Display Functionality on the Stages Page to use either REST API or data from other tables

2019-05-08 Thread GitBox
SparkQA commented on issue #24561: [SPARK-26130] : Change Event Timeline Display Functionality on the Stages Page to use either REST API or data from other tables URL: https://github.com/apache/spark/pull/24561#issuecomment-490628412 **[Test build #105269 has

[GitHub] [spark] peter-toth commented on a change in pull request #24495: [SPARK-27604][SQL] Add filter reduction

2019-05-08 Thread GitBox
peter-toth commented on a change in pull request #24495: [SPARK-27604][SQL] Add filter reduction URL: https://github.com/apache/spark/pull/24495#discussion_r282226297 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala ##

[GitHub] [spark] AmplabJenkins commented on issue #24561: [SPARK-26130] : Change Event Timeline Display Functionality on the Stages Page to use either REST API or data from other tables

2019-05-08 Thread GitBox
AmplabJenkins commented on issue #24561: [SPARK-26130] : Change Event Timeline Display Functionality on the Stages Page to use either REST API or data from other tables URL: https://github.com/apache/spark/pull/24561#issuecomment-490628431 Test FAILed. Refer to this link for build

[GitHub] [spark] peter-toth commented on a change in pull request #24495: [SPARK-27604][SQL] Add filter reduction

2019-05-08 Thread GitBox
peter-toth commented on a change in pull request #24495: [SPARK-27604][SQL] Add filter reduction URL: https://github.com/apache/spark/pull/24495#discussion_r282224333 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala ##

[GitHub] [spark] SparkQA commented on issue #24559: [SPARK-27658][SQL] Add FunctionCatalog API

2019-05-08 Thread GitBox
SparkQA commented on issue #24559: [SPARK-27658][SQL] Add FunctionCatalog API URL: https://github.com/apache/spark/pull/24559#issuecomment-490644253 **[Test build #105263 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/105263/testReport)** for PR 24559 at

[GitHub] [spark] AmplabJenkins commented on issue #24559: [SPARK-27658][SQL] Add FunctionCatalog API

2019-05-08 Thread GitBox
AmplabJenkins commented on issue #24559: [SPARK-27658][SQL] Add FunctionCatalog API URL: https://github.com/apache/spark/pull/24559#issuecomment-490644854 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #24559: [SPARK-27658][SQL] Add FunctionCatalog API

2019-05-08 Thread GitBox
AmplabJenkins commented on issue #24559: [SPARK-27658][SQL] Add FunctionCatalog API URL: https://github.com/apache/spark/pull/24559#issuecomment-490644847 Merged build finished. Test PASSed. This is an automated message from

[GitHub] [spark] AmplabJenkins commented on issue #24561: [SPARK-26130] : Change Event Timeline Display Functionality on the Stages Page to use either REST API or data from other tables

2019-05-08 Thread GitBox
AmplabJenkins commented on issue #24561: [SPARK-26130] : Change Event Timeline Display Functionality on the Stages Page to use either REST API or data from other tables URL: https://github.com/apache/spark/pull/24561#issuecomment-490625970 Test FAILed. Refer to this link for build

[GitHub] [spark] AmplabJenkins commented on issue #24561: [SPARK-26130] : Change Event Timeline Display Functionality on the Stages Page to use either REST API or data from other tables

2019-05-08 Thread GitBox
AmplabJenkins commented on issue #24561: [SPARK-26130] : Change Event Timeline Display Functionality on the Stages Page to use either REST API or data from other tables URL: https://github.com/apache/spark/pull/24561#issuecomment-490625967 Merged build finished. Test FAILed.

[GitHub] [spark] SparkQA commented on issue #24561: [SPARK-26130] : Change Event Timeline Display Functionality on the Stages Page to use either REST API or data from other tables

2019-05-08 Thread GitBox
SparkQA commented on issue #24561: [SPARK-26130] : Change Event Timeline Display Functionality on the Stages Page to use either REST API or data from other tables URL: https://github.com/apache/spark/pull/24561#issuecomment-490625951 **[Test build #105268 has

[GitHub] [spark] pgandhi999 commented on issue #24561: [SPARK-26130] : Change Event Timeline Display Functionality on the Stages Page to use either REST API or data from other tables

2019-05-08 Thread GitBox
pgandhi999 commented on issue #24561: [SPARK-26130] : Change Event Timeline Display Functionality on the Stages Page to use either REST API or data from other tables URL: https://github.com/apache/spark/pull/24561#issuecomment-490627268 ok to test

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24495: [SPARK-27604][SQL] Add filter reduction

2019-05-08 Thread GitBox
dongjoon-hyun commented on a change in pull request #24495: [SPARK-27604][SQL] Add filter reduction URL: https://github.com/apache/spark/pull/24495#discussion_r282239448 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/FilterReductionSuite.scala

[GitHub] [spark] AmplabJenkins commented on issue #24561: [SPARK-26130] : Change Event Timeline Display Functionality on the Stages Page to use either REST API or data from other tables

2019-05-08 Thread GitBox
AmplabJenkins commented on issue #24561: [SPARK-26130] : Change Event Timeline Display Functionality on the Stages Page to use either REST API or data from other tables URL: https://github.com/apache/spark/pull/24561#issuecomment-490626994 Can one of the admins verify this patch?

[GitHub] [spark] peter-toth commented on a change in pull request #24495: [SPARK-27604][SQL] Add filter reduction

2019-05-08 Thread GitBox
peter-toth commented on a change in pull request #24495: [SPARK-27604][SQL] Add filter reduction URL: https://github.com/apache/spark/pull/24495#discussion_r282224333 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala ##

[GitHub] [spark] peter-toth commented on a change in pull request #24495: [SPARK-27604][SQL] Add filter reduction

2019-05-08 Thread GitBox
peter-toth commented on a change in pull request #24495: [SPARK-27604][SQL] Add filter reduction URL: https://github.com/apache/spark/pull/24495#discussion_r282224333 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala ##

[GitHub] [spark] peter-toth commented on a change in pull request #24495: [SPARK-27604][SQL] Add filter reduction

2019-05-08 Thread GitBox
peter-toth commented on a change in pull request #24495: [SPARK-27604][SQL] Add filter reduction URL: https://github.com/apache/spark/pull/24495#discussion_r282225784 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/QueryPlanConstraints.scala

[GitHub] [spark] AmplabJenkins commented on issue #24561: [SPARK-26130] : Change Event Timeline Display Functionality on the Stages Page to use either REST API or data from other tables

2019-05-08 Thread GitBox
AmplabJenkins commented on issue #24561: [SPARK-26130] : Change Event Timeline Display Functionality on the Stages Page to use either REST API or data from other tables URL: https://github.com/apache/spark/pull/24561#issuecomment-490628421 Merged build finished. Test FAILed.

[GitHub] [spark] peter-toth commented on a change in pull request #24495: [SPARK-27604][SQL] Add filter reduction

2019-05-08 Thread GitBox
peter-toth commented on a change in pull request #24495: [SPARK-27604][SQL] Add filter reduction URL: https://github.com/apache/spark/pull/24495#discussion_r282226493 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala ##

[GitHub] [spark] SparkQA commented on issue #24561: [SPARK-26130] : Change Event Timeline Display Functionality on the Stages Page to use either REST API or data from other tables

2019-05-08 Thread GitBox
SparkQA commented on issue #24561: [SPARK-26130] : Change Event Timeline Display Functionality on the Stages Page to use either REST API or data from other tables URL: https://github.com/apache/spark/pull/24561#issuecomment-490627766 **[Test build #105269 has

  1   2   3   4   5   >