[GitHub] [spark] SparkQA commented on issue #25170: [SPARK-28343][FOLLOW-UP][SQL][TEST] Enable spark.sql.function.preferIntegralDivision for PostgreSQL testing

2019-07-16 Thread GitBox
SparkQA commented on issue #25170: [SPARK-28343][FOLLOW-UP][SQL][TEST] Enable spark.sql.function.preferIntegralDivision for PostgreSQL testing URL: https://github.com/apache/spark/pull/25170#issuecomment-511724645 **[Test build #107729 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #25164: [SPARK-28375] Prevent the PullupCorrelatedPredicates optimizer rule from removing predicates if run multiple times

2019-07-16 Thread GitBox
AmplabJenkins removed a comment on issue #25164: [SPARK-28375] Prevent the PullupCorrelatedPredicates optimizer rule from removing predicates if run multiple times URL: https://github.com/apache/spark/pull/25164#issuecomment-511738235 Test FAILed. Refer to this link for build results

[GitHub] [spark] AmplabJenkins commented on issue #25135: [SPARK-28367][SS] Use new KafkaConsumer.poll API in Kafka connector

2019-07-16 Thread GitBox
AmplabJenkins commented on issue #25135: [SPARK-28367][SS] Use new KafkaConsumer.poll API in Kafka connector URL: https://github.com/apache/spark/pull/25135#issuecomment-511747773 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] beliefer commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax

2019-07-16 Thread GitBox
beliefer commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-511748248 > yea, I'll check in a day and just a sec. This answer is very interesting.

[GitHub] [spark] SparkQA commented on issue #25135: [SPARK-28367][SS] Use new KafkaConsumer.poll API in Kafka connector

2019-07-16 Thread GitBox
SparkQA commented on issue #25135: [SPARK-28367][SS] Use new KafkaConsumer.poll API in Kafka connector URL: https://github.com/apache/spark/pull/25135#issuecomment-511747752 **[Test build #107731 has

[GitHub] [spark] AmplabJenkins commented on issue #25135: [SPARK-28367][SS] Use new KafkaConsumer.poll API in Kafka connector

2019-07-16 Thread GitBox
AmplabJenkins commented on issue #25135: [SPARK-28367][SS] Use new KafkaConsumer.poll API in Kafka connector URL: https://github.com/apache/spark/pull/25135#issuecomment-511753204 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25074: [SPARK-27924]Support ANSI SQL Boolean-Predicate syntax

2019-07-16 Thread GitBox
AmplabJenkins commented on issue #25074: [SPARK-27924]Support ANSI SQL Boolean-Predicate syntax URL: https://github.com/apache/spark/pull/25074#issuecomment-511753372 Merged build finished. Test PASSed. This is an automated

[GitHub] [spark] AmplabJenkins commented on issue #25074: [SPARK-27924]Support ANSI SQL Boolean-Predicate syntax

2019-07-16 Thread GitBox
AmplabJenkins commented on issue #25074: [SPARK-27924]Support ANSI SQL Boolean-Predicate syntax URL: https://github.com/apache/spark/pull/25074#issuecomment-511753380 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] gaborgsomogyi commented on issue #25135: [SPARK-28367][SS] Use new KafkaConsumer.poll API in Kafka connector

2019-07-16 Thread GitBox
gaborgsomogyi commented on issue #25135: [SPARK-28367][SS] Use new KafkaConsumer.poll API in Kafka connector URL: https://github.com/apache/spark/pull/25135#issuecomment-511757383 Created a quick fix https://github.com/apache/spark/pull/25171

[GitHub] [spark] SparkQA removed a comment on issue #24759: [SPARK-27395][SQL][WIP] Improve EXPLAIN command

2019-07-16 Thread GitBox
SparkQA removed a comment on issue #24759: [SPARK-27395][SQL][WIP] Improve EXPLAIN command URL: https://github.com/apache/spark/pull/24759#issuecomment-511693975 **[Test build #107723 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/107723/testReport)** for

[GitHub] [spark] SparkQA commented on issue #24759: [SPARK-27395][SQL][WIP] Improve EXPLAIN command

2019-07-16 Thread GitBox
SparkQA commented on issue #24759: [SPARK-27395][SQL][WIP] Improve EXPLAIN command URL: https://github.com/apache/spark/pull/24759#issuecomment-511757320 **[Test build #107723 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/107723/testReport)** for PR

[GitHub] [spark] AmplabJenkins commented on issue #24931: [SPARK-28129][SQL][TEST] Port float8.sql

2019-07-16 Thread GitBox
AmplabJenkins commented on issue #24931: [SPARK-28129][SQL][TEST] Port float8.sql URL: https://github.com/apache/spark/pull/24931#issuecomment-511759567 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25171: [SPARK-27485][FOLLOWUP] Quick fix

2019-07-16 Thread GitBox
AmplabJenkins removed a comment on issue #25171: [SPARK-27485][FOLLOWUP] Quick fix URL: https://github.com/apache/spark/pull/25171#issuecomment-511758170 Can one of the admins verify this patch? This is an automated message

[GitHub] [spark] AmplabJenkins commented on issue #24931: [SPARK-28129][SQL][TEST] Port float8.sql

2019-07-16 Thread GitBox
AmplabJenkins commented on issue #24931: [SPARK-28129][SQL][TEST] Port float8.sql URL: https://github.com/apache/spark/pull/24931#issuecomment-511759560 Merged build finished. Test PASSed. This is an automated message from

[GitHub] [spark] SparkQA removed a comment on issue #24931: [SPARK-28129][SQL][TEST] Port float8.sql

2019-07-16 Thread GitBox
SparkQA removed a comment on issue #24931: [SPARK-28129][SQL][TEST] Port float8.sql URL: https://github.com/apache/spark/pull/24931#issuecomment-511696164 **[Test build #107725 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/107725/testReport)** for PR

[GitHub] [spark] hvanhovell commented on issue #25171: [SPARK-27485][FOLLOWUP] Quick fix

2019-07-16 Thread GitBox
hvanhovell commented on issue #25171: [SPARK-27485][FOLLOWUP] Quick fix URL: https://github.com/apache/spark/pull/25171#issuecomment-511759662 @gaborgsomogyi thanks for the PR! I will merge this as soon as compilation has finished.

[GitHub] [spark] SparkQA commented on issue #25168: [SPARK-28276][SQL][PYTHON][TEST] Convert and port 'cross-join.sql' into UDF test base

2019-07-16 Thread GitBox
SparkQA commented on issue #25168: [SPARK-28276][SQL][PYTHON][TEST] Convert and port 'cross-join.sql' into UDF test base URL: https://github.com/apache/spark/pull/25168#issuecomment-511759751 **[Test build #107727 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #24931: [SPARK-28129][SQL][TEST] Port float8.sql

2019-07-16 Thread GitBox
AmplabJenkins removed a comment on issue #24931: [SPARK-28129][SQL][TEST] Port float8.sql URL: https://github.com/apache/spark/pull/24931#issuecomment-511759560 Merged build finished. Test PASSed. This is an automated

[GitHub] [spark] AmplabJenkins removed a comment on issue #24931: [SPARK-28129][SQL][TEST] Port float8.sql

2019-07-16 Thread GitBox
AmplabJenkins removed a comment on issue #24931: [SPARK-28129][SQL][TEST] Port float8.sql URL: https://github.com/apache/spark/pull/24931#issuecomment-511759567 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] ozancicek commented on a change in pull request #24939: [SPARK-18569][ML][R] Support RFormula arithmetic, I() and spark functions

2019-07-16 Thread GitBox
ozancicek commented on a change in pull request #24939: [SPARK-18569][ML][R] Support RFormula arithmetic, I() and spark functions URL: https://github.com/apache/spark/pull/24939#discussion_r303864360 ## File path: mllib/src/main/scala/org/apache/spark/ml/feature/RFormula.scala

[GitHub] [spark] maropu commented on issue #25071: [SPARK-28292][SQL] Enable inject user-defined Hint

2019-07-16 Thread GitBox
maropu commented on issue #25071: [SPARK-28292][SQL] Enable inject user-defined Hint URL: https://github.com/apache/spark/pull/25071#issuecomment-511816502 retest this please This is an automated message from the Apache Git

[GitHub] [spark] srowen closed pull request #25154: [SPARK-28247][SS][BRANCH-2.4] Fix flaky test "query without test harness" on ContinuousSuite

2019-07-16 Thread GitBox
srowen closed pull request #25154: [SPARK-28247][SS][BRANCH-2.4] Fix flaky test "query without test harness" on ContinuousSuite URL: https://github.com/apache/spark/pull/25154 This is an automated message from the Apache

[GitHub] [spark] maropu commented on issue #24903: [SPARK-28084][SQL] Resolving the partition column name based on the resolver in sql load command

2019-07-16 Thread GitBox
maropu commented on issue #24903: [SPARK-28084][SQL] Resolving the partition column name based on the resolver in sql load command URL: https://github.com/apache/spark/pull/24903#issuecomment-511816332 retest this please

[GitHub] [spark] srowen commented on issue #25154: [SPARK-28247][SS][BRANCH-2.4] Fix flaky test "query without test harness" on ContinuousSuite

2019-07-16 Thread GitBox
srowen commented on issue #25154: [SPARK-28247][SS][BRANCH-2.4] Fix flaky test "query without test harness" on ContinuousSuite URL: https://github.com/apache/spark/pull/25154#issuecomment-511816391 Merged to 2.4 This is an

[GitHub] [spark] gaborgsomogyi commented on issue #21861: [SPARK-24907][SQL][WIP] Migrate JDBC DataSource to JDBCDataSourceV2 Read using DataSourceV2 API

2019-07-16 Thread GitBox
gaborgsomogyi commented on issue #21861: [SPARK-24907][SQL][WIP] Migrate JDBC DataSource to JDBCDataSourceV2 Read using DataSourceV2 API URL: https://github.com/apache/spark/pull/21861#issuecomment-511722470 @shivsood thanks for considering me as collaborator. Since I'm mainly in the

[GitHub] [spark] cloud-fan commented on issue #25167: [SPARK-27485] EnsureRequirements.reorder should handle duplicate expressions gracefully

2019-07-16 Thread GitBox
cloud-fan commented on issue #25167: [SPARK-27485] EnsureRequirements.reorder should handle duplicate expressions gracefully URL: https://github.com/apache/spark/pull/25167#issuecomment-511735270 thanks, merging to master!

[GitHub] [spark] AmplabJenkins commented on issue #25164: [SPARK-28375] Prevent the PullupCorrelatedPredicates optimizer rule from removing predicates if run multiple times

2019-07-16 Thread GitBox
AmplabJenkins commented on issue #25164: [SPARK-28375] Prevent the PullupCorrelatedPredicates optimizer rule from removing predicates if run multiple times URL: https://github.com/apache/spark/pull/25164#issuecomment-511735714 Test PASSed. Refer to this link for build results (access

[GitHub] [spark] HeartSaVioR commented on a change in pull request #25135: [SPARK-28367][SS] Use new KafkaConsumer.poll API in Kafka connector

2019-07-16 Thread GitBox
HeartSaVioR commented on a change in pull request #25135: [SPARK-28367][SS] Use new KafkaConsumer.poll API in Kafka connector URL: https://github.com/apache/spark/pull/25135#discussion_r303804331 ## File path:

[GitHub] [spark] HeartSaVioR commented on a change in pull request #25135: [SPARK-28367][SS] Use new KafkaConsumer.poll API in Kafka connector

2019-07-16 Thread GitBox
HeartSaVioR commented on a change in pull request #25135: [SPARK-28367][SS] Use new KafkaConsumer.poll API in Kafka connector URL: https://github.com/apache/spark/pull/25135#discussion_r303804331 ## File path:

[GitHub] [spark] HeartSaVioR commented on a change in pull request #25135: [SPARK-28367][SS] Use new KafkaConsumer.poll API in Kafka connector

2019-07-16 Thread GitBox
HeartSaVioR commented on a change in pull request #25135: [SPARK-28367][SS] Use new KafkaConsumer.poll API in Kafka connector URL: https://github.com/apache/spark/pull/25135#discussion_r303804331 ## File path:

[GitHub] [spark] priyankagargnitk commented on issue #25022: [SPARK-24695][SQL]: To expose Calendar interval type, so that same can be returned from the UDF.

2019-07-16 Thread GitBox
priyankagargnitk commented on issue #25022: [SPARK-24695][SQL]: To expose Calendar interval type, so that same can be returned from the UDF. URL: https://github.com/apache/spark/pull/25022#issuecomment-511735997 @dongjoon-hyun @HyukjinKwon @rxin: All the review comments are incorporated.

[GitHub] [spark] HeartSaVioR commented on issue #25135: [SPARK-28367][SS] Use new KafkaConsumer.poll API in Kafka connector

2019-07-16 Thread GitBox
HeartSaVioR commented on issue #25135: [SPARK-28367][SS] Use new KafkaConsumer.poll API in Kafka connector URL: https://github.com/apache/spark/pull/25135#issuecomment-511744146 LGTM again. This is an automated message from

[GitHub] [spark] maropu commented on issue #25137: [SPARK-28348][SQL] Decimal precision promotion for binary arithmetic with casted decimal type

2019-07-16 Thread GitBox
maropu commented on issue #25137: [SPARK-28348][SQL] Decimal precision promotion for binary arithmetic with casted decimal type URL: https://github.com/apache/spark/pull/25137#issuecomment-511744139 Which one does follow the SQL standard? IIUC the current spark behaviour depends on the

[GitHub] [spark] SparkQA removed a comment on issue #25135: [SPARK-28367][SS] Use new KafkaConsumer.poll API in Kafka connector

2019-07-16 Thread GitBox
SparkQA removed a comment on issue #25135: [SPARK-28367][SS] Use new KafkaConsumer.poll API in Kafka connector URL: https://github.com/apache/spark/pull/25135#issuecomment-511745312 **[Test build #107731 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #25135: [SPARK-28367][SS] Use new KafkaConsumer.poll API in Kafka connector

2019-07-16 Thread GitBox
AmplabJenkins removed a comment on issue #25135: [SPARK-28367][SS] Use new KafkaConsumer.poll API in Kafka connector URL: https://github.com/apache/spark/pull/25135#issuecomment-511747773 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #22054: [SPARK-24703][SQL]: To add support to multiply CalendarInterval with Integral Type.

2019-07-16 Thread GitBox
AmplabJenkins removed a comment on issue #22054: [SPARK-24703][SQL]: To add support to multiply CalendarInterval with Integral Type. URL: https://github.com/apache/spark/pull/22054#issuecomment-511750701 Test FAILed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] SparkQA commented on issue #24931: [SPARK-28129][SQL][TEST] Port float8.sql

2019-07-16 Thread GitBox
SparkQA commented on issue #24931: [SPARK-28129][SQL][TEST] Port float8.sql URL: https://github.com/apache/spark/pull/24931#issuecomment-511758992 **[Test build #107725 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/107725/testReport)** for PR 24931 at

[GitHub] [spark] gaborgsomogyi commented on issue #25135: [SPARK-28367][SS] Use new KafkaConsumer.poll API in Kafka connector

2019-07-16 Thread GitBox
gaborgsomogyi commented on issue #25135: [SPARK-28367][SS] Use new KafkaConsumer.poll API in Kafka connector URL: https://github.com/apache/spark/pull/25135#issuecomment-511771601 retest this please This is an automated

[GitHub] [spark] AmplabJenkins commented on issue #25135: [SPARK-28367][SS] Use new KafkaConsumer.poll API in Kafka connector

2019-07-16 Thread GitBox
AmplabJenkins commented on issue #25135: [SPARK-28367][SS] Use new KafkaConsumer.poll API in Kafka connector URL: https://github.com/apache/spark/pull/25135#issuecomment-511784040 Merged build finished. Test FAILed. This is

[GitHub] [spark] SparkQA removed a comment on issue #25135: [SPARK-28367][SS] Use new KafkaConsumer.poll API in Kafka connector

2019-07-16 Thread GitBox
SparkQA removed a comment on issue #25135: [SPARK-28367][SS] Use new KafkaConsumer.poll API in Kafka connector URL: https://github.com/apache/spark/pull/25135#issuecomment-511773381 **[Test build #107735 has

[GitHub] [spark] AmplabJenkins commented on issue #25135: [SPARK-28367][SS] Use new KafkaConsumer.poll API in Kafka connector

2019-07-16 Thread GitBox
AmplabJenkins commented on issue #25135: [SPARK-28367][SS] Use new KafkaConsumer.poll API in Kafka connector URL: https://github.com/apache/spark/pull/25135#issuecomment-511784046 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on issue #25135: [SPARK-28367][SS] Use new KafkaConsumer.poll API in Kafka connector

2019-07-16 Thread GitBox
SparkQA commented on issue #25135: [SPARK-28367][SS] Use new KafkaConsumer.poll API in Kafka connector URL: https://github.com/apache/spark/pull/25135#issuecomment-511783995 **[Test build #107735 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #25135: [SPARK-28367][SS] Use new KafkaConsumer.poll API in Kafka connector

2019-07-16 Thread GitBox
AmplabJenkins removed a comment on issue #25135: [SPARK-28367][SS] Use new KafkaConsumer.poll API in Kafka connector URL: https://github.com/apache/spark/pull/25135#issuecomment-511784040 Merged build finished. Test FAILed.

[GitHub] [spark] SparkQA commented on issue #24939: [SPARK-18569][ML][R] Support RFormula arithmetic, I() and spark functions

2019-07-16 Thread GitBox
SparkQA commented on issue #24939: [SPARK-18569][ML][R] Support RFormula arithmetic, I() and spark functions URL: https://github.com/apache/spark/pull/24939#issuecomment-511798279 **[Test build #107736 has

[GitHub] [spark] gengliangwang edited a comment on issue #25137: [SPARK-28348][SQL] Decimal precision promotion for binary arithmetic with casted decimal type

2019-07-16 Thread GitBox
gengliangwang edited a comment on issue #25137: [SPARK-28348][SQL] Decimal precision promotion for binary arithmetic with casted decimal type URL: https://github.com/apache/spark/pull/25137#issuecomment-511815571 @maropu I just checked and found PostgreSQL and MySQL has bigger precision

[GitHub] [spark] SparkQA commented on issue #24989: [SPARK-27959][YARN][test-hadoop3.2] Change YARN resource configs to use .amount

2019-07-16 Thread GitBox
SparkQA commented on issue #24989: [SPARK-27959][YARN][test-hadoop3.2] Change YARN resource configs to use .amount URL: https://github.com/apache/spark/pull/24989#issuecomment-511815544 **[Test build #107738 has

[GitHub] [spark] gengliangwang commented on issue #25137: [SPARK-28348][SQL] Decimal precision promotion for binary arithmetic with casted decimal type

2019-07-16 Thread GitBox
gengliangwang commented on issue #25137: [SPARK-28348][SQL] Decimal precision promotion for binary arithmetic with casted decimal type URL: https://github.com/apache/spark/pull/25137#issuecomment-511815571 @maropu I just checked and find PostgreSQL and MySQL has bigger precision than

[GitHub] [spark] SparkQA removed a comment on issue #24989: [SPARK-27959][YARN][test-hadoop3.2] Change YARN resource configs to use .amount

2019-07-16 Thread GitBox
SparkQA removed a comment on issue #24989: [SPARK-27959][YARN][test-hadoop3.2] Change YARN resource configs to use .amount URL: https://github.com/apache/spark/pull/24989#issuecomment-511815544 **[Test build #107738 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #24989: [SPARK-27959][YARN][test-hadoop3.2] Change YARN resource configs to use .amount

2019-07-16 Thread GitBox
AmplabJenkins removed a comment on issue #24989: [SPARK-27959][YARN][test-hadoop3.2] Change YARN resource configs to use .amount URL: https://github.com/apache/spark/pull/24989#issuecomment-511823339 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25170: [SPARK-28343][FOLLOW-UP][SQL][TEST] Enable spark.sql.function.preferIntegralDivision for PostgreSQL testing

2019-07-16 Thread GitBox
AmplabJenkins removed a comment on issue #25170: [SPARK-28343][FOLLOW-UP][SQL][TEST] Enable spark.sql.function.preferIntegralDivision for PostgreSQL testing URL: https://github.com/apache/spark/pull/25170#issuecomment-511726821 Test PASSed. Refer to this link for build results (access

[GitHub] [spark] AmplabJenkins commented on issue #25170: [SPARK-28343][FOLLOW-UP][SQL][TEST] Enable spark.sql.function.preferIntegralDivision for PostgreSQL testing

2019-07-16 Thread GitBox
AmplabJenkins commented on issue #25170: [SPARK-28343][FOLLOW-UP][SQL][TEST] Enable spark.sql.function.preferIntegralDivision for PostgreSQL testing URL: https://github.com/apache/spark/pull/25170#issuecomment-511726821 Test PASSed. Refer to this link for build results (access rights to

[GitHub] [spark] AmplabJenkins commented on issue #25170: [SPARK-28343][FOLLOW-UP][SQL][TEST] Enable spark.sql.function.preferIntegralDivision for PostgreSQL testing

2019-07-16 Thread GitBox
AmplabJenkins commented on issue #25170: [SPARK-28343][FOLLOW-UP][SQL][TEST] Enable spark.sql.function.preferIntegralDivision for PostgreSQL testing URL: https://github.com/apache/spark/pull/25170#issuecomment-511726809 Merged build finished. Test PASSed.

[GitHub] [spark] HyukjinKwon commented on issue #25168: [SPARK-28276][SQL][PYTHON][TEST] Convert and port 'cross-join.sql' into UDF test base

2019-07-16 Thread GitBox
HyukjinKwon commented on issue #25168: [SPARK-28276][SQL][PYTHON][TEST] Convert and port 'cross-join.sql' into UDF test base URL: https://github.com/apache/spark/pull/25168#issuecomment-511726635 Looks good .. but let's get #25130 first .. just in case that causes some changes in those

[GitHub] [spark] HyukjinKwon closed pull request #24931: [SPARK-28129][SQL][TEST] Port float8.sql

2019-07-16 Thread GitBox
HyukjinKwon closed pull request #24931: [SPARK-28129][SQL][TEST] Port float8.sql URL: https://github.com/apache/spark/pull/24931 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [spark] srowen commented on issue #25133: [SPARK-28365][ML] Fallback locale to en_US in StopWordsRemover if system default locale isn't in available locales in JVM

2019-07-16 Thread GitBox
srowen commented on issue #25133: [SPARK-28365][ML] Fallback locale to en_US in StopWordsRemover if system default locale isn't in available locales in JVM URL: https://github.com/apache/spark/pull/25133#issuecomment-511785224 Yeah, I'm just wondering - wouldn't this cause a hundred other

[GitHub] [spark] SparkQA commented on issue #25170: [SPARK-28343][FOLLOW-UP][SQL][TEST] Enable spark.sql.function.preferIntegralDivision for PostgreSQL testing

2019-07-16 Thread GitBox
SparkQA commented on issue #25170: [SPARK-28343][FOLLOW-UP][SQL][TEST] Enable spark.sql.function.preferIntegralDivision for PostgreSQL testing URL: https://github.com/apache/spark/pull/25170#issuecomment-511785259 **[Test build #107729 has

[GitHub] [spark] SparkQA removed a comment on issue #25170: [SPARK-28343][FOLLOW-UP][SQL][TEST] Enable spark.sql.function.preferIntegralDivision for PostgreSQL testing

2019-07-16 Thread GitBox
SparkQA removed a comment on issue #25170: [SPARK-28343][FOLLOW-UP][SQL][TEST] Enable spark.sql.function.preferIntegralDivision for PostgreSQL testing URL: https://github.com/apache/spark/pull/25170#issuecomment-511724645 **[Test build #107729 has

[GitHub] [spark] cloud-fan commented on issue #25171: [SPARK-27485][FOLLOWUP] Do not reduce the number of partitions for repartition in adaptive execution - fix compilation

2019-07-16 Thread GitBox
cloud-fan commented on issue #25171: [SPARK-27485][FOLLOWUP] Do not reduce the number of partitions for repartition in adaptive execution - fix compilation URL: https://github.com/apache/spark/pull/25171#issuecomment-511791231 cool, thanks for the fix!

[GitHub] [spark] maropu commented on issue #25118: [SPARK-27878][SQL] Support ARRAY(subquery) expressions

2019-07-16 Thread GitBox
maropu commented on issue #25118: [SPARK-27878][SQL] Support ARRAY(subquery) expressions URL: https://github.com/apache/spark/pull/25118#issuecomment-511807478 Thanks. This is just my opinion and the other developers might not think so. Its ok to keep it open for a while.

[GitHub] [spark] SparkQA commented on issue #25172: [SPARK-28412][SQL]ANSI SQL: OVERLAY function support byte array

2019-07-16 Thread GitBox
SparkQA commented on issue #25172: [SPARK-28412][SQL]ANSI SQL: OVERLAY function support byte array URL: https://github.com/apache/spark/pull/25172#issuecomment-511809713 **[Test build #107737 has

[GitHub] [spark] HeartSaVioR commented on a change in pull request #25135: [SPARK-28367][SS] Use new KafkaConsumer.poll API in Kafka connector

2019-07-16 Thread GitBox
HeartSaVioR commented on a change in pull request #25135: [SPARK-28367][SS] Use new KafkaConsumer.poll API in Kafka connector URL: https://github.com/apache/spark/pull/25135#discussion_r303792433 ## File path:

[GitHub] [spark] cloud-fan closed pull request #25167: [SPARK-27485] EnsureRequirements.reorder should handle duplicate expressions gracefully

2019-07-16 Thread GitBox
cloud-fan closed pull request #25167: [SPARK-27485] EnsureRequirements.reorder should handle duplicate expressions gracefully URL: https://github.com/apache/spark/pull/25167 This is an automated message from the Apache Git

[GitHub] [spark] SparkQA commented on issue #25168: [SPARK-28276][SQL][PYTHON][TEST] Convert and port 'cross-join.sql' into UDF test base

2019-07-16 Thread GitBox
SparkQA commented on issue #25168: [SPARK-28276][SQL][PYTHON][TEST] Convert and port 'cross-join.sql' into UDF test base URL: https://github.com/apache/spark/pull/25168#issuecomment-511740298 **[Test build #107724 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #25135: [SPARK-28367][SS] Use new KafkaConsumer.poll API in Kafka connector

2019-07-16 Thread GitBox
AmplabJenkins removed a comment on issue #25135: [SPARK-28367][SS] Use new KafkaConsumer.poll API in Kafka connector URL: https://github.com/apache/spark/pull/25135#issuecomment-511753199 Merged build finished. Test FAILed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25074: [SPARK-27924]Support ANSI SQL Boolean-Predicate syntax

2019-07-16 Thread GitBox
AmplabJenkins removed a comment on issue #25074: [SPARK-27924]Support ANSI SQL Boolean-Predicate syntax URL: https://github.com/apache/spark/pull/25074#issuecomment-511753372 Merged build finished. Test PASSed. This is an

[GitHub] [spark] SparkQA removed a comment on issue #25135: [SPARK-28367][SS] Use new KafkaConsumer.poll API in Kafka connector

2019-07-16 Thread GitBox
SparkQA removed a comment on issue #25135: [SPARK-28367][SS] Use new KafkaConsumer.poll API in Kafka connector URL: https://github.com/apache/spark/pull/25135#issuecomment-511751256 **[Test build #107732 has

[GitHub] [spark] AmplabJenkins commented on issue #25135: [SPARK-28367][SS] Use new KafkaConsumer.poll API in Kafka connector

2019-07-16 Thread GitBox
AmplabJenkins commented on issue #25135: [SPARK-28367][SS] Use new KafkaConsumer.poll API in Kafka connector URL: https://github.com/apache/spark/pull/25135#issuecomment-511753199 Merged build finished. Test FAILed. This is

[GitHub] [spark] SparkQA commented on issue #25135: [SPARK-28367][SS] Use new KafkaConsumer.poll API in Kafka connector

2019-07-16 Thread GitBox
SparkQA commented on issue #25135: [SPARK-28367][SS] Use new KafkaConsumer.poll API in Kafka connector URL: https://github.com/apache/spark/pull/25135#issuecomment-511753177 **[Test build #107732 has

[GitHub] [spark] AmplabJenkins commented on issue #25171: [SPARK-27485][FOLLOWUP] Quick fix

2019-07-16 Thread GitBox
AmplabJenkins commented on issue #25171: [SPARK-27485][FOLLOWUP] Quick fix URL: https://github.com/apache/spark/pull/25171#issuecomment-511758170 Can one of the admins verify this patch? This is an automated message from the

[GitHub] [spark] AmplabJenkins removed a comment on issue #25171: [SPARK-27485][FOLLOWUP] Quick fix

2019-07-16 Thread GitBox
AmplabJenkins removed a comment on issue #25171: [SPARK-27485][FOLLOWUP] Quick fix URL: https://github.com/apache/spark/pull/25171#issuecomment-511757995 Can one of the admins verify this patch? This is an automated message

[GitHub] [spark] AmplabJenkins commented on issue #25168: [SPARK-28276][SQL][PYTHON][TEST] Convert and port 'cross-join.sql' into UDF test base

2019-07-16 Thread GitBox
AmplabJenkins commented on issue #25168: [SPARK-28276][SQL][PYTHON][TEST] Convert and port 'cross-join.sql' into UDF test base URL: https://github.com/apache/spark/pull/25168#issuecomment-511760337 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25168: [SPARK-28276][SQL][PYTHON][TEST] Convert and port 'cross-join.sql' into UDF test base

2019-07-16 Thread GitBox
AmplabJenkins commented on issue #25168: [SPARK-28276][SQL][PYTHON][TEST] Convert and port 'cross-join.sql' into UDF test base URL: https://github.com/apache/spark/pull/25168#issuecomment-511760343 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on issue #25168: [SPARK-28276][SQL][PYTHON][TEST] Convert and port 'cross-join.sql' into UDF test base

2019-07-16 Thread GitBox
SparkQA removed a comment on issue #25168: [SPARK-28276][SQL][PYTHON][TEST] Convert and port 'cross-join.sql' into UDF test base URL: https://github.com/apache/spark/pull/25168#issuecomment-511700709 **[Test build #107727 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #25168: [SPARK-28276][SQL][PYTHON][TEST] Convert and port 'cross-join.sql' into UDF test base

2019-07-16 Thread GitBox
AmplabJenkins removed a comment on issue #25168: [SPARK-28276][SQL][PYTHON][TEST] Convert and port 'cross-join.sql' into UDF test base URL: https://github.com/apache/spark/pull/25168#issuecomment-511760337 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25168: [SPARK-28276][SQL][PYTHON][TEST] Convert and port 'cross-join.sql' into UDF test base

2019-07-16 Thread GitBox
AmplabJenkins removed a comment on issue #25168: [SPARK-28276][SQL][PYTHON][TEST] Convert and port 'cross-join.sql' into UDF test base URL: https://github.com/apache/spark/pull/25168#issuecomment-511760343 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins commented on issue #25172: [SPARK-28412][SQL]ANSI SQL: OVERLAY function support byte array

2019-07-16 Thread GitBox
AmplabJenkins commented on issue #25172: [SPARK-28412][SQL]ANSI SQL: OVERLAY function support byte array URL: https://github.com/apache/spark/pull/25172#issuecomment-511781742 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25172: [SPARK-28412][SQL]ANSI SQL: OVERLAY function support byte array

2019-07-16 Thread GitBox
AmplabJenkins commented on issue #25172: [SPARK-28412][SQL]ANSI SQL: OVERLAY function support byte array URL: https://github.com/apache/spark/pull/25172#issuecomment-511781738 Merged build finished. Test PASSed. This is an

[GitHub] [spark] maropu edited a comment on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax

2019-07-16 Thread GitBox
maropu edited a comment on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-511803526 Also, could you check the query below? Then, plz add some tests in `SQLQueryTestSuite`. ``` scala> sql("""select *

[GitHub] [spark] AmplabJenkins removed a comment on issue #24903: [SPARK-28084][SQL] Resolving the partition column name based on the resolver in sql load command

2019-07-16 Thread GitBox
AmplabJenkins removed a comment on issue #24903: [SPARK-28084][SQL] Resolving the partition column name based on the resolver in sql load command URL: https://github.com/apache/spark/pull/24903#issuecomment-511818135 Test PASSed. Refer to this link for build results (access rights to

[GitHub] [spark] AmplabJenkins removed a comment on issue #25071: [SPARK-28292][SQL] Enable inject user-defined Hint

2019-07-16 Thread GitBox
AmplabJenkins removed a comment on issue #25071: [SPARK-28292][SQL] Enable inject user-defined Hint URL: https://github.com/apache/spark/pull/25071#issuecomment-511818025 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25071: [SPARK-28292][SQL] Enable inject user-defined Hint

2019-07-16 Thread GitBox
AmplabJenkins removed a comment on issue #25071: [SPARK-28292][SQL] Enable inject user-defined Hint URL: https://github.com/apache/spark/pull/25071#issuecomment-511818016 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins removed a comment on issue #24903: [SPARK-28084][SQL] Resolving the partition column name based on the resolver in sql load command

2019-07-16 Thread GitBox
AmplabJenkins removed a comment on issue #24903: [SPARK-28084][SQL] Resolving the partition column name based on the resolver in sql load command URL: https://github.com/apache/spark/pull/24903#issuecomment-511818127 Merged build finished. Test PASSed.

[GitHub] [spark] gengliangwang commented on issue #25137: [SPARK-28348][SQL] Decimal precision promotion for binary arithmetic with casted decimal type

2019-07-16 Thread GitBox
gengliangwang commented on issue #25137: [SPARK-28348][SQL] Decimal precision promotion for binary arithmetic with casted decimal type URL: https://github.com/apache/spark/pull/25137#issuecomment-511822926 I am actually slightly -1 with this proposal. If this is OK, in following case

[GitHub] [spark] wangyum opened a new pull request #25170: [SPARK-28343][FOLLOW-UP][SQL][TEST] Enable spark.sql.function.preferIntegralDivision for PostgreSQL testing

2019-07-16 Thread GitBox
wangyum opened a new pull request #25170: [SPARK-28343][FOLLOW-UP][SQL][TEST] Enable spark.sql.function.preferIntegralDivision for PostgreSQL testing URL: https://github.com/apache/spark/pull/25170 ## What changes were proposed in this pull request? This PR enables

[GitHub] [spark] cloud-fan commented on issue #25167: [SPARK-27485] EnsureRequirements.reorder should handle duplicate expressions gracefully

2019-07-16 Thread GitBox
cloud-fan commented on issue #25167: [SPARK-27485] EnsureRequirements.reorder should handle duplicate expressions gracefully URL: https://github.com/apache/spark/pull/25167#issuecomment-511736945 ah we probably need to fix it in 2.4 as well, @dongjoon-hyun can you help to backport?

[GitHub] [spark] AmplabJenkins removed a comment on issue #25164: [SPARK-28375] Prevent the PullupCorrelatedPredicates optimizer rule from removing predicates if run multiple times

2019-07-16 Thread GitBox
AmplabJenkins removed a comment on issue #25164: [SPARK-28375] Prevent the PullupCorrelatedPredicates optimizer rule from removing predicates if run multiple times URL: https://github.com/apache/spark/pull/25164#issuecomment-511735709 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25164: [SPARK-28375] Prevent the PullupCorrelatedPredicates optimizer rule from removing predicates if run multiple times

2019-07-16 Thread GitBox
AmplabJenkins removed a comment on issue #25164: [SPARK-28375] Prevent the PullupCorrelatedPredicates optimizer rule from removing predicates if run multiple times URL: https://github.com/apache/spark/pull/25164#issuecomment-511735714 Test PASSed. Refer to this link for build results

[GitHub] [spark] priyankagargnitk commented on issue #22054: [SPARK-24703][SQL]: To add support to multiply CalendarInterval with Integral Type.

2019-07-16 Thread GitBox
priyankagargnitk commented on issue #22054: [SPARK-24703][SQL]: To add support to multiply CalendarInterval with Integral Type. URL: https://github.com/apache/spark/pull/22054#issuecomment-511736337 @hvanhovell @dongjoon-hyun: All the review comments are incorporated. Please have a look

[GitHub] [spark] SparkQA commented on issue #25164: [SPARK-28375] Prevent the PullupCorrelatedPredicates optimizer rule from removing predicates if run multiple times

2019-07-16 Thread GitBox
SparkQA commented on issue #25164: [SPARK-28375] Prevent the PullupCorrelatedPredicates optimizer rule from removing predicates if run multiple times URL: https://github.com/apache/spark/pull/25164#issuecomment-511736419 **[Test build #107730 has

[GitHub] [spark] maropu commented on issue #25137: [SPARK-28348][SQL] Decimal precision promotion for binary arithmetic with casted decimal type

2019-07-16 Thread GitBox
maropu commented on issue #25137: [SPARK-28348][SQL] Decimal precision promotion for binary arithmetic with casted decimal type URL: https://github.com/apache/spark/pull/25137#issuecomment-511744926 @cloud-fan The current behaiovur comes from

[GitHub] [spark] maropu commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax

2019-07-16 Thread GitBox
maropu commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-511745351 yea, I'll check in a day and just a sec. This is an automated message

[GitHub] [spark] gaborgsomogyi commented on issue #25171: [SPARK-27485][FOLLOWUP] Quick fix

2019-07-16 Thread GitBox
gaborgsomogyi commented on issue #25171: [SPARK-27485][FOLLOWUP] Quick fix URL: https://github.com/apache/spark/pull/25171#issuecomment-511757137 cc @cloud-fan @hvanhovell This is an automated message from the Apache Git

[GitHub] [spark] SparkQA commented on issue #24759: [SPARK-27395][SQL][WIP] Improve EXPLAIN command

2019-07-16 Thread GitBox
SparkQA commented on issue #24759: [SPARK-27395][SQL][WIP] Improve EXPLAIN command URL: https://github.com/apache/spark/pull/24759#issuecomment-511763648 **[Test build #107726 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/107726/testReport)** for PR

[GitHub] [spark] SparkQA removed a comment on issue #24759: [SPARK-27395][SQL][WIP] Improve EXPLAIN command

2019-07-16 Thread GitBox
SparkQA removed a comment on issue #24759: [SPARK-27395][SQL][WIP] Improve EXPLAIN command URL: https://github.com/apache/spark/pull/24759#issuecomment-511696191 **[Test build #107726 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/107726/testReport)** for

[GitHub] [spark] AmplabJenkins commented on issue #24939: [SPARK-18569][ML][R] Support RFormula arithmetic, I() and spark functions

2019-07-16 Thread GitBox
AmplabJenkins commented on issue #24939: [SPARK-18569][ML][R] Support RFormula arithmetic, I() and spark functions URL: https://github.com/apache/spark/pull/24939#issuecomment-511775069 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #24939: [SPARK-18569][ML][R] Support RFormula arithmetic, I() and spark functions

2019-07-16 Thread GitBox
AmplabJenkins commented on issue #24939: [SPARK-18569][ML][R] Support RFormula arithmetic, I() and spark functions URL: https://github.com/apache/spark/pull/24939#issuecomment-511775076 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] ozancicek commented on a change in pull request #24939: [SPARK-18569][ML][R] Support RFormula arithmetic, I() and spark functions

2019-07-16 Thread GitBox
ozancicek commented on a change in pull request #24939: [SPARK-18569][ML][R] Support RFormula arithmetic, I() and spark functions URL: https://github.com/apache/spark/pull/24939#discussion_r303856796 ## File path: mllib/src/main/scala/org/apache/spark/ml/feature/RFormula.scala

[GitHub] [spark] AmplabJenkins removed a comment on issue #25172: [SPARK-28412][SQL]ANSI SQL: OVERLAY function support byte array

2019-07-16 Thread GitBox
AmplabJenkins removed a comment on issue #25172: [SPARK-28412][SQL]ANSI SQL: OVERLAY function support byte array URL: https://github.com/apache/spark/pull/25172#issuecomment-511781742 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on issue #25172: [SPARK-28412][SQL]ANSI SQL: OVERLAY function support byte array

2019-07-16 Thread GitBox
SparkQA commented on issue #25172: [SPARK-28412][SQL]ANSI SQL: OVERLAY function support byte array URL: https://github.com/apache/spark/pull/25172#issuecomment-511782308 **[Test build #107737 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #25172: [SPARK-28412][SQL]ANSI SQL: OVERLAY function support byte array

2019-07-16 Thread GitBox
AmplabJenkins removed a comment on issue #25172: [SPARK-28412][SQL]ANSI SQL: OVERLAY function support byte array URL: https://github.com/apache/spark/pull/25172#issuecomment-511781429 Can one of the admins verify this patch?

  1   2   3   4   5   6   7   8   9   >