[GitHub] [spark] SparkQA commented on issue #26263: [SPARK-29570][WEBUI] Improve tooltip for Executor Tab for Shuffle Write, Blacklisted, Logs, Threaddump columns

2019-11-10 Thread GitBox
SparkQA commented on issue #26263: [SPARK-29570][WEBUI] Improve tooltip for Executor Tab for Shuffle Write,Blacklisted,Logs,Threaddump columns URL: https://github.com/apache/spark/pull/26263#issuecomment-552232572 **[Test build #4918 has

[GitHub] [spark] SparkQA removed a comment on issue #26263: [SPARK-29570][WEBUI] Improve tooltip for Executor Tab for Shuffle Write, Blacklisted, Logs, Threaddump columns

2019-11-10 Thread GitBox
SparkQA removed a comment on issue #26263: [SPARK-29570][WEBUI] Improve tooltip for Executor Tab for Shuffle Write,Blacklisted,Logs,Threaddump columns URL: https://github.com/apache/spark/pull/26263#issuecomment-55854 **[Test build #4918 has

[GitHub] [spark] SparkQA commented on issue #25734: [SPARK-28939][SQL][2.4] Propagate SQLConf for plans executed by toRdd

2019-11-10 Thread GitBox
SparkQA commented on issue #25734: [SPARK-28939][SQL][2.4] Propagate SQLConf for plans executed by toRdd URL: https://github.com/apache/spark/pull/25734#issuecomment-552237974 **[Test build #113545 has

[GitHub] [spark] SparkQA removed a comment on issue #25734: [SPARK-28939][SQL][2.4] Propagate SQLConf for plans executed by toRdd

2019-11-10 Thread GitBox
SparkQA removed a comment on issue #25734: [SPARK-28939][SQL][2.4] Propagate SQLConf for plans executed by toRdd URL: https://github.com/apache/spark/pull/25734#issuecomment-552220925 **[Test build #113545 has

[GitHub] [spark] maropu edited a comment on issue #26458: [SPARK-29821] Allow calling non-aggregate SQL functions with column name

2019-11-10 Thread GitBox
maropu edited a comment on issue #26458: [SPARK-29821] Allow calling non-aggregate SQL functions with column name URL: https://github.com/apache/spark/pull/26458#issuecomment-552192167 IIRC we don't actively add an interface for string column names in functions. plz use `selectExpr`

[GitHub] [spark] maropu commented on a change in pull request #26459: [SPARK-29825][SQL][TESTS] Add join conditions in join-related tests of SQLQueryTestSuite

2019-11-10 Thread GitBox
maropu commented on a change in pull request #26459: [SPARK-29825][SQL][TESTS] Add join conditions in join-related tests of SQLQueryTestSuite URL: https://github.com/apache/spark/pull/26459#discussion_r344526125 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #26097: [SPARK-29421][SQL] Supporting Create Table Like Using Provider

2019-11-10 Thread GitBox
AmplabJenkins removed a comment on issue #26097: [SPARK-29421][SQL] Supporting Create Table Like Using Provider URL: https://github.com/apache/spark/pull/26097#issuecomment-552265005 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on issue #26097: [SPARK-29421][SQL] Supporting Create Table Like Using Provider

2019-11-10 Thread GitBox
SparkQA commented on issue #26097: [SPARK-29421][SQL] Supporting Create Table Like Using Provider URL: https://github.com/apache/spark/pull/26097#issuecomment-552268405 **[Test build #113559 has

[GitHub] [spark] LantaoJin commented on issue #26097: [SPARK-29421][SQL] Supporting Create Table Like Using Provider

2019-11-10 Thread GitBox
LantaoJin commented on issue #26097: [SPARK-29421][SQL] Supporting Create Table Like Using Provider URL: https://github.com/apache/spark/pull/26097#issuecomment-552268279 retest this please This is an automated message from

[GitHub] [spark] AmplabJenkins removed a comment on issue #26461: [SPARK-29831][SQL] Scan Hive partitioned table should not dramatically increase data parallelism

2019-11-10 Thread GitBox
AmplabJenkins removed a comment on issue #26461: [SPARK-29831][SQL] Scan Hive partitioned table should not dramatically increase data parallelism URL: https://github.com/apache/spark/pull/26461#issuecomment-552289217 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #26461: [SPARK-29831][SQL] Scan Hive partitioned table should not dramatically increase data parallelism

2019-11-10 Thread GitBox
AmplabJenkins removed a comment on issue #26461: [SPARK-29831][SQL] Scan Hive partitioned table should not dramatically increase data parallelism URL: https://github.com/apache/spark/pull/26461#issuecomment-552289221 Test PASSed. Refer to this link for build results (access rights to CI

[GitHub] [spark] AmplabJenkins commented on issue #26461: [SPARK-29831][SQL] Scan Hive partitioned table should not dramatically increase data parallelism

2019-11-10 Thread GitBox
AmplabJenkins commented on issue #26461: [SPARK-29831][SQL] Scan Hive partitioned table should not dramatically increase data parallelism URL: https://github.com/apache/spark/pull/26461#issuecomment-552289221 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins commented on issue #26461: [SPARK-29831][SQL] Scan Hive partitioned table should not dramatically increase data parallelism

2019-11-10 Thread GitBox
AmplabJenkins commented on issue #26461: [SPARK-29831][SQL] Scan Hive partitioned table should not dramatically increase data parallelism URL: https://github.com/apache/spark/pull/26461#issuecomment-552289217 Merged build finished. Test PASSed.

[GitHub] [spark] imback82 commented on a change in pull request #26441: [SPARK-29682][SQL] Resolve conflicting references in aggregate expressions

2019-11-10 Thread GitBox
imback82 commented on a change in pull request #26441: [SPARK-29682][SQL] Resolve conflicting references in aggregate expressions URL: https://github.com/apache/spark/pull/26441#discussion_r344557807 ## File path:

[GitHub] [spark] beliefer commented on a change in pull request #26420: [SPARK-27986][SQL] Support ANSI SQL filter predicate for aggregate expression.

2019-11-10 Thread GitBox
beliefer commented on a change in pull request #26420: [SPARK-27986][SQL] Support ANSI SQL filter predicate for aggregate expression. URL: https://github.com/apache/spark/pull/26420#discussion_r344557825 ## File path:

[GitHub] [spark] beliefer commented on a change in pull request #26420: [SPARK-27986][SQL] Support ANSI SQL filter predicate for aggregate expression.

2019-11-10 Thread GitBox
beliefer commented on a change in pull request #26420: [SPARK-27986][SQL] Support ANSI SQL filter predicate for aggregate expression. URL: https://github.com/apache/spark/pull/26420#discussion_r344557706 ## File path:

[GitHub] [spark] beliefer commented on a change in pull request #26420: [SPARK-27986][SQL] Support ANSI SQL filter predicate for aggregate expression.

2019-11-10 Thread GitBox
beliefer commented on a change in pull request #26420: [SPARK-27986][SQL] Support ANSI SQL filter predicate for aggregate expression. URL: https://github.com/apache/spark/pull/26420#discussion_r344557683 ## File path: docs/sql-keywords.md ## @@ -115,6 +115,7 @@ Below is a

[GitHub] [spark] imback82 commented on a change in pull request #26441: [SPARK-29682][SQL] Resolve conflicting references in aggregate expressions

2019-11-10 Thread GitBox
imback82 commented on a change in pull request #26441: [SPARK-29682][SQL] Resolve conflicting references in aggregate expressions URL: https://github.com/apache/spark/pull/26441#discussion_r344557828 ## File path:

[GitHub] [spark] maropu commented on issue #26459: [SPARK-29825][SQL][TESTS] Add join-related configs in `inner-join.sql` and `postgreSQL/join.sql`

2019-11-10 Thread GitBox
maropu commented on issue #26459: [SPARK-29825][SQL][TESTS] Add join-related configs in `inner-join.sql` and `postgreSQL/join.sql` URL: https://github.com/apache/spark/pull/26459#issuecomment-552252750 > Hi, @maropu . This PR adds comment. Is Add join conditions in join-related tests

[GitHub] [spark] LantaoJin edited a comment on issue #26097: [SPARK-29421][SQL] Supporting Create Table Like Using Provider

2019-11-10 Thread GitBox
LantaoJin edited a comment on issue #26097: [SPARK-29421][SQL] Supporting Create Table Like Using Provider URL: https://github.com/apache/spark/pull/26097#issuecomment-552254605 > we can add an extra check `DDLUtils.isHiveProvider`, to make it work I think we can reuse

[GitHub] [spark] AmplabJenkins removed a comment on issue #26444: [SPARK-29807][SQL] Rename "spark.sql.ansi.enabled" to "spark.sql.dialect.spark.ansi.enabled"

2019-11-10 Thread GitBox
AmplabJenkins removed a comment on issue #26444: [SPARK-29807][SQL] Rename "spark.sql.ansi.enabled" to "spark.sql.dialect.spark.ansi.enabled" URL: https://github.com/apache/spark/pull/26444#issuecomment-552258689 Test PASSed. Refer to this link for build results (access rights to CI

[GitHub] [spark] HyukjinKwon commented on a change in pull request #26435: [SPARK-29821][SQL] Allow calling non-aggregate SQL functions with column name

2019-11-10 Thread GitBox
HyukjinKwon commented on a change in pull request #26435: [SPARK-29821][SQL] Allow calling non-aggregate SQL functions with column name URL: https://github.com/apache/spark/pull/26435#discussion_r344531175 ## File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala

[GitHub] [spark] AmplabJenkins removed a comment on issue #26444: [SPARK-29807][SQL] Rename "spark.sql.ansi.enabled" to "spark.sql.dialect.spark.ansi.enabled"

2019-11-10 Thread GitBox
AmplabJenkins removed a comment on issue #26444: [SPARK-29807][SQL] Rename "spark.sql.ansi.enabled" to "spark.sql.dialect.spark.ansi.enabled" URL: https://github.com/apache/spark/pull/26444#issuecomment-552258687 Merged build finished. Test PASSed.

[GitHub] [spark] Icysandwich commented on a change in pull request #26454: [SPARK-29818][MLLIB] Missing persist on RDD

2019-11-10 Thread GitBox
Icysandwich commented on a change in pull request #26454: [SPARK-29818][MLLIB] Missing persist on RDD URL: https://github.com/apache/spark/pull/26454#discussion_r344531250 ## File path: mllib/src/main/scala/org/apache/spark/ml/evaluation/MultilabelClassificationEvaluator.scala

[GitHub] [spark] Icysandwich commented on a change in pull request #26454: [SPARK-29818][MLLIB] Missing persist on RDD

2019-11-10 Thread GitBox
Icysandwich commented on a change in pull request #26454: [SPARK-29818][MLLIB] Missing persist on RDD URL: https://github.com/apache/spark/pull/26454#discussion_r344531250 ## File path: mllib/src/main/scala/org/apache/spark/ml/evaluation/MultilabelClassificationEvaluator.scala

[GitHub] [spark] HyukjinKwon commented on a change in pull request #26435: [SPARK-29821][SQL] Allow calling non-aggregate SQL functions with column name

2019-11-10 Thread GitBox
HyukjinKwon commented on a change in pull request #26435: [SPARK-29821][SQL] Allow calling non-aggregate SQL functions with column name URL: https://github.com/apache/spark/pull/26435#discussion_r344531088 ## File path: python/pyspark/sql/functions.py ## @@ -513,6 +513,8

[GitHub] [spark] AmplabJenkins commented on issue #26444: [SPARK-29807][SQL] Rename "spark.sql.ansi.enabled" to "spark.sql.dialect.spark.ansi.enabled"

2019-11-10 Thread GitBox
AmplabJenkins commented on issue #26444: [SPARK-29807][SQL] Rename "spark.sql.ansi.enabled" to "spark.sql.dialect.spark.ansi.enabled" URL: https://github.com/apache/spark/pull/26444#issuecomment-552258689 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins commented on issue #26444: [SPARK-29807][SQL] Rename "spark.sql.ansi.enabled" to "spark.sql.dialect.spark.ansi.enabled"

2019-11-10 Thread GitBox
AmplabJenkins commented on issue #26444: [SPARK-29807][SQL] Rename "spark.sql.ansi.enabled" to "spark.sql.dialect.spark.ansi.enabled" URL: https://github.com/apache/spark/pull/26444#issuecomment-552258687 Merged build finished. Test PASSed.

[GitHub] [spark] HyukjinKwon commented on a change in pull request #26435: [SPARK-29821][SQL] Allow calling non-aggregate SQL functions with column name

2019-11-10 Thread GitBox
HyukjinKwon commented on a change in pull request #26435: [SPARK-29821][SQL] Allow calling non-aggregate SQL functions with column name URL: https://github.com/apache/spark/pull/26435#discussion_r344530892 ## File path: python/pyspark/sql/functions.py ## @@ -513,6 +513,8

[GitHub] [spark] HyukjinKwon commented on a change in pull request #26435: [SPARK-29821][SQL] Allow calling non-aggregate SQL functions with column name

2019-11-10 Thread GitBox
HyukjinKwon commented on a change in pull request #26435: [SPARK-29821][SQL] Allow calling non-aggregate SQL functions with column name URL: https://github.com/apache/spark/pull/26435#discussion_r344531140 ## File path: python/pyspark/sql/functions.py ## @@ -513,6 +513,8

[GitHub] [spark] HyukjinKwon commented on a change in pull request #26435: [SPARK-29821][SQL] Allow calling non-aggregate SQL functions with column name

2019-11-10 Thread GitBox
HyukjinKwon commented on a change in pull request #26435: [SPARK-29821][SQL] Allow calling non-aggregate SQL functions with column name URL: https://github.com/apache/spark/pull/26435#discussion_r344531286 ## File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala

[GitHub] [spark] Icysandwich commented on a change in pull request #26454: [SPARK-29818][MLLIB] Missing persist on RDD

2019-11-10 Thread GitBox
Icysandwich commented on a change in pull request #26454: [SPARK-29818][MLLIB] Missing persist on RDD URL: https://github.com/apache/spark/pull/26454#discussion_r344531250 ## File path: mllib/src/main/scala/org/apache/spark/ml/evaluation/MultilabelClassificationEvaluator.scala

[GitHub] [spark] HyukjinKwon commented on a change in pull request #26435: [SPARK-29821][SQL] Allow calling non-aggregate SQL functions with column name

2019-11-10 Thread GitBox
HyukjinKwon commented on a change in pull request #26435: [SPARK-29821][SQL] Allow calling non-aggregate SQL functions with column name URL: https://github.com/apache/spark/pull/26435#discussion_r344530920 ## File path: python/pyspark/sql/functions.py ## @@ -513,6 +513,8

[GitHub] [spark] stczwd commented on a change in pull request #26433: [SPARK-29771][K8S] Add configure to limit executor failures

2019-11-10 Thread GitBox
stczwd commented on a change in pull request #26433: [SPARK-29771][K8S] Add configure to limit executor failures URL: https://github.com/apache/spark/pull/26433#discussion_r344532781 ## File path:

[GitHub] [spark] viirya opened a new pull request #26461: [SPARK-29831][SQL] Scan Hive partitioned table should not dramatically increase data parallelism

2019-11-10 Thread GitBox
viirya opened a new pull request #26461: [SPARK-29831][SQL] Scan Hive partitioned table should not dramatically increase data parallelism URL: https://github.com/apache/spark/pull/26461 ### What changes were proposed in this pull request? Hive table scan operator reads

[GitHub] [spark] dongjoon-hyun commented on issue #26459: [SPARK-29825][SQL][TESTS] Add join-related configs in `inner-join.sql` and `postgreSQL/join.sql`

2019-11-10 Thread GitBox
dongjoon-hyun commented on issue #26459: [SPARK-29825][SQL][TESTS] Add join-related configs in `inner-join.sql` and `postgreSQL/join.sql` URL: https://github.com/apache/spark/pull/26459#issuecomment-552266698 Shall we add the following line as a first line? This PR is adding a comment

[GitHub] [spark] viirya commented on issue #26461: [SPARK-29831][SQL] Scan Hive partitioned table should not dramatically increase data parallelism

2019-11-10 Thread GitBox
viirya commented on issue #26461: [SPARK-29831][SQL] Scan Hive partitioned table should not dramatically increase data parallelism URL: https://github.com/apache/spark/pull/26461#issuecomment-552266990 cc @cloud-fan @dongjoon-hyun @felixcheung

[GitHub] [spark] maropu commented on issue #26459: [SPARK-29825][SQL][TESTS] Add join-related configs in `inner-join.sql` and `postgreSQL/join.sql`

2019-11-10 Thread GitBox
maropu commented on issue #26459: [SPARK-29825][SQL][TESTS] Add join-related configs in `inner-join.sql` and `postgreSQL/join.sql` URL: https://github.com/apache/spark/pull/26459#issuecomment-552266911 Ah, ok. This is an

[GitHub] [spark] mob-ai commented on a change in pull request #26124: [SPARK-29224][ML]Implement Factorization Machines as a ml-pipeline component

2019-11-10 Thread GitBox
mob-ai commented on a change in pull request #26124: [SPARK-29224][ML]Implement Factorization Machines as a ml-pipeline component URL: https://github.com/apache/spark/pull/26124#discussion_r344544387 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #25964: [SPARK-29287][Core] Add ExecutorConstructed message to tell driver which executor is ready for making offers

2019-11-10 Thread GitBox
AmplabJenkins removed a comment on issue #25964: [SPARK-29287][Core] Add ExecutorConstructed message to tell driver which executor is ready for making offers URL: https://github.com/apache/spark/pull/25964#issuecomment-552276404 Test PASSed. Refer to this link for build results (access

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #26459: [SPARK-29825][SQL][TESTS] Add join-related configs in `inner-join.sql` and `postgreSQL/join.sql`

2019-11-10 Thread GitBox
AngersZh commented on a change in pull request #26459: [SPARK-29825][SQL][TESTS] Add join-related configs in `inner-join.sql` and `postgreSQL/join.sql` URL: https://github.com/apache/spark/pull/26459#discussion_r344544527 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #25964: [SPARK-29287][Core] Add ExecutorConstructed message to tell driver which executor is ready for making offers

2019-11-10 Thread GitBox
AmplabJenkins removed a comment on issue #25964: [SPARK-29287][Core] Add ExecutorConstructed message to tell driver which executor is ready for making offers URL: https://github.com/apache/spark/pull/25964#issuecomment-552276390 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25964: [SPARK-29287][Core] Add ExecutorConstructed message to tell driver which executor is ready for making offers

2019-11-10 Thread GitBox
AmplabJenkins commented on issue #25964: [SPARK-29287][Core] Add ExecutorConstructed message to tell driver which executor is ready for making offers URL: https://github.com/apache/spark/pull/25964#issuecomment-552276404 Test PASSed. Refer to this link for build results (access rights

[GitHub] [spark] AmplabJenkins commented on issue #25964: [SPARK-29287][Core] Add ExecutorConstructed message to tell driver which executor is ready for making offers

2019-11-10 Thread GitBox
AmplabJenkins commented on issue #25964: [SPARK-29287][Core] Add ExecutorConstructed message to tell driver which executor is ready for making offers URL: https://github.com/apache/spark/pull/25964#issuecomment-552276390 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #26444: [SPARK-29807][SQL] Rename "spark.sql.ansi.enabled" to "spark.sql.dialect.spark.ansi.enabled"

2019-11-10 Thread GitBox
AmplabJenkins removed a comment on issue #26444: [SPARK-29807][SQL] Rename "spark.sql.ansi.enabled" to "spark.sql.dialect.spark.ansi.enabled" URL: https://github.com/apache/spark/pull/26444#issuecomment-552284932 Merged build finished. Test FAILed.

[GitHub] [spark] iRakson commented on a change in pull request #26315: [SPARK-29152][CORE] Executor Plugin shutdown when dynamic allocation is ena…

2019-11-10 Thread GitBox
iRakson commented on a change in pull request #26315: [SPARK-29152][CORE] Executor Plugin shutdown when dynamic allocation is ena… URL: https://github.com/apache/spark/pull/26315#discussion_r344551590 ## File path: core/src/main/scala/org/apache/spark/executor/Executor.scala

[GitHub] [spark] AmplabJenkins removed a comment on issue #26444: [SPARK-29807][SQL] Rename "spark.sql.ansi.enabled" to "spark.sql.dialect.spark.ansi.enabled"

2019-11-10 Thread GitBox
AmplabJenkins removed a comment on issue #26444: [SPARK-29807][SQL] Rename "spark.sql.ansi.enabled" to "spark.sql.dialect.spark.ansi.enabled" URL: https://github.com/apache/spark/pull/26444#issuecomment-552284941 Test FAILed. Refer to this link for build results (access rights to CI

[GitHub] [spark] AmplabJenkins removed a comment on issue #25964: [SPARK-29287][Core] Add ExecutorConstructed message to tell driver which executor is ready for making offers

2019-11-10 Thread GitBox
AmplabJenkins removed a comment on issue #25964: [SPARK-29287][Core] Add ExecutorConstructed message to tell driver which executor is ready for making offers URL: https://github.com/apache/spark/pull/25964#issuecomment-552297321 Test PASSed. Refer to this link for build results (access

[GitHub] [spark] AmplabJenkins commented on issue #25964: [SPARK-29287][Core] Add ExecutorConstructed message to tell driver which executor is ready for making offers

2019-11-10 Thread GitBox
AmplabJenkins commented on issue #25964: [SPARK-29287][Core] Add ExecutorConstructed message to tell driver which executor is ready for making offers URL: https://github.com/apache/spark/pull/25964#issuecomment-552297316 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25964: [SPARK-29287][Core] Add ExecutorConstructed message to tell driver which executor is ready for making offers

2019-11-10 Thread GitBox
AmplabJenkins removed a comment on issue #25964: [SPARK-29287][Core] Add ExecutorConstructed message to tell driver which executor is ready for making offers URL: https://github.com/apache/spark/pull/25964#issuecomment-552297316 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25964: [SPARK-29287][Core] Add ExecutorConstructed message to tell driver which executor is ready for making offers

2019-11-10 Thread GitBox
AmplabJenkins commented on issue #25964: [SPARK-29287][Core] Add ExecutorConstructed message to tell driver which executor is ready for making offers URL: https://github.com/apache/spark/pull/25964#issuecomment-552297321 Test PASSed. Refer to this link for build results (access rights

[GitHub] [spark] cloud-fan commented on issue #25024: [SPARK-27296][SQL] User Defined Aggregators that do not ser/de on each input row

2019-11-10 Thread GitBox
cloud-fan commented on issue #25024: [SPARK-27296][SQL] User Defined Aggregators that do not ser/de on each input row URL: https://github.com/apache/spark/pull/25024#issuecomment-552303072 UDAF should work in Java, and I don't think put scala implict in the public API is a good idea.

[GitHub] [spark] viirya commented on a change in pull request #26461: [SPARK-29831][SQL] Scan Hive partitioned table should not dramatically increase data parallelism

2019-11-10 Thread GitBox
viirya commented on a change in pull request #26461: [SPARK-29831][SQL] Scan Hive partitioned table should not dramatically increase data parallelism URL: https://github.com/apache/spark/pull/26461#discussion_r344565178 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #26449: [SPARK-29822][SQL] Fix cast error when there are white spaces between signs and values

2019-11-10 Thread GitBox
cloud-fan commented on a change in pull request #26449: [SPARK-29822][SQL] Fix cast error when there are white spaces between signs and values URL: https://github.com/apache/spark/pull/26449#discussion_r344573164 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #26449: [SPARK-29822][SQL] Fix cast error when there are white spaces between signs and values

2019-11-10 Thread GitBox
cloud-fan commented on a change in pull request #26449: [SPARK-29822][SQL] Fix cast error when there are white spaces between signs and values URL: https://github.com/apache/spark/pull/26449#discussion_r344573164 ## File path:

[GitHub] [spark] dilipbiswal commented on a change in pull request #26437: [SPARK-29800][SQL] Plan Exists 's subquery in PlanSubqueries

2019-11-10 Thread GitBox
dilipbiswal commented on a change in pull request #26437: [SPARK-29800][SQL] Plan Exists 's subquery in PlanSubqueries URL: https://github.com/apache/spark/pull/26437#discussion_r344582313 ## File path:

[GitHub] [spark] dilipbiswal commented on a change in pull request #26437: [SPARK-29800][SQL] Plan Exists 's subquery in PlanSubqueries

2019-11-10 Thread GitBox
dilipbiswal commented on a change in pull request #26437: [SPARK-29800][SQL] Plan Exists 's subquery in PlanSubqueries URL: https://github.com/apache/spark/pull/26437#discussion_r344582313 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #26118: [SPARK-24915][Python] Fix Row handling with Schema.

2019-11-10 Thread GitBox
AmplabJenkins removed a comment on issue #26118: [SPARK-24915][Python] Fix Row handling with Schema. URL: https://github.com/apache/spark/pull/26118#issuecomment-552230486 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins removed a comment on issue #26118: [SPARK-24915][Python] Fix Row handling with Schema.

2019-11-10 Thread GitBox
AmplabJenkins removed a comment on issue #26118: [SPARK-24915][Python] Fix Row handling with Schema. URL: https://github.com/apache/spark/pull/26118#issuecomment-552230489 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] imback82 commented on a change in pull request #26441: [SPARK-29682][SQL] Resolve conflicting references in aggregate expressions

2019-11-10 Thread GitBox
imback82 commented on a change in pull request #26441: [SPARK-29682][SQL] Resolve conflicting references in aggregate expressions URL: https://github.com/apache/spark/pull/26441#discussion_r344516803 ## File path:

[GitHub] [spark] dongjoon-hyun closed pull request #25734: [SPARK-28939][SQL][2.4] Propagate SQLConf for plans executed by toRdd

2019-11-10 Thread GitBox
dongjoon-hyun closed pull request #25734: [SPARK-28939][SQL][2.4] Propagate SQLConf for plans executed by toRdd URL: https://github.com/apache/spark/pull/25734 This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on issue #26446: [SPARK-29393][SQL] Add `make_interval` function

2019-11-10 Thread GitBox
AmplabJenkins commented on issue #26446: [SPARK-29393][SQL] Add `make_interval` function URL: https://github.com/apache/spark/pull/26446#issuecomment-552241564 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on issue #26446: [SPARK-29393][SQL] Add `make_interval` function

2019-11-10 Thread GitBox
SparkQA removed a comment on issue #26446: [SPARK-29393][SQL] Add `make_interval` function URL: https://github.com/apache/spark/pull/26446#issuecomment-552221679 **[Test build #113546 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/113546/testReport)** for

[GitHub] [spark] AmplabJenkins commented on issue #26446: [SPARK-29393][SQL] Add `make_interval` function

2019-11-10 Thread GitBox
AmplabJenkins commented on issue #26446: [SPARK-29393][SQL] Add `make_interval` function URL: https://github.com/apache/spark/pull/26446#issuecomment-552241563 Merged build finished. Test PASSed. This is an automated message

[GitHub] [spark] holdenk commented on issue #26312: [SPARK-29649][SQL] Stop task set if FileAlreadyExistsException was thrown when writing to output file

2019-11-10 Thread GitBox
holdenk commented on issue #26312: [SPARK-29649][SQL] Stop task set if FileAlreadyExistsException was thrown when writing to output file URL: https://github.com/apache/spark/pull/26312#issuecomment-552246303 Sure, I've got some review cycles on Tuesday I'll take a look then unless it's

[GitHub] [spark] maropu commented on issue #26458: [SPARK-29821] Allow calling non-aggregate SQL functions with column name

2019-11-10 Thread GitBox
maropu commented on issue #26458: [SPARK-29821] Allow calling non-aggregate SQL functions with column name URL: https://github.com/apache/spark/pull/26458#issuecomment-552249017 Similar PRs to support string columns periodically come up, so it might be worth leaving some notes about this

[GitHub] [spark] AmplabJenkins removed a comment on issue #26444: [SPARK-29807][SQL] Rename "spark.sql.ansi.enabled" to "spark.sql.dialect.spark.ansi.enabled"

2019-11-10 Thread GitBox
AmplabJenkins removed a comment on issue #26444: [SPARK-29807][SQL] Rename "spark.sql.ansi.enabled" to "spark.sql.dialect.spark.ansi.enabled" URL: https://github.com/apache/spark/pull/26444#issuecomment-552257101 Test PASSed. Refer to this link for build results (access rights to CI

[GitHub] [spark] AmplabJenkins removed a comment on issue #26444: [SPARK-29807][SQL] Rename "spark.sql.ansi.enabled" to "spark.sql.dialect.spark.ansi.enabled"

2019-11-10 Thread GitBox
AmplabJenkins removed a comment on issue #26444: [SPARK-29807][SQL] Rename "spark.sql.ansi.enabled" to "spark.sql.dialect.spark.ansi.enabled" URL: https://github.com/apache/spark/pull/26444#issuecomment-552257094 Build finished. Test PASSed.

[GitHub] [spark] hahadsg commented on a change in pull request #26124: [SPARK-29224][ML]Implement Factorization Machines as a ml-pipeline component

2019-11-10 Thread GitBox
hahadsg commented on a change in pull request #26124: [SPARK-29224][ML]Implement Factorization Machines as a ml-pipeline component URL: https://github.com/apache/spark/pull/26124#discussion_r344534187 ## File path:

[GitHub] [spark] hahadsg commented on a change in pull request #26124: [SPARK-29224][ML]Implement Factorization Machines as a ml-pipeline component

2019-11-10 Thread GitBox
hahadsg commented on a change in pull request #26124: [SPARK-29224][ML]Implement Factorization Machines as a ml-pipeline component URL: https://github.com/apache/spark/pull/26124#discussion_r344534187 ## File path:

[GitHub] [spark] mob-ai commented on a change in pull request #26124: [SPARK-29224][ML]Implement Factorization Machines as a ml-pipeline component

2019-11-10 Thread GitBox
mob-ai commented on a change in pull request #26124: [SPARK-29224][ML]Implement Factorization Machines as a ml-pipeline component URL: https://github.com/apache/spark/pull/26124#discussion_r344536192 ## File path:

[GitHub] [spark] SparkQA commented on issue #26416: [WIP][SPARK-29779][CORE] Compact old event log files and cleanup

2019-11-10 Thread GitBox
SparkQA commented on issue #26416: [WIP][SPARK-29779][CORE] Compact old event log files and cleanup URL: https://github.com/apache/spark/pull/26416#issuecomment-552265549 **[Test build #113556 has

[GitHub] [spark] AmplabJenkins commented on issue #26359: [SPARK-29713][SQL] Support Interval Unit Abbreviations in Interval Literals

2019-11-10 Thread GitBox
AmplabJenkins commented on issue #26359: [SPARK-29713][SQL] Support Interval Unit Abbreviations in Interval Literals URL: https://github.com/apache/spark/pull/26359#issuecomment-552273207 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #26359: [SPARK-29713][SQL] Support Interval Unit Abbreviations in Interval Literals

2019-11-10 Thread GitBox
AmplabJenkins commented on issue #26359: [SPARK-29713][SQL] Support Interval Unit Abbreviations in Interval Literals URL: https://github.com/apache/spark/pull/26359#issuecomment-552273213 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #26359: [SPARK-29713][SQL] Support Interval Unit Abbreviations in Interval Literals

2019-11-10 Thread GitBox
AmplabJenkins removed a comment on issue #26359: [SPARK-29713][SQL] Support Interval Unit Abbreviations in Interval Literals URL: https://github.com/apache/spark/pull/26359#issuecomment-552273207 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #26359: [SPARK-29713][SQL] Support Interval Unit Abbreviations in Interval Literals

2019-11-10 Thread GitBox
AmplabJenkins removed a comment on issue #26359: [SPARK-29713][SQL] Support Interval Unit Abbreviations in Interval Literals URL: https://github.com/apache/spark/pull/26359#issuecomment-552273213 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #26439: [SPARK-29801][ML] ML models unify toString method

2019-11-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #26439: [SPARK-29801][ML] ML models unify toString method URL: https://github.com/apache/spark/pull/26439#discussion_r344539537 ## File path: mllib/src/main/scala/org/apache/spark/ml/clustering/GaussianMixture.scala ##

[GitHub] [spark] SparkQA commented on issue #26359: [SPARK-29713][SQL] Support Interval Unit Abbreviations in Interval Literals

2019-11-10 Thread GitBox
SparkQA commented on issue #26359: [SPARK-29713][SQL] Support Interval Unit Abbreviations in Interval Literals URL: https://github.com/apache/spark/pull/26359#issuecomment-552272984 **[Test build #113560 has

[GitHub] [spark] SparkQA commented on issue #26097: [SPARK-29421][SQL] Supporting Create Table Like Using Provider

2019-11-10 Thread GitBox
SparkQA commented on issue #26097: [SPARK-29421][SQL] Supporting Create Table Like Using Provider URL: https://github.com/apache/spark/pull/26097#issuecomment-552274572 **[Test build #113561 has

[GitHub] [spark] fuwhu commented on a change in pull request #26176: [SPARK-29519][SQL] SHOW TBLPROPERTIES should do multi-catalog resolution.

2019-11-10 Thread GitBox
fuwhu commented on a change in pull request #26176: [SPARK-29519][SQL] SHOW TBLPROPERTIES should do multi-catalog resolution. URL: https://github.com/apache/spark/pull/26176#discussion_r344542958 ## File path:

[GitHub] [spark] SparkQA commented on issue #26444: [SPARK-29807][SQL] Rename "spark.sql.ansi.enabled" to "spark.sql.dialect.spark.ansi.enabled"

2019-11-10 Thread GitBox
SparkQA commented on issue #26444: [SPARK-29807][SQL] Rename "spark.sql.ansi.enabled" to "spark.sql.dialect.spark.ansi.enabled" URL: https://github.com/apache/spark/pull/26444#issuecomment-552275701 **[Test build #113551 has

[GitHub] [spark] SparkQA removed a comment on issue #26444: [SPARK-29807][SQL] Rename "spark.sql.ansi.enabled" to "spark.sql.dialect.spark.ansi.enabled"

2019-11-10 Thread GitBox
SparkQA removed a comment on issue #26444: [SPARK-29807][SQL] Rename "spark.sql.ansi.enabled" to "spark.sql.dialect.spark.ansi.enabled" URL: https://github.com/apache/spark/pull/26444#issuecomment-552256924 **[Test build #113551 has

[GitHub] [spark] stczwd commented on issue #26433: [SPARK-29771][K8S] Add configure to limit executor failures

2019-11-10 Thread GitBox
stczwd commented on issue #26433: [SPARK-29771][K8S] Add configure to limit executor failures URL: https://github.com/apache/spark/pull/26433#issuecomment-552275557 @dongjoon-hyun Thanks for paying attention to this patch, I have made changes to comments.

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #26378: [SPARK-29724][SPARK-29726][WEBUI][SQL] Support JDBC/ODBC tab for HistoryServer WebUI

2019-11-10 Thread GitBox
AngersZh commented on a change in pull request #26378: [SPARK-29724][SPARK-29726][WEBUI][SQL] Support JDBC/ODBC tab for HistoryServer WebUI URL: https://github.com/apache/spark/pull/26378#discussion_r344548231 ## File path:

[GitHub] [spark] AmplabJenkins commented on issue #26462: [SPARK-29833][YARN] Add FileNotFoundException check for spark.yarn.jars

2019-11-10 Thread GitBox
AmplabJenkins commented on issue #26462: [SPARK-29833][YARN] Add FileNotFoundException check for spark.yarn.jars URL: https://github.com/apache/spark/pull/26462#issuecomment-552291173 Can one of the admins verify this patch?

[GitHub] [spark] AmplabJenkins commented on issue #26462: [SPARK-29833][YARN] Add FileNotFoundException check for spark.yarn.jars

2019-11-10 Thread GitBox
AmplabJenkins commented on issue #26462: [SPARK-29833][YARN] Add FileNotFoundException check for spark.yarn.jars URL: https://github.com/apache/spark/pull/26462#issuecomment-552290926 Can one of the admins verify this patch?

[GitHub] [spark] AmplabJenkins removed a comment on issue #25964: [SPARK-29287][Core] Add ExecutorConstructed message to tell driver which executor is ready for making offers

2019-11-10 Thread GitBox
AmplabJenkins removed a comment on issue #25964: [SPARK-29287][Core] Add ExecutorConstructed message to tell driver which executor is ready for making offers URL: https://github.com/apache/spark/pull/25964#issuecomment-552293293 Test FAILed. Refer to this link for build results (access

[GitHub] [spark] AmplabJenkins commented on issue #25964: [SPARK-29287][Core] Add ExecutorConstructed message to tell driver which executor is ready for making offers

2019-11-10 Thread GitBox
AmplabJenkins commented on issue #25964: [SPARK-29287][Core] Add ExecutorConstructed message to tell driver which executor is ready for making offers URL: https://github.com/apache/spark/pull/25964#issuecomment-552293290 Merged build finished. Test FAILed.

[GitHub] [spark] SparkQA commented on issue #25964: [SPARK-29287][Core] Add ExecutorConstructed message to tell driver which executor is ready for making offers

2019-11-10 Thread GitBox
SparkQA commented on issue #25964: [SPARK-29287][Core] Add ExecutorConstructed message to tell driver which executor is ready for making offers URL: https://github.com/apache/spark/pull/25964#issuecomment-552293178 **[Test build #113562 has

[GitHub] [spark] AmplabJenkins commented on issue #25964: [SPARK-29287][Core] Add ExecutorConstructed message to tell driver which executor is ready for making offers

2019-11-10 Thread GitBox
AmplabJenkins commented on issue #25964: [SPARK-29287][Core] Add ExecutorConstructed message to tell driver which executor is ready for making offers URL: https://github.com/apache/spark/pull/25964#issuecomment-552293293 Test FAILed. Refer to this link for build results (access rights

[GitHub] [spark] SparkQA removed a comment on issue #25964: [SPARK-29287][Core] Add ExecutorConstructed message to tell driver which executor is ready for making offers

2019-11-10 Thread GitBox
SparkQA removed a comment on issue #25964: [SPARK-29287][Core] Add ExecutorConstructed message to tell driver which executor is ready for making offers URL: https://github.com/apache/spark/pull/25964#issuecomment-552275998 **[Test build #113562 has

[GitHub] [spark] SparkQA commented on issue #26420: [SPARK-27986][SQL] Support ANSI SQL filter predicate for aggregate expression.

2019-11-10 Thread GitBox
SparkQA commented on issue #26420: [SPARK-27986][SQL] Support ANSI SQL filter predicate for aggregate expression. URL: https://github.com/apache/spark/pull/26420#issuecomment-552293709 **[Test build #113566 has

[GitHub] [spark] SparkQA commented on issue #26441: [SPARK-29682][SQL] Resolve conflicting references in aggregate expressions

2019-11-10 Thread GitBox
SparkQA commented on issue #26441: [SPARK-29682][SQL] Resolve conflicting references in aggregate expressions URL: https://github.com/apache/spark/pull/26441#issuecomment-552293705 **[Test build #113565 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #25964: [SPARK-29287][Core] Add ExecutorConstructed message to tell driver which executor is ready for making offers

2019-11-10 Thread GitBox
AmplabJenkins removed a comment on issue #25964: [SPARK-29287][Core] Add ExecutorConstructed message to tell driver which executor is ready for making offers URL: https://github.com/apache/spark/pull/25964#issuecomment-552293290 Merged build finished. Test FAILed.

[GitHub] [spark] cloud-fan commented on issue #26441: [SPARK-29682][SQL] Resolve conflicting references in aggregate expressions

2019-11-10 Thread GitBox
cloud-fan commented on issue #26441: [SPARK-29682][SQL] Resolve conflicting references in aggregate expressions URL: https://github.com/apache/spark/pull/26441#issuecomment-552298083 It's better to explain why the bug happens in the PR description. I don't understand the current fix,

[GitHub] [spark] SparkQA commented on issue #26097: [SPARK-29421][SQL] Supporting Create Table Like Using Provider

2019-11-10 Thread GitBox
SparkQA commented on issue #26097: [SPARK-29421][SQL] Supporting Create Table Like Using Provider URL: https://github.com/apache/spark/pull/26097#issuecomment-552318069 **[Test build #113561 has

[GitHub] [spark] yaooqinn commented on a change in pull request #26449: [SPARK-29822][SQL] Fix cast error when there are white spaces between signs and values

2019-11-10 Thread GitBox
yaooqinn commented on a change in pull request #26449: [SPARK-29822][SQL] Fix cast error when there are white spaces between signs and values URL: https://github.com/apache/spark/pull/26449#discussion_r344583580 ## File path:

[GitHub] [spark] SparkQA removed a comment on issue #26118: [SPARK-24915][Python] Fix Row handling with Schema.

2019-11-10 Thread GitBox
SparkQA removed a comment on issue #26118: [SPARK-24915][Python] Fix Row handling with Schema. URL: https://github.com/apache/spark/pull/26118#issuecomment-552228093 **[Test build #113550 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/113550/testReport)**

[GitHub] [spark] AmplabJenkins commented on issue #26118: [SPARK-24915][Python] Fix Row handling with Schema.

2019-11-10 Thread GitBox
AmplabJenkins commented on issue #26118: [SPARK-24915][Python] Fix Row handling with Schema. URL: https://github.com/apache/spark/pull/26118#issuecomment-552230489 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26118: [SPARK-24915][Python] Fix Row handling with Schema.

2019-11-10 Thread GitBox
AmplabJenkins commented on issue #26118: [SPARK-24915][Python] Fix Row handling with Schema. URL: https://github.com/apache/spark/pull/26118#issuecomment-552230486 Merged build finished. Test PASSed. This is an automated

  1   2   3   4   5   6   7   >