[GitHub] [spark] yaooqinn commented on a change in pull request #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres

2019-12-03 Thread GitBox
yaooqinn commented on a change in pull request #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres URL: https://github.com/apache/spark/pull/26412#discussion_r353588331 ## File path:

[GitHub] [spark] deshanxiao commented on issue #26744: [SPARK-30106][SQL][TEST] Fix the test of DynamicPartitionPruningSuite

2019-12-03 Thread GitBox
deshanxiao commented on issue #26744: [SPARK-30106][SQL][TEST] Fix the test of DynamicPartitionPruningSuite URL: https://github.com/apache/spark/pull/26744#issuecomment-561518774 Thank you @dongjoon-hyun @cloud-fan . This is

[GitHub] [spark] AmplabJenkins removed a comment on issue #26485: [SPARK-29860][SQL] Fix dataType mismatch issue for InSubquery.

2019-12-03 Thread GitBox
AmplabJenkins removed a comment on issue #26485: [SPARK-29860][SQL] Fix dataType mismatch issue for InSubquery. URL: https://github.com/apache/spark/pull/26485#issuecomment-561518455 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26739: [SPARK-29967][ML][PYTHON] KMeans support instance weighting

2019-12-03 Thread GitBox
AmplabJenkins commented on issue #26739: [SPARK-29967][ML][PYTHON] KMeans support instance weighting URL: https://github.com/apache/spark/pull/26739#issuecomment-561519890 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #26739: [SPARK-29967][ML][PYTHON] KMeans support instance weighting

2019-12-03 Thread GitBox
AmplabJenkins removed a comment on issue #26739: [SPARK-29967][ML][PYTHON] KMeans support instance weighting URL: https://github.com/apache/spark/pull/26739#issuecomment-561519890 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on issue #26747: [SPARK-29188][PYTHON] toPandas (without Arrow) gets wrong dtypes when applied on empty DF

2019-12-03 Thread GitBox
SparkQA commented on issue #26747: [SPARK-29188][PYTHON] toPandas (without Arrow) gets wrong dtypes when applied on empty DF URL: https://github.com/apache/spark/pull/26747#issuecomment-561519854 **[Test build #114838 has

[GitHub] [spark] dlindelof commented on issue #26747: [SPARK-29188][PYTHON] toPandas (without Arrow) gets wrong dtypes when applied on empty DF

2019-12-03 Thread GitBox
dlindelof commented on issue #26747: [SPARK-29188][PYTHON] toPandas (without Arrow) gets wrong dtypes when applied on empty DF URL: https://github.com/apache/spark/pull/26747#issuecomment-561519797 @srowen This illustrates the current behaviour, where an empty Spark Dataframe with a

[GitHub] [spark] AmplabJenkins commented on issue #26739: [SPARK-29967][ML][PYTHON] KMeans support instance weighting

2019-12-03 Thread GitBox
AmplabJenkins commented on issue #26739: [SPARK-29967][ML][PYTHON] KMeans support instance weighting URL: https://github.com/apache/spark/pull/26739#issuecomment-561519884 Merged build finished. Test PASSed. This is an

[GitHub] [spark] cloud-fan commented on issue #26485: [SPARK-29860][SQL] Fix dataType mismatch issue for InSubquery.

2019-12-03 Thread GitBox
cloud-fan commented on issue #26485: [SPARK-29860][SQL] Fix dataType mismatch issue for InSubquery. URL: https://github.com/apache/spark/pull/26485#issuecomment-561520060 LGTM. Can we check the behavior in other databases like pgsql? It's better to know if Spark follows SQL standard or

[GitHub] [spark] AmplabJenkins removed a comment on issue #26739: [SPARK-29967][ML][PYTHON] KMeans support instance weighting

2019-12-03 Thread GitBox
AmplabJenkins removed a comment on issue #26739: [SPARK-29967][ML][PYTHON] KMeans support instance weighting URL: https://github.com/apache/spark/pull/26739#issuecomment-561519884 Merged build finished. Test PASSed. This is

[GitHub] [spark] SparkQA commented on issue #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres

2019-12-03 Thread GitBox
SparkQA commented on issue #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres URL: https://github.com/apache/spark/pull/26412#issuecomment-561519865 **[Test build #114839 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres

2019-12-03 Thread GitBox
AmplabJenkins removed a comment on issue #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres URL: https://github.com/apache/spark/pull/26412#issuecomment-561520318 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres

2019-12-03 Thread GitBox
AmplabJenkins commented on issue #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres URL: https://github.com/apache/spark/pull/26412#issuecomment-561520322 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres

2019-12-03 Thread GitBox
AmplabJenkins commented on issue #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres URL: https://github.com/apache/spark/pull/26412#issuecomment-561520318 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres

2019-12-03 Thread GitBox
AmplabJenkins removed a comment on issue #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres URL: https://github.com/apache/spark/pull/26412#issuecomment-561520322 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on issue #26739: [SPARK-29967][ML][PYTHON] KMeans support instance weighting

2019-12-03 Thread GitBox
SparkQA commented on issue #26739: [SPARK-29967][ML][PYTHON] KMeans support instance weighting URL: https://github.com/apache/spark/pull/26739#issuecomment-561519522 **[Test build #114831 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114831/testReport)**

[GitHub] [spark] SparkQA removed a comment on issue #26739: [SPARK-29967][ML][PYTHON] KMeans support instance weighting

2019-12-03 Thread GitBox
SparkQA removed a comment on issue #26739: [SPARK-29967][ML][PYTHON] KMeans support instance weighting URL: https://github.com/apache/spark/pull/26739#issuecomment-561499537 **[Test build #114831 has

[GitHub] [spark] SparkQA commented on issue #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres

2019-12-03 Thread GitBox
SparkQA commented on issue #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres URL: https://github.com/apache/spark/pull/26412#issuecomment-561513617 **[Test build #114825 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres

2019-12-03 Thread GitBox
AmplabJenkins removed a comment on issue #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres URL: https://github.com/apache/spark/pull/26412#issuecomment-561513979 Merged build finished. Test FAILed.

[GitHub] [spark] AmplabJenkins commented on issue #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres

2019-12-03 Thread GitBox
AmplabJenkins commented on issue #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres URL: https://github.com/apache/spark/pull/26412#issuecomment-561513979 Merged build finished. Test FAILed.

[GitHub] [spark] beliefer commented on a change in pull request #26656: [SPARK-27986][SQL] Support ANSI SQL filter clause for aggregate expression

2019-12-03 Thread GitBox
beliefer commented on a change in pull request #26656: [SPARK-27986][SQL] Support ANSI SQL filter clause for aggregate expression URL: https://github.com/apache/spark/pull/26656#discussion_r353583379 ## File path:

[GitHub] [spark] AmplabJenkins commented on issue #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres

2019-12-03 Thread GitBox
AmplabJenkins commented on issue #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres URL: https://github.com/apache/spark/pull/26412#issuecomment-561513987 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on issue #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres

2019-12-03 Thread GitBox
SparkQA removed a comment on issue #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres URL: https://github.com/apache/spark/pull/26412#issuecomment-561465729 **[Test build #114825 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres

2019-12-03 Thread GitBox
AmplabJenkins removed a comment on issue #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres URL: https://github.com/apache/spark/pull/26412#issuecomment-561513987 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #26750: [SPARK-28948][SQL] Support passing all Table metadata in TableProvider

2019-12-03 Thread GitBox
AmplabJenkins removed a comment on issue #26750: [SPARK-28948][SQL] Support passing all Table metadata in TableProvider URL: https://github.com/apache/spark/pull/26750#issuecomment-561518074 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #26736: [SPARK-30098][SQL] Use default datasource as provider for CREATE TABLE syntax

2019-12-03 Thread GitBox
AmplabJenkins removed a comment on issue #26736: [SPARK-30098][SQL] Use default datasource as provider for CREATE TABLE syntax URL: https://github.com/apache/spark/pull/26736#issuecomment-561518093 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #26747: [SPARK-29188][PYTHON] toPandas (without Arrow) gets wrong dtypes when applied on empty DF

2019-12-03 Thread GitBox
AmplabJenkins removed a comment on issue #26747: [SPARK-29188][PYTHON] toPandas (without Arrow) gets wrong dtypes when applied on empty DF URL: https://github.com/apache/spark/pull/26747#issuecomment-561518042 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #26485: [SPARK-29860][SQL] Fix dataType mismatch issue for InSubquery.

2019-12-03 Thread GitBox
AmplabJenkins removed a comment on issue #26485: [SPARK-29860][SQL] Fix dataType mismatch issue for InSubquery. URL: https://github.com/apache/spark/pull/26485#issuecomment-561518445 Merged build finished. Test FAILed. This

[GitHub] [spark] AmplabJenkins commented on issue #26485: [SPARK-29860][SQL] Fix dataType mismatch issue for InSubquery.

2019-12-03 Thread GitBox
AmplabJenkins commented on issue #26485: [SPARK-29860][SQL] Fix dataType mismatch issue for InSubquery. URL: https://github.com/apache/spark/pull/26485#issuecomment-561518445 Merged build finished. Test FAILed. This is an

[GitHub] [spark] SparkQA removed a comment on issue #26485: [SPARK-29860][SQL] Fix dataType mismatch issue for InSubquery.

2019-12-03 Thread GitBox
SparkQA removed a comment on issue #26485: [SPARK-29860][SQL] Fix dataType mismatch issue for InSubquery. URL: https://github.com/apache/spark/pull/26485#issuecomment-561508568 **[Test build #114835 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #26750: [SPARK-28948][SQL] Support passing all Table metadata in TableProvider

2019-12-03 Thread GitBox
AmplabJenkins removed a comment on issue #26750: [SPARK-28948][SQL] Support passing all Table metadata in TableProvider URL: https://github.com/apache/spark/pull/26750#issuecomment-561518059 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #26736: [SPARK-30098][SQL] Use default datasource as provider for CREATE TABLE syntax

2019-12-03 Thread GitBox
AmplabJenkins removed a comment on issue #26736: [SPARK-30098][SQL] Use default datasource as provider for CREATE TABLE syntax URL: https://github.com/apache/spark/pull/26736#issuecomment-561518084 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #26747: [SPARK-29188][PYTHON] toPandas (without Arrow) gets wrong dtypes when applied on empty DF

2019-12-03 Thread GitBox
AmplabJenkins removed a comment on issue #26747: [SPARK-29188][PYTHON] toPandas (without Arrow) gets wrong dtypes when applied on empty DF URL: https://github.com/apache/spark/pull/26747#issuecomment-561518049 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] SparkQA commented on issue #26485: [SPARK-29860][SQL] Fix dataType mismatch issue for InSubquery.

2019-12-03 Thread GitBox
SparkQA commented on issue #26485: [SPARK-29860][SQL] Fix dataType mismatch issue for InSubquery. URL: https://github.com/apache/spark/pull/26485#issuecomment-561518402 **[Test build #114835 has

[GitHub] [spark] AmplabJenkins commented on issue #26485: [SPARK-29860][SQL] Fix dataType mismatch issue for InSubquery.

2019-12-03 Thread GitBox
AmplabJenkins commented on issue #26485: [SPARK-29860][SQL] Fix dataType mismatch issue for InSubquery. URL: https://github.com/apache/spark/pull/26485#issuecomment-561518455 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] cloud-fan commented on a change in pull request #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax

2019-12-03 Thread GitBox
cloud-fan commented on a change in pull request #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#discussion_r353591631 ## File path:

[GitHub] [spark] AmplabJenkins commented on issue #26754: [SPARK-30115][SQL] Improve limit only query on datasource table

2019-12-03 Thread GitBox
AmplabJenkins commented on issue #26754: [SPARK-30115][SQL] Improve limit only query on datasource table URL: https://github.com/apache/spark/pull/26754#issuecomment-561516686 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26754: [SPARK-30115][SQL] Improve limit only query on datasource table

2019-12-03 Thread GitBox
AmplabJenkins commented on issue #26754: [SPARK-30115][SQL] Improve limit only query on datasource table URL: https://github.com/apache/spark/pull/26754#issuecomment-561516682 Merged build finished. Test PASSed. This is an

[GitHub] [spark] cloud-fan commented on issue #26750: [SPARK-28948][SQL] Support passing all Table metadata in TableProvider

2019-12-03 Thread GitBox
cloud-fan commented on issue #26750: [SPARK-28948][SQL] Support passing all Table metadata in TableProvider URL: https://github.com/apache/spark/pull/26750#issuecomment-561516747 This is preferred over https://github.com/apache/spark/pull/26297, because 1. This follows the existing API

[GitHub] [spark] AmplabJenkins removed a comment on issue #26754: [SPARK-30115][SQL] Improve limit only query on datasource table

2019-12-03 Thread GitBox
AmplabJenkins removed a comment on issue #26754: [SPARK-30115][SQL] Improve limit only query on datasource table URL: https://github.com/apache/spark/pull/26754#issuecomment-561516686 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #26754: [SPARK-30115][SQL] Improve limit only query on datasource table

2019-12-03 Thread GitBox
AmplabJenkins removed a comment on issue #26754: [SPARK-30115][SQL] Improve limit only query on datasource table URL: https://github.com/apache/spark/pull/26754#issuecomment-561516682 Merged build finished. Test PASSed. This

[GitHub] [spark] SparkQA commented on issue #26754: [SPARK-30115][SQL] Improve limit only query on datasource table

2019-12-03 Thread GitBox
SparkQA commented on issue #26754: [SPARK-30115][SQL] Improve limit only query on datasource table URL: https://github.com/apache/spark/pull/26754#issuecomment-561516125 **[Test build #114822 has

[GitHub] [spark] SparkQA removed a comment on issue #26754: [SPARK-30115][SQL] Improve limit only query on datasource table

2019-12-03 Thread GitBox
SparkQA removed a comment on issue #26754: [SPARK-30115][SQL] Improve limit only query on datasource table URL: https://github.com/apache/spark/pull/26754#issuecomment-561459485 **[Test build #114822 has

[GitHub] [spark] SparkQA commented on issue #26736: [SPARK-30098][SQL] Use default datasource as provider for CREATE TABLE syntax

2019-12-03 Thread GitBox
SparkQA commented on issue #26736: [SPARK-30098][SQL] Use default datasource as provider for CREATE TABLE syntax URL: https://github.com/apache/spark/pull/26736#issuecomment-561517640 **[Test build #114836 has

[GitHub] [spark] AmplabJenkins commented on issue #26736: [SPARK-30098][SQL] Use default datasource as provider for CREATE TABLE syntax

2019-12-03 Thread GitBox
AmplabJenkins commented on issue #26736: [SPARK-30098][SQL] Use default datasource as provider for CREATE TABLE syntax URL: https://github.com/apache/spark/pull/26736#issuecomment-561518084 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #26750: [SPARK-28948][SQL] Support passing all Table metadata in TableProvider

2019-12-03 Thread GitBox
AmplabJenkins commented on issue #26750: [SPARK-28948][SQL] Support passing all Table metadata in TableProvider URL: https://github.com/apache/spark/pull/26750#issuecomment-561518059 Merged build finished. Test PASSed. This

[GitHub] [spark] AmplabJenkins commented on issue #26750: [SPARK-28948][SQL] Support passing all Table metadata in TableProvider

2019-12-03 Thread GitBox
AmplabJenkins commented on issue #26750: [SPARK-28948][SQL] Support passing all Table metadata in TableProvider URL: https://github.com/apache/spark/pull/26750#issuecomment-561518074 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] dlindelof commented on issue #26747: [SPARK-29188][PYTHON] toPandas (without Arrow) gets wrong dtypes when applied on empty DF

2019-12-03 Thread GitBox
dlindelof commented on issue #26747: [SPARK-29188][PYTHON] toPandas (without Arrow) gets wrong dtypes when applied on empty DF URL: https://github.com/apache/spark/pull/26747#issuecomment-561518046 @HyukjinKwon I've reverted back to an if-else chain instead of a dict. Was there anything

[GitHub] [spark] AmplabJenkins commented on issue #26736: [SPARK-30098][SQL] Use default datasource as provider for CREATE TABLE syntax

2019-12-03 Thread GitBox
AmplabJenkins commented on issue #26736: [SPARK-30098][SQL] Use default datasource as provider for CREATE TABLE syntax URL: https://github.com/apache/spark/pull/26736#issuecomment-561518093 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on issue #26750: [SPARK-28948][SQL] Support passing all Table metadata in TableProvider

2019-12-03 Thread GitBox
SparkQA commented on issue #26750: [SPARK-28948][SQL] Support passing all Table metadata in TableProvider URL: https://github.com/apache/spark/pull/26750#issuecomment-561517649 **[Test build #114837 has

[GitHub] [spark] AmplabJenkins commented on issue #26747: [SPARK-29188][PYTHON] toPandas (without Arrow) gets wrong dtypes when applied on empty DF

2019-12-03 Thread GitBox
AmplabJenkins commented on issue #26747: [SPARK-29188][PYTHON] toPandas (without Arrow) gets wrong dtypes when applied on empty DF URL: https://github.com/apache/spark/pull/26747#issuecomment-561518049 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins commented on issue #26747: [SPARK-29188][PYTHON] toPandas (without Arrow) gets wrong dtypes when applied on empty DF

2019-12-03 Thread GitBox
AmplabJenkins commented on issue #26747: [SPARK-29188][PYTHON] toPandas (without Arrow) gets wrong dtypes when applied on empty DF URL: https://github.com/apache/spark/pull/26747#issuecomment-561518042 Merged build finished. Test PASSed.

[GitHub] [spark] cloud-fan commented on a change in pull request #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres

2019-12-03 Thread GitBox
cloud-fan commented on a change in pull request #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres URL: https://github.com/apache/spark/pull/26412#discussion_r353581578 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax

2019-12-03 Thread GitBox
cloud-fan commented on a change in pull request #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#discussion_r353590982 ## File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ##

[GitHub] [spark] Fokko commented on a change in pull request #24405: [SPARK-27506][SQL] Allow deserialization of Avro data using compatible schemas

2019-12-03 Thread GitBox
Fokko commented on a change in pull request #24405: [SPARK-27506][SQL] Allow deserialization of Avro data using compatible schemas URL: https://github.com/apache/spark/pull/24405#discussion_r353590959 ## File path: docs/sql-data-sources-avro.md ## @@ -240,6 +240,14 @@

[GitHub] [spark] cloud-fan commented on a change in pull request #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax

2019-12-03 Thread GitBox
cloud-fan commented on a change in pull request #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#discussion_r353591940 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax

2019-12-03 Thread GitBox
cloud-fan commented on a change in pull request #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#discussion_r353591631 ## File path:

[GitHub] [spark] yaooqinn commented on a change in pull request #26080: [SPARK-29425][SQL] The ownership of a database should be respected

2019-12-03 Thread GitBox
yaooqinn commented on a change in pull request #26080: [SPARK-29425][SQL] The ownership of a database should be respected URL: https://github.com/apache/spark/pull/26080#discussion_r353046453 ## File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala

[GitHub] [spark] cloud-fan commented on issue #26195: [SPARK-29537][SQL] throw exception when user defined a wrong base path

2019-12-03 Thread GitBox
cloud-fan commented on issue #26195: [SPARK-29537][SQL] throw exception when user defined a wrong base path URL: https://github.com/apache/spark/pull/26195#issuecomment-561068117 thanks, merging to master! This is an

[GitHub] [spark] cloud-fan closed pull request #26195: [SPARK-29537][SQL] throw exception when user defined a wrong base path

2019-12-03 Thread GitBox
cloud-fan closed pull request #26195: [SPARK-29537][SQL] throw exception when user defined a wrong base path URL: https://github.com/apache/spark/pull/26195 This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins removed a comment on issue #26692: [SPARK-30060][CORE] Rename metrics enable/disable configs

2019-12-03 Thread GitBox
AmplabJenkins removed a comment on issue #26692: [SPARK-30060][CORE] Rename metrics enable/disable configs URL: https://github.com/apache/spark/pull/26692#issuecomment-561067202 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #26692: [SPARK-30060][CORE] Rename metrics enable/disable configs

2019-12-03 Thread GitBox
AmplabJenkins removed a comment on issue #26692: [SPARK-30060][CORE] Rename metrics enable/disable configs URL: https://github.com/apache/spark/pull/26692#issuecomment-561067188 Merged build finished. Test PASSed. This is an

[GitHub] [spark] deshanxiao commented on a change in pull request #26744: [SPARK-30106][SQL][MINOR][TEST] Fix the test of DynamicPartitionPruningSuite

2019-12-03 Thread GitBox
deshanxiao commented on a change in pull request #26744: [SPARK-30106][SQL][MINOR][TEST] Fix the test of DynamicPartitionPruningSuite URL: https://github.com/apache/spark/pull/26744#discussion_r353061795 ## File path:

[GitHub] [spark] hvanhovell commented on issue #26127: [SPARK-29348][SQL] Add observable Metrics for Streaming queries

2019-12-03 Thread GitBox
hvanhovell commented on issue #26127: [SPARK-29348][SQL] Add observable Metrics for Streaming queries URL: https://github.com/apache/spark/pull/26127#issuecomment-561101580 Merging this. Thanks for the reviews! This is an

[GitHub] [spark] hvanhovell closed pull request #26127: [SPARK-29348][SQL] Add observable Metrics for Streaming queries

2019-12-03 Thread GitBox
hvanhovell closed pull request #26127: [SPARK-29348][SQL] Add observable Metrics for Streaming queries URL: https://github.com/apache/spark/pull/26127 This is an automated message from the Apache Git Service. To respond to

[GitHub] [spark] SparkQA commented on issue #26745: [SPARK-30109][ML] PCA use BLAS.gemv for sparse vectors

2019-12-03 Thread GitBox
SparkQA commented on issue #26745: [SPARK-30109][ML] PCA use BLAS.gemv for sparse vectors URL: https://github.com/apache/spark/pull/26745#issuecomment-56765 **[Test build #114767 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114767/testReport)** for

[GitHub] [spark] cloud-fan commented on a change in pull request #26716: [SPARK-30083][SQL] visitArithmeticUnary should wrap PLUS case with UnaryPositive for type checking

2019-12-03 Thread GitBox
cloud-fan commented on a change in pull request #26716: [SPARK-30083][SQL] visitArithmeticUnary should wrap PLUS case with UnaryPositive for type checking URL: https://github.com/apache/spark/pull/26716#discussion_r353111040 ## File path: docs/sql-migration-guide.md ## @@

[GitHub] [spark] cloud-fan commented on a change in pull request #26716: [SPARK-30083][SQL] visitArithmeticUnary should wrap PLUS case with UnaryPositive for type checking

2019-12-03 Thread GitBox
cloud-fan commented on a change in pull request #26716: [SPARK-30083][SQL] visitArithmeticUnary should wrap PLUS case with UnaryPositive for type checking URL: https://github.com/apache/spark/pull/26716#discussion_r353111472 ## File path: docs/sql-migration-guide.md ## @@

[GitHub] [spark] AmplabJenkins removed a comment on issue #26738: [SPARK-30082][SQL] Do not replace Zeros when replacing NaNs

2019-12-03 Thread GitBox
AmplabJenkins removed a comment on issue #26738: [SPARK-30082][SQL] Do not replace Zeros when replacing NaNs URL: https://github.com/apache/spark/pull/26738#issuecomment-561119393 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26744: [SPARK-30106][SQL][MINOR][TEST] Fix the test of DynamicPartitionPruningSuite

2019-12-03 Thread GitBox
AmplabJenkins commented on issue #26744: [SPARK-30106][SQL][MINOR][TEST] Fix the test of DynamicPartitionPruningSuite URL: https://github.com/apache/spark/pull/26744#issuecomment-561119420 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #26738: [SPARK-30082][SQL] Do not replace Zeros when replacing NaNs

2019-12-03 Thread GitBox
AmplabJenkins commented on issue #26738: [SPARK-30082][SQL] Do not replace Zeros when replacing NaNs URL: https://github.com/apache/spark/pull/26738#issuecomment-561119393 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26744: [SPARK-30106][SQL][MINOR][TEST] Fix the test of DynamicPartitionPruningSuite

2019-12-03 Thread GitBox
AmplabJenkins commented on issue #26744: [SPARK-30106][SQL][MINOR][TEST] Fix the test of DynamicPartitionPruningSuite URL: https://github.com/apache/spark/pull/26744#issuecomment-561119431 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #26738: [SPARK-30082][SQL] Do not replace Zeros when replacing NaNs

2019-12-03 Thread GitBox
AmplabJenkins removed a comment on issue #26738: [SPARK-30082][SQL] Do not replace Zeros when replacing NaNs URL: https://github.com/apache/spark/pull/26738#issuecomment-561119388 Merged build finished. Test PASSed. This is

[GitHub] [spark] cloud-fan commented on a change in pull request #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres

2019-12-03 Thread GitBox
cloud-fan commented on a change in pull request #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres URL: https://github.com/apache/spark/pull/26412#discussion_r353115036 ## File path:

[GitHub] [spark] SparkQA commented on issue #26738: [SPARK-30082][SQL] Do not replace Zeros when replacing NaNs

2019-12-03 Thread GitBox
SparkQA commented on issue #26738: [SPARK-30082][SQL] Do not replace Zeros when replacing NaNs URL: https://github.com/apache/spark/pull/26738#issuecomment-561118864 **[Test build #114769 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114769/testReport)**

[GitHub] [spark] SparkQA commented on issue #26744: [SPARK-30106][SQL][MINOR][TEST] Fix the test of DynamicPartitionPruningSuite

2019-12-03 Thread GitBox
SparkQA commented on issue #26744: [SPARK-30106][SQL][MINOR][TEST] Fix the test of DynamicPartitionPruningSuite URL: https://github.com/apache/spark/pull/26744#issuecomment-561118870 **[Test build #114768 has

[GitHub] [spark] AmplabJenkins commented on issue #26738: [SPARK-30082][SQL] Do not replace Zeros when replacing NaNs

2019-12-03 Thread GitBox
AmplabJenkins commented on issue #26738: [SPARK-30082][SQL] Do not replace Zeros when replacing NaNs URL: https://github.com/apache/spark/pull/26738#issuecomment-561119388 Merged build finished. Test PASSed. This is an

[GitHub] [spark] SparkQA commented on issue #26738: [SPARK-30082][SQL] Do not replace Zeros when replacing NaNs

2019-12-03 Thread GitBox
SparkQA commented on issue #26738: [SPARK-30082][SQL] Do not replace Zeros when replacing NaNs URL: https://github.com/apache/spark/pull/26738#issuecomment-561132654 **[Test build #114772 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114772/testReport)**

[GitHub] [spark] SparkQA commented on issue #26712: [SPARK-29883][SQL] Improve error messages when function name is an alias

2019-12-03 Thread GitBox
SparkQA commented on issue #26712: [SPARK-29883][SQL] Improve error messages when function name is an alias URL: https://github.com/apache/spark/pull/26712#issuecomment-561133148 **[Test build #114764 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #26745: [SPARK-30109][ML] PCA use BLAS.gemv for sparse vectors

2019-12-03 Thread GitBox
AmplabJenkins removed a comment on issue #26745: [SPARK-30109][ML] PCA use BLAS.gemv for sparse vectors URL: https://github.com/apache/spark/pull/26745#issuecomment-561135421 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #26745: [SPARK-30109][ML] PCA use BLAS.gemv for sparse vectors

2019-12-03 Thread GitBox
AmplabJenkins removed a comment on issue #26745: [SPARK-30109][ML] PCA use BLAS.gemv for sparse vectors URL: https://github.com/apache/spark/pull/26745#issuecomment-561135414 Merged build finished. Test PASSed. This is an

[GitHub] [spark] SparkQA commented on issue #26712: [SPARK-29883][SQL] Improve error messages when function name is an alias

2019-12-03 Thread GitBox
SparkQA commented on issue #26712: [SPARK-29883][SQL] Improve error messages when function name is an alias URL: https://github.com/apache/spark/pull/26712#issuecomment-561054793 **[Test build #114761 has

[GitHub] [spark] yaooqinn commented on a change in pull request #26080: [SPARK-29425][SQL] The ownership of a database should be respected

2019-12-03 Thread GitBox
yaooqinn commented on a change in pull request #26080: [SPARK-29425][SQL] The ownership of a database should be respected URL: https://github.com/apache/spark/pull/26080#discussion_r353041646 ## File path:

[GitHub] [spark] yaooqinn commented on a change in pull request #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres

2019-12-03 Thread GitBox
yaooqinn commented on a change in pull request #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres URL: https://github.com/apache/spark/pull/26412#discussion_r353050305 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #26744: [SPARK-30106][SQL][MINOR][TEST] Fix the test of DynamicPartitionPruningSuite

2019-12-03 Thread GitBox
cloud-fan commented on a change in pull request #26744: [SPARK-30106][SQL][MINOR][TEST] Fix the test of DynamicPartitionPruningSuite URL: https://github.com/apache/spark/pull/26744#discussion_r353050619 ## File path:

[GitHub] [spark] cloud-fan commented on issue #26692: [SPARK-30060][CORE] Rename metrics enable/disable configs

2019-12-03 Thread GitBox
cloud-fan commented on issue #26692: [SPARK-30060][CORE] Rename metrics enable/disable configs URL: https://github.com/apache/spark/pull/26692#issuecomment-561066073 retest this please This is an automated message from the

[GitHub] [spark] AmplabJenkins removed a comment on issue #26712: [SPARK-29883][SQL] Improve error messages when function name is an alias

2019-12-03 Thread GitBox
AmplabJenkins removed a comment on issue #26712: [SPARK-29883][SQL] Improve error messages when function name is an alias URL: https://github.com/apache/spark/pull/26712#issuecomment-561070254 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #26712: [SPARK-29883][SQL] Improve error messages when function name is an alias

2019-12-03 Thread GitBox
AmplabJenkins removed a comment on issue #26712: [SPARK-29883][SQL] Improve error messages when function name is an alias URL: https://github.com/apache/spark/pull/26712#issuecomment-561070268 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] Gschiavon commented on issue #26733: [WIP][SPARK-30097][SS][SQL] - Add suport for core sinks in writeStream

2019-12-03 Thread GitBox
Gschiavon commented on issue #26733: [WIP][SPARK-30097][SS][SQL] - Add suport for core sinks in writeStream URL: https://github.com/apache/spark/pull/26733#issuecomment-561076246 @adipola I added some more test for csv, json, parquet and text

[GitHub] [spark] SparkQA commented on issue #26716: [SPARK-30083][SQL] visitArithmeticUnary should wrap PLUS case with UnaryPositive for type checking

2019-12-03 Thread GitBox
SparkQA commented on issue #26716: [SPARK-30083][SQL] visitArithmeticUnary should wrap PLUS case with UnaryPositive for type checking URL: https://github.com/apache/spark/pull/26716#issuecomment-561076255 **[Test build #114766 has

[GitHub] [spark] AmplabJenkins commented on issue #26716: [SPARK-30083][SQL] visitArithmeticUnary should wrap PLUS case with UnaryPositive for type checking

2019-12-03 Thread GitBox
AmplabJenkins commented on issue #26716: [SPARK-30083][SQL] visitArithmeticUnary should wrap PLUS case with UnaryPositive for type checking URL: https://github.com/apache/spark/pull/26716#issuecomment-561076763 Test PASSed. Refer to this link for build results (access rights to CI

[GitHub] [spark] AmplabJenkins commented on issue #26716: [SPARK-30083][SQL] visitArithmeticUnary should wrap PLUS case with UnaryPositive for type checking

2019-12-03 Thread GitBox
AmplabJenkins commented on issue #26716: [SPARK-30083][SQL] visitArithmeticUnary should wrap PLUS case with UnaryPositive for type checking URL: https://github.com/apache/spark/pull/26716#issuecomment-561076754 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA commented on issue #26127: [SPARK-29348][SQL] Add observable Metrics for Streaming queries

2019-12-03 Thread GitBox
SparkQA commented on issue #26127: [SPARK-29348][SQL] Add observable Metrics for Streaming queries URL: https://github.com/apache/spark/pull/26127#issuecomment-561100456 **[Test build #114758 has

[GitHub] [spark] SparkQA removed a comment on issue #26127: [SPARK-29348][SQL] Add observable Metrics for Streaming queries

2019-12-03 Thread GitBox
SparkQA removed a comment on issue #26127: [SPARK-29348][SQL] Add observable Metrics for Streaming queries URL: https://github.com/apache/spark/pull/26127#issuecomment-561047163 **[Test build #114758 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #26744: [SPARK-30106][SQL][MINOR][TEST] Fix the test of DynamicPartitionPruningSuite

2019-12-03 Thread GitBox
AmplabJenkins removed a comment on issue #26744: [SPARK-30106][SQL][MINOR][TEST] Fix the test of DynamicPartitionPruningSuite URL: https://github.com/apache/spark/pull/26744#issuecomment-561049994 Can one of the admins verify this patch?

[GitHub] [spark] johnhany97 commented on a change in pull request #26738: [SPARK-30082][SQL] Do not replace Zeros when replacing NaNs

2019-12-03 Thread GitBox
johnhany97 commented on a change in pull request #26738: [SPARK-30082][SQL] Do not replace Zeros when replacing NaNs URL: https://github.com/apache/spark/pull/26738#discussion_r353118553 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameNaFunctionsSuite.scala

[GitHub] [spark] johnhany97 commented on a change in pull request #26738: [SPARK-30082][SQL] Do not replace Zeros when replacing NaNs

2019-12-03 Thread GitBox
johnhany97 commented on a change in pull request #26738: [SPARK-30082][SQL] Do not replace Zeros when replacing NaNs URL: https://github.com/apache/spark/pull/26738#discussion_r353118604 ## File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameNaFunctions.scala

[GitHub] [spark] AmplabJenkins commented on issue #26738: [SPARK-30082][SQL] Do not replace Zeros when replacing NaNs

2019-12-03 Thread GitBox
AmplabJenkins commented on issue #26738: [SPARK-30082][SQL] Do not replace Zeros when replacing NaNs URL: https://github.com/apache/spark/pull/26738#issuecomment-561122443 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #26738: [SPARK-30082][SQL] Do not replace Zeros when replacing NaNs

2019-12-03 Thread GitBox
AmplabJenkins removed a comment on issue #26738: [SPARK-30082][SQL] Do not replace Zeros when replacing NaNs URL: https://github.com/apache/spark/pull/26738#issuecomment-561122443 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26738: [SPARK-30082][SQL] Do not replace Zeros when replacing NaNs

2019-12-03 Thread GitBox
AmplabJenkins commented on issue #26738: [SPARK-30082][SQL] Do not replace Zeros when replacing NaNs URL: https://github.com/apache/spark/pull/26738#issuecomment-561122435 Merged build finished. Test PASSed. This is an

  1   2   3   4   5   6   7   8   9   10   >