liucht-inspur commented on pull request #28680:
URL: https://github.com/apache/spark/pull/28680#issuecomment-636665331
@sarutak
Thanks for your response .
before this change
history server page like this:
maropu opened a new pull request #28691:
URL: https://github.com/apache/spark/pull/28691
### What changes were proposed in this pull request?
This PR intends to fix a bug of `Dataset.map` below when the whole-stage
codegen enabled;
```
scala> val ds =
SparkQA commented on pull request #28674:
URL: https://github.com/apache/spark/pull/28674#issuecomment-636680139
**[Test build #123366 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123366/testReport)**
for PR 28674 at commit
cloud-fan commented on pull request #28679:
URL: https://github.com/apache/spark/pull/28679#issuecomment-636699031
it's not. the median size of the right table is `360`, and `720` is only 2
times of the median size.
This is
yaooqinn opened a new pull request #28692:
URL: https://github.com/apache/spark/pull/28692
# What changes were proposed in this pull request?
This PR switches the default Locale from the `US` to `GB` to change the
behavior of the first day of the week from Sunday-started to
cloud-fan commented on a change in pull request #27627:
URL: https://github.com/apache/spark/pull/27627#discussion_r433126035
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Sum.scala
##
@@ -62,38 +62,74 @@ case class Sum(child:
cloud-fan commented on a change in pull request #27627:
URL: https://github.com/apache/spark/pull/27627#discussion_r433128417
##
File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
##
@@ -200,14 +222,90 @@ class DataFrameSuite extends QueryTest
HyukjinKwon commented on pull request #28689:
URL: https://github.com/apache/spark/pull/28689#issuecomment-636662036
Haven't tested it by myself but seems okay.
This is an automated message from the Apache Git Service.
To
HyukjinKwon commented on a change in pull request #28689:
URL: https://github.com/apache/spark/pull/28689#discussion_r433080460
##
File path:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/Utils.scala
##
@@ -131,4
AmplabJenkins removed a comment on pull request #27402:
URL: https://github.com/apache/spark/pull/27402#issuecomment-636675176
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
liucht-inspur commented on pull request #28680:
URL: https://github.com/apache/spark/pull/28680#issuecomment-636684197
hi @sarutak the console log of browser is this:
cloud-fan commented on a change in pull request #28592:
URL: https://github.com/apache/spark/pull/28592#discussion_r433122526
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/UnivocityParser.scala
##
@@ -85,13 +85,13 @@ class UnivocityParser(
//
yaooqinn commented on pull request #28674:
URL: https://github.com/apache/spark/pull/28674#issuecomment-636718215
> Can we define the 2.4 behavior first? The behavior looks very weird to me.
I found it very difficult to follow the behavior of 2.4. It is also hard to
fully define
caneGuy commented on a change in pull request #28688:
URL: https://github.com/apache/spark/pull/28688#discussion_r433130400
##
File path:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala
##
@@ -171,8 +171,14 @@ private[spark] class Client(
ulysses-you commented on a change in pull request #28647:
URL: https://github.com/apache/spark/pull/28647#discussion_r433130893
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala
##
@@ -839,6 +839,19 @@ case class
AmplabJenkins removed a comment on pull request #28674:
URL: https://github.com/apache/spark/pull/28674#issuecomment-636753180
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
MaxGekk opened a new pull request #28693:
URL: https://github.com/apache/spark/pull/28693
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How
SparkQA removed a comment on pull request #28674:
URL: https://github.com/apache/spark/pull/28674#issuecomment-636691375
**[Test build #123368 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123368/testReport)**
for PR 28674 at commit
AmplabJenkins removed a comment on pull request #28674:
URL: https://github.com/apache/spark/pull/28674#issuecomment-636753170
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
AmplabJenkins commented on pull request #28693:
URL: https://github.com/apache/spark/pull/28693#issuecomment-636754694
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
dilipbiswal commented on a change in pull request #28683:
URL: https://github.com/apache/spark/pull/28683#discussion_r433063615
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##
@@ -2065,6 +2065,16 @@ object SQLConf {
.booleanConf
SparkQA commented on pull request #28689:
URL: https://github.com/apache/spark/pull/28689#issuecomment-636645598
**[Test build #123359 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123359/testReport)**
for PR 28689 at commit
AmplabJenkins commented on pull request #28689:
URL: https://github.com/apache/spark/pull/28689#issuecomment-636646580
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #28686:
URL: https://github.com/apache/spark/pull/28686#issuecomment-636658370
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins removed a comment on pull request #28691:
URL: https://github.com/apache/spark/pull/28691#issuecomment-636673681
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #28691:
URL: https://github.com/apache/spark/pull/28691#issuecomment-636673681
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #28691:
URL: https://github.com/apache/spark/pull/28691#issuecomment-636673060
**[Test build #123365 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123365/testReport)**
for PR 28691 at commit
SparkQA commented on pull request #28690:
URL: https://github.com/apache/spark/pull/28690#issuecomment-636685616
**[Test build #123360 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123360/testReport)**
for PR 28690 at commit
cloud-fan commented on pull request #28674:
URL: https://github.com/apache/spark/pull/28674#issuecomment-636704178
Can we define the 2.4 behavior first? The behavior looks very weird to me.
If it doesn't make sense, we can narrow down the scope or even forbid it.
SparkQA commented on pull request #28688:
URL: https://github.com/apache/spark/pull/28688#issuecomment-636732483
**[Test build #123370 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123370/testReport)**
for PR 28688 at commit
SparkQA removed a comment on pull request #28689:
URL: https://github.com/apache/spark/pull/28689#issuecomment-636598512
**[Test build #123359 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123359/testReport)**
for PR 28689 at commit
AmplabJenkins removed a comment on pull request #28683:
URL: https://github.com/apache/spark/pull/28683#issuecomment-636663090
This is an automated message from the Apache Git Service.
To respond to the message, please log on
yaooqinn commented on a change in pull request #28674:
URL: https://github.com/apache/spark/pull/28674#discussion_r433097046
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeFormatterHelper.scala
##
@@ -31,26 +33,92 @@ import
SparkQA commented on pull request #28674:
URL: https://github.com/apache/spark/pull/28674#issuecomment-636691375
**[Test build #123368 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123368/testReport)**
for PR 28674 at commit
AmplabJenkins commented on pull request #28674:
URL: https://github.com/apache/spark/pull/28674#issuecomment-636691990
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #28692:
URL: https://github.com/apache/spark/pull/28692#issuecomment-636709285
**[Test build #123369 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123369/testReport)**
for PR 28692 at commit
cloud-fan commented on a change in pull request #27627:
URL: https://github.com/apache/spark/pull/27627#discussion_r433125761
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Sum.scala
##
@@ -62,38 +62,74 @@ case class Sum(child:
SparkQA commented on pull request #28674:
URL: https://github.com/apache/spark/pull/28674#issuecomment-636753059
**[Test build #123368 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123368/testReport)**
for PR 28674 at commit
AmplabJenkins commented on pull request #28674:
URL: https://github.com/apache/spark/pull/28674#issuecomment-636753170
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
manuzhang commented on pull request #28679:
URL: https://github.com/apache/spark/pull/28679#issuecomment-636643824
@cloud-fan
Is joining tables of partitions [660, 720] and [720, 0] with target size
100 a skew join ?
SparkQA commented on pull request #28683:
URL: https://github.com/apache/spark/pull/28683#issuecomment-636662587
**[Test build #123364 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123364/testReport)**
for PR 28683 at commit
maropu commented on pull request #28681:
URL: https://github.com/apache/spark/pull/28681#issuecomment-636662645
Sure, I will.
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #28683:
URL: https://github.com/apache/spark/pull/28683#issuecomment-636663090
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #28674:
URL: https://github.com/apache/spark/pull/28674#issuecomment-636691990
This is an automated message from the Apache Git Service.
To respond to the message, please log on
cloud-fan commented on a change in pull request #28647:
URL: https://github.com/apache/spark/pull/28647#discussion_r433114569
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala
##
@@ -839,6 +839,19 @@ case class
cloud-fan commented on pull request #27627:
URL: https://github.com/apache/spark/pull/27627#issuecomment-636729872
LGTM except a few minor comments. This changes the aggregate buffer of the
sum function, which means the streaming state store format is also changed. We
need to mention it
HyukjinKwon commented on pull request #28681:
URL: https://github.com/apache/spark/pull/28681#issuecomment-636657545
+1 for backporting. LGTM too
This is an automated message from the Apache Git Service.
To respond to the
SparkQA removed a comment on pull request #27402:
URL: https://github.com/apache/spark/pull/27402#issuecomment-636610386
**[Test build #123361 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123361/testReport)**
for PR 27402 at commit
SparkQA commented on pull request #27402:
URL: https://github.com/apache/spark/pull/27402#issuecomment-636674601
**[Test build #123361 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123361/testReport)**
for PR 27402 at commit
AmplabJenkins commented on pull request #27402:
URL: https://github.com/apache/spark/pull/27402#issuecomment-636675162
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #27402:
URL: https://github.com/apache/spark/pull/27402#issuecomment-636675162
Build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To respond
AmplabJenkins commented on pull request #28674:
URL: https://github.com/apache/spark/pull/28674#issuecomment-636680743
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #28674:
URL: https://github.com/apache/spark/pull/28674#issuecomment-636680743
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA commented on pull request #28619:
URL: https://github.com/apache/spark/pull/28619#issuecomment-636687341
**[Test build #123367 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123367/testReport)**
for PR 28619 at commit
AmplabJenkins removed a comment on pull request #28690:
URL: https://github.com/apache/spark/pull/28690#issuecomment-636686732
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #28619:
URL: https://github.com/apache/spark/pull/28619#issuecomment-636688077
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #28619:
URL: https://github.com/apache/spark/pull/28619#issuecomment-636688077
This is an automated message from the Apache Git Service.
To respond to the message, please log on
yaooqinn commented on a change in pull request #28674:
URL: https://github.com/apache/spark/pull/28674#discussion_r433100740
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeFormatterHelper.scala
##
@@ -31,26 +33,92 @@ import
yaooqinn commented on a change in pull request #28674:
URL: https://github.com/apache/spark/pull/28674#discussion_r43337
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeFormatterHelper.scala
##
@@ -39,15 +39,22 @@ trait
AmplabJenkins commented on pull request #28692:
URL: https://github.com/apache/spark/pull/28692#issuecomment-636710088
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #28692:
URL: https://github.com/apache/spark/pull/28692#issuecomment-636710088
This is an automated message from the Apache Git Service.
To respond to the message, please log on
cloud-fan commented on pull request #28674:
URL: https://github.com/apache/spark/pull/28674#issuecomment-636720489
this makes sense to me that week-based date fields should not co-exist with
non-week-based date fields. We should also clearly define the default values if
year or month or
SparkQA commented on pull request #28688:
URL: https://github.com/apache/spark/pull/28688#issuecomment-636746471
**[Test build #123370 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123370/testReport)**
for PR 28688 at commit
AmplabJenkins commented on pull request #28688:
URL: https://github.com/apache/spark/pull/28688#issuecomment-636746685
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #28688:
URL: https://github.com/apache/spark/pull/28688#issuecomment-636746685
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA removed a comment on pull request #28688:
URL: https://github.com/apache/spark/pull/28688#issuecomment-636732483
**[Test build #123370 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123370/testReport)**
for PR 28688 at commit
AmplabJenkins removed a comment on pull request #28689:
URL: https://github.com/apache/spark/pull/28689#issuecomment-636646580
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #28686:
URL: https://github.com/apache/spark/pull/28686#issuecomment-636658361
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #28686:
URL: https://github.com/apache/spark/pull/28686#issuecomment-636658164
**[Test build #123362 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123362/testReport)**
for PR 28686 at commit
SparkQA removed a comment on pull request #28686:
URL: https://github.com/apache/spark/pull/28686#issuecomment-636617351
**[Test build #123362 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123362/testReport)**
for PR 28686 at commit
AmplabJenkins removed a comment on pull request #28686:
URL: https://github.com/apache/spark/pull/28686#issuecomment-636658361
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
SparkQA removed a comment on pull request #28690:
URL: https://github.com/apache/spark/pull/28690#issuecomment-636610385
**[Test build #123360 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123360/testReport)**
for PR 28690 at commit
AmplabJenkins commented on pull request #28690:
URL: https://github.com/apache/spark/pull/28690#issuecomment-636686732
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #28692:
URL: https://github.com/apache/spark/pull/28692#issuecomment-637214611
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
SparkQA removed a comment on pull request #28692:
URL: https://github.com/apache/spark/pull/28692#issuecomment-637207235
**[Test build #123410 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123410/testReport)**
for PR 28692 at commit
AmplabJenkins removed a comment on pull request #28692:
URL: https://github.com/apache/spark/pull/28692#issuecomment-637214619
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
cloud-fan commented on pull request #28593:
URL: https://github.com/apache/spark/pull/28593#issuecomment-637217206
You can change `Cast(Cast(UnixTimestamp(left, format), TimestampType),
DateType))` to `Cast(SecondsToTimestamp(UnixTimestamp(left, format)),
DateType))`
HyukjinKwon commented on pull request #28690:
URL: https://github.com/apache/spark/pull/28690#issuecomment-637217419
Looks okay. cc @gengliangwang FYI
This is an automated message from the Apache Git Service.
To respond to
cloud-fan commented on pull request #27627:
URL: https://github.com/apache/spark/pull/27627#issuecomment-637219873
How about we merge it to master only first, and wait for the schema
incompatibility check to be done? This is a long-standing issue and we don't
need to block 3.0. We can
AmplabJenkins removed a comment on pull request #27908:
URL: https://github.com/apache/spark/pull/27908#issuecomment-637219719
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #27908:
URL: https://github.com/apache/spark/pull/27908#issuecomment-637219719
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
yaooqinn commented on pull request #28692:
URL: https://github.com/apache/spark/pull/28692#issuecomment-637219782
```java
+ val defaultLocale: Locale = Locale.ROOT
def defaultPattern(): String = s"${DateFormatter.defaultPattern} HH:mm:ss"
diff --git
sarutak edited a comment on pull request #28680:
URL: https://github.com/apache/spark/pull/28680#issuecomment-636848505
@liucht-inspur I confirmed this issue happens for `branch-2.4`.
This issue is resolved in `master` by overriding the corresponding style
using CSS.
HeartSaVioR commented on pull request #27627:
URL: https://github.com/apache/spark/pull/27627#issuecomment-637226780
Personally I'm OK with skip including this on Spark 3.0.0, preferably with
mentioning as "known issue". It would be ideal if we can maintain the page
about known
AmplabJenkins commented on pull request #28692:
URL: https://github.com/apache/spark/pull/28692#issuecomment-637228101
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #28692:
URL: https://github.com/apache/spark/pull/28692#issuecomment-637227803
**[Test build #123413 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123413/testReport)**
for PR 28692 at commit
cloud-fan commented on pull request #26082:
URL: https://github.com/apache/spark/pull/26082#issuecomment-637232556
Let's fix the conflict and get it merged.
This is an automated message from the Apache Git Service.
To
AmplabJenkins removed a comment on pull request #28686:
URL: https://github.com/apache/spark/pull/28686#issuecomment-637231646
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
planga82 opened a new pull request #26082:
URL: https://github.com/apache/spark/pull/26082
### What changes were proposed in this pull request?
With this pull request I want to improve the Web UI / SQL tab visualization.
The principal problem that I find is when you have a cache in your
AmplabJenkins commented on pull request #26082:
URL: https://github.com/apache/spark/pull/26082#issuecomment-637232519
Can one of the admins verify this patch?
This is an automated message from the Apache Git Service.
To
SparkQA removed a comment on pull request #27627:
URL: https://github.com/apache/spark/pull/27627#issuecomment-637092906
**[Test build #123398 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123398/testReport)**
for PR 27627 at commit
AmplabJenkins commented on pull request #28654:
URL: https://github.com/apache/spark/pull/28654#issuecomment-637245560
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #28654:
URL: https://github.com/apache/spark/pull/28654#issuecomment-637245560
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #28697:
URL: https://github.com/apache/spark/pull/28697#issuecomment-637249269
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #28697:
URL: https://github.com/apache/spark/pull/28697#issuecomment-637249269
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
AmplabJenkins removed a comment on pull request #28697:
URL: https://github.com/apache/spark/pull/28697#issuecomment-637249274
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
HyukjinKwon opened a new pull request #28701:
URL: https://github.com/apache/spark/pull/28701
### What changes were proposed in this pull request?
It increases the timeout for
`StreamingLinearRegressionWithTests.test_train_prediction`
```
Traceback (most recent call last):
HyukjinKwon commented on pull request #28697:
URL: https://github.com/apache/spark/pull/28697#issuecomment-637256241
Merged to master.
This is an automated message from the Apache Git Service.
To respond to the message,
SparkQA commented on pull request #28701:
URL: https://github.com/apache/spark/pull/28701#issuecomment-637256851
**[Test build #123417 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123417/testReport)**
for PR 28701 at commit
cloud-fan commented on pull request #28667:
URL: https://github.com/apache/spark/pull/28667#issuecomment-637218309
previously I delete the tags if something goes wrong. This looks like a
better solution
This is an automated
1 - 100 of 612 matches
Mail list logo
