uncleGen commented on a change in pull request #28391:
URL: https://github.com/apache/spark/pull/28391#discussion_r434380758
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingQueryListenerSuite.scala
##
@@ -433,9 +433,13 @@ class
maropu commented on a change in pull request #28686:
URL: https://github.com/apache/spark/pull/28686#discussion_r434381576
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
##
@@ -654,7 +654,8 @@ case class HiveTableRelation(
cloud-fan opened a new pull request #28717:
URL: https://github.com/apache/spark/pull/28717
### What changes were proposed in this pull request?
This is a followup of https://github.com/apache/spark/pull/26589, which
caches the table relations to speed up the table lookup.
uncleGen commented on a change in pull request #28391:
URL: https://github.com/apache/spark/pull/28391#discussion_r434380758
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingQueryListenerSuite.scala
##
@@ -433,9 +433,13 @@ class
cloud-fan commented on a change in pull request #28575:
URL: https://github.com/apache/spark/pull/28575#discussion_r434399611
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##
@@ -1372,6 +1376,108 @@ object
AmplabJenkins removed a comment on pull request #28704:
URL: https://github.com/apache/spark/pull/28704#issuecomment-638068044
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
AmplabJenkins commented on pull request #28704:
URL: https://github.com/apache/spark/pull/28704#issuecomment-638068044
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
wangyum commented on a change in pull request #28575:
URL: https://github.com/apache/spark/pull/28575#discussion_r434458943
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##
@@ -1372,6 +1376,108 @@ object
AmplabJenkins removed a comment on pull request #28713:
URL: https://github.com/apache/spark/pull/28713#issuecomment-638105470
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
SparkQA commented on pull request #28575:
URL: https://github.com/apache/spark/pull/28575#issuecomment-638114251
**[Test build #123483 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123483/testReport)**
for PR 28575 at commit
juliuszsompolski commented on a change in pull request #28705:
URL: https://github.com/apache/spark/pull/28705#discussion_r434480076
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/HiveResult.scala
##
@@ -37,30 +37,45 @@ object HiveResult {
* Returns
rednaxelafx commented on a change in pull request #28707:
URL: https://github.com/apache/spark/pull/28707#discussion_r434457124
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StreamingAggregationStateManager.scala
##
@@ -94,6 +110,28 @@
cloud-fan edited a comment on pull request #28692:
URL: https://github.com/apache/spark/pull/28692#issuecomment-638147190
> please also create a PR to explain what gets changed in the meaning of u
in the migration guide.
@bart-samwel maybe you were confused by this. The meaning was
cloud-fan commented on pull request #28687:
URL: https://github.com/apache/spark/pull/28687#issuecomment-638160456
fixed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
maropu commented on a change in pull request #28490:
URL: https://github.com/apache/spark/pull/28490#discussion_r434366090
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##
@@ -506,31 +506,55 @@ class Analyzer(
maropu commented on a change in pull request #28490:
URL: https://github.com/apache/spark/pull/28490#discussion_r434366334
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##
@@ -506,31 +506,55 @@ class Analyzer(
gengliangwang closed pull request #28694:
URL: https://github.com/apache/spark/pull/28694
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
AmplabJenkins removed a comment on pull request #28704:
URL: https://github.com/apache/spark/pull/28704#issuecomment-638068063
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins removed a comment on pull request #28713:
URL: https://github.com/apache/spark/pull/28713#issuecomment-638091920
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins removed a comment on pull request #28713:
URL: https://github.com/apache/spark/pull/28713#issuecomment-638091912
Build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To respond
AmplabJenkins removed a comment on pull request #28713:
URL: https://github.com/apache/spark/pull/28713#issuecomment-638098118
This is an automated message from the Apache Git Service.
To respond to the message, please log on
juliuszsompolski commented on a change in pull request #28705:
URL: https://github.com/apache/spark/pull/28705#discussion_r434508113
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/HiveResult.scala
##
@@ -37,30 +37,45 @@ object HiveResult {
* Returns
maropu commented on a change in pull request #28490:
URL: https://github.com/apache/spark/pull/28490#discussion_r434369978
##
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
##
@@ -3495,6 +3495,59 @@ class SQLQuerySuite extends QueryTest with
maropu commented on a change in pull request #28490:
URL: https://github.com/apache/spark/pull/28490#discussion_r434366090
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##
@@ -506,31 +506,55 @@ class Analyzer(
gengliangwang commented on pull request #28694:
URL: https://github.com/apache/spark/pull/28694#issuecomment-638038924
Thanks, merging to master/3.0
This is an automated message from the Apache Git Service.
To respond to the
xuanyuanking commented on a change in pull request #28707:
URL: https://github.com/apache/spark/pull/28707#discussion_r434420491
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##
@@ -1545,6 +1545,15 @@ object SQLConf {
SparkQA commented on pull request #28704:
URL: https://github.com/apache/spark/pull/28704#issuecomment-638067129
**[Test build #123470 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123470/testReport)**
for PR 28704 at commit
SparkQA removed a comment on pull request #28704:
URL: https://github.com/apache/spark/pull/28704#issuecomment-638021723
**[Test build #123470 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123470/testReport)**
for PR 28704 at commit
AmplabJenkins removed a comment on pull request #28718:
URL: https://github.com/apache/spark/pull/28718#issuecomment-638077191
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins removed a comment on pull request #28645:
URL: https://github.com/apache/spark/pull/28645#issuecomment-638077216
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #28707:
URL: https://github.com/apache/spark/pull/28707#issuecomment-638077280
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #27685:
URL: https://github.com/apache/spark/pull/27685#issuecomment-638077321
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #27685:
URL: https://github.com/apache/spark/pull/27685#issuecomment-638077321
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins removed a comment on pull request #28707:
URL: https://github.com/apache/spark/pull/28707#issuecomment-638077280
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #28645:
URL: https://github.com/apache/spark/pull/28645#issuecomment-638077216
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #28718:
URL: https://github.com/apache/spark/pull/28718#issuecomment-638077191
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on pull request #28716:
URL: https://github.com/apache/spark/pull/28716#issuecomment-638002012
**[Test build #123466 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123466/testReport)**
for PR 28716 at commit
SparkQA commented on pull request #28718:
URL: https://github.com/apache/spark/pull/28718#issuecomment-638100797
**[Test build #123482 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123482/testReport)**
for PR 28718 at commit
SparkQA commented on pull request #28716:
URL: https://github.com/apache/spark/pull/28716#issuecomment-638100839
**[Test build #123466 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123466/testReport)**
for PR 28716 at commit
AmplabJenkins removed a comment on pull request #28718:
URL: https://github.com/apache/spark/pull/28718#issuecomment-638101322
This is an automated message from the Apache Git Service.
To respond to the message, please log on
yaooqinn commented on a change in pull request #28718:
URL: https://github.com/apache/spark/pull/28718#discussion_r434468970
##
File path: sql/core/src/test/resources/sql-tests/results/datetime.sql.out
##
@@ -1013,3 +1013,110 @@ select date_format('2020-01-01', '-MM-dd
AmplabJenkins removed a comment on pull request #28575:
URL: https://github.com/apache/spark/pull/28575#issuecomment-638114794
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #28575:
URL: https://github.com/apache/spark/pull/28575#issuecomment-638114794
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
MaxGekk commented on pull request #28709:
URL: https://github.com/apache/spark/pull/28709#issuecomment-638123922
@cloud-fan @HyukjinKwon The changes can lead to inconsistent behaviour when
JVM and session time zones are different:
```scala
$ export TZ="Europe/Moscow"
$
MaxGekk commented on a change in pull request #28705:
URL: https://github.com/apache/spark/pull/28705#discussion_r434513532
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/HiveResult.scala
##
@@ -37,30 +37,45 @@ object HiveResult {
* Returns the
cloud-fan commented on pull request #28687:
URL: https://github.com/apache/spark/pull/28687#issuecomment-638150723
Spark 2.4 also creates date formatter only once, we need to backport it to
fix perf regression.
Since the last commit just updates the comment, we don't need to wait
SparkQA commented on pull request #28687:
URL: https://github.com/apache/spark/pull/28687#issuecomment-638150770
**[Test build #123484 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123484/testReport)**
for PR 28687 at commit
AmplabJenkins commented on pull request #28687:
URL: https://github.com/apache/spark/pull/28687#issuecomment-638150807
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on pull request #28687:
URL: https://github.com/apache/spark/pull/28687#issuecomment-638146646
**[Test build #123484 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123484/testReport)**
for PR 28687 at commit
AmplabJenkins removed a comment on pull request #28687:
URL: https://github.com/apache/spark/pull/28687#issuecomment-638150807
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
dongjoon-hyun commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-638015764
Sounds reasonable. Thanks!
This is an automated message from the Apache Git Service.
To respond to the
sarutak edited a comment on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-638014904
@dongjoon-hyun @HyukjinKwon The reason of the failure seems that `bytebuddy`
which upgraded-selenium depends on is much older than `mockito` depends on.
I've excluded
maropu commented on a change in pull request #28490:
URL: https://github.com/apache/spark/pull/28490#discussion_r434371772
##
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
##
@@ -3495,6 +3495,59 @@ class SQLQuerySuite extends QueryTest with
AmplabJenkins removed a comment on pull request #28704:
URL: https://github.com/apache/spark/pull/28704#issuecomment-638022253
This is an automated message from the Apache Git Service.
To respond to the message, please log on
maropu commented on a change in pull request #28490:
URL: https://github.com/apache/spark/pull/28490#discussion_r434372717
##
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
##
@@ -3495,6 +3495,59 @@ class SQLQuerySuite extends QueryTest with
yaooqinn closed pull request #28673:
URL: https://github.com/apache/spark/pull/28673
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
xuanyuanking commented on a change in pull request #28707:
URL: https://github.com/apache/spark/pull/28707#discussion_r434419336
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StreamingAggregationStateManager.scala
##
@@ -77,13 +82,24 @@
AmplabJenkins removed a comment on pull request #28707:
URL: https://github.com/apache/spark/pull/28707#issuecomment-638065366
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #28707:
URL: https://github.com/apache/spark/pull/28707#issuecomment-638065366
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
MaxGekk commented on a change in pull request #28705:
URL: https://github.com/apache/spark/pull/28705#discussion_r434443354
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/HiveResult.scala
##
@@ -37,30 +37,45 @@ object HiveResult {
* Returns the
SparkQA commented on pull request #28718:
URL: https://github.com/apache/spark/pull/28718#issuecomment-638087232
**[Test build #123480 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123480/testReport)**
for PR 28718 at commit
AmplabJenkins commented on pull request #28718:
URL: https://github.com/apache/spark/pull/28718#issuecomment-638087801
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
yaooqinn commented on pull request #28713:
URL: https://github.com/apache/spark/pull/28713#issuecomment-638097083
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
AmplabJenkins commented on pull request #28707:
URL: https://github.com/apache/spark/pull/28707#issuecomment-638119689
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on pull request #28707:
URL: https://github.com/apache/spark/pull/28707#issuecomment-638076637
**[Test build #123477 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123477/testReport)**
for PR 28707 at commit
SparkQA commented on pull request #28707:
URL: https://github.com/apache/spark/pull/28707#issuecomment-638119541
**[Test build #123477 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123477/testReport)**
for PR 28707 at commit
cloud-fan commented on pull request #28692:
URL: https://github.com/apache/spark/pull/28692#issuecomment-638139165
As I mentioned in:
https://github.com/apache/spark/pull/28692#issuecomment-637226576
There are only 2 localized pattern letter: `e: localized day-of-week` and
`O:
cloud-fan closed pull request #28687:
URL: https://github.com/apache/spark/pull/28687
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
AmplabJenkins removed a comment on pull request #28687:
URL: https://github.com/apache/spark/pull/28687#issuecomment-638150813
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
viirya commented on pull request #28704:
URL: https://github.com/apache/spark/pull/28704#issuecomment-638020051
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
cloud-fan commented on pull request #28717:
URL: https://github.com/apache/spark/pull/28717#issuecomment-638030909
@wangyum
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA commented on pull request #28716:
URL: https://github.com/apache/spark/pull/28716#issuecomment-638030508
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/28086/
dongjoon-hyun commented on pull request #28716:
URL: https://github.com/apache/spark/pull/28716#issuecomment-638029939
cc @holdenk since she informed me this regression.
This is an automated message from the Apache Git
AmplabJenkins commented on pull request #28391:
URL: https://github.com/apache/spark/pull/28391#issuecomment-638029901
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #28391:
URL: https://github.com/apache/spark/pull/28391#issuecomment-638029901
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins removed a comment on pull request #28618:
URL: https://github.com/apache/spark/pull/28618#issuecomment-638045051
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #28618:
URL: https://github.com/apache/spark/pull/28618#issuecomment-638045051
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
xuanyuanking commented on a change in pull request #28707:
URL: https://github.com/apache/spark/pull/28707#discussion_r434418012
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StreamingAggregationStateManager.scala
##
@@ -94,6 +110,28 @@
SparkQA commented on pull request #28707:
URL: https://github.com/apache/spark/pull/28707#issuecomment-638064669
**[Test build #123475 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123475/testReport)**
for PR 28707 at commit
SparkQA commented on pull request #28687:
URL: https://github.com/apache/spark/pull/28687#issuecomment-638146646
**[Test build #123484 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123484/testReport)**
for PR 28687 at commit
AmplabJenkins removed a comment on pull request #28687:
URL: https://github.com/apache/spark/pull/28687#issuecomment-638147120
This is an automated message from the Apache Git Service.
To respond to the message, please log on
cloud-fan edited a comment on pull request #28692:
URL: https://github.com/apache/spark/pull/28692#issuecomment-638147190
> please also create a PR to explain what gets changed in the meaning of u
in the migration guide.
@bart-samwel maybe you were confused by this. The meaning was
AmplabJenkins commented on pull request #28687:
URL: https://github.com/apache/spark/pull/28687#issuecomment-638147120
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
cloud-fan commented on pull request #28687:
URL: https://github.com/apache/spark/pull/28687#issuecomment-638152357
it has a logical conflict with https://github.com/apache/spark/pull/28706,
I'm fixing it
This is an
maropu commented on a change in pull request #28490:
URL: https://github.com/apache/spark/pull/28490#discussion_r434371366
##
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
##
@@ -3495,6 +3495,59 @@ class SQLQuerySuite extends QueryTest with
AmplabJenkins commented on pull request #28704:
URL: https://github.com/apache/spark/pull/28704#issuecomment-638022253
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #28704:
URL: https://github.com/apache/spark/pull/28704#issuecomment-638021723
**[Test build #123470 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123470/testReport)**
for PR 28704 at commit
AmplabJenkins commented on pull request #28497:
URL: https://github.com/apache/spark/pull/28497#issuecomment-638051935
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #28497:
URL: https://github.com/apache/spark/pull/28497#issuecomment-638051935
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA commented on pull request #28497:
URL: https://github.com/apache/spark/pull/28497#issuecomment-638051393
**[Test build #123474 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123474/testReport)**
for PR 28497 at commit
ulysses-you commented on a change in pull request #28647:
URL: https://github.com/apache/spark/pull/28647#discussion_r434403470
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala
##
@@ -839,6 +839,19 @@ case class
dongjoon-hyun commented on pull request #28716:
URL: https://github.com/apache/spark/pull/28716#issuecomment-638052650
Hi, @HyukjinKwon . Could you review this PR?
This is an automated message from the Apache Git Service.
To
cloud-fan commented on a change in pull request #28575:
URL: https://github.com/apache/spark/pull/28575#discussion_r434425950
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##
@@ -1372,6 +1376,108 @@ object
gengliangwang commented on a change in pull request #28575:
URL: https://github.com/apache/spark/pull/28575#discussion_r434424853
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##
@@ -1372,6 +1376,108 @@ object
xuanyuanking commented on pull request #28707:
URL: https://github.com/apache/spark/pull/28707#issuecomment-638072075
> @skambha it doesn't fix the issue, it gives a better error message when we
hit the issue.
Yep, I WIP for the integrated test of the state store format
dongjoon-hyun commented on pull request #28716:
URL: https://github.com/apache/spark/pull/28716#issuecomment-638072809
Thank you, @HyukjinKwon . Merged to master/3.0.
This is an automated message from the Apache Git Service.
dongjoon-hyun closed pull request #28716:
URL: https://github.com/apache/spark/pull/28716
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
AmplabJenkins commented on pull request #28718:
URL: https://github.com/apache/spark/pull/28718#issuecomment-638101322
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #28716:
URL: https://github.com/apache/spark/pull/28716#issuecomment-638102073
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #28716:
URL: https://github.com/apache/spark/pull/28716#issuecomment-638102073
This is an automated message from the Apache Git Service.
To respond to the message, please log on
1 - 100 of 681 matches
Mail list logo
