[GitHub] [spark] HeartSaVioR commented on pull request #28830: [SPARK-31990][SS] Use toSet.toSeq in Dataset.dropDuplicates

2020-06-15 Thread GitBox
HeartSaVioR commented on pull request #28830: URL: https://github.com/apache/spark/pull/28830#issuecomment-643942982 Btw now we know it is broken in Spark 3.0.0, and we will fix it again in Spark 3.0.1. Do we have some best practice to follow on guiding such change to end users?

[GitHub] [spark] SparkQA commented on pull request #28807: [SPARK-26905][SQL] Follow the SQL:2016 reserved keywords

2020-06-15 Thread GitBox
SparkQA commented on pull request #28807: URL: https://github.com/apache/spark/pull/28807#issuecomment-643944312 **[Test build #124031 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124031/testReport)** for PR 28807 at commit [`eeceb30`](https://github.co

[GitHub] [spark] SparkQA commented on pull request #28829: [SPARK-31992][SQL] Benchmark the EXCEPTION rebase mode

2020-06-15 Thread GitBox
SparkQA commented on pull request #28829: URL: https://github.com/apache/spark/pull/28829#issuecomment-643944316 **[Test build #124033 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124033/testReport)** for PR 28829 at commit [`16e90be`](https://github.co

[GitHub] [spark] SparkQA commented on pull request #28619: [SPARK-21040][CORE] Speculate tasks which are running on decommission executors

2020-06-15 Thread GitBox
SparkQA commented on pull request #28619: URL: https://github.com/apache/spark/pull/28619#issuecomment-643944305 **[Test build #124034 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124034/testReport)** for PR 28619 at commit [`4affa58`](https://github.co

[GitHub] [spark] SparkQA commented on pull request #28710: [SPARK-31893][ML] Add a generic ClassificationSummary trait

2020-06-15 Thread GitBox
SparkQA commented on pull request #28710: URL: https://github.com/apache/spark/pull/28710#issuecomment-643944306 **[Test build #124030 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124030/testReport)** for PR 28710 at commit [`2e6f35c`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #28830: [SPARK-31990][SS] Use toSet.toSeq in Dataset.dropDuplicates

2020-06-15 Thread GitBox
SparkQA removed a comment on pull request #28830: URL: https://github.com/apache/spark/pull/28830#issuecomment-643855612 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [spark] SparkQA commented on pull request #28826: [SPARK-31988][SQL] Schema pruning may discard attribute metadata

2020-06-15 Thread GitBox
SparkQA commented on pull request #28826: URL: https://github.com/apache/spark/pull/28826#issuecomment-643944317 **[Test build #124019 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124019/testReport)** for PR 28826 at commit [`0c46105`](https://github.co

[GitHub] [spark] AmplabJenkins commented on pull request #28829: [SPARK-31992][SQL] Benchmark the EXCEPTION rebase mode

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28829: URL: https://github.com/apache/spark/pull/28829#issuecomment-64391 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins commented on pull request #28807: [SPARK-26905][SQL] Follow the SQL:2016 reserved keywords

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28807: URL: https://github.com/apache/spark/pull/28807#issuecomment-643944591 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #28784: [SPARK-31957][SQL][test-maven] Cleanup hive scratch dir for the developer api startWithContext

2020-06-15 Thread GitBox
SparkQA commented on pull request #28784: URL: https://github.com/apache/spark/pull/28784#issuecomment-643944313 **[Test build #124035 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124035/testReport)** for PR 28784 at commit [`d055d60`](https://github.co

[GitHub] [spark] SparkQA commented on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

2020-06-15 Thread GitBox
SparkQA commented on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-643944314 **[Test build #124029 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124029/testReport)** for PR 28593 at commit [`8fe1960`](https://github.co

[GitHub] [spark] SparkQA commented on pull request #27690: [SPARK-21514][SQL] Added a new option to use non-blobstore storage when writing into blobstore storage

2020-06-15 Thread GitBox
SparkQA commented on pull request #27690: URL: https://github.com/apache/spark/pull/27690#issuecomment-643944304 **[Test build #124028 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124028/testReport)** for PR 27690 at commit [`0fbeaf3`](https://github.co

[GitHub] [spark] AmplabJenkins commented on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-643944573 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #27019: [SPARK-30027][SQL] Support codegen for aggregate filters in HashAggregateExec

2020-06-15 Thread GitBox
SparkQA commented on pull request #27019: URL: https://github.com/apache/spark/pull/27019#issuecomment-643944307 **[Test build #124022 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124022/testReport)** for PR 27019 at commit [`464fbaa`](https://github.co

[GitHub] [spark] SparkQA commented on pull request #28642: [SPARK-31809][SQL] Infer IsNotNull for non null intolerant child of null intolerant in join condition

2020-06-15 Thread GitBox
SparkQA commented on pull request #28642: URL: https://github.com/apache/spark/pull/28642#issuecomment-643944315 **[Test build #124032 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124032/testReport)** for PR 28642 at commit [`65cd324`](https://github.co

[GitHub] [spark] AmplabJenkins commented on pull request #28784: [SPARK-31957][SQL][test-maven] Cleanup hive scratch dir for the developer api startWithContext

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28784: URL: https://github.com/apache/spark/pull/28784#issuecomment-643944336 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #28710: [SPARK-31893][ML] Add a generic ClassificationSummary trait

2020-06-15 Thread GitBox
SparkQA removed a comment on pull request #28710: URL: https://github.com/apache/spark/pull/28710#issuecomment-643897635 **[Test build #124030 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124030/testReport)** for PR 28710 at commit [`2e6f35c`](https://gi

[GitHub] [spark] AmplabJenkins commented on pull request #28642: [SPARK-31809][SQL] Infer IsNotNull for non null intolerant child of null intolerant in join condition

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28642: URL: https://github.com/apache/spark/pull/28642#issuecomment-64399 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #28830: [SPARK-31990][SS] Use toSet.toSeq in Dataset.dropDuplicates

2020-06-15 Thread GitBox
SparkQA commented on pull request #28830: URL: https://github.com/apache/spark/pull/28830#issuecomment-643944319 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] AmplabJenkins commented on pull request #28619: [SPARK-21040][CORE] Speculate tasks which are running on decommission executors

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28619: URL: https://github.com/apache/spark/pull/28619#issuecomment-643944732 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins commented on pull request #28830: [SPARK-31990][SS] Use toSet.toSeq in Dataset.dropDuplicates

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28830: URL: https://github.com/apache/spark/pull/28830#issuecomment-643944675 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-643944573 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] SparkQA removed a comment on pull request #28807: [SPARK-26905][SQL] Follow the SQL:2016 reserved keywords

2020-06-15 Thread GitBox
SparkQA removed a comment on pull request #28807: URL: https://github.com/apache/spark/pull/28807#issuecomment-643899210 **[Test build #124031 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124031/testReport)** for PR 28807 at commit [`eeceb30`](https://gi

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28642: [SPARK-31809][SQL] Infer IsNotNull for non null intolerant child of null intolerant in join condition

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28642: URL: https://github.com/apache/spark/pull/28642#issuecomment-64399 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28619: [SPARK-21040][CORE] Speculate tasks which are running on decommission executors

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28619: URL: https://github.com/apache/spark/pull/28619#issuecomment-643944732 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] SparkQA removed a comment on pull request #28619: [SPARK-21040][CORE] Speculate tasks which are running on decommission executors

2020-06-15 Thread GitBox
SparkQA removed a comment on pull request #28619: URL: https://github.com/apache/spark/pull/28619#issuecomment-643916615 **[Test build #124034 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124034/testReport)** for PR 28619 at commit [`4affa58`](https://gi

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28829: [SPARK-31992][SQL] Benchmark the EXCEPTION rebase mode

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28829: URL: https://github.com/apache/spark/pull/28829#issuecomment-64391 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] SparkQA removed a comment on pull request #28826: [SPARK-31988][SQL] Schema pruning may discard attribute metadata

2020-06-15 Thread GitBox
SparkQA removed a comment on pull request #28826: URL: https://github.com/apache/spark/pull/28826#issuecomment-643854058 **[Test build #124019 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124019/testReport)** for PR 28826 at commit [`0c46105`](https://gi

[GitHub] [spark] SparkQA removed a comment on pull request #28642: [SPARK-31809][SQL] Infer IsNotNull for non null intolerant child of null intolerant in join condition

2020-06-15 Thread GitBox
SparkQA removed a comment on pull request #28642: URL: https://github.com/apache/spark/pull/28642#issuecomment-643914470 **[Test build #124032 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124032/testReport)** for PR 28642 at commit [`65cd324`](https://gi

[GitHub] [spark] SparkQA removed a comment on pull request #28829: [SPARK-31992][SQL] Benchmark the EXCEPTION rebase mode

2020-06-15 Thread GitBox
SparkQA removed a comment on pull request #28829: URL: https://github.com/apache/spark/pull/28829#issuecomment-643916564 **[Test build #124033 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124033/testReport)** for PR 28829 at commit [`16e90be`](https://gi

[GitHub] [spark] SparkQA removed a comment on pull request #27019: [SPARK-30027][SQL] Support codegen for aggregate filters in HashAggregateExec

2020-06-15 Thread GitBox
SparkQA removed a comment on pull request #27019: URL: https://github.com/apache/spark/pull/27019#issuecomment-643860056 **[Test build #124022 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124022/testReport)** for PR 27019 at commit [`464fbaa`](https://gi

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28807: [SPARK-26905][SQL] Follow the SQL:2016 reserved keywords

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28807: URL: https://github.com/apache/spark/pull/28807#issuecomment-643944591 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28830: [SPARK-31990][SS] Use toSet.toSeq in Dataset.dropDuplicates

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28830: URL: https://github.com/apache/spark/pull/28830#issuecomment-643944675 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] SparkQA removed a comment on pull request #28784: [SPARK-31957][SQL][test-maven] Cleanup hive scratch dir for the developer api startWithContext

2020-06-15 Thread GitBox
SparkQA removed a comment on pull request #28784: URL: https://github.com/apache/spark/pull/28784#issuecomment-643926432 **[Test build #124035 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124035/testReport)** for PR 28784 at commit [`d055d60`](https://gi

[GitHub] [spark] SparkQA removed a comment on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

2020-06-15 Thread GitBox
SparkQA removed a comment on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-643892530 **[Test build #124029 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124029/testReport)** for PR 28593 at commit [`8fe1960`](https://gi

[GitHub] [spark] SparkQA removed a comment on pull request #27690: [SPARK-21514][SQL] Added a new option to use non-blobstore storage when writing into blobstore storage

2020-06-15 Thread GitBox
SparkQA removed a comment on pull request #27690: URL: https://github.com/apache/spark/pull/27690#issuecomment-643887119 **[Test build #124028 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124028/testReport)** for PR 27690 at commit [`0fbeaf3`](https://gi

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28784: [SPARK-31957][SQL][test-maven] Cleanup hive scratch dir for the developer api startWithContext

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28784: URL: https://github.com/apache/spark/pull/28784#issuecomment-643944336 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins commented on pull request #27690: [SPARK-21514][SQL] Added a new option to use non-blobstore storage when writing into blobstore storage

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #27690: URL: https://github.com/apache/spark/pull/27690#issuecomment-643945198 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28642: [SPARK-31809][SQL] Infer IsNotNull for non null intolerant child of null intolerant in join condition

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28642: URL: https://github.com/apache/spark/pull/28642#issuecomment-643944467 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28829: [SPARK-31992][SQL] Benchmark the EXCEPTION rebase mode

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28829: URL: https://github.com/apache/spark/pull/28829#issuecomment-64398 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124

[GitHub] [spark] dilipbiswal commented on pull request #28032: [SPARK-31264][SQL] Repartition by dynamic partition columns before insert partition table

2020-06-15 Thread GitBox
dilipbiswal commented on pull request #28032: URL: https://github.com/apache/spark/pull/28032#issuecomment-643945536 @wangyum > Yes, this strategy may introduce the data skew issue, but the case of skewed data will only affect itself. Creating a large number of files will affect the Na

[GitHub] [spark] AmplabJenkins commented on pull request #28826: [SPARK-31988][SQL] Schema pruning may discard attribute metadata

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28826: URL: https://github.com/apache/spark/pull/28826#issuecomment-643945401 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28619: [SPARK-21040][CORE] Speculate tasks which are running on decommission executors

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28619: URL: https://github.com/apache/spark/pull/28619#issuecomment-643944742 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-643944584 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124

[GitHub] [spark] AmplabJenkins commented on pull request #28830: [SPARK-31990][SS] Use toSet.toSeq in Dataset.dropDuplicates

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28830: URL: https://github.com/apache/spark/pull/28830#issuecomment-643945423 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28807: [SPARK-26905][SQL] Follow the SQL:2016 reserved keywords

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28807: URL: https://github.com/apache/spark/pull/28807#issuecomment-643944613 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28784: [SPARK-31957][SQL][test-maven] Cleanup hive scratch dir for the developer api startWithContext

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28784: URL: https://github.com/apache/spark/pull/28784#issuecomment-643944348 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124

[GitHub] [spark] AmplabJenkins commented on pull request #28710: [SPARK-31893][ML] Add a generic ClassificationSummary trait

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28710: URL: https://github.com/apache/spark/pull/28710#issuecomment-643945441 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27690: [SPARK-21514][SQL] Added a new option to use non-blobstore storage when writing into blobstore storage

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #27690: URL: https://github.com/apache/spark/pull/27690#issuecomment-643945198 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28830: [SPARK-31990][SS] Use toSet.toSeq in Dataset.dropDuplicates

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28830: URL: https://github.com/apache/spark/pull/28830#issuecomment-643944683 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124

[GitHub] [spark] AmplabJenkins commented on pull request #27019: [SPARK-30027][SQL] Support codegen for aggregate filters in HashAggregateExec

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #27019: URL: https://github.com/apache/spark/pull/27019#issuecomment-643945565 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] huaxingao commented on pull request #28710: [SPARK-31893][ML] Add a generic ClassificationSummary trait

2020-06-15 Thread GitBox
huaxingao commented on pull request #28710: URL: https://github.com/apache/spark/pull/28710#issuecomment-643945627 retest this please This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28830: [SPARK-31990][SS] Use toSet.toSeq in Dataset.dropDuplicates

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28830: URL: https://github.com/apache/spark/pull/28830#issuecomment-643945423 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27019: [SPARK-30027][SQL] Support codegen for aggregate filters in HashAggregateExec

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #27019: URL: https://github.com/apache/spark/pull/27019#issuecomment-643945565 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] zhengruifeng commented on a change in pull request #28710: [SPARK-31893][ML] Add a generic ClassificationSummary trait

2020-06-15 Thread GitBox
zhengruifeng commented on a change in pull request #28710: URL: https://github.com/apache/spark/pull/28710#discussion_r439969774 ## File path: project/MimaExcludes.scala ## @@ -39,18 +39,44 @@ object MimaExcludes { // [SPARK-31077] Remove ChiSqSelector dependency on mllib

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28826: [SPARK-31988][SQL] Schema pruning may discard attribute metadata

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28826: URL: https://github.com/apache/spark/pull/28826#issuecomment-643945401 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28710: [SPARK-31893][ML] Add a generic ClassificationSummary trait

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28710: URL: https://github.com/apache/spark/pull/28710#issuecomment-643945441 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27690: [SPARK-21514][SQL] Added a new option to use non-blobstore storage when writing into blobstore storage

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #27690: URL: https://github.com/apache/spark/pull/27690#issuecomment-643945205 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28826: [SPARK-31988][SQL] Schema pruning may discard attribute metadata

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28826: URL: https://github.com/apache/spark/pull/28826#issuecomment-643945407 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124

[GitHub] [spark] yaooqinn commented on pull request #28784: [SPARK-31957][SQL][test-maven] Cleanup hive scratch dir for the developer api startWithContext

2020-06-15 Thread GitBox
yaooqinn commented on pull request #28784: URL: https://github.com/apache/spark/pull/28784#issuecomment-643946210 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27019: [SPARK-30027][SQL] Support codegen for aggregate filters in HashAggregateExec

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #27019: URL: https://github.com/apache/spark/pull/27019#issuecomment-643945575 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124

[GitHub] [spark] gengliangwang commented on pull request #28830: [SPARK-31990][SS] Use toSet.toSeq in Dataset.dropDuplicates

2020-06-15 Thread GitBox
gengliangwang commented on pull request #28830: URL: https://github.com/apache/spark/pull/28830#issuecomment-643946468 retest this please This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28830: [SPARK-31990][SS] Use toSet.toSeq in Dataset.dropDuplicates

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28830: URL: https://github.com/apache/spark/pull/28830#issuecomment-643945431 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124

[GitHub] [spark] HyukjinKwon commented on pull request #28642: [SPARK-31809][SQL] Infer IsNotNull for non null intolerant child of null intolerant in join condition

2020-06-15 Thread GitBox
HyukjinKwon commented on pull request #28642: URL: https://github.com/apache/spark/pull/28642#issuecomment-643946838 retest this please This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [spark] xuanyuanking edited a comment on pull request #28707: [SPARK-31894][SS] Introduce UnsafeRow format validation for streaming state store

2020-06-15 Thread GitBox
xuanyuanking edited a comment on pull request #28707: URL: https://github.com/apache/spark/pull/28707#issuecomment-643916110 cc @maropu @gatorsmile @HeartSaVioR @dongjoon-hyun A new regression bug SPARK-31990 was found when investigating the test failure https://github.com/apache/sp

[GitHub] [spark] SparkQA commented on pull request #28830: [SPARK-31990][SS] Use toSet.toSeq in Dataset.dropDuplicates

2020-06-15 Thread GitBox
SparkQA commented on pull request #28830: URL: https://github.com/apache/spark/pull/28830#issuecomment-643948852 **[Test build #124036 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124036/testReport)** for PR 28830 at commit [`7546ba4`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #28784: [SPARK-31957][SQL][test-maven] Cleanup hive scratch dir for the developer api startWithContext

2020-06-15 Thread GitBox
SparkQA commented on pull request #28784: URL: https://github.com/apache/spark/pull/28784#issuecomment-643948887 **[Test build #124037 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124037/testReport)** for PR 28784 at commit [`d055d60`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #28642: [SPARK-31809][SQL] Infer IsNotNull for non null intolerant child of null intolerant in join condition

2020-06-15 Thread GitBox
SparkQA commented on pull request #28642: URL: https://github.com/apache/spark/pull/28642#issuecomment-643948913 **[Test build #124038 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124038/testReport)** for PR 28642 at commit [`65cd324`](https://github.com

[GitHub] [spark] AmplabJenkins commented on pull request #28784: [SPARK-31957][SQL][test-maven] Cleanup hive scratch dir for the developer api startWithContext

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28784: URL: https://github.com/apache/spark/pull/28784#issuecomment-643949327 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28784: [SPARK-31957][SQL][test-maven] Cleanup hive scratch dir for the developer api startWithContext

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28784: URL: https://github.com/apache/spark/pull/28784#issuecomment-643949327 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28642: [SPARK-31809][SQL] Infer IsNotNull for non null intolerant child of null intolerant in join condition

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28642: URL: https://github.com/apache/spark/pull/28642#issuecomment-643949432 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28830: [SPARK-31990][SS] Use toSet.toSeq in Dataset.dropDuplicates

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28830: URL: https://github.com/apache/spark/pull/28830#issuecomment-643949392 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins commented on pull request #28642: [SPARK-31809][SQL] Infer IsNotNull for non null intolerant child of null intolerant in join condition

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28642: URL: https://github.com/apache/spark/pull/28642#issuecomment-643949432 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28830: [SPARK-31990][SS] Use toSet.toSeq in Dataset.dropDuplicates

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28830: URL: https://github.com/apache/spark/pull/28830#issuecomment-643949392 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] EnricoMi commented on pull request #27375: [SPARK-30664][Web UI] Add optional metrics to all-stages page

2020-06-15 Thread GitBox
EnricoMi commented on pull request #27375: URL: https://github.com/apache/spark/pull/27375#issuecomment-643950332 Can someone please reopen this PR? This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] cloud-fan commented on pull request #28830: [SPARK-31990][SS] Use toSet.toSeq in Dataset.dropDuplicates

2020-06-15 Thread GitBox
cloud-fan commented on pull request #28830: URL: https://github.com/apache/spark/pull/28830#issuecomment-643950413 > Btw now we know it is broken in Spark 3.0.0, and we will fix it again in Spark 3.0.1. I think we should list it as a known issue of 3.0.0, and release 3.0.1 soon. --

[GitHub] [spark] cloud-fan commented on pull request #28829: [SPARK-31992][SQL] Benchmark the EXCEPTION rebase mode

2020-06-15 Thread GitBox
cloud-fan commented on pull request #28829: URL: https://github.com/apache/spark/pull/28829#issuecomment-643951131 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] SparkQA commented on pull request #28829: [SPARK-31992][SQL] Benchmark the EXCEPTION rebase mode

2020-06-15 Thread GitBox
SparkQA commented on pull request #28829: URL: https://github.com/apache/spark/pull/28829#issuecomment-643952127 **[Test build #124039 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124039/testReport)** for PR 28829 at commit [`16e90be`](https://github.com

[GitHub] [spark] cloud-fan commented on pull request #28829: [SPARK-31992][SQL] Benchmark the EXCEPTION rebase mode

2020-06-15 Thread GitBox
cloud-fan commented on pull request #28829: URL: https://github.com/apache/spark/pull/28829#issuecomment-643952756 This updates benchmark only and doesn't affect jenkins builder, I'm merging it to master/3.0, thanks! This is

[GitHub] [spark] AmplabJenkins commented on pull request #28829: [SPARK-31992][SQL] Benchmark the EXCEPTION rebase mode

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28829: URL: https://github.com/apache/spark/pull/28829#issuecomment-643952643 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28829: [SPARK-31992][SQL] Benchmark the EXCEPTION rebase mode

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28829: URL: https://github.com/apache/spark/pull/28829#issuecomment-643952643 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] cloud-fan closed pull request #28829: [SPARK-31992][SQL] Benchmark the EXCEPTION rebase mode

2020-06-15 Thread GitBox
cloud-fan closed pull request #28829: URL: https://github.com/apache/spark/pull/28829 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [spark] cloud-fan commented on pull request #28807: [SPARK-26905][SQL] Follow the SQL:2016 reserved keywords

2020-06-15 Thread GitBox
cloud-fan commented on pull request #28807: URL: https://github.com/apache/spark/pull/28807#issuecomment-643964961 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] SparkQA commented on pull request #28807: [SPARK-26905][SQL] Follow the SQL:2016 reserved keywords

2020-06-15 Thread GitBox
SparkQA commented on pull request #28807: URL: https://github.com/apache/spark/pull/28807#issuecomment-643965298 **[Test build #124041 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124041/testReport)** for PR 28807 at commit [`eeceb30`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #28828: [SPARK-24634][SS][FOLLOWUP] Rename the variable from "numLateInputs" to "numRowsDroppedByWatermark"

2020-06-15 Thread GitBox
SparkQA commented on pull request #28828: URL: https://github.com/apache/spark/pull/28828#issuecomment-643965274 **[Test build #124040 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124040/testReport)** for PR 28828 at commit [`75d12d3`](https://github.com

[GitHub] [spark] cloud-fan commented on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

2020-06-15 Thread GitBox
cloud-fan commented on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-643965087 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] AmplabJenkins commented on pull request #28828: [SPARK-24634][SS][FOLLOWUP] Rename the variable from "numLateInputs" to "numRowsDroppedByWatermark"

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28828: URL: https://github.com/apache/spark/pull/28828#issuecomment-643965873 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins commented on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-643965980 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-643965980 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28828: [SPARK-24634][SS][FOLLOWUP] Rename the variable from "numLateInputs" to "numRowsDroppedByWatermark"

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28828: URL: https://github.com/apache/spark/pull/28828#issuecomment-643965873 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28807: [SPARK-26905][SQL] Follow the SQL:2016 reserved keywords

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28807: URL: https://github.com/apache/spark/pull/28807#issuecomment-643966139 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28807: [SPARK-26905][SQL] Follow the SQL:2016 reserved keywords

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28807: URL: https://github.com/apache/spark/pull/28807#issuecomment-643966139 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] cloud-fan commented on pull request #28816: [SPARK-31986][SQL] Fix Julian-Gregorian micros rebasing of overlapping local timestamps

2020-06-15 Thread GitBox
cloud-fan commented on pull request #28816: URL: https://github.com/apache/spark/pull/28816#issuecomment-643967758 let's wait until https://github.com/apache/spark/pull/28809 is merged This is an automated message from the Ap

[GitHub] [spark] SparkQA commented on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

2020-06-15 Thread GitBox
SparkQA commented on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-643969029 **[Test build #124042 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124042/testReport)** for PR 28593 at commit [`8fe1960`](https://github.com

[GitHub] [spark] zhengruifeng commented on a change in pull request #28710: [SPARK-31893][ML] Add a generic ClassificationSummary trait

2020-06-15 Thread GitBox
zhengruifeng commented on a change in pull request #28710: URL: https://github.com/apache/spark/pull/28710#discussion_r43029 ## File path: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala ## @@ -1396,239 +1393,34 @@ object LogisticRegression

[GitHub] [spark] HeartSaVioR opened a new pull request #28831: [SPARK-31993][SQL] Don't split code blocks in generated code for 'concat_ws' for mixed string/array types of columns

2020-06-15 Thread GitBox
HeartSaVioR opened a new pull request #28831: URL: https://github.com/apache/spark/pull/28831 ### What changes were proposed in this pull request? This patch fixes the code generation logic for mixed string/array types of columns in `concat_ws` to not split methods, because splitting

[GitHub] [spark] AmplabJenkins commented on pull request #28831: [SPARK-31993][SQL] Don't split code blocks in generated code for 'concat_ws' for mixed string/array types of columns

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28831: URL: https://github.com/apache/spark/pull/28831#issuecomment-643977050 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] HeartSaVioR commented on pull request #28831: [SPARK-31993][SQL] Don't split code blocks in generated code for 'concat_ws' for mixed string/array types of columns

2020-06-15 Thread GitBox
HeartSaVioR commented on pull request #28831: URL: https://github.com/apache/spark/pull/28831#issuecomment-643978420 There might be still a chance to compose these all parts into one and pass to splitExpressionsWithCurrentInputs, but it requires rewrite of code because there're two differe

[GitHub] [spark] SparkQA commented on pull request #28831: [SPARK-31993][SQL] Don't split code blocks in generated code for 'concat_ws' for mixed string/array types of columns

2020-06-15 Thread GitBox
SparkQA commented on pull request #28831: URL: https://github.com/apache/spark/pull/28831#issuecomment-643980234 **[Test build #124043 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124043/testReport)** for PR 28831 at commit [`3e4ffbd`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28831: [SPARK-31993][SQL] Don't split code blocks in generated code for 'concat_ws' for mixed string/array types of columns

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28831: URL: https://github.com/apache/spark/pull/28831#issuecomment-643977050 This is an automated message from the Apache Git Service. To respond to the message, please log on

  1   2   3   4   5   6   7   8   >