[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29966: [SPARK-33084][CORE][SQL] Add jar support ivy path

2020-11-24 Thread GitBox
AngersZh commented on a change in pull request #29966: URL: https://github.com/apache/spark/pull/29966#discussion_r529294582 ## File path: docs/sql-ref-syntax-aux-resource-mgmt-add-jar.md ## @@ -42,6 +42,10 @@ ADD JAR /tmp/test.jar; ADD JAR "/path/to/some.jar"; ADD JAR

[GitHub] [spark] cloud-fan commented on pull request #28026: [SPARK-31257][SQL] Unify create table syntax

2020-11-24 Thread GitBox
cloud-fan commented on pull request #28026: URL: https://github.com/apache/spark/pull/28026#issuecomment-732745010 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] SparkQA commented on pull request #30468: [SPARK-33518][ML][WIP] Improve performance of ML ALS recommendForAll by GEMV

2020-11-24 Thread GitBox
SparkQA commented on pull request #30468: URL: https://github.com/apache/spark/pull/30468#issuecomment-732761536 **[Test build #131629 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131629/testReport)** for PR 30468 at commit

[GitHub] [spark] beliefer commented on a change in pull request #30465: [SPARK-33045][SQL][FOLLOWUP] Support built-in function like_any and fix StackOverflowError issue.

2020-11-24 Thread GitBox
beliefer commented on a change in pull request #30465: URL: https://github.com/apache/spark/pull/30465#discussion_r529322480 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -216,16 +216,16 @@ object SQLConf { "for using

[GitHub] [spark] AmplabJenkins commented on pull request #29000: [SPARK-27194][SPARK-29302][SQL] Fix commit collision in dynamic partition overwrite mode

2020-11-24 Thread GitBox
AmplabJenkins commented on pull request #29000: URL: https://github.com/apache/spark/pull/29000#issuecomment-732765233 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29000: [SPARK-27194][SPARK-29302][SQL] Fix commit collision in dynamic partition overwrite mode

2020-11-24 Thread GitBox
AmplabJenkins removed a comment on pull request #29000: URL: https://github.com/apache/spark/pull/29000#issuecomment-732765233 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] maropu commented on pull request #30408: [SPARK-33477][SQL] Hive Metastore should support filter by date type

2020-11-24 Thread GitBox
maropu commented on pull request #30408: URL: https://github.com/apache/spark/pull/30408#issuecomment-732788459 @wangyum How about asking it in the spark-dev thread so that Shane could notice it

[GitHub] [spark] AmplabJenkins commented on pull request #30479: [WIP][SPARK-33527][SQL] Extend the function of decode so as consistent with mainstream databases

2020-11-24 Thread GitBox
AmplabJenkins commented on pull request #30479: URL: https://github.com/apache/spark/pull/30479#issuecomment-732790562 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #30482: [SPARK-33529][SQL] Handle '__HIVE_DEFAULT_PARTITION__' while resolving V2 partition specs

2020-11-24 Thread GitBox
SparkQA commented on pull request #30482: URL: https://github.com/apache/spark/pull/30482#issuecomment-732790773 **[Test build #131641 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131641/testReport)** for PR 30482 at commit

[GitHub] [spark] SparkQA commented on pull request #30481: [SPARK-33526][SQL] Add config to control if cancel invoke interrupt task on thriftserver

2020-11-24 Thread GitBox
SparkQA commented on pull request #30481: URL: https://github.com/apache/spark/pull/30481#issuecomment-732790797 **[Test build #131642 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131642/testReport)** for PR 30481 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #30479: [WIP][SPARK-33527][SQL] Extend the function of decode so as consistent with mainstream databases

2020-11-24 Thread GitBox
SparkQA removed a comment on pull request #30479: URL: https://github.com/apache/spark/pull/30479#issuecomment-732725257 **[Test build #131628 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131628/testReport)** for PR 30479 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30479: [WIP][SPARK-33527][SQL] Extend the function of decode so as consistent with mainstream databases

2020-11-24 Thread GitBox
AmplabJenkins removed a comment on pull request #30479: URL: https://github.com/apache/spark/pull/30479#issuecomment-732790562 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #30465: [SPARK-33045][SQL][FOLLOWUP] Support built-in function like_any and fix StackOverflowError issue.

2020-11-24 Thread GitBox
SparkQA commented on pull request #30465: URL: https://github.com/apache/spark/pull/30465#issuecomment-732790908 **[Test build #131643 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131643/testReport)** for PR 30465 at commit

[GitHub] [spark] SparkQA commented on pull request #30479: [WIP][SPARK-33527][SQL] Extend the function of decode so as consistent with mainstream databases

2020-11-24 Thread GitBox
SparkQA commented on pull request #30479: URL: https://github.com/apache/spark/pull/30479#issuecomment-732790339 **[Test build #131628 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131628/testReport)** for PR 30479 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28026: [SPARK-31257][SQL] Unify create table syntax

2020-11-24 Thread GitBox
AmplabJenkins commented on pull request #28026: URL: https://github.com/apache/spark/pull/28026#issuecomment-732797564 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #30450: [SPARK-33185][YARN][FOLLOW-ON] Leverage RM's RPC API instead of REST to fetch driver log links in yarn.Client

2020-11-24 Thread GitBox
AmplabJenkins commented on pull request #30450: URL: https://github.com/apache/spark/pull/30450#issuecomment-732797906 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28026: [SPARK-31257][SQL] Unify create table syntax

2020-11-24 Thread GitBox
AmplabJenkins removed a comment on pull request #28026: URL: https://github.com/apache/spark/pull/28026#issuecomment-732797564 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #30476: [SPARK-33523][SQL][TEST] Add predicate related benchmark to SubExprEliminationBenchmark

2020-11-24 Thread GitBox
AmplabJenkins commented on pull request #30476: URL: https://github.com/apache/spark/pull/30476#issuecomment-732798130 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AngersZhuuuu commented on pull request #30421: [SPARK-33474][SQL] Support TypeConstructed partition spec value

2020-11-24 Thread GitBox
AngersZh commented on pull request #30421: URL: https://github.com/apache/spark/pull/30421#issuecomment-732802953 > > Yes, user can use TypeConstruct value as partition spec value such as > > `` > > Is the description above incomplete? Btw, could you put an example query that

[GitHub] [spark] AmplabJenkins commented on pull request #29000: [SPARK-27194][SPARK-29302][SQL] Fix commit collision in dynamic partition overwrite mode

2020-11-24 Thread GitBox
AmplabJenkins commented on pull request #29000: URL: https://github.com/apache/spark/pull/29000#issuecomment-732803500 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #29966: [SPARK-33084][CORE][SQL] Add jar support ivy path

2020-11-24 Thread GitBox
AmplabJenkins commented on pull request #29966: URL: https://github.com/apache/spark/pull/29966#issuecomment-732803609 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #29966: [SPARK-33084][CORE][SQL] Add jar support ivy path

2020-11-24 Thread GitBox
SparkQA removed a comment on pull request #29966: URL: https://github.com/apache/spark/pull/29966#issuecomment-732725669 **[Test build #131632 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131632/testReport)** for PR 29966 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #29000: [SPARK-27194][SPARK-29302][SQL] Fix commit collision in dynamic partition overwrite mode

2020-11-24 Thread GitBox
SparkQA removed a comment on pull request #29000: URL: https://github.com/apache/spark/pull/29000#issuecomment-732730489 **[Test build #131634 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131634/testReport)** for PR 29000 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30481: [SPARK-33526][SQL] Add config to control if cancel invoke interrupt task on thriftserver

2020-11-24 Thread GitBox
AmplabJenkins removed a comment on pull request #30481: URL: https://github.com/apache/spark/pull/30481#issuecomment-732835381 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #30481: [SPARK-33526][SQL] Add config to control if cancel invoke interrupt task on thriftserver

2020-11-24 Thread GitBox
SparkQA removed a comment on pull request #30481: URL: https://github.com/apache/spark/pull/30481#issuecomment-732790797 **[Test build #131642 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131642/testReport)** for PR 30481 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #30481: [SPARK-33526][SQL] Add config to control if cancel invoke interrupt task on thriftserver

2020-11-24 Thread GitBox
AmplabJenkins commented on pull request #30481: URL: https://github.com/apache/spark/pull/30481#issuecomment-732835381 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] cloud-fan commented on a change in pull request #30482: [SPARK-33529][SQL] Handle '__HIVE_DEFAULT_PARTITION__' while resolving V2 partition specs

2020-11-24 Thread GitBox
cloud-fan commented on a change in pull request #30482: URL: https://github.com/apache/spark/pull/30482#discussion_r529465696 ## File path: sql/core/src/test/scala/org/apache/spark/sql/connector/AlterTablePartitionV2SQLSuite.scala ## @@ -243,4 +243,22 @@ class

[GitHub] [spark] gengliangwang commented on pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast

2020-11-24 Thread GitBox
gengliangwang commented on pull request #30440: URL: https://github.com/apache/spark/pull/30440#issuecomment-732842384 @cloud-fan @maropu Thanks for the suggestions. I have addressed them. This is an automated message from

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #30336: [SPARK-33287][SS][UI]Expose state custom metrics information on SS UI

2020-11-24 Thread GitBox
gaborgsomogyi commented on a change in pull request #30336: URL: https://github.com/apache/spark/pull/30336#discussion_r529477504 ## File path: sql/core/src/main/scala/org/apache/spark/sql/streaming/ui/StreamingQueryStatisticsPage.scala ## @@ -22,15 +22,25 @@ import

[GitHub] [spark] SparkQA removed a comment on pull request #30465: [SPARK-33045][SQL][FOLLOWUP] Support built-in function like_any and fix StackOverflowError issue.

2020-11-24 Thread GitBox
SparkQA removed a comment on pull request #30465: URL: https://github.com/apache/spark/pull/30465#issuecomment-732790908 **[Test build #131643 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131643/testReport)** for PR 30465 at commit

[GitHub] [spark] SparkQA commented on pull request #30465: [SPARK-33045][SQL][FOLLOWUP] Support built-in function like_any and fix StackOverflowError issue.

2020-11-24 Thread GitBox
SparkQA commented on pull request #30465: URL: https://github.com/apache/spark/pull/30465#issuecomment-732899668 **[Test build #131643 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131643/testReport)** for PR 30465 at commit

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #30212: [SPARK-33308][SQL] Support CUBE(...) and ROLLUP(...), GROUPING SETS(...) as group by expr in parser level

2020-11-24 Thread GitBox
AngersZh commented on a change in pull request #30212: URL: https://github.com/apache/spark/pull/30212#discussion_r529496396 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -665,13 +676,15 @@ class Analyzer( //

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #30212: [SPARK-33308][SQL] Support CUBE(...) and ROLLUP(...), GROUPING SETS(...) as group by expr in parser level

2020-11-24 Thread GitBox
AngersZh commented on a change in pull request #30212: URL: https://github.com/apache/spark/pull/30212#discussion_r529496579 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1971,65 +2025,84 @@ class Analyzer( */

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #30212: [SPARK-33308][SQL] Support CUBE(...) and ROLLUP(...), GROUPING SETS(...) as group by expr in parser level

2020-11-24 Thread GitBox
AngersZh commented on a change in pull request #30212: URL: https://github.com/apache/spark/pull/30212#discussion_r529496711 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1971,65 +2025,84 @@ class Analyzer( */

[GitHub] [spark] Fokko commented on a change in pull request #29122: [SPARK-32320][PYSPARK] Remove mutable default arguments

2020-11-24 Thread GitBox
Fokko commented on a change in pull request #29122: URL: https://github.com/apache/spark/pull/29122#discussion_r529496774 ## File path: python/pyspark/sql/functions.py ## @@ -3471,7 +3473,7 @@ def from_json(col, schema, options={}): return Column(jc) -def to_json(col,

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30476: [SPARK-33523][SQL][TEST] Add predicate related benchmark to SubExprEliminationBenchmark

2020-11-24 Thread GitBox
AmplabJenkins removed a comment on pull request #30476: URL: https://github.com/apache/spark/pull/30476#issuecomment-732724339 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30470: [SPARK-33495][BUILD] Remove commons-logging.jar's dependency

2020-11-24 Thread GitBox
AmplabJenkins removed a comment on pull request #30470: URL: https://github.com/apache/spark/pull/30470#issuecomment-732724341 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30473: [SPARK-33430][SQL] Support namespaces in JDBC v2 Table Catalog

2020-11-24 Thread GitBox
AmplabJenkins removed a comment on pull request #30473: URL: https://github.com/apache/spark/pull/30473#issuecomment-732724340 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30315: [SPARK-33388][SQL] Merge In and InSet predicate

2020-11-24 Thread GitBox
AmplabJenkins removed a comment on pull request #30315: URL: https://github.com/apache/spark/pull/30315#issuecomment-732724345 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29122: [SPARK-32320][PYSPARK] Remove mutable default arguments

2020-11-24 Thread GitBox
AmplabJenkins commented on pull request #29122: URL: https://github.com/apache/spark/pull/29122#issuecomment-732763225 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #30465: [SPARK-33045][SQL][FOLLOWUP] Support built-in function like_any and fix StackOverflowError issue.

2020-11-24 Thread GitBox
SparkQA commented on pull request #30465: URL: https://github.com/apache/spark/pull/30465#issuecomment-732764182 **[Test build #131640 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131640/testReport)** for PR 30465 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29122: [SPARK-32320][PYSPARK] Remove mutable default arguments

2020-11-24 Thread GitBox
AmplabJenkins removed a comment on pull request #29122: URL: https://github.com/apache/spark/pull/29122#issuecomment-732763225 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30442: [SPARK-33498][SQL] Datetime parsing should fail if the input string can't be parsed, or the pattern string is invalid

2020-11-24 Thread GitBox
AmplabJenkins removed a comment on pull request #30442: URL: https://github.com/apache/spark/pull/30442#issuecomment-732799105 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #30481: [SPARK-33526][SQL] Add config to control if cancel invoke interrupt task on thriftserver

2020-11-24 Thread GitBox
SparkQA commented on pull request #30481: URL: https://github.com/apache/spark/pull/30481#issuecomment-732834680 **[Test build #131642 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131642/testReport)** for PR 30481 at commit

[GitHub] [spark] cloud-fan closed pull request #30457: [SPARK-33514][SQL] Migrate TRUNCATE TABLE command to use UnresolvedTable to resolve the identifier

2020-11-24 Thread GitBox
cloud-fan closed pull request #30457: URL: https://github.com/apache/spark/pull/30457 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] SparkQA removed a comment on pull request #30421: [SPARK-33474][SQL] Support TypeConstructed partition spec value

2020-11-24 Thread GitBox
SparkQA removed a comment on pull request #30421: URL: https://github.com/apache/spark/pull/30421#issuecomment-732802365 **[Test build #131646 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131646/testReport)** for PR 30421 at commit

[GitHub] [spark] MaxGekk commented on a change in pull request #30482: [SPARK-33529][SQL] Handle '__HIVE_DEFAULT_PARTITION__' while resolving V2 partition specs

2020-11-24 Thread GitBox
MaxGekk commented on a change in pull request #30482: URL: https://github.com/apache/spark/pull/30482#discussion_r529474127 ## File path: sql/core/src/test/scala/org/apache/spark/sql/connector/AlterTablePartitionV2SQLSuite.scala ## @@ -243,4 +243,22 @@ class

[GitHub] [spark] LuciferYang opened a new pull request #30483: [WIP][SPARK-33449][SQL] Add File Metadata cache support for Parquet and Orc

2020-11-24 Thread GitBox
LuciferYang opened a new pull request #30483: URL: https://github.com/apache/spark/pull/30483 ### What changes were proposed in this pull request? Add File Metadata cache support for Parquet and Orc, this pr is WIP now ### Why are the changes needed? Support Parquet and Orc

[GitHub] [spark] LuciferYang commented on pull request #30483: [WIP][SPARK-33449][SQL] Add File Metadata cache support for Parquet and Orc

2020-11-24 Thread GitBox
LuciferYang commented on pull request #30483: URL: https://github.com/apache/spark/pull/30483#issuecomment-732905089 @wangyum WIP now, missing some configuration entries, test suite and orc file support This is an

[GitHub] [spark] maropu commented on a change in pull request #30212: [SPARK-33308][SQL] Support CUBE(...) and ROLLUP(...), GROUPING SETS(...) as group by expr in parser level

2020-11-24 Thread GitBox
maropu commented on a change in pull request #30212: URL: https://github.com/apache/spark/pull/30212#discussion_r529480121 ## File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ## @@ -587,13 +587,24 @@ fromClause ;

[GitHub] [spark] SparkQA commented on pull request #30442: [SPARK-33498][SQL] Datetime parsing should fail if the input string can't be parsed, or the pattern string is invalid

2020-11-24 Thread GitBox
SparkQA commented on pull request #30442: URL: https://github.com/apache/spark/pull/30442#issuecomment-732919060 **[Test build #131656 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131656/testReport)** for PR 30442 at commit

[GitHub] [spark] SparkQA commented on pull request #30336: [SPARK-33287][SS][UI]Expose state custom metrics information on SS UI

2020-11-24 Thread GitBox
SparkQA commented on pull request #30336: URL: https://github.com/apache/spark/pull/30336#issuecomment-732919629 **[Test build #131657 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131657/testReport)** for PR 30336 at commit

[GitHub] [spark] SparkQA commented on pull request #30483: [WIP][SPARK-33449][SQL] Add File Metadata cache support for Parquet and Orc

2020-11-24 Thread GitBox
SparkQA commented on pull request #30483: URL: https://github.com/apache/spark/pull/30483#issuecomment-732918797 **[Test build #131655 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131655/testReport)** for PR 30483 at commit

[GitHub] [spark] maropu commented on a change in pull request #30421: [SPARK-33474][SQL] Support TypeConstructed partition spec value

2020-11-24 Thread GitBox
maropu commented on a change in pull request #30421: URL: https://github.com/apache/spark/pull/30421#discussion_r529498575 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala ## @@ -503,13 +503,32 @@ class AstBuilder extends

[GitHub] [spark] SparkQA commented on pull request #29000: [SPARK-27194][SPARK-29302][SQL] Fix commit collision in dynamic partition overwrite mode

2020-11-24 Thread GitBox
SparkQA commented on pull request #29000: URL: https://github.com/apache/spark/pull/29000#issuecomment-732730489 **[Test build #131634 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131634/testReport)** for PR 29000 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29966: [SPARK-33084][CORE][SQL] Add jar support ivy path

2020-11-24 Thread GitBox
AmplabJenkins removed a comment on pull request #29966: URL: https://github.com/apache/spark/pull/29966#issuecomment-732734928 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28026: [SPARK-31257][SQL] Unify create table syntax

2020-11-24 Thread GitBox
SparkQA commented on pull request #28026: URL: https://github.com/apache/spark/pull/28026#issuecomment-732757294 **[Test build #131639 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131639/testReport)** for PR 28026 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #30468: [SPARK-33518][ML][WIP] Improve performance of ML ALS recommendForAll by GEMV

2020-11-24 Thread GitBox
AmplabJenkins commented on pull request #30468: URL: https://github.com/apache/spark/pull/30468#issuecomment-732761870 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] beliefer commented on a change in pull request #30465: [SPARK-33045][SQL][FOLLOWUP] Support built-in function like_any and fix StackOverflowError issue.

2020-11-24 Thread GitBox
beliefer commented on a change in pull request #30465: URL: https://github.com/apache/spark/pull/30465#discussion_r529323100 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -216,16 +216,16 @@ object SQLConf { "for using

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30468: [SPARK-33518][ML][WIP] Improve performance of ML ALS recommendForAll by GEMV

2020-11-24 Thread GitBox
AmplabJenkins removed a comment on pull request #30468: URL: https://github.com/apache/spark/pull/30468#issuecomment-732761870 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #30468: [SPARK-33518][ML][WIP] Improve performance of ML ALS recommendForAll by GEMV

2020-11-24 Thread GitBox
SparkQA removed a comment on pull request #30468: URL: https://github.com/apache/spark/pull/30468#issuecomment-732725287 **[Test build #131629 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131629/testReport)** for PR 30468 at commit

[GitHub] [spark] SparkQA commented on pull request #30403: [SPARK-33448][SQL] Support CACHE/UNCACHE TABLE commands for v2 tables

2020-11-24 Thread GitBox
SparkQA commented on pull request #30403: URL: https://github.com/apache/spark/pull/30403#issuecomment-732766111 **[Test build #131633 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131633/testReport)** for PR 30403 at commit

[GitHub] [spark] ulysses-you opened a new pull request #30481: [SPARK-33526][SQL] Add config to control if cancel invoke interrupt task on thriftserver

2020-11-24 Thread GitBox
ulysses-you opened a new pull request #30481: URL: https://github.com/apache/spark/pull/30481 ### What changes were proposed in this pull request? This PR add a new config `spark.sql.thriftServer.forceCancel` to give user a way to interrupt task when cancel statement.

[GitHub] [spark] MaxGekk commented on a change in pull request #30482: [SPARK-33529][SQL] Handle '__HIVE_DEFAULT_PARTITION__' while resolving V2 partition specs

2020-11-24 Thread GitBox
MaxGekk commented on a change in pull request #30482: URL: https://github.com/apache/spark/pull/30482#discussion_r529377394 ## File path: sql/core/src/test/scala/org/apache/spark/sql/connector/AlterTablePartitionV2SQLSuite.scala ## @@ -243,4 +243,22 @@ class

[GitHub] [spark] SparkQA commented on pull request #30427: [SPARK-33224][SS] Add watermark gap information into SS UI page

2020-11-24 Thread GitBox
SparkQA commented on pull request #30427: URL: https://github.com/apache/spark/pull/30427#issuecomment-732815872 **[Test build #131630 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131630/testReport)** for PR 30427 at commit

[GitHub] [spark] gaborgsomogyi commented on pull request #30427: [SPARK-33224][SS] Add watermark gap information into SS UI page

2020-11-24 Thread GitBox
gaborgsomogyi commented on pull request #30427: URL: https://github.com/apache/spark/pull/30427#issuecomment-732819837 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] SparkQA commented on pull request #30427: [SPARK-33224][SS] Add watermark gap information into SS UI page

2020-11-24 Thread GitBox
SparkQA commented on pull request #30427: URL: https://github.com/apache/spark/pull/30427#issuecomment-732725370 **[Test build #131630 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131630/testReport)** for PR 30427 at commit

[GitHub] [spark] SparkQA commented on pull request #30408: [SPARK-33477][SQL] Hive Metastore should support filter by date type

2020-11-24 Thread GitBox
SparkQA commented on pull request #30408: URL: https://github.com/apache/spark/pull/30408#issuecomment-732725416 **[Test build #131631 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131631/testReport)** for PR 30408 at commit

[GitHub] [spark] SparkQA commented on pull request #29966: [SPARK-33084][CORE][SQL] Add jar support ivy path

2020-11-24 Thread GitBox
SparkQA commented on pull request #29966: URL: https://github.com/apache/spark/pull/29966#issuecomment-732725669 **[Test build #131632 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131632/testReport)** for PR 29966 at commit

[GitHub] [spark] cloud-fan commented on pull request #30432: [SPARK-33494][SQL][AQE] Do not use local shuffle reader for repartition

2020-11-24 Thread GitBox
cloud-fan commented on pull request #30432: URL: https://github.com/apache/spark/pull/30432#issuecomment-732751428 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] Victsm opened a new pull request #30480: [SPARK-32921][SHUFFLE][test-maven][test-hadoop2.7] MapOutputTracker extensions to support push-based shuffle

2020-11-24 Thread GitBox
Victsm opened a new pull request #30480: URL: https://github.com/apache/spark/pull/30480 ### What changes were proposed in this pull request? This is one of the patches for SPIP SPARK-30602 for push-based shuffle. Summary of changes: - Introduce `MergeStatus` which tracks the

[GitHub] [spark] SparkQA commented on pull request #30442: [SPARK-33498][SQL] Datetime parsing should fail if the input string can't be parsed, or the pattern string is invalid

2020-11-24 Thread GitBox
SparkQA commented on pull request #30442: URL: https://github.com/apache/spark/pull/30442#issuecomment-732756404 **[Test build #131635 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131635/testReport)** for PR 30442 at commit

[GitHub] [spark] SparkQA commented on pull request #30432: [SPARK-33494][SQL][AQE] Do not use local shuffle reader for repartition

2020-11-24 Thread GitBox
SparkQA commented on pull request #30432: URL: https://github.com/apache/spark/pull/30432#issuecomment-732756403 **[Test build #131636 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131636/testReport)** for PR 30432 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #30480: [SPARK-32921][SHUFFLE][test-maven][test-hadoop2.7] MapOutputTracker extensions to support push-based shuffle

2020-11-24 Thread GitBox
AmplabJenkins commented on pull request #30480: URL: https://github.com/apache/spark/pull/30480#issuecomment-732756039 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA commented on pull request #29966: [SPARK-33084][CORE][SQL] Add jar support ivy path

2020-11-24 Thread GitBox
SparkQA commented on pull request #29966: URL: https://github.com/apache/spark/pull/29966#issuecomment-732756825 **[Test build #131638 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131638/testReport)** for PR 29966 at commit

[GitHub] [spark] SparkQA commented on pull request #30412: [SPARK-33480][SQL] Support char/varchar type

2020-11-24 Thread GitBox
SparkQA commented on pull request #30412: URL: https://github.com/apache/spark/pull/30412#issuecomment-732756465 **[Test build #131637 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131637/testReport)** for PR 30412 at commit

[GitHub] [spark] wangyum commented on pull request #30408: [SPARK-33477][SQL] Hive Metastore should support filter by date type

2020-11-24 Thread GitBox
wangyum commented on pull request #30408: URL: https://github.com/apache/spark/pull/30408#issuecomment-732769319 @shaneknapp Did you set :`export LANG=en_US.UTF-8`? ``` org.apache.spark.sql.AnalysisException: org.apache.hadoop.hive.ql.metadata.HiveException:

[GitHub] [spark] SparkQA removed a comment on pull request #28026: [SPARK-31257][SQL] Unify create table syntax

2020-11-24 Thread GitBox
SparkQA removed a comment on pull request #28026: URL: https://github.com/apache/spark/pull/28026#issuecomment-732757294 **[Test build #131639 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131639/testReport)** for PR 28026 at commit

[GitHub] [spark] SparkQA commented on pull request #28026: [SPARK-31257][SQL] Unify create table syntax

2020-11-24 Thread GitBox
SparkQA commented on pull request #28026: URL: https://github.com/apache/spark/pull/28026#issuecomment-732781939 **[Test build #131639 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131639/testReport)** for PR 28026 at commit

[GitHub] [spark] SparkQA commented on pull request #30482: [SPARK-33529][SQL] Handle '__HIVE_DEFAULT_PARTITION__' while resolving V2 partition specs

2020-11-24 Thread GitBox
SparkQA commented on pull request #30482: URL: https://github.com/apache/spark/pull/30482#issuecomment-732794164 **[Test build #131641 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131641/testReport)** for PR 30482 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #30482: [SPARK-33529][SQL] Handle '__HIVE_DEFAULT_PARTITION__' while resolving V2 partition specs

2020-11-24 Thread GitBox
AmplabJenkins commented on pull request #30482: URL: https://github.com/apache/spark/pull/30482#issuecomment-732794192 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30482: [SPARK-33529][SQL] Handle '__HIVE_DEFAULT_PARTITION__' while resolving V2 partition specs

2020-11-24 Thread GitBox
AmplabJenkins removed a comment on pull request #30482: URL: https://github.com/apache/spark/pull/30482#issuecomment-732794192 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #30482: [SPARK-33529][SQL] Handle '__HIVE_DEFAULT_PARTITION__' while resolving V2 partition specs

2020-11-24 Thread GitBox
SparkQA removed a comment on pull request #30482: URL: https://github.com/apache/spark/pull/30482#issuecomment-732790773 **[Test build #131641 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131641/testReport)** for PR 30482 at commit

[GitHub] [spark] gengliangwang commented on a change in pull request #30440: [SPARK-33496][SQL]Improve error message of ANSI explicit cast

2020-11-24 Thread GitBox
gengliangwang commented on a change in pull request #30440: URL: https://github.com/apache/spark/pull/30440#discussion_r529459190 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala ## @@ -98,6 +98,19 @@ object Cast { case _ =>

[GitHub] [spark] AmplabJenkins commented on pull request #30478: [SPARK-33525][SQL] Update hive-service-rpc to 3.1.2

2020-11-24 Thread GitBox
AmplabJenkins commented on pull request #30478: URL: https://github.com/apache/spark/pull/30478#issuecomment-732849766 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #30421: [SPARK-33474][SQL] Support TypeConstructed partition spec value

2020-11-24 Thread GitBox
SparkQA commented on pull request #30421: URL: https://github.com/apache/spark/pull/30421#issuecomment-732862083 **[Test build #131646 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131646/testReport)** for PR 30421 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #30482: [SPARK-33529][SQL] Handle '__HIVE_DEFAULT_PARTITION__' while resolving V2 partition specs

2020-11-24 Thread GitBox
cloud-fan commented on a change in pull request #30482: URL: https://github.com/apache/spark/pull/30482#discussion_r529472863 ## File path: sql/core/src/test/scala/org/apache/spark/sql/connector/AlterTablePartitionV2SQLSuite.scala ## @@ -243,4 +243,22 @@ class

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #30336: [SPARK-33287][SS][UI]Expose state custom metrics information on SS UI

2020-11-24 Thread GitBox
gaborgsomogyi commented on a change in pull request #30336: URL: https://github.com/apache/spark/pull/30336#discussion_r529477301 ## File path: sql/core/src/main/scala/org/apache/spark/sql/streaming/ui/StreamingQueryStatisticsPage.scala ## @@ -199,49 +209,100 @@ private[ui]

[GitHub] [spark] AmplabJenkins commented on pull request #30473: [SPARK-33430][SQL] Support namespaces in JDBC v2 Table Catalog

2020-11-24 Thread GitBox
AmplabJenkins commented on pull request #30473: URL: https://github.com/apache/spark/pull/30473#issuecomment-732934562 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #30403: [SPARK-33448][SQL] Support CACHE/UNCACHE TABLE commands for v2 tables

2020-11-24 Thread GitBox
SparkQA commented on pull request #30403: URL: https://github.com/apache/spark/pull/30403#issuecomment-732727595 **[Test build #131633 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131633/testReport)** for PR 30403 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29729: [SPARK-32032][SS] Avoid infinite wait in driver because of KafkaConsumer.poll(long) API

2020-11-24 Thread GitBox
AmplabJenkins removed a comment on pull request #29729: URL: https://github.com/apache/spark/pull/29729#issuecomment-732755010 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29729: [SPARK-32032][SS] Avoid infinite wait in driver because of KafkaConsumer.poll(long) API

2020-11-24 Thread GitBox
AmplabJenkins commented on pull request #29729: URL: https://github.com/apache/spark/pull/29729#issuecomment-732755010 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] ulysses-you commented on a change in pull request #30481: [SPARK-33526][SQL] Add config to control if cancel invoke interrupt task on thriftserver

2020-11-24 Thread GitBox
ulysses-you commented on a change in pull request #30481: URL: https://github.com/apache/spark/pull/30481#discussion_r529336316 ## File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ThriftServerWithSparkContextSuite.scala ## @@ -79,6 +84,45

[GitHub] [spark] MaxGekk commented on a change in pull request #30474: [SPARK-33521][SQL] Universal type conversion in resolving V2 partition specs

2020-11-24 Thread GitBox
MaxGekk commented on a change in pull request #30474: URL: https://github.com/apache/spark/pull/30474#discussion_r529375116 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolvePartitionSpec.scala ## @@ -65,31 +65,8 @@ object

[GitHub] [spark] MaxGekk commented on a change in pull request #30474: [SPARK-33521][SQL] Universal type conversion in resolving V2 partition specs

2020-11-24 Thread GitBox
MaxGekk commented on a change in pull request #30474: URL: https://github.com/apache/spark/pull/30474#discussion_r529375116 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolvePartitionSpec.scala ## @@ -65,31 +65,8 @@ object

[GitHub] [spark] AmplabJenkins commented on pull request #30476: [SPARK-33523][SQL][TEST] Add predicate related benchmark to SubExprEliminationBenchmark

2020-11-24 Thread GitBox
AmplabJenkins commented on pull request #30476: URL: https://github.com/apache/spark/pull/30476#issuecomment-732790036 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30476: [SPARK-33523][SQL][TEST] Add predicate related benchmark to SubExprEliminationBenchmark

2020-11-24 Thread GitBox
AmplabJenkins removed a comment on pull request #30476: URL: https://github.com/apache/spark/pull/30476#issuecomment-732789718 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #29966: [SPARK-33084][CORE][SQL] Add jar support ivy path

2020-11-24 Thread GitBox
SparkQA commented on pull request #29966: URL: https://github.com/apache/spark/pull/29966#issuecomment-732802966 **[Test build #131632 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131632/testReport)** for PR 29966 at commit

[GitHub] [spark] SparkQA commented on pull request #30421: [SPARK-33474][SQL] Support TypeConstructed partition spec value

2020-11-24 Thread GitBox
SparkQA commented on pull request #30421: URL: https://github.com/apache/spark/pull/30421#issuecomment-732802365 **[Test build #131646 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131646/testReport)** for PR 30421 at commit

[GitHub] [spark] SparkQA commented on pull request #29000: [SPARK-27194][SPARK-29302][SQL] Fix commit collision in dynamic partition overwrite mode

2020-11-24 Thread GitBox
SparkQA commented on pull request #29000: URL: https://github.com/apache/spark/pull/29000#issuecomment-732802576 **[Test build #131634 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131634/testReport)** for PR 29000 at commit

  1   2   3   4   5   6   7   8   9   10   >