[GitHub] [spark] SparkQA commented on pull request #34674: [SPARK-37419][PYTHON][ML] Rewrite _shared_params_code_gen.py to inline type hints for ml/param/shared.py

2021-11-20 Thread GitBox
SparkQA commented on pull request #34674: URL: https://github.com/apache/spark/pull/34674#issuecomment-974712101 **[Test build #145479 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145479/testReport)** for PR 34674 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #34674: [SPARK-37419][PYTHON][ML] Rewrite _shared_params_code_gen.py to inline type hints for ml/param/shared.py

2021-11-20 Thread GitBox
SparkQA removed a comment on pull request #34674: URL: https://github.com/apache/spark/pull/34674#issuecomment-974709701 **[Test build #145479 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145479/testReport)** for PR 34674 at commit

[GitHub] [spark] SparkQA commented on pull request #34674: [SPARK-37419][PYTHON][ML] Rewrite _shared_params_code_gen.py to inline type hints for ml/param/shared.py

2021-11-20 Thread GitBox
SparkQA commented on pull request #34674: URL: https://github.com/apache/spark/pull/34674#issuecomment-974714243 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49951/ -- This is an automated message from the Apache

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34674: [SPARK-37419][PYTHON][ML] Rewrite _shared_params_code_gen.py to inline type hints for ml/param/shared.py

2021-11-20 Thread GitBox
AmplabJenkins removed a comment on pull request #34674: URL: https://github.com/apache/spark/pull/34674#issuecomment-974715748 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145479/

[GitHub] [spark] AmplabJenkins commented on pull request #34674: [SPARK-37419][PYTHON][ML] Rewrite _shared_params_code_gen.py to inline type hints for ml/param/shared.py

2021-11-20 Thread GitBox
AmplabJenkins commented on pull request #34674: URL: https://github.com/apache/spark/pull/34674#issuecomment-974715748 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145479/ -- This

[GitHub] [spark] github-actions[bot] closed pull request #33662: [SPARK-36162][SQL] Support estimation of equal null safe join

2021-11-20 Thread GitBox
github-actions[bot] closed pull request #33662: URL: https://github.com/apache/spark/pull/33662 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [spark] github-actions[bot] closed pull request #33632: [SPARK-36360][Streaming] Delete appName from StreamingSource sourceName

2021-11-20 Thread GitBox
github-actions[bot] closed pull request #33632: URL: https://github.com/apache/spark/pull/33632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [spark] github-actions[bot] commented on pull request #33717: [SPARK-36486][SQL] Support cast type constructed same string to day time interval

2021-11-20 Thread GitBox
github-actions[bot] commented on pull request #33717: URL: https://github.com/apache/spark/pull/33717#issuecomment-974730396 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue

[GitHub] [spark] HyukjinKwon commented on pull request #34669: [SPARK-37390][PYTHON][DOCS] Add default value to getattr(app, add_javascript)

2021-11-20 Thread GitBox
HyukjinKwon commented on pull request #34669: URL: https://github.com/apache/spark/pull/34669#issuecomment-974734313 Lgtm thx! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] imback82 commented on a change in pull request #34610: [SPARK-34332][SQL][TEST] Unify v1 and v2 ALTER TABLE .. SET LOCATION tests

2021-11-20 Thread GitBox
imback82 commented on a change in pull request #34610: URL: https://github.com/apache/spark/pull/34610#discussion_r753744480 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/command/AlterNamespaceSetLocationSuite.scala ## @@ -0,0 +1,41 @@ +/* + *

[GitHub] [spark] SparkQA commented on pull request #34610: [SPARK-34332][SQL][TEST] Unify v1 and v2 ALTER TABLE .. SET LOCATION tests

2021-11-20 Thread GitBox
SparkQA commented on pull request #34610: URL: https://github.com/apache/spark/pull/34610#issuecomment-974766922 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49953/ -- This is an automated message from the

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34668: [SPARK-37389][SQL] Check unclosed bracketed comments

2021-11-20 Thread GitBox
AmplabJenkins removed a comment on pull request #34668: URL: https://github.com/apache/spark/pull/34668#issuecomment-974770280 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145480/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34610: [SPARK-34332][SQL][TEST] Unify v1 and v2 ALTER TABLE .. SET LOCATION tests

2021-11-20 Thread GitBox
AmplabJenkins removed a comment on pull request #34610: URL: https://github.com/apache/spark/pull/34610#issuecomment-974770281 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49953/

[GitHub] [spark] AmplabJenkins commented on pull request #34610: [SPARK-34332][SQL][TEST] Unify v1 and v2 ALTER TABLE .. SET LOCATION tests

2021-11-20 Thread GitBox
AmplabJenkins commented on pull request #34610: URL: https://github.com/apache/spark/pull/34610#issuecomment-974770281 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49953/ --

[GitHub] [spark] AmplabJenkins commented on pull request #34668: [SPARK-37389][SQL] Check unclosed bracketed comments

2021-11-20 Thread GitBox
AmplabJenkins commented on pull request #34668: URL: https://github.com/apache/spark/pull/34668#issuecomment-974770280 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145480/ -- This

[GitHub] [spark] SparkQA commented on pull request #34668: [SPARK-37389][SQL] Check unclosed bracketed comments

2021-11-20 Thread GitBox
SparkQA commented on pull request #34668: URL: https://github.com/apache/spark/pull/34668#issuecomment-974769898 **[Test build #145480 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145480/testReport)** for PR 34668 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #34668: [SPARK-37389][SQL] Check unclosed bracketed comments

2021-11-20 Thread GitBox
SparkQA removed a comment on pull request #34668: URL: https://github.com/apache/spark/pull/34668#issuecomment-974745809 **[Test build #145480 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145480/testReport)** for PR 34668 at commit

[GitHub] [spark] SparkQA commented on pull request #34610: [SPARK-34332][SQL][TEST] Unify v1 and v2 ALTER TABLE .. SET LOCATION tests

2021-11-20 Thread GitBox
SparkQA commented on pull request #34610: URL: https://github.com/apache/spark/pull/34610#issuecomment-974763243 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49953/ -- This is an automated message from the Apache

[GitHub] [spark] LuciferYang edited a comment on pull request #34620: [SPARK-37209][YARN][TESTS] Fix `YarnShuffleIntegrationSuite` releated UTs when using `hadoop-3.2` profile without `assembly/target

2021-11-20 Thread GitBox
LuciferYang edited a comment on pull request #34620: URL: https://github.com/apache/spark/pull/34620#issuecomment-974643612 > the hadoop-2.7 stacktrace looks like is due the hadoop-3.2 dependency somehow was incorrectly picked (since org.apache.hadoop.shaded.* should only be from 3.2

[GitHub] [spark] LuciferYang commented on pull request #34620: [SPARK-37209][YARN][TESTS] Fix `YarnShuffleIntegrationSuite` releated UTs when using `hadoop-3.2` profile without `assembly/target/scala-

2021-11-20 Thread GitBox
LuciferYang commented on pull request #34620: URL: https://github.com/apache/spark/pull/34620#issuecomment-974699508 > Is this OK to merge by itself and back port to ... 3.0? Yes -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #34668: [SPARK-37389][SQL] Check unclosed bracketed comments

2021-11-20 Thread GitBox
AmplabJenkins commented on pull request #34668: URL: https://github.com/apache/spark/pull/34668#issuecomment-974755306 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49952/ --

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34668: [SPARK-37389][SQL] Check unclosed bracketed comments

2021-11-20 Thread GitBox
AmplabJenkins removed a comment on pull request #34668: URL: https://github.com/apache/spark/pull/34668#issuecomment-974755306 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49952/

[GitHub] [spark] srowen commented on pull request #34620: [SPARK-37209][YARN][TESTS] Fix `YarnShuffleIntegrationSuite` releated UTs when using `hadoop-3.2` profile without `assembly/target/scala-%s/ja

2021-11-20 Thread GitBox
srowen commented on pull request #34620: URL: https://github.com/apache/spark/pull/34620#issuecomment-974695484 Is this OK to merge by itself and back port to ... 3.0? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [spark] AmplabJenkins commented on pull request #34674: [SPARK-37419][PYTHON][ML] Rewrite _shared_params_code_gen.py to inline type hints for ml/param/shared.py

2021-11-20 Thread GitBox
AmplabJenkins commented on pull request #34674: URL: https://github.com/apache/spark/pull/34674#issuecomment-974722003 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49951/ --

[GitHub] [spark] SparkQA commented on pull request #34610: [SPARK-34332][SQL][TEST] Unify v1 and v2 ALTER TABLE .. SET LOCATION tests

2021-11-20 Thread GitBox
SparkQA commented on pull request #34610: URL: https://github.com/apache/spark/pull/34610#issuecomment-974760014 **[Test build #145481 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145481/testReport)** for PR 34610 at commit

[GitHub] [spark] imback82 commented on a change in pull request #34610: [SPARK-34332][SQL][TEST] Unify v1 and v2 ALTER TABLE .. SET LOCATION tests

2021-11-20 Thread GitBox
imback82 commented on a change in pull request #34610: URL: https://github.com/apache/spark/pull/34610#discussion_r753744196 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala ## @@ -778,18 +778,6 @@ abstract class DDLSuite extends

[GitHub] [spark] SparkQA commented on pull request #34668: [SPARK-37389][SQL] Check unclosed bracketed comments

2021-11-20 Thread GitBox
SparkQA commented on pull request #34668: URL: https://github.com/apache/spark/pull/34668#issuecomment-974753720 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49952/ -- This is an automated message from the

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34674: [SPARK-37419][PYTHON][ML] Rewrite _shared_params_code_gen.py to inline type hints for ml/param/shared.py

2021-11-20 Thread GitBox
AmplabJenkins removed a comment on pull request #34674: URL: https://github.com/apache/spark/pull/34674#issuecomment-974722003 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49951/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34674: [SPARK-37419][PYTHON][ML] Rewrite _shared_params_code_gen.py to inline type hints for ml/param/shared.py

2021-11-20 Thread GitBox
AmplabJenkins removed a comment on pull request #34674: URL: https://github.com/apache/spark/pull/34674#issuecomment-974668773 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49949/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34620: [SPARK-37209][YARN][TESTS] Fix `YarnShuffleIntegrationSuite` releated UTs when using `hadoop-3.2` profile without `assembly/tar

2021-11-20 Thread GitBox
AmplabJenkins removed a comment on pull request #34620: URL: https://github.com/apache/spark/pull/34620#issuecomment-974668772 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49950/

[GitHub] [spark] AmplabJenkins commented on pull request #34674: [SPARK-37419][PYTHON][ML] Rewrite _shared_params_code_gen.py to inline type hints for ml/param/shared.py

2021-11-20 Thread GitBox
AmplabJenkins commented on pull request #34674: URL: https://github.com/apache/spark/pull/34674#issuecomment-974668773 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49949/ --

[GitHub] [spark] AmplabJenkins commented on pull request #34620: [SPARK-37209][YARN][TESTS] Fix `YarnShuffleIntegrationSuite` releated UTs when using `hadoop-3.2` profile without `assembly/target/scal

2021-11-20 Thread GitBox
AmplabJenkins commented on pull request #34620: URL: https://github.com/apache/spark/pull/34620#issuecomment-974668772 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49950/ --

[GitHub] [spark] SparkQA commented on pull request #34674: [SPARK-37419][PYTHON][ML] Rewrite _shared_params_code_gen.py to inline type hints for ml/param/shared.py

2021-11-20 Thread GitBox
SparkQA commented on pull request #34674: URL: https://github.com/apache/spark/pull/34674#issuecomment-974709701 **[Test build #145479 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145479/testReport)** for PR 34674 at commit

[GitHub] [spark] SparkQA commented on pull request #34668: [SPARK-37389][SQL] Check unclosed bracketed comments

2021-11-20 Thread GitBox
SparkQA commented on pull request #34668: URL: https://github.com/apache/spark/pull/34668#issuecomment-974745809 **[Test build #145480 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145480/testReport)** for PR 34668 at commit

[GitHub] [spark] LuciferYang commented on pull request #34620: [SPARK-37209][YARN][TESTS] Fix `YarnShuffleIntegrationSuite` releated UTs when using `hadoop-3.2` profile without `assembly/target/scala-

2021-11-20 Thread GitBox
LuciferYang commented on pull request #34620: URL: https://github.com/apache/spark/pull/34620#issuecomment-974673504 @srowen I tested the ``` mvn clean install -Phadoop-3.2 -Pyarn -Dtest=none -DwildcardSuites=org.apache.spark.deploy.yarn.YarnShuffleIntegrationSuite ```

[GitHub] [spark] LuciferYang edited a comment on pull request #34620: [SPARK-37209][YARN][TESTS] Fix `YarnShuffleIntegrationSuite` releated UTs when using `hadoop-3.2` profile without `assembly/target

2021-11-20 Thread GitBox
LuciferYang edited a comment on pull request #34620: URL: https://github.com/apache/spark/pull/34620#issuecomment-974673504 @srowen I tested the ``` mvn clean install -Phadoop-3.2 -Pyarn -Dtest=none -DwildcardSuites=org.apache.spark.deploy.yarn.YarnShuffleIntegrationSuite

[GitHub] [spark] SparkQA commented on pull request #34674: [SPARK-37419][PYTHON][ML] Rewrite _shared_params_code_gen.py to inline type hints for ml/param/shared.py

2021-11-20 Thread GitBox
SparkQA commented on pull request #34674: URL: https://github.com/apache/spark/pull/34674#issuecomment-974720622 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49951/ -- This is an automated message from the

[GitHub] [spark] imback82 commented on a change in pull request #34610: [SPARK-34332][SQL][TEST] Unify v1 and v2 ALTER TABLE .. SET LOCATION tests

2021-11-20 Thread GitBox
imback82 commented on a change in pull request #34610: URL: https://github.com/apache/spark/pull/34610#discussion_r753749487 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/AlterNamespaceSetLocationSuiteBase.scala ## @@ -0,0 +1,74 @@ +/* + *

[GitHub] [spark] srowen commented on pull request #34620: [SPARK-37209][YARN][TESTS] Fix `YarnShuffleIntegrationSuite` releated UTs when using `hadoop-3.2` profile without `assembly/target/scala-%s/ja

2021-11-20 Thread GitBox
srowen commented on pull request #34620: URL: https://github.com/apache/spark/pull/34620#issuecomment-974678905 Should we end up with this change and the servlet change backported to 3.0? would that seem to resolve the known issues? -- This is an automated message from the Apache Git

[GitHub] [spark] LuciferYang commented on pull request #34620: [SPARK-37209][YARN][TESTS] Fix `YarnShuffleIntegrationSuite` releated UTs when using `hadoop-3.2` profile without `assembly/target/scala-

2021-11-20 Thread GitBox
LuciferYang commented on pull request #34620: URL: https://github.com/apache/spark/pull/34620#issuecomment-974689759 Yes, servlet issue in branch-3.0 should be a known issue. I also test current pr on `branch-3.2`, `branch-3.1` and `branch-3.0`, for `branch-3.2` and `branch-3.1`,

[GitHub] [spark] SparkQA commented on pull request #34668: [SPARK-37389][SQL] Check unclosed bracketed comments

2021-11-20 Thread GitBox
SparkQA commented on pull request #34668: URL: https://github.com/apache/spark/pull/34668#issuecomment-974749286 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49952/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA removed a comment on pull request #34642: [SPARK-37369][SQL] Avoid redundant ColumnarToRow transistion on InMemoryTableScan

2021-11-20 Thread GitBox
SparkQA removed a comment on pull request #34642: URL: https://github.com/apache/spark/pull/34642#issuecomment-974587333 **[Test build #145474 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145474/testReport)** for PR 34642 at commit

[GitHub] [spark] SparkQA commented on pull request #34642: [SPARK-37369][SQL] Avoid redundant ColumnarToRow transistion on InMemoryTableScan

2021-11-20 Thread GitBox
SparkQA commented on pull request #34642: URL: https://github.com/apache/spark/pull/34642#issuecomment-974615129 **[Test build #145474 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145474/testReport)** for PR 34642 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #34642: [SPARK-37369][SQL] Avoid redundant ColumnarToRow transistion on InMemoryTableScan

2021-11-20 Thread GitBox
AmplabJenkins commented on pull request #34642: URL: https://github.com/apache/spark/pull/34642#issuecomment-974616963 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145474/ -- This

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34642: [SPARK-37369][SQL] Avoid redundant ColumnarToRow transistion on InMemoryTableScan

2021-11-20 Thread GitBox
AmplabJenkins removed a comment on pull request #34642: URL: https://github.com/apache/spark/pull/34642#issuecomment-974616963 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145474/

[GitHub] [spark] SparkQA removed a comment on pull request #34674: [SPARK-37419][PYTHON][ML] Rewrite _shared_params_code_gen.py to inline type hints for ml/param/shared.py

2021-11-20 Thread GitBox
SparkQA removed a comment on pull request #34674: URL: https://github.com/apache/spark/pull/34674#issuecomment-974647337 **[Test build #145476 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145476/testReport)** for PR 34674 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #34674: [SPARK-37419][PYTHON][ML] Rewrite _shared_params_code_gen.py to inline type hints for ml/param/shared.py

2021-11-20 Thread GitBox
AmplabJenkins commented on pull request #34674: URL: https://github.com/apache/spark/pull/34674#issuecomment-974652358 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145476/ -- This

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34674: [SPARK-37419][PYTHON][ML] Rewrite _shared_params_code_gen.py to inline type hints for ml/param/shared.py

2021-11-20 Thread GitBox
AmplabJenkins removed a comment on pull request #34674: URL: https://github.com/apache/spark/pull/34674#issuecomment-974652358 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145476/

[GitHub] [spark] SparkQA commented on pull request #34674: [SPARK-37419][PYTHON][ML] Rewrite _shared_params_code_gen.py to inline type hints for ml/param/shared.py

2021-11-20 Thread GitBox
SparkQA commented on pull request #34674: URL: https://github.com/apache/spark/pull/34674#issuecomment-974652446 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49948/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA commented on pull request #34620: [SPARK-37209][YARN][TESTS] Fix `YarnShuffleIntegrationSuite` releated UTs when using `hadoop-3.2` profile without `assembly/target/scala-%s/j

2021-11-20 Thread GitBox
SparkQA commented on pull request #34620: URL: https://github.com/apache/spark/pull/34620#issuecomment-974652798 **[Test build #145478 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145478/testReport)** for PR 34620 at commit

[GitHub] [spark] SparkQA commented on pull request #34674: [SPARK-37419][PYTHON][ML] Rewrite _shared_params_code_gen.py to inline type hints for ml/param/shared.py

2021-11-20 Thread GitBox
SparkQA commented on pull request #34674: URL: https://github.com/apache/spark/pull/34674#issuecomment-974652775 **[Test build #145477 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145477/testReport)** for PR 34674 at commit

[GitHub] [spark] srowen commented on a change in pull request #34604: [SPARK-37329][YARN] File system delegation tokens are leaked

2021-11-20 Thread GitBox
srowen commented on a change in pull request #34604: URL: https://github.com/apache/spark/pull/34604#discussion_r753678616 ## File path: core/src/main/scala/org/apache/spark/deploy/security/HadoopFSDelegationTokenProvider.scala ## @@ -145,6 +145,12 @@ private[deploy] class

[GitHub] [spark] SparkQA commented on pull request #34674: [SPARK-37419][PYTHON][ML] Rewrite _shared_params_code_gen.py to inline type hints for ml/param/shared.py

2021-11-20 Thread GitBox
SparkQA commented on pull request #34674: URL: https://github.com/apache/spark/pull/34674#issuecomment-974655597 **[Test build #145477 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145477/testReport)** for PR 34674 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #34674: [SPARK-37419][PYTHON][ML] Rewrite _shared_params_code_gen.py to inline type hints for ml/param/shared.py

2021-11-20 Thread GitBox
SparkQA removed a comment on pull request #34674: URL: https://github.com/apache/spark/pull/34674#issuecomment-974652775 **[Test build #145477 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145477/testReport)** for PR 34674 at commit

[GitHub] [spark] SparkQA commented on pull request #34620: [SPARK-37209][YARN][TESTS] Fix `YarnShuffleIntegrationSuite` releated UTs when using `hadoop-3.2` profile without `assembly/target/scala-%s/j

2021-11-20 Thread GitBox
SparkQA commented on pull request #34620: URL: https://github.com/apache/spark/pull/34620#issuecomment-974655912 **[Test build #145478 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145478/testReport)** for PR 34620 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #34620: [SPARK-37209][YARN][TESTS] Fix `YarnShuffleIntegrationSuite` releated UTs when using `hadoop-3.2` profile without `assembly/target/sc

2021-11-20 Thread GitBox
SparkQA removed a comment on pull request #34620: URL: https://github.com/apache/spark/pull/34620#issuecomment-974652798 **[Test build #145478 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145478/testReport)** for PR 34620 at commit

[GitHub] [spark] SparkQA commented on pull request #34674: [SPARK-37419][PYTHON][ML] Rewrite _shared_params_code_gen.py to inline type hints for ml/param/shared.py

2021-11-20 Thread GitBox
SparkQA commented on pull request #34674: URL: https://github.com/apache/spark/pull/34674#issuecomment-974657683 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49948/ -- This is an automated message from the

[GitHub] [spark] SparkQA commented on pull request #34674: [SPARK-37419][PYTHON][ML] Rewrite _shared_params_code_gen.py to inline type hints for ml/param/shared.py

2021-11-20 Thread GitBox
SparkQA commented on pull request #34674: URL: https://github.com/apache/spark/pull/34674#issuecomment-97465 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49949/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA commented on pull request #34620: [SPARK-37209][YARN][TESTS] Fix `YarnShuffleIntegrationSuite` releated UTs when using `hadoop-3.2` profile without `assembly/target/scala-%s/j

2021-11-20 Thread GitBox
SparkQA commented on pull request #34620: URL: https://github.com/apache/spark/pull/34620#issuecomment-974657769 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49950/ -- This is an automated message from the Apache

[GitHub] [spark] AmplabJenkins commented on pull request #34620: [SPARK-37209][YARN][TESTS] Fix `YarnShuffleIntegrationSuite` releated UTs when using `hadoop-3.2` profile without `assembly/target/scal

2021-11-20 Thread GitBox
AmplabJenkins commented on pull request #34620: URL: https://github.com/apache/spark/pull/34620#issuecomment-974659662 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145478/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #34674: [SPARK-37419][PYTHON][ML] Rewrite _shared_params_code_gen.py to inline type hints for ml/param/shared.py

2021-11-20 Thread GitBox
AmplabJenkins commented on pull request #34674: URL: https://github.com/apache/spark/pull/34674#issuecomment-974659663 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34674: [SPARK-37419][PYTHON][ML] Rewrite _shared_params_code_gen.py to inline type hints for ml/param/shared.py

2021-11-20 Thread GitBox
AmplabJenkins removed a comment on pull request #34674: URL: https://github.com/apache/spark/pull/34674#issuecomment-974659661 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34620: [SPARK-37209][YARN][TESTS] Fix `YarnShuffleIntegrationSuite` releated UTs when using `hadoop-3.2` profile without `assembly/tar

2021-11-20 Thread GitBox
AmplabJenkins removed a comment on pull request #34620: URL: https://github.com/apache/spark/pull/34620#issuecomment-974659662 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145478/

[GitHub] [spark] sathiyapk commented on pull request #34593: [SPARK-37324][SQL] Adds support for decimal rounding mode up, down, half_down

2021-11-20 Thread GitBox
sathiyapk commented on pull request #34593: URL: https://github.com/apache/spark/pull/34593#issuecomment-974659848 @HyukjinKwon May I know the status of this PR please ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] SparkQA commented on pull request #34674: [SPARK-37419][PYTHON][ML] Rewrite _shared_params_code_gen.py to inline type hints for ml/param/shared.py

2021-11-20 Thread GitBox
SparkQA commented on pull request #34674: URL: https://github.com/apache/spark/pull/34674#issuecomment-974663430 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49949/ -- This is an automated message from the

[GitHub] [spark] SparkQA commented on pull request #34620: [SPARK-37209][YARN][TESTS] Fix `YarnShuffleIntegrationSuite` releated UTs when using `hadoop-3.2` profile without `assembly/target/scala-%s/j

2021-11-20 Thread GitBox
SparkQA commented on pull request #34620: URL: https://github.com/apache/spark/pull/34620#issuecomment-974663756 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49950/ -- This is an automated message from the

[GitHub] [spark] LuciferYang commented on pull request #34620: [SPARK-37209][YARN][TESTS] Fix `YarnShuffleIntegrationSuite` releated UTs when using `hadoop-3.2` profile without `assembly/target/scala-

2021-11-20 Thread GitBox
LuciferYang commented on pull request #34620: URL: https://github.com/apache/spark/pull/34620#issuecomment-974663690 @sunchao I think run ``` mvn clean install -Phadoop-3.2 -Pyarn -Dtest=none -DwildcardSuites=org.apache.spark.deploy.yarn.YarnShuffleIntegrationSuite

[GitHub] [spark] sarutak commented on a change in pull request #34607: [SPARK-36038][CORE] Speculation metrics summary at stage level

2021-11-20 Thread GitBox
sarutak commented on a change in pull request #34607: URL: https://github.com/apache/spark/pull/34607#discussion_r753684507 ## File path: core/src/main/scala/org/apache/spark/status/storeTypes.scala ## @@ -399,6 +399,20 @@ private[spark] class ExecutorStageSummaryWrapper( }

[GitHub] [spark] SparkQA commented on pull request #34673: [WIP][SPARK-37343][SQL] Implement createIndex, IndexExists and dropIndex in JDBC (Postgres dialect)

2021-11-20 Thread GitBox
SparkQA commented on pull request #34673: URL: https://github.com/apache/spark/pull/34673#issuecomment-974627366 **[Test build #145475 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145475/testReport)** for PR 34673 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #34673: [WIP][SPARK-37343][SQL] Implement createIndex, IndexExists and dropIndex in JDBC (Postgres dialect)

2021-11-20 Thread GitBox
SparkQA removed a comment on pull request #34673: URL: https://github.com/apache/spark/pull/34673#issuecomment-974599139 **[Test build #145475 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145475/testReport)** for PR 34673 at commit

[GitHub] [spark] LuciferYang commented on pull request #34620: [SPARK-37209][YARN][TESTS] Fix `YarnShuffleIntegrationSuite` releated UTs when using `hadoop-3.2` profile without `assembly/target/scala-

2021-11-20 Thread GitBox
LuciferYang commented on pull request #34620: URL: https://github.com/apache/spark/pull/34620#issuecomment-974643077 > @LuciferYang What is the stacktrace from hadoop-3.2 profile? is it the same as the one in the PR description? @sunchao Yes, it's same as the one in the PR

[GitHub] [spark] LuciferYang commented on pull request #34620: [SPARK-37209][YARN][TESTS] Fix `YarnShuffleIntegrationSuite` releated UTs when using `hadoop-3.2` profile without `assembly/target/scala-

2021-11-20 Thread GitBox
LuciferYang commented on pull request #34620: URL: https://github.com/apache/spark/pull/34620#issuecomment-974643612 > the hadoop-2.7 stacktrace looks like is due the hadoop-3.2 dependency somehow was incorrectly picked (since org.apache.hadoop.shaded.* should only be from 3.2 profile.)

[GitHub] [spark] LuciferYang commented on pull request #34648: [SPARK-37282][TESTS][FOLLOWUP] Extract `Utils.isMacOnAppleSilicon` for reuse in UTs

2021-11-20 Thread GitBox
LuciferYang commented on pull request #34648: URL: https://github.com/apache/spark/pull/34648#issuecomment-974644902 thanks all -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] SparkQA commented on pull request #34674: [SPARK-37419][PYTHON][ML] Rewrite _shared_params_code_gen.py to inline type hints for ml/param/shared.py

2021-11-20 Thread GitBox
SparkQA commented on pull request #34674: URL: https://github.com/apache/spark/pull/34674#issuecomment-974647337 **[Test build #145476 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145476/testReport)** for PR 34674 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #34673: [WIP][SPARK-37343][SQL] Implement createIndex, IndexExists and dropIndex in JDBC (Postgres dialect)

2021-11-20 Thread GitBox
AmplabJenkins commented on pull request #34673: URL: https://github.com/apache/spark/pull/34673#issuecomment-974630135 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145475/ -- This

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34673: [WIP][SPARK-37343][SQL] Implement createIndex, IndexExists and dropIndex in JDBC (Postgres dialect)

2021-11-20 Thread GitBox
AmplabJenkins removed a comment on pull request #34673: URL: https://github.com/apache/spark/pull/34673#issuecomment-974630135 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145475/

[GitHub] [spark] zero323 closed pull request #34669: [SPARK-37390][PYTHON][DOCS] Add default value to getattr(app, add_javascript)

2021-11-20 Thread GitBox
zero323 closed pull request #34669: URL: https://github.com/apache/spark/pull/34669 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [spark] zero323 commented on pull request #34669: [SPARK-37390][PYTHON][DOCS] Add default value to getattr(app, add_javascript)

2021-11-20 Thread GitBox
zero323 commented on pull request #34669: URL: https://github.com/apache/spark/pull/34669#issuecomment-974630664 Merged into master, branch-3.2, branch-3.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [spark] zero323 opened a new pull request #34674: [SPARK-37419][PYTHON][ML] Rewrite _shared_params_code_gen.py to inline type hints for ml/param/shared.py

2021-11-20 Thread GitBox
zero323 opened a new pull request #34674: URL: https://github.com/apache/spark/pull/34674 ### What changes were proposed in this pull request? This PR modifies `_shared_params_code_gen.py ` to include type hints in generated code. Additionally, it applies minor

[GitHub] [spark] SparkQA commented on pull request #34674: [SPARK-37419][PYTHON][ML] Rewrite _shared_params_code_gen.py to inline type hints for ml/param/shared.py

2021-11-20 Thread GitBox
SparkQA commented on pull request #34674: URL: https://github.com/apache/spark/pull/34674#issuecomment-974649042 **[Test build #145476 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145476/testReport)** for PR 34674 at commit