[GitHub] spark pull request: [SPARK-3560] Fixed setting spark.jars system p...

2014-09-18 Thread Victsm
GitHub user Victsm opened a pull request: https://github.com/apache/spark/pull/2449 [SPARK-3560] Fixed setting spark.jars system property in yarn-cluster mode You can merge this pull request into a Git repository by running: $ git pull https://github.com/Victsm/spark SPARK

[GitHub] spark pull request: [SPARK-3560] Fixed setting spark.jars system p...

2014-09-18 Thread Victsm
Github user Victsm commented on the pull request: https://github.com/apache/spark/pull/2449#issuecomment-56105298 @vanzin The --jars will still work in YARN cluster mode through the distributed cache. Removing the spark.jars system property only prevents the HttpFileServer mechanism

[GitHub] spark pull request: [SPARK-3560] Fixed setting spark.jars system p...

2014-09-18 Thread Victsm
Github user Victsm commented on the pull request: https://github.com/apache/spark/pull/2449#issuecomment-56115620 @andrewor14 My JIRA account is mshen. That issues has just been closed. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request #21402: SPARK-24335 Spark external shuffle server improve...

2018-05-22 Thread Victsm
GitHub user Victsm opened a pull request: https://github.com/apache/spark/pull/21402 SPARK-24335 Spark external shuffle server improvement to better handle block fetch requests. ## What changes were proposed in this pull request? Right now, the default server

[GitHub] spark issue #21402: SPARK-24355 Spark external shuffle server improvement to...

2018-05-23 Thread Victsm
Github user Victsm commented on the issue: https://github.com/apache/spark/pull/21402 `StreamRequest` will not block the server netty handler thread. Only `ChunkFetchRequest` does, as this request is the one that actually triggers seeking the disk to return the shuffle block to the

[GitHub] spark issue #21402: SPARK-24355 Spark external shuffle server improvement to...

2018-05-23 Thread Victsm
Github user Victsm commented on the issue: https://github.com/apache/spark/pull/21402 Using a percentage to configure the number of threads to handle chunk fetch requests does make sense. Will update the PR for this change

[GitHub] spark issue #21402: SPARK-24355 Spark external shuffle server improvement to...

2018-05-24 Thread Victsm
Github user Victsm commented on the issue: https://github.com/apache/spark/pull/21402 @felixcheung Adding these metrics are indeed things we have been working on recently. I'd prefer to propose it in a separate t

[GitHub] spark pull request #19839: SPARK-22373 Bump Janino dependency version to fix...

2017-11-28 Thread Victsm
GitHub user Victsm opened a pull request: https://github.com/apache/spark/pull/19839 SPARK-22373 Bump Janino dependency version to fix thread safety issue… … with Janino when compiling generated code. ## What changes were proposed in this pull request? Bump up

[GitHub] spark issue #19839: SPARK-22373 Bump Janino dependency version to fix thread...

2017-11-30 Thread Victsm
Github user Victsm commented on the issue: https://github.com/apache/spark/pull/19839 @srowen @kiszk @mgaido91 Is this patch ready to merge? --- - To unsubscribe, e-mail: reviews-unsubscr

[GitHub] spark pull request #18801: SPARK-10878 Fix race condition when multiple clie...

2017-08-01 Thread Victsm
GitHub user Victsm opened a pull request: https://github.com/apache/spark/pull/18801 SPARK-10878 Fix race condition when multiple clients resolves artifacts at the same time ## What changes were proposed in this pull request? When multiple clients attempt to resolve

[GitHub] spark issue #18801: SPARK-10878 Fix race condition when multiple clients res...

2017-08-08 Thread Victsm
Github user Victsm commented on the issue: https://github.com/apache/spark/pull/18801 @jiangxb1987 @kiszk Thanks for the review. Will update the PR shortly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If