[GitHub] spark pull request #16746: [SPARK-15648][SQL] Add teradataDialect for JDBC c...

Github user klinvill commented on a diff in the pull request: https://github.com/apache/spark/pull/16746#discussion_r98814211 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/TeradataDialect.scala --- @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software

[GitHub] spark issue #16746: [SPARK-15648][SQL] Add teradataDialect for JDBC connecti...

Github user klinvill commented on the issue: https://github.com/apache/spark/pull/16746 @dongjoon-hyun Yup, I was using a real instance for testing. The best way to test without a real instance is probably going to be using the Teradata Express vm: http://downloads.teradata.com

[GitHub] spark pull request #16746: [SPARK-15648][SQL] Add teradataDialect for JDBC c...

Github user klinvill commented on a diff in the pull request: https://github.com/apache/spark/pull/16746#discussion_r98710451 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/TeradataDialect.scala --- @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #16746: [SPARK-15648][SQL] Add teradataDialect for JDBC c...

Github user klinvill commented on a diff in the pull request: https://github.com/apache/spark/pull/16746#discussion_r98706364 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/TeradataDialect.scala --- @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software

[GitHub] spark issue #16746: [SPARK-15648][SQL] Add teradataDialect for JDBC connecti...

Github user klinvill commented on the issue: https://github.com/apache/spark/pull/16746 Unfortunately I don't think there's a docker image for Teradata available yet. They do have the VM version and an AMI. Would either of those be sufficient? --- If your project is set up

[GitHub] spark pull request #16746: [SPARK-15648][SQL] Add teradataDialect for JDBC c...

GitHub user klinvill opened a pull request: https://github.com/apache/spark/pull/16746 [SPARK-15648][SQL] Add teradataDialect for JDBC connection to Teradata The contribution is my original work and I license the work to the project under the project’s open source license

[GitHub] spark issue #16746: [SPARK-15648][SQL] Add teradataDialect for JDBC connecti...

Github user klinvill commented on the issue: https://github.com/apache/spark/pull/16746 I just tested it manually with a Teradata instance I have running. I didn't test it too extensively other than making sure that a write to a teradata table using a string datatype was working

[GitHub] spark issue #16746: [SPARK-15648][SQL] Add teradataDialect for JDBC connecti...

Github user klinvill commented on the issue: https://github.com/apache/spark/pull/16746 Hi @dongjoon-hyun @gatorsmile, just circling back. Is it going to be impractical to check the PR against a VM rather than against a docker image? --- If your project is set up for it, you can

[GitHub] spark issue #16746: [SPARK-15648][SQL] Add teradataDialect for JDBC connecti...

Github user klinvill commented on the issue: https://github.com/apache/spark/pull/16746 Thanks for the help and review! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request #20057: [SPARK-22880][SQL] Add cascadeTruncate option to ...

Github user klinvill commented on a diff in the pull request: https://github.com/apache/spark/pull/20057#discussion_r169526767 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/TeradataDialect.scala --- @@ -31,4 +31,19 @@ private case object TeradataDialect extends