Github user xflin commented on the issue:
https://github.com/apache/spark/pull/9518
I think I've done all I can at this point. Anyone with permission wants to
bless it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user xflin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9518#discussion_r124882926
--- Diff:
core/src/main/scala/org/apache/spark/metrics/sink/StatsdReporter.scala ---
@@ -0,0 +1,167 @@
+/*
+ * Licensed to the Apache Software
Github user xflin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9518#discussion_r124883621
--- Diff:
core/src/test/scala/org/apache/spark/metrics/sink/StatsdSinkSuite.scala ---
@@ -0,0 +1,161 @@
+/*
+ * Licensed to the Apache Software
Github user xflin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9518#discussion_r124883764
--- Diff:
core/src/main/scala/org/apache/spark/metrics/sink/StatsdReporter.scala ---
@@ -0,0 +1,167 @@
+/*
+ * Licensed to the Apache Software
GitHub user xflin opened a pull request:
https://github.com/apache/spark/pull/9518
Add metrics StatsD sink
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xflin/spark statsd
Alternatively you can review and apply these changes
Github user xflin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9518#discussion_r47201120
--- Diff:
core/src/main/scala/org/apache/spark/metrics/sink/StatsdReporter.scala ---
@@ -0,0 +1,143 @@
+/*
+ * Licensed to the Apache Software
Github user xflin commented on the pull request:
https://github.com/apache/spark/pull/9518#issuecomment-163536015
I'll try to add some tests (following hadoop-common's test example).
---
If your project is set up for it, you can reply to this email and have your
reply
Github user xflin commented on the pull request:
https://github.com/apache/spark/pull/9518#issuecomment-164114988
StatsdSink unit tests have been added.
I've also tested the patch on a spark v1.5.2 deployment with datadog agent
installed. Datadog agent contains a (sli
Github user xflin commented on the pull request:
https://github.com/apache/spark/pull/9518#issuecomment-174412303
I've adjusted parameter wrappings and import orderings. Ran through "sbt
stylecheck" and "sbt test:stylecheck" on the three scala files, no
Github user xflin commented on the issue:
https://github.com/apache/spark/pull/9518
@jerryshao I believe all comments have been addressed. If you agree, would
you hep merge the PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user xflin commented on the issue:
https://github.com/apache/spark/pull/9518
The build error was caused by the change of `org.apache.spark.Logging` to
`org.apache.spark.internal.Logging`. The fix is on the way.
---
If your project is set up for it, you can reply to this
Github user xflin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9518#discussion_r123627980
--- Diff:
core/src/main/scala/org/apache/spark/metrics/sink/StatsdReporter.scala ---
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache Software
Github user xflin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9518#discussion_r123628327
--- Diff:
core/src/main/scala/org/apache/spark/metrics/sink/StatsdReporter.scala ---
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache Software
Github user xflin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9518#discussion_r123628385
--- Diff:
core/src/main/scala/org/apache/spark/metrics/sink/StatsdReporter.scala ---
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache Software
Github user xflin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9518#discussion_r123628448
--- Diff:
core/src/main/scala/org/apache/spark/metrics/sink/StatsdReporter.scala ---
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache Software
Github user xflin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9518#discussion_r123856570
--- Diff:
core/src/test/scala/org/apache/spark/metrics/sink/StatsdSinkSuite.scala ---
@@ -0,0 +1,159 @@
+/*
+ * Licensed to the Apache Software
Github user xflin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9518#discussion_r123856611
--- Diff:
core/src/test/scala/org/apache/spark/metrics/sink/StatsdSinkSuite.scala ---
@@ -0,0 +1,159 @@
+/*
+ * Licensed to the Apache Software
Github user xflin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9518#discussion_r123857033
--- Diff:
core/src/main/scala/org/apache/spark/metrics/sink/StatsdReporter.scala ---
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache Software
Github user xflin commented on the issue:
https://github.com/apache/spark/pull/9518
Well, the unit test indeed passed. Some other (not related) test failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
19 matches
Mail list logo
