[GitHub] [spark] BryanCutler commented on issue #25749: [SPARK-29041][PYTHON] Allows createDataFrame to accept bytes as binary type
BryanCutler commented on issue #25749: [SPARK-29041][PYTHON] Allows createDataFrame to accept bytes as binary type URL: https://github.com/apache/spark/pull/25749#issuecomment-551346841 > what do you think of adding auto inferring BinaryType for bytes, but only in python3 I think this is the correct thing to do. What type is inferred now for python3 with bytes? @HyukjinKwon is this a breaking change only for Python2? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] BryanCutler commented on issue #25749: [SPARK-29041][PYTHON] Allows createDataFrame to accept bytes as binary type
BryanCutler commented on issue #25749: [SPARK-29041][PYTHON] Allows createDataFrame to accept bytes as binary type URL: https://github.com/apache/spark/pull/25749#issuecomment-530565191 @HyukjinKwon I think it was by design to only accept `bytearray` and not `bytes` in pyspark - possibly to avoid `str` mixup with Python 2. So I'm not sure if it is should be backported... Otherwise, I think this is fine to allow `bytes` if the user specifies a binary column. And once support for Python2 is dropped, it could be inferred also. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
