[GitHub] [spark] EnricoMi commented on a diff in pull request #38312: [SPARK-40819][SQL] Timestamp nanos behaviour regression

2023-02-03 Thread via GitHub
EnricoMi commented on code in PR #38312: URL: https://github.com/apache/spark/pull/38312#discussion_r1095704158 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetSchemaConverter.scala: ## @@ -49,24 +49,28 @@ import org.apache.spark.sql.types._

[GitHub] [spark] EnricoMi commented on a diff in pull request #38312: [SPARK-40819][SQL] Timestamp nanos behaviour regression

2023-02-03 Thread via GitHub
EnricoMi commented on code in PR #38312: URL: https://github.com/apache/spark/pull/38312#discussion_r1095651650 ## sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala: ## @@ -4946,6 +4953,8 @@ class SQLConf extends Serializable with Logging { def

[GitHub] [spark] EnricoMi commented on a diff in pull request #38312: [SPARK-40819][SQL] Timestamp nanos behaviour regression

2022-11-17 Thread GitBox
EnricoMi commented on code in PR #38312: URL: https://github.com/apache/spark/pull/38312#discussion_r1025422089 ## sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetSchemaSuite.scala: ## @@ -1040,6 +1040,14 @@ class ParquetSchemaSuite extends

[GitHub] [spark] EnricoMi commented on a diff in pull request #38312: [SPARK-40819][SQL] Timestamp nanos behaviour regression

2022-11-17 Thread GitBox
EnricoMi commented on code in PR #38312: URL: https://github.com/apache/spark/pull/38312#discussion_r1025413969 ## sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetSchemaSuite.scala: ## @@ -1040,6 +1040,14 @@ class ParquetSchemaSuite extends

[GitHub] [spark] EnricoMi commented on a diff in pull request #38312: [SPARK-40819][SQL] Timestamp nanos behaviour regression

2022-11-17 Thread GitBox
EnricoMi commented on code in PR #38312: URL: https://github.com/apache/spark/pull/38312#discussion_r1025407302 ## sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetSchemaSuite.scala: ## @@ -1040,6 +1040,14 @@ class ParquetSchemaSuite extends

[GitHub] [spark] EnricoMi commented on a diff in pull request #38312: [SPARK-40819][SQL] Timestamp nanos behaviour regression

2022-11-09 Thread GitBox
EnricoMi commented on code in PR #38312: URL: https://github.com/apache/spark/pull/38312#discussion_r1017736181 ## sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetSchemaSuite.scala: ## @@ -198,6 +205,31 @@ abstract class ParquetSchemaTest

[GitHub] [spark] EnricoMi commented on a diff in pull request #38312: [SPARK-40819][SQL] Timestamp nanos behaviour regression

2022-10-24 Thread GitBox
EnricoMi commented on code in PR #38312: URL: https://github.com/apache/spark/pull/38312#discussion_r1002966819 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetSchemaConverter.scala: ## @@ -271,6 +271,10 @@ class

[GitHub] [spark] EnricoMi commented on a diff in pull request #38312: [SPARK-40819][SQL] Timestamp nanos behaviour regression

2022-10-24 Thread GitBox
EnricoMi commented on code in PR #38312: URL: https://github.com/apache/spark/pull/38312#discussion_r1002966819 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetSchemaConverter.scala: ## @@ -271,6 +271,10 @@ class

[GitHub] [spark] EnricoMi commented on a diff in pull request #38312: [SPARK-40819][SQL] Timestamp nanos behaviour regression

2022-10-21 Thread GitBox
EnricoMi commented on code in PR #38312: URL: https://github.com/apache/spark/pull/38312#discussion_r1001531184 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetSchemaConverter.scala: ## @@ -271,6 +271,8 @@ class

[GitHub] [spark] EnricoMi commented on a diff in pull request #38312: [SPARK-40819][SQL] Timestamp nanos behaviour regression

2022-10-20 Thread GitBox
EnricoMi commented on code in PR #38312: URL: https://github.com/apache/spark/pull/38312#discussion_r1001088325 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetSchemaConverter.scala: ## @@ -271,6 +271,8 @@ class