[GitHub] [spark] HeartSaVioR commented on issue #27996: [SPARK-31101][BUILD][3.0] Upgrade Janino to 3.0.16
HeartSaVioR commented on issue #27996: [SPARK-31101][BUILD][3.0] Upgrade Janino to 3.0.16 URL: https://github.com/apache/spark/pull/27996#issuecomment-603679883 Thanks all for reviewing and merging! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on issue #27996: [SPARK-31101][BUILD][3.0] Upgrade Janino to 3.0.16
HeartSaVioR commented on issue #27996: [SPARK-31101][BUILD][3.0] Upgrade Janino to 3.0.16 URL: https://github.com/apache/spark/pull/27996#issuecomment-603613705 I've added the UT in the description of PR. If we would like to avoid regression I can add UT as well, but the threshold might depend on the code change (the values are different between branch-3.0/master and branch-2.4) and the test can fail with other reason (beyond 64KB) so I'm not sure we want to add it to the codebase. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on issue #27996: [SPARK-31101][BUILD][3.0] Upgrade Janino to 3.0.16
HeartSaVioR commented on issue #27996: [SPARK-31101][BUILD][3.0] Upgrade Janino to 3.0.16 URL: https://github.com/apache/spark/pull/27996#issuecomment-603162856 retest this, please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on issue #27996: [SPARK-31101][BUILD][3.0] Upgrade Janino to 3.0.16
HeartSaVioR commented on issue #27996: [SPARK-31101][BUILD][3.0] Upgrade Janino to 3.0.16 URL: https://github.com/apache/spark/pull/27996#issuecomment-603076273 retest this, please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
