[GitHub] [spark] HyukjinKwon commented on a change in pull request #28322: [SPARK-31550][SQL][DOCS] Set nondeterministic configurations with general meanings in sql configuration doc

2020-04-25 Thread GitBox 


HyukjinKwon commented on a change in pull request #28322:
URL: https://github.com/apache/spark/pull/28322#discussion_r415200619



##
File path: 
sql/core/src/main/scala/org/apache/spark/sql/api/python/PythonSQLUtils.scala
##
@@ -40,17 +40,27 @@ private[sql] object PythonSQLUtils {
 FunctionRegistry.functionSet.flatMap(f => 
FunctionRegistry.builtin.lookupFunction(f)).toArray
   }
 
-  def listSQLConfigs(): Array[(String, String, String, String)] = {
+  private def listAllSQLConfigs(): Seq[(String, String, String, String)] = {
 val conf = new SQLConf()
+// Force to build static SQL configurations
+StaticSQLConf
+// set nondeterministic configurations with general meanings
+conf.getAllDefinedConfs.map {
+  case p @ (SQLConf.SESSION_LOCAL_TIMEZONE.key, _, _, _) =>
+p.copy(_2 = "value of local timezone")
+  case p @ (StaticSQLConf.WAREHOUSE_PATH.key, _, _, _) =>
+p.copy(_2 = "value of $PWD/spark-warehouse")
+  case o => o
+}

Review comment:
   Yeah, let's handle it in Python script.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28322: [SPARK-31550][SQL][DOCS] Set nondeterministic configurations with general meanings in sql configuration doc

2020-04-25 Thread GitBox 


HyukjinKwon commented on a change in pull request #28322:
URL: https://github.com/apache/spark/pull/28322#discussion_r415200272



##
File path: 
sql/core/src/main/scala/org/apache/spark/sql/api/python/PythonSQLUtils.scala
##
@@ -40,17 +40,27 @@ private[sql] object PythonSQLUtils {
 FunctionRegistry.functionSet.flatMap(f => 
FunctionRegistry.builtin.lookupFunction(f)).toArray
   }
 
-  def listSQLConfigs(): Array[(String, String, String, String)] = {
+  private def listAllSQLConfigs(): Seq[(String, String, String, String)] = {
 val conf = new SQLConf()
+// Force to build static SQL configurations
+StaticSQLConf
+// set nondeterministic configurations with general meanings
+conf.getAllDefinedConfs.map {
+  case p @ (SQLConf.SESSION_LOCAL_TIMEZONE.key, _, _, _) =>

Review comment:
   nit: I would do p if `case p if p.key == SESSION_LOCAL_TIMEZONE.key =>`





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org