[GitHub] [spark] HyukjinKwon commented on pull request #28723: [SPARK-28624][SQL][TESTS][3.0] Run date.sql via Thrift Server

2020-06-05 Thread GitBox


HyukjinKwon commented on pull request #28723:
URL: https://github.com/apache/spark/pull/28723#issuecomment-639285714


   I discussed with @MaxGekk @cloud-fan. The tests will have to be disabled 
back at SPARK-30808. Basically, resulting to `0045-03-15` itself is actually 
controversial.
   
   We strictly _can just merge_ and enable it for Spark 3.0 specifically 
because SPARK-30808 won't land to `branch-3.0` but let me just don't merge this 
for simplicity.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] HyukjinKwon commented on pull request #28723: [SPARK-28624][SQL][TESTS][3.0] Run date.sql via Thrift Server

2020-06-04 Thread GitBox


HyukjinKwon commented on pull request #28723:
URL: https://github.com/apache/spark/pull/28723#issuecomment-638634561


   Let's cut out RC3 first and then merge.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] HyukjinKwon commented on pull request #28723: [SPARK-28624][SQL][TESTS][3.0] Run date.sql via Thrift Server

2020-06-03 Thread GitBox


HyukjinKwon commented on pull request #28723:
URL: https://github.com/apache/spark/pull/28723#issuecomment-638608705


   Looks good if the tests pass. WDYT can you point out which change fixed this 
if you already know?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org