[GitHub] [spark] HyukjinKwon edited a comment on issue #27989: [SPARK-31228][DSTREAMS] Add version information to the configuration of Kafka

2020-03-25 Thread GitBox
HyukjinKwon edited a comment on issue #27989: [SPARK-31228][DSTREAMS] Add 
version information to the configuration of Kafka
URL: https://github.com/apache/spark/pull/27989#issuecomment-604208560
 
 
   Is it an option instead of configuration? If that's the case, let's document 
it separately in a separate PR. Sure, it should be best to document the 
versions added.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] HyukjinKwon edited a comment on issue #27989: [SPARK-31228][DSTREAMS] Add version information to the configuration of Kafka

2020-03-25 Thread GitBox
HyukjinKwon edited a comment on issue #27989: [SPARK-31228][DSTREAMS] Add 
version information to the configuration of Kafka
URL: https://github.com/apache/spark/pull/27989#issuecomment-604207880
 
 
   Oh, okay, about options right? Sure, it's best to add the versions I guess. 
Let's do it separately though technically documenting versions in options are 
orthogonal to documenting in configurations.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org