Ngone51 commented on a change in pull request #27217: [SPARK-30518] Precision and scale should be same for values between -1.0 and 1.0 in Decimal URL: https://github.com/apache/spark/pull/27217#discussion_r367193098
########## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ArithmeticExpressionSuite.scala ########## @@ -409,9 +409,9 @@ class ArithmeticExpressionSuite extends SparkFunSuite with ExpressionEvalHelper test("SPARK-28322: IntegralDivide supports decimal type") { withSQLConf(SQLConf.LEGACY_INTEGRALDIVIDE_RETURN_LONG.key -> "false") { checkEvaluation(IntegralDivide(Literal(Decimal(1)), Literal(Decimal(2))), Decimal(0)) - checkEvaluation(IntegralDivide(Literal(Decimal(1.4)), Literal(Decimal(0.6))), Decimal(2)) Review comment: No. `IntegralDivide` requires same data type for left and right. And the type of `Literal(Decimal(0.6))` has changed from `DecimalType(2, 1)` to `DecimalType(1, 1)`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org