[GitHub] [spark] Ngone51 commented on a change in pull request #28014: [SPARK-31242][SQL][TEST] mergeSparkConf in WithTestConf should also respect spark.sql.legacy.sessionInitWithConfigDefaults
Ngone51 commented on a change in pull request #28014: [SPARK-31242][SQL][TEST]
mergeSparkConf in WithTestConf should also respect
spark.sql.legacy.sessionInitWithConfigDefaults
URL: https://github.com/apache/spark/pull/28014#discussion_r397701478
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala
##
@@ -780,5 +780,14 @@ class AdaptiveQueryExecSuite
}
}
}
+
+ test("SPARK-31242: clone SparkSession should respect
sessionInitWithConfigDefaults") {
Review comment:
sounds good.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] Ngone51 commented on a change in pull request #28014: [SPARK-31242][SQL][TEST] mergeSparkConf in WithTestConf should also respect spark.sql.legacy.sessionInitWithConfigDefaults
Ngone51 commented on a change in pull request #28014: [SPARK-31242][SQL][TEST]
mergeSparkConf in WithTestConf should also respect
spark.sql.legacy.sessionInitWithConfigDefaults
URL: https://github.com/apache/spark/pull/28014#discussion_r397628164
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala
##
@@ -780,5 +780,14 @@ class AdaptiveQueryExecSuite
}
}
}
+
+ test("SPARK-31242: clone SparkSession should respect
sessionInitWithConfigDefaults") {
Review comment:
I know it's not directly related to AQE. But the issue can not be reproduced
without `SharedSparkSessionBase` and seems AQE now is more likely related to
`cloneSession`. So I decide to add it here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
