[GitHub] [spark] Ngone51 commented on issue #26736: [SPARK-30098][SQL] Use default datasource as provider for CREATE TABLE syntax
Ngone51 commented on issue #26736: [SPARK-30098][SQL] Use default datasource as provider for CREATE TABLE syntax URL: https://github.com/apache/spark/pull/26736#issuecomment-562832661 thanks a lot! @cloud-fan This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] Ngone51 commented on issue #26736: [SPARK-30098][SQL] Use default datasource as provider for CREATE TABLE syntax
Ngone51 commented on issue #26736: [SPARK-30098][SQL] Use default datasource as provider for CREATE TABLE syntax URL: https://github.com/apache/spark/pull/26736#issuecomment-561638982 Jenkins, retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] Ngone51 commented on issue #26736: [SPARK-30098][SQL] Use default datasource as provider for CREATE TABLE syntax
Ngone51 commented on issue #26736: [SPARK-30098][SQL] Use default datasource as provider for CREATE TABLE syntax URL: https://github.com/apache/spark/pull/26736#issuecomment-561158800 ***Review note:*** A bunch of tests referenced the table created in `TestHive.scala`: https://github.com/apache/spark/blob/abba53e78b5556016a9d6935cfc65a9299a78977/sql/hive/src/test/scala/org/apache/spark/sql/hive/test/TestHive.scala#L324-L332 And those test tables are migrated from Hive directly. So, in this case, we simply use legacy mode (create hive table by default) for those tests. For other tests, we append `USING hive` or `STORED AS` to make sure that they can match `#createHiveTable` parser rule. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] Ngone51 commented on issue #26736: [SPARK-30098][SQL] Use default datasource as provider for CREATE TABLE syntax
Ngone51 commented on issue #26736: [SPARK-30098][SQL] Use default datasource as provider for CREATE TABLE syntax URL: https://github.com/apache/spark/pull/26736#issuecomment-560369892 cc @cloud-fan @gatorsmile This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
