[GitHub] [spark] Yikun commented on a diff in pull request #36464: [SPARK-38947][PYTHON] Supports groupby positional indexing

2022-05-16 Thread GitBox
Yikun commented on code in PR #36464: URL: https://github.com/apache/spark/pull/36464#discussion_r873426625 ## python/pyspark/pandas/groupby.py: ## @@ -2110,22 +2110,79 @@ def _limit(self, n: int, asc: bool) -> FrameLike: groupkey_scols =

[GitHub] [spark] Yikun commented on a diff in pull request #36464: [SPARK-38947][PYTHON] Supports groupby positional indexing

2022-05-16 Thread GitBox
Yikun commented on code in PR #36464: URL: https://github.com/apache/spark/pull/36464#discussion_r873437306 ## python/pyspark/pandas/groupby.py: ## @@ -2110,22 +2110,60 @@ def _limit(self, n: int, asc: bool) -> FrameLike: groupkey_scols =

[GitHub] [spark] Yikun commented on a diff in pull request #36464: [SPARK-38947][PYTHON] Supports groupby positional indexing

2022-05-16 Thread GitBox
Yikun commented on code in PR #36464: URL: https://github.com/apache/spark/pull/36464#discussion_r873437306 ## python/pyspark/pandas/groupby.py: ## @@ -2110,22 +2110,60 @@ def _limit(self, n: int, asc: bool) -> FrameLike: groupkey_scols =

[GitHub] [spark] Yikun commented on a diff in pull request #36464: [SPARK-38947][PYTHON] Supports groupby positional indexing

2022-05-16 Thread GitBox
Yikun commented on code in PR #36464: URL: https://github.com/apache/spark/pull/36464#discussion_r873426625 ## python/pyspark/pandas/groupby.py: ## @@ -2110,22 +2110,79 @@ def _limit(self, n: int, asc: bool) -> FrameLike: groupkey_scols =

[GitHub] [spark] Yikun commented on a diff in pull request #36464: [SPARK-38947][PYTHON] Supports groupby positional indexing

2022-05-14 Thread GitBox
Yikun commented on code in PR #36464: URL: https://github.com/apache/spark/pull/36464#discussion_r873100372 ## python/pyspark/pandas/groupby.py: ## @@ -2110,22 +2110,79 @@ def _limit(self, n: int, asc: bool) -> FrameLike: groupkey_scols =

[GitHub] [spark] Yikun commented on a diff in pull request #36464: [SPARK-38947][PYTHON] Supports groupby positional indexing

2022-05-14 Thread GitBox
Yikun commented on code in PR #36464: URL: https://github.com/apache/spark/pull/36464#discussion_r872956648 ## python/pyspark/pandas/groupby.py: ## @@ -2110,22 +2110,79 @@ def _limit(self, n: int, asc: bool) -> FrameLike: groupkey_scols =

[GitHub] [spark] Yikun commented on a diff in pull request #36464: [SPARK-38947][PYTHON] Supports groupby positional indexing

2022-05-14 Thread GitBox
Yikun commented on code in PR #36464: URL: https://github.com/apache/spark/pull/36464#discussion_r872956648 ## python/pyspark/pandas/groupby.py: ## @@ -2110,22 +2110,79 @@ def _limit(self, n: int, asc: bool) -> FrameLike: groupkey_scols =

[GitHub] [spark] Yikun commented on a diff in pull request #36464: [SPARK-38947][PYTHON] Supports groupby positional indexing

2022-05-14 Thread GitBox
Yikun commented on code in PR #36464: URL: https://github.com/apache/spark/pull/36464#discussion_r872956648 ## python/pyspark/pandas/groupby.py: ## @@ -2110,22 +2110,79 @@ def _limit(self, n: int, asc: bool) -> FrameLike: groupkey_scols =

[GitHub] [spark] Yikun commented on a diff in pull request #36464: [SPARK-38947][PYTHON] Supports groupby positional indexing

2022-05-14 Thread GitBox
Yikun commented on code in PR #36464: URL: https://github.com/apache/spark/pull/36464#discussion_r872956648 ## python/pyspark/pandas/groupby.py: ## @@ -2110,22 +2110,79 @@ def _limit(self, n: int, asc: bool) -> FrameLike: groupkey_scols =

[GitHub] [spark] Yikun commented on a diff in pull request #36464: [SPARK-38947][PYTHON] Supports groupby positional indexing

2022-05-14 Thread GitBox
Yikun commented on code in PR #36464: URL: https://github.com/apache/spark/pull/36464#discussion_r872956648 ## python/pyspark/pandas/groupby.py: ## @@ -2110,22 +2110,79 @@ def _limit(self, n: int, asc: bool) -> FrameLike: groupkey_scols =

[GitHub] [spark] Yikun commented on a diff in pull request #36464: [SPARK-38947][PYTHON] Supports groupby positional indexing

2022-05-14 Thread GitBox
Yikun commented on code in PR #36464: URL: https://github.com/apache/spark/pull/36464#discussion_r872956648 ## python/pyspark/pandas/groupby.py: ## @@ -2110,22 +2110,79 @@ def _limit(self, n: int, asc: bool) -> FrameLike: groupkey_scols =

[GitHub] [spark] Yikun commented on a diff in pull request #36464: [SPARK-38947][PYTHON] Supports groupby positional indexing

2022-05-11 Thread GitBox
Yikun commented on code in PR #36464: URL: https://github.com/apache/spark/pull/36464#discussion_r870137936 ## python/pyspark/pandas/groupby.py: ## @@ -2228,6 +2299,20 @@ def tail(self, n: int = 5) -> FrameLike: 65 98 Name: b, dtype: int64 + +

[GitHub] [spark] Yikun commented on a diff in pull request #36464: [SPARK-38947][PYTHON] Supports groupby positional indexing

2022-05-11 Thread GitBox
Yikun commented on code in PR #36464: URL: https://github.com/apache/spark/pull/36464#discussion_r870127549 ## python/pyspark/pandas/groupby.py: ## @@ -2121,11 +2121,22 @@ def _limit(self, n: int, asc: bool) -> FrameLike: ) ) -sdf = ( -