[GitHub] [spark] amaliujia commented on a diff in pull request #38908: [SPARK-41384][CONNECT] Should use SQLExpression for str arguments in Projection

2022-12-04 Thread GitBox
amaliujia commented on code in PR #38908: URL: https://github.com/apache/spark/pull/38908#discussion_r1039159115 ## python/pyspark/sql/connect/dataframe.py: ## @@ -137,7 +137,13 @@ def isEmpty(self) -> bool: return len(self.take(1)) == 0 def select(self, *cols: "

[GitHub] [spark] amaliujia commented on a diff in pull request #38908: [SPARK-41384][CONNECT] Should use SQLExpression for str arguments in Projection

2022-12-04 Thread GitBox
amaliujia commented on code in PR #38908: URL: https://github.com/apache/spark/pull/38908#discussion_r1039156011 ## python/pyspark/sql/connect/dataframe.py: ## @@ -137,7 +137,13 @@ def isEmpty(self) -> bool: return len(self.take(1)) == 0 def select(self, *cols: "