[GitHub] [spark] bart-samwel commented on a change in pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

2020-05-20 Thread GitBox
bart-samwel commented on a change in pull request #28534: URL: https://github.com/apache/spark/pull/28534#discussion_r427967213 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ## @@ -401,6 +401,78 @@ case class

[GitHub] [spark] bart-samwel commented on a change in pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

2020-05-20 Thread GitBox
bart-samwel commented on a change in pull request #28534: URL: https://github.com/apache/spark/pull/28534#discussion_r427884768 ## File path: sql/core/src/test/resources/sql-tests/inputs/datetime.sql ## @@ -4,6 +4,9 @@ select

[GitHub] [spark] bart-samwel commented on a change in pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

2020-05-20 Thread GitBox
bart-samwel commented on a change in pull request #28534: URL: https://github.com/apache/spark/pull/28534#discussion_r427840937 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ## @@ -401,6 +401,78 @@ case class

[GitHub] [spark] bart-samwel commented on a change in pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

2020-05-20 Thread GitBox
bart-samwel commented on a change in pull request #28534: URL: https://github.com/apache/spark/pull/28534#discussion_r427840563 ## File path: sql/core/src/test/resources/sql-tests/inputs/datetime.sql ## @@ -1,5 +1,10 @@ -- date time functions +-- [SPARK-31710]

[GitHub] [spark] bart-samwel commented on a change in pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

2020-05-20 Thread GitBox
bart-samwel commented on a change in pull request #28534: URL: https://github.com/apache/spark/pull/28534#discussion_r427818024 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ## @@ -401,6 +401,78 @@ case class