[GitHub] [spark] beliefer commented on a change in pull request #29135: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-07-17 Thread GitBox
beliefer commented on a change in pull request #29135: URL: https://github.com/apache/spark/pull/29135#discussion_r456359546 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregates.scala ## @@ -226,7 +226,10 @@ object

[GitHub] [spark] beliefer commented on a change in pull request #29135: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-07-17 Thread GitBox
beliefer commented on a change in pull request #29135: URL: https://github.com/apache/spark/pull/29135#discussion_r456363151 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/AggUtils.scala ## @@ -142,19 +142,25 @@ object AggUtils { val

[GitHub] [spark] beliefer commented on a change in pull request #29135: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-07-17 Thread GitBox
beliefer commented on a change in pull request #29135: URL: https://github.com/apache/spark/pull/29135#discussion_r456359546 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregates.scala ## @@ -226,7 +226,10 @@ object

[GitHub] [spark] beliefer commented on a change in pull request #29135: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-07-17 Thread GitBox
beliefer commented on a change in pull request #29135: URL: https://github.com/apache/spark/pull/29135#discussion_r456358235 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/ProjectFilterInAggregates.scala ## @@ -0,0 +1,193 @@ +/* + * Licensed