[GitHub] [spark] cloud-fan commented on a diff in pull request #40397: [SPARK-42052][SQL] Codegen Support for HiveSimpleUDF

2023-03-17 Thread via GitHub
cloud-fan commented on code in PR #40397: URL: https://github.com/apache/spark/pull/40397#discussion_r1140198056 ## sql/hive/src/main/scala/org/apache/spark/sql/hive/hiveUDFEvaluators.scala: ## @@ -0,0 +1,148 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [spark] cloud-fan commented on a diff in pull request #40397: [SPARK-42052][SQL] Codegen Support for HiveSimpleUDF

2023-03-17 Thread via GitHub
cloud-fan commented on code in PR #40397: URL: https://github.com/apache/spark/pull/40397#discussion_r1139899830 ## sql/hive/src/main/scala/org/apache/spark/sql/hive/hiveUDFs.scala: ## @@ -49,68 +48,137 @@ private[hive] case class HiveSimpleUDF( name: String, funcWrapper:

[GitHub] [spark] cloud-fan commented on a diff in pull request #40397: [SPARK-42052][SQL] Codegen Support for HiveSimpleUDF

2023-03-17 Thread via GitHub
cloud-fan commented on code in PR #40397: URL: https://github.com/apache/spark/pull/40397#discussion_r1139898978 ## sql/hive/src/main/scala/org/apache/spark/sql/hive/hiveUDFs.scala: ## @@ -49,68 +48,137 @@ private[hive] case class HiveSimpleUDF( name: String, funcWrapper:

[GitHub] [spark] cloud-fan commented on a diff in pull request #40397: [SPARK-42052][SQL] Codegen Support for HiveSimpleUDF

2023-03-17 Thread via GitHub
cloud-fan commented on code in PR #40397: URL: https://github.com/apache/spark/pull/40397#discussion_r1139897525 ## sql/hive/src/main/scala/org/apache/spark/sql/hive/hiveUDFs.scala: ## @@ -49,68 +48,137 @@ private[hive] case class HiveSimpleUDF( name: String, funcWrapper:

[GitHub] [spark] cloud-fan commented on a diff in pull request #40397: [SPARK-42052][SQL] Codegen Support for HiveSimpleUDF

2023-03-17 Thread via GitHub
cloud-fan commented on code in PR #40397: URL: https://github.com/apache/spark/pull/40397#discussion_r1139897200 ## sql/hive/src/main/scala/org/apache/spark/sql/hive/hiveUDFs.scala: ## @@ -49,68 +48,137 @@ private[hive] case class HiveSimpleUDF( name: String, funcWrapper:

[GitHub] [spark] cloud-fan commented on a diff in pull request #40397: [SPARK-42052][SQL] Codegen Support for HiveSimpleUDF

2023-03-17 Thread via GitHub
cloud-fan commented on code in PR #40397: URL: https://github.com/apache/spark/pull/40397#discussion_r1139896355 ## sql/hive/src/main/scala/org/apache/spark/sql/hive/hiveUDFs.scala: ## @@ -49,68 +48,137 @@ private[hive] case class HiveSimpleUDF( name: String, funcWrapper:

[GitHub] [spark] cloud-fan commented on a diff in pull request #40397: [SPARK-42052][SQL] Codegen Support for HiveSimpleUDF

2023-03-15 Thread via GitHub
cloud-fan commented on code in PR #40397: URL: https://github.com/apache/spark/pull/40397#discussion_r1137003368 ## sql/hive/src/main/scala/org/apache/spark/sql/hive/hiveUDFs.scala: ## @@ -49,68 +48,140 @@ private[hive] case class HiveSimpleUDF( name: String, funcWrapper: