[GitHub] [spark] cloud-fan commented on issue #25465: [SPARK-28747][SQL] merge the two data source v2 fallback configs

2019-08-27 Thread GitBox
cloud-fan commented on issue #25465: [SPARK-28747][SQL] merge the two data source v2 fallback configs URL: https://github.com/apache/spark/pull/25465#issuecomment-525284966 thanks for the review, merging to master! This is an

[GitHub] [spark] cloud-fan commented on issue #25465: [SPARK-28747][SQL] merge the two data source v2 fallback configs

2019-08-27 Thread GitBox
cloud-fan commented on issue #25465: [SPARK-28747][SQL] merge the two data source v2 fallback configs URL: https://github.com/apache/spark/pull/25465#issuecomment-525177530 retest this please This is an automated message from

[GitHub] [spark] cloud-fan commented on issue #25465: [SPARK-28747][SQL] merge the two data source v2 fallback configs

2019-08-25 Thread GitBox
cloud-fan commented on issue #25465: [SPARK-28747][SQL] merge the two data source v2 fallback configs URL: https://github.com/apache/spark/pull/25465#issuecomment-524737775 just an import statement conflict in `DataSourceResolution.scala`, easy to fix.

[GitHub] [spark] cloud-fan commented on issue #25465: [SPARK-28747][SQL] merge the two data source v2 fallback configs

2019-08-22 Thread GitBox
cloud-fan commented on issue #25465: [SPARK-28747][SQL] merge the two data source v2 fallback configs URL: https://github.com/apache/spark/pull/25465#issuecomment-524148603 @rdblue thanks for your review! I replied to your comment, I think we have some misunderstanding about what is the fi

[GitHub] [spark] cloud-fan commented on issue #25465: [SPARK-28747][SQL] merge the two data source v2 fallback configs

2019-08-20 Thread GitBox
cloud-fan commented on issue #25465: [SPARK-28747][SQL] merge the two data source v2 fallback configs URL: https://github.com/apache/spark/pull/25465#issuecomment-523255746 > I'm seeing a lot of renaming from USE_V1_SOURCE_READER_LIST to USE_V1_SOURCE_LIST in test classes This is th

[GitHub] [spark] cloud-fan commented on issue #25465: [SPARK-28747][SQL] merge the two data source v2 fallback configs

2019-08-16 Thread GitBox
cloud-fan commented on issue #25465: [SPARK-28747][SQL] merge the two data source v2 fallback configs URL: https://github.com/apache/spark/pull/25465#issuecomment-521922341 retest this please This is an automated message from

[GitHub] [spark] cloud-fan commented on issue #25465: [SPARK-28747][SQL] merge the two data source v2 fallback configs

2019-08-15 Thread GitBox
cloud-fan commented on issue #25465: [SPARK-28747][SQL] merge the two data source v2 fallback configs URL: https://github.com/apache/spark/pull/25465#issuecomment-521706641 cc @brkyvz @rdblue @gengliangwang This is an automa