[GitHub] [spark] cloud-fan commented on issue #25601: [SPARK-28856][SQL] Implement SHOW DATABASES for Data Source V2 Tables

2019-09-10 Thread GitBox
cloud-fan commented on issue #25601: [SPARK-28856][SQL] Implement SHOW DATABASES for Data Source V2 Tables URL: https://github.com/apache/spark/pull/25601#issuecomment-529932794 thanks, merging to master! This is an

[GitHub] [spark] cloud-fan commented on issue #25601: [SPARK-28856][SQL] Implement SHOW DATABASES for Data Source V2 Tables

2019-09-10 Thread GitBox
cloud-fan commented on issue #25601: [SPARK-28856][SQL] Implement SHOW DATABASES for Data Source V2 Tables URL: https://github.com/apache/spark/pull/25601#issuecomment-529848214 retest this please This is an automated

[GitHub] [spark] cloud-fan commented on issue #25601: [SPARK-28856][SQL] Implement SHOW DATABASES for Data Source V2 Tables

2019-09-09 Thread GitBox
cloud-fan commented on issue #25601: [SPARK-28856][SQL] Implement SHOW DATABASES for Data Source V2 Tables URL: https://github.com/apache/spark/pull/25601#issuecomment-529753449 retest this please This is an automated

[GitHub] [spark] cloud-fan commented on issue #25601: [SPARK-28856][SQL] Implement SHOW DATABASES for Data Source V2 Tables

2019-09-04 Thread GitBox
cloud-fan commented on issue #25601: [SPARK-28856][SQL] Implement SHOW DATABASES for Data Source V2 Tables URL: https://github.com/apache/spark/pull/25601#issuecomment-527891463 LGTM except some code style issues. This is an

[GitHub] [spark] cloud-fan commented on issue #25601: [SPARK-28856][SQL] Implement SHOW DATABASES for Data Source V2 Tables

2019-09-04 Thread GitBox
cloud-fan commented on issue #25601: [SPARK-28856][SQL] Implement SHOW DATABASES for Data Source V2 Tables URL: https://github.com/apache/spark/pull/25601#issuecomment-527778096 retest this please This is an automated

[GitHub] [spark] cloud-fan commented on issue #25601: [SPARK-28856][SQL] Implement SHOW DATABASES for Data Source V2 Tables

2019-08-29 Thread GitBox
cloud-fan commented on issue #25601: [SPARK-28856][SQL] Implement SHOW DATABASES for Data Source V2 Tables URL: https://github.com/apache/spark/pull/25601#issuecomment-526173979 I think we have to keep `SHOW DATABASES` for backward compatibility. We can just treat `SHOW DATABASES` as an

[GitHub] [spark] cloud-fan commented on issue #25601: [SPARK-28856][SQL] Implement SHOW DATABASES for Data Source V2 Tables

2019-08-27 Thread GitBox
cloud-fan commented on issue #25601: [SPARK-28856][SQL] Implement SHOW DATABASES for Data Source V2 Tables URL: https://github.com/apache/spark/pull/25601#issuecomment-525580222 shall we call it `SHOW NAMESPACES`? This is an