[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25463: [SPARK-28744][SQL][TEST] rename SharedSQLContext to SharedSparkSession
dongjoon-hyun commented on a change in pull request #25463:
[SPARK-28744][SQL][TEST] rename SharedSQLContext to SharedSparkSession
URL: https://github.com/apache/spark/pull/25463#discussion_r314363301
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
##
@@ -33,12 +33,12 @@ import org.apache.spark.sql.catalyst.catalog._
import org.apache.spark.sql.catalyst.catalog.CatalogTypes.TablePartitionSpec
import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.internal.StaticSQLConf.CATALOG_IMPLEMENTATION
-import org.apache.spark.sql.test.{SharedSQLContext, SQLTestUtils}
+import org.apache.spark.sql.test.{SharedSparkSession, SQLTestUtils}
import org.apache.spark.sql.types._
import org.apache.spark.util.Utils
-class InMemoryCatalogedDDLSuite extends DDLSuite with SharedSQLContext with
BeforeAndAfterEach {
Review comment:
Ah, I got it. I thought it's related. Never mind then.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25463: [SPARK-28744][SQL][TEST] rename SharedSQLContext to SharedSparkSession
dongjoon-hyun commented on a change in pull request #25463:
[SPARK-28744][SQL][TEST] rename SharedSQLContext to SharedSparkSession
URL: https://github.com/apache/spark/pull/25463#discussion_r314362751
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/binaryfile/BinaryFileFormatSuite.scala
##
@@ -34,11 +34,11 @@ import
org.apache.spark.sql.execution.datasources.PartitionedFile
import org.apache.spark.sql.functions.col
import org.apache.spark.sql.internal.SQLConf.SOURCES_BINARY_FILE_MAX_LENGTH
import org.apache.spark.sql.sources._
-import org.apache.spark.sql.test.{SharedSQLContext, SQLTestUtils}
+import org.apache.spark.sql.test.{SharedSparkSession, SQLTestUtils}
Review comment:
nit
```
- import org.apache.spark.sql.test.{SharedSparkSession, SQLTestUtils}
+ import org.apache.spark.sql.test.SharedSparkSession
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25463: [SPARK-28744][SQL][TEST] rename SharedSQLContext to SharedSparkSession
dongjoon-hyun commented on a change in pull request #25463:
[SPARK-28744][SQL][TEST] rename SharedSQLContext to SharedSparkSession
URL: https://github.com/apache/spark/pull/25463#discussion_r314357768
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/joins/HashedRelationSuite.scala
##
@@ -28,13 +28,13 @@ import org.apache.spark.memory.{TaskMemoryManager,
UnifiedMemoryManager}
import org.apache.spark.serializer.KryoSerializer
import org.apache.spark.sql.catalyst.InternalRow
import org.apache.spark.sql.catalyst.expressions._
-import org.apache.spark.sql.test.SharedSQLContext
+import org.apache.spark.sql.test.SharedSparkSession
import org.apache.spark.sql.types._
import org.apache.spark.unsafe.map.BytesToBytesMap
import org.apache.spark.unsafe.types.UTF8String
import org.apache.spark.util.collection.CompactBuffer
-class HashedRelationSuite extends SparkFunSuite with SharedSQLContext {
Review comment:
nit
```
- import org.apache.spark.{SparkConf, SparkFunSuite}
+ import org.apache.spark.SparkConf
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25463: [SPARK-28744][SQL][TEST] rename SharedSQLContext to SharedSparkSession
dongjoon-hyun commented on a change in pull request #25463:
[SPARK-28744][SQL][TEST] rename SharedSQLContext to SharedSparkSession
URL: https://github.com/apache/spark/pull/25463#discussion_r314357247
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/v2/V2SessionCatalogSuite.scala
##
@@ -30,12 +30,12 @@ import org.apache.spark.sql.catalog.v2.{Catalogs,
Identifier, TableCatalog, Tabl
import org.apache.spark.sql.catalyst.analysis.{NoSuchTableException,
TableAlreadyExistsException}
import org.apache.spark.sql.catalyst.parser.CatalystSqlParser
import org.apache.spark.sql.internal.SQLConf
-import org.apache.spark.sql.test.SharedSQLContext
+import org.apache.spark.sql.test.SharedSparkSession
import org.apache.spark.sql.types.{DoubleType, IntegerType, LongType,
StringType, StructField, StructType, TimestampType}
import org.apache.spark.sql.util.CaseInsensitiveStringMap
class V2SessionCatalogSuite
-extends SparkFunSuite with SharedSQLContext with BeforeAndAfter with
BeforeAndAfterAll {
Review comment:
nit.
```
- import org.scalatest.{BeforeAndAfter, BeforeAndAfterAll}
+ import org.scalatest.BeforeAndAfter
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25463: [SPARK-28744][SQL][TEST] rename SharedSQLContext to SharedSparkSession
dongjoon-hyun commented on a change in pull request #25463:
[SPARK-28744][SQL][TEST] rename SharedSQLContext to SharedSparkSession
URL: https://github.com/apache/spark/pull/25463#discussion_r314355321
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
##
@@ -33,12 +33,12 @@ import org.apache.spark.sql.catalyst.catalog._
import org.apache.spark.sql.catalyst.catalog.CatalogTypes.TablePartitionSpec
import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.internal.StaticSQLConf.CATALOG_IMPLEMENTATION
-import org.apache.spark.sql.test.{SharedSQLContext, SQLTestUtils}
+import org.apache.spark.sql.test.{SharedSparkSession, SQLTestUtils}
import org.apache.spark.sql.types._
import org.apache.spark.util.Utils
-class InMemoryCatalogedDDLSuite extends DDLSuite with SharedSQLContext with
BeforeAndAfterEach {
Review comment:
Shall we remove line 25?
```
import org.scalatest.BeforeAndAfterEach
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
