[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28342: [SPARK-31562][SQL] Update ExpressionDescription for substring, current_date, and current_timestamp

2020-04-25 Thread GitBox
dongjoon-hyun commented on a change in pull request #28342: URL: https://github.com/apache/spark/pull/28342#discussion_r415218045 ## File path: sql/gen-sql-functions-docs.py ## @@ -106,7 +106,7 @@ def _make_pretty_usage(infos): for info in infos: # Extracts

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28342: [SPARK-31562][SQL] Update ExpressionDescription for substring, current_date, and current_timestamp

2020-04-25 Thread GitBox
dongjoon-hyun commented on a change in pull request #28342: URL: https://github.com/apache/spark/pull/28342#discussion_r415217525 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ## @@ -83,26 +93,44 @@ case class

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28342: [SPARK-31562][SQL] Update ExpressionDescription for substring, current_date, and current_timestamp

2020-04-25 Thread GitBox
dongjoon-hyun commented on a change in pull request #28342: URL: https://github.com/apache/spark/pull/28342#discussion_r415217525 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ## @@ -83,26 +93,44 @@ case class

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28342: [SPARK-31562][SQL] Update ExpressionDescription for substring, current_date, and current_timestamp

2020-04-25 Thread GitBox
dongjoon-hyun commented on a change in pull request #28342: URL: https://github.com/apache/spark/pull/28342#discussion_r415217525 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ## @@ -83,26 +93,44 @@ case class

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28342: [SPARK-31562][SQL] Update ExpressionDescription for substring, current_date, and current_timestamp

2020-04-25 Thread GitBox
dongjoon-hyun commented on a change in pull request #28342: URL: https://github.com/apache/spark/pull/28342#discussion_r415215025 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ## @@ -83,26 +93,44 @@ case class

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28342: [SPARK-31562][SQL] Update ExpressionDescription for substring, current_date, and current_timestamp

2020-04-25 Thread GitBox
dongjoon-hyun commented on a change in pull request #28342: URL: https://github.com/apache/spark/pull/28342#discussion_r415098375 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ## @@ -83,26 +93,44 @@ case class