dongjoon-hyun commented on code in PR #38912:
URL: https://github.com/apache/spark/pull/38912#discussion_r1039267464
##########
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocatorSuite.scala:
##########
@@ -721,8 +722,10 @@ class ExecutorPodsAllocatorSuite extends SparkFunSuite
with BeforeAndAfter {
.set(s"$prefix.option.sizeLimit", "200Gi")
.set(s"$prefix.option.storageClass", "gp2")
- when(persistentVolumeClaimList.getItems)
- .thenReturn(Seq(persistentVolumeClaim("pvc-0", "gp2", "200Gi")).asJava)
+ val pvc = persistentVolumeClaim("pvc-0", "gp2", "200Gi")
+ pvc.getMetadata
+ .setCreationTimestamp(Instant.now().minus(podAllocationDelay + 1,
MILLIS).toString)
Review Comment:
This is a previous test case for `SPARK-35416: Support PersistentVolumeClaim
Reuse`.
Since our test framework does't fill `CreationTimestamp`, this PR added it
properly.
-
https://github.com/apache/spark/blob/94829065f677221938d00f77e60a07bcccecf9d4/resource-managers/kubernetes/core/src/test/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorLifecycleTestUtils.scala#L224-L227
##########
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocatorSuite.scala:
##########
@@ -721,8 +722,10 @@ class ExecutorPodsAllocatorSuite extends SparkFunSuite
with BeforeAndAfter {
.set(s"$prefix.option.sizeLimit", "200Gi")
.set(s"$prefix.option.storageClass", "gp2")
- when(persistentVolumeClaimList.getItems)
- .thenReturn(Seq(persistentVolumeClaim("pvc-0", "gp2", "200Gi")).asJava)
+ val pvc = persistentVolumeClaim("pvc-0", "gp2", "200Gi")
+ pvc.getMetadata
+ .setCreationTimestamp(Instant.now().minus(podAllocationDelay + 1,
MILLIS).toString)
Review Comment:
This is a previous test case for `SPARK-35416: Support PersistentVolumeClaim
Reuse`.
Since our test framework does't fill `CreationTimestamp`, this PR added it
properly.
https://github.com/apache/spark/blob/94829065f677221938d00f77e60a07bcccecf9d4/resource-managers/kubernetes/core/src/test/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorLifecycleTestUtils.scala#L224-L227
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
