[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #40444: [SPARK-42813][K8S] Print application info when waitAppCompletion is false
dongjoon-hyun commented on code in PR #40444:
URL: https://github.com/apache/spark/pull/40444#discussion_r1137906960
##
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/LoggingPodStatusWatcher.scala:
##
@@ -95,8 +95,8 @@ private[k8s] class LoggingPodStatusWatcherImpl(conf:
KubernetesDriverConf)
this.notifyAll()
}
- override def watchOrStop(sId: String): Boolean = if
(conf.get(WAIT_FOR_APP_COMPLETION)) {
-logInfo(s"Waiting for application ${conf.appName} with submission ID $sId
to finish...")
+ override def watchOrStop(sId: String): Boolean = {
+logInfo(s"Waiting for application ${conf.appId} with submission ID $sId to
finish...")
Review Comment:
Got it. Now, I understand what you meant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #40444: [SPARK-42813][K8S] Print application info when waitAppCompletion is false
dongjoon-hyun commented on code in PR #40444:
URL: https://github.com/apache/spark/pull/40444#discussion_r1137331510
##
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/LoggingPodStatusWatcher.scala:
##
@@ -95,8 +95,8 @@ private[k8s] class LoggingPodStatusWatcherImpl(conf:
KubernetesDriverConf)
this.notifyAll()
}
- override def watchOrStop(sId: String): Boolean = if
(conf.get(WAIT_FOR_APP_COMPLETION)) {
-logInfo(s"Waiting for application ${conf.appName} with submission ID $sId
to finish...")
+ override def watchOrStop(sId: String): Boolean = {
+logInfo(s"Waiting for application ${conf.appId} with submission ID $sId to
finish...")
Review Comment:
This part is SPARK-24266 instead of SPARK-35174. This change looks risky to
me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #40444: [SPARK-42813][K8S] Print application info when waitAppCompletion is false
dongjoon-hyun commented on code in PR #40444:
URL: https://github.com/apache/spark/pull/40444#discussion_r1137331510
##
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/LoggingPodStatusWatcher.scala:
##
@@ -95,8 +95,8 @@ private[k8s] class LoggingPodStatusWatcherImpl(conf:
KubernetesDriverConf)
this.notifyAll()
}
- override def watchOrStop(sId: String): Boolean = if
(conf.get(WAIT_FOR_APP_COMPLETION)) {
-logInfo(s"Waiting for application ${conf.appName} with submission ID $sId
to finish...")
+ override def watchOrStop(sId: String): Boolean = {
+logInfo(s"Waiting for application ${conf.appId} with submission ID $sId to
finish...")
Review Comment:
This part is SPARK-24266 instead of `SPARK-35174`. This change looks risky
to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
