[GitHub] [spark] dongjoon-hyun commented on issue #24902: [SPARK-28093][SQL] Fix TRIM/LTRIM/RTRIM function parameter order issue

2020-02-14 Thread GitBox
dongjoon-hyun commented on issue #24902: [SPARK-28093][SQL] Fix TRIM/LTRIM/RTRIM function parameter order issue URL: https://github.com/apache/spark/pull/24902#issuecomment-586388074 I also don't want to block 3.0 release. If you guys are reluctant to send it officially, let me summarize t

[GitHub] [spark] dongjoon-hyun commented on issue #24902: [SPARK-28093][SQL] Fix TRIM/LTRIM/RTRIM function parameter order issue

2020-02-13 Thread GitBox
dongjoon-hyun commented on issue #24902: [SPARK-28093][SQL] Fix TRIM/LTRIM/RTRIM function parameter order issue URL: https://github.com/apache/spark/pull/24902#issuecomment-586019446 What Matei said is `cosmetic change` instead of bug fixes, isn't it? > Given this, I think that any cosme

[GitHub] [spark] dongjoon-hyun commented on issue #24902: [SPARK-28093][SQL] Fix TRIM/LTRIM/RTRIM function parameter order issue

2020-02-11 Thread GitBox
dongjoon-hyun commented on issue #24902: [SPARK-28093][SQL] Fix TRIM/LTRIM/RTRIM function parameter order issue URL: https://github.com/apache/spark/pull/24902#issuecomment-585042944 Yes. I'm not against for your decision. What I'm asking is that let's do this in a public manner if we make

[GitHub] [spark] dongjoon-hyun commented on issue #24902: [SPARK-28093][SQL] Fix TRIM/LTRIM/RTRIM function parameter order issue

2020-02-11 Thread GitBox
dongjoon-hyun commented on issue #24902: [SPARK-28093][SQL] Fix TRIM/LTRIM/RTRIM function parameter order issue URL: https://github.com/apache/spark/pull/24902#issuecomment-584768114 @cloud-fan . SQL Syntax and function is not the same. Why do we need to follow that? > More importantly,

[GitHub] [spark] dongjoon-hyun commented on issue #24902: [SPARK-28093][SQL] Fix TRIM/LTRIM/RTRIM function parameter order issue

2019-06-19 Thread GitBox
dongjoon-hyun commented on issue #24902: [SPARK-28093][SQL] Fix TRIM/LTRIM/RTRIM function parameter order issue URL: https://github.com/apache/spark/pull/24902#issuecomment-503597391 Thank you, @srowen ! This is an automated

[GitHub] [spark] dongjoon-hyun commented on issue #24902: [SPARK-28093][SQL] Fix TRIM/LTRIM/RTRIM function parameter order issue

2019-06-18 Thread GitBox
dongjoon-hyun commented on issue #24902: [SPARK-28093][SQL] Fix TRIM/LTRIM/RTRIM function parameter order issue URL: https://github.com/apache/spark/pull/24902#issuecomment-503300167 Could you make two backporting PRs for branch-2.4 and branch-2.3, @wangyum ? There exist conflicts at `st