[GitHub] [spark] dongjoon-hyun commented on issue #27184: [SPARK-28152][SQL][FOLLOWUP] Add a legacy conf for old MsSqlServerDialect numeric mapping

2020-01-15 Thread GitBox
dongjoon-hyun commented on issue #27184: [SPARK-28152][SQL][FOLLOWUP] Add a 
legacy conf for old MsSqlServerDialect numeric mapping
URL: https://github.com/apache/spark/pull/27184#issuecomment-574968455
 
 
   BTW, @gatorsmile . If you have any concern on 2.4.5 RC1, could you vote on 
the mailing list like @cloud-fan ? I want to collect all feedback.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] dongjoon-hyun commented on issue #27184: [SPARK-28152][SQL][FOLLOWUP] Add a legacy conf for old MsSqlServerDialect numeric mapping

2020-01-12 Thread GitBox
dongjoon-hyun commented on issue #27184: [SPARK-28152][SQL][FOLLOWUP] Add a 
legacy conf for old MsSqlServerDialect numeric mapping
URL: https://github.com/apache/spark/pull/27184#issuecomment-573532081
 
 
   All Scala/Java test passed and the PySpark failure is due to a known 
`test_memory_limit (pyspark.tests.test_worker.WorkerMemoryTest)` flakiness. I 
also verified this in JDBC integration test manually. I'll merge this PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] dongjoon-hyun commented on issue #27184: [SPARK-28152][SQL][FOLLOWUP] Add a legacy conf for old MsSqlServerDialect numeric mapping

2020-01-12 Thread GitBox
dongjoon-hyun commented on issue #27184: [SPARK-28152][SQL][FOLLOWUP] Add a 
legacy conf for old MsSqlServerDialect numeric mapping
URL: https://github.com/apache/spark/pull/27184#issuecomment-573528380
 
 
   Thank you for review and approval, @HyukjinKwon !


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] dongjoon-hyun commented on issue #27184: [SPARK-28152][SQL][FOLLOWUP] Add a legacy conf for old MsSqlServerDialect numeric mapping

2020-01-12 Thread GitBox
dongjoon-hyun commented on issue #27184: [SPARK-28152][SQL][FOLLOWUP] Add a 
legacy conf for old MsSqlServerDialect numeric mapping
URL: https://github.com/apache/spark/pull/27184#issuecomment-573515240
 
 
   cc @shivsood , @HyukjinKwon , @maropu , @srowen , @gatorsmile , @zsxwing 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org