[GitHub] [spark] itholic commented on a diff in pull request #38664: [SPARK-41147][SQL] Assign a name to the legacy error class `_LEGACY_ERROR_TEMP_1042`

itholic commented on code in PR #38664: URL: https://github.com/apache/spark/pull/38664#discussion_r1040452617 ## sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala: ## @@ -637,17 +637,21 @@ private[sql] object QueryCompilationErrors extends

[GitHub] [spark] itholic commented on a diff in pull request #38664: [SPARK-41147][SQL] Assign a name to the legacy error class `_LEGACY_ERROR_TEMP_1042`

itholic commented on code in PR #38664: URL: https://github.com/apache/spark/pull/38664#discussion_r1034604147 ## sql/core/src/test/resources/sql-tests/results/ansi/string-functions.sql.out: ## @@ -848,7 +849,8 @@ org.apache.spark.sql.AnalysisException "messageParameters" :

[GitHub] [spark] itholic commented on a diff in pull request #38664: [SPARK-41147][SQL] Assign a name to the legacy error class `_LEGACY_ERROR_TEMP_1042`

itholic commented on code in PR #38664: URL: https://github.com/apache/spark/pull/38664#discussion_r1028813303 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala: ## @@ -146,7 +147,10 @@ object FunctionRegistryBase {