[GitHub] [spark] jiangxb1987 commented on a change in pull request #27002: [SPARK-30346][CORE]Improve logging when events dropped
jiangxb1987 commented on a change in pull request #27002:
[SPARK-30346][CORE]Improve logging when events dropped
URL: https://github.com/apache/spark/pull/27002#discussion_r379709740
##
File path: core/src/main/scala/org/apache/spark/scheduler/AsyncEventQueue.scala
##
@@ -167,22 +170,19 @@ private class AsyncEventQueue(
}
logTrace(s"Dropping event $event")
-val droppedCount = droppedEventsCounter.get
-if (droppedCount > 0) {
- // Don't log too frequently
- if (System.currentTimeMillis() - lastReportTimestamp >= 60 * 1000) {
-// There may be multiple threads trying to decrease
droppedEventsCounter.
-// Use "compareAndSet" to make sure only one thread can win.
-// And if another thread is increasing droppedEventsCounter,
"compareAndSet" will fail and
-// then that thread will update it.
-if (droppedEventsCounter.compareAndSet(droppedCount, 0)) {
- val prevLastReportTimestamp = lastReportTimestamp
- lastReportTimestamp = System.currentTimeMillis()
- val previous = new java.util.Date(prevLastReportTimestamp)
+val droppedCount = droppedEventsCounter.get - lastDroppedEventsCounter
+val lastReportTime = lastReportTimestamp.get
+val curTime = System.currentTimeMillis()
+// Don't log too frequently
+if (droppedCount > 0 && curTime - lastReportTime >= LOGGING_INTERVAL) {
+// There may be multiple threads trying to logging dropped events,
+// Use 'compareAndSet' to make sure only one thread can win.
+if (lastReportTimestamp.compareAndSet(lastReportTime, curTime)) {
+ val previous = new java.util.Date(lastReportTime)
+ lastDroppedEventsCounter = droppedCount
Review comment:
IIUC this should be reset to `droppedEventsCounter.get` ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] jiangxb1987 commented on a change in pull request #27002: [SPARK-30346][CORE]Improve logging when events dropped
jiangxb1987 commented on a change in pull request #27002:
[SPARK-30346][CORE]Improve logging when events dropped
URL: https://github.com/apache/spark/pull/27002#discussion_r379206377
##
File path: core/src/main/scala/org/apache/spark/scheduler/AsyncEventQueue.scala
##
@@ -167,20 +170,29 @@ private class AsyncEventQueue(
}
logTrace(s"Dropping event $event")
-val droppedCount = droppedEventsCounter.get
+val droppedCount = droppedEventsCounter.get - lastDroppedEventsCounter
+val lastReportTime = lastReportTimestamp.get
+val curTime = System.currentTimeMillis()
if (droppedCount > 0) {
// Don't log too frequently
- if (System.currentTimeMillis() - lastReportTimestamp >= 60 * 1000) {
-// There may be multiple threads trying to decrease
droppedEventsCounter.
-// Use "compareAndSet" to make sure only one thread can win.
-// And if another thread is increasing droppedEventsCounter,
"compareAndSet" will fail and
-// then that thread will update it.
-if (droppedEventsCounter.compareAndSet(droppedCount, 0)) {
Review comment:
Can we just remove this check and use `droppedEventsCounter.getAndSet()`
instead?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] jiangxb1987 commented on a change in pull request #27002: [SPARK-30346][CORE]Improve logging when events dropped
jiangxb1987 commented on a change in pull request #27002:
[SPARK-30346][CORE]Improve logging when events dropped
URL: https://github.com/apache/spark/pull/27002#discussion_r379206377
##
File path: core/src/main/scala/org/apache/spark/scheduler/AsyncEventQueue.scala
##
@@ -167,20 +170,29 @@ private class AsyncEventQueue(
}
logTrace(s"Dropping event $event")
-val droppedCount = droppedEventsCounter.get
+val droppedCount = droppedEventsCounter.get - lastDroppedEventsCounter
+val lastReportTime = lastReportTimestamp.get
+val curTime = System.currentTimeMillis()
if (droppedCount > 0) {
// Don't log too frequently
- if (System.currentTimeMillis() - lastReportTimestamp >= 60 * 1000) {
-// There may be multiple threads trying to decrease
droppedEventsCounter.
-// Use "compareAndSet" to make sure only one thread can win.
-// And if another thread is increasing droppedEventsCounter,
"compareAndSet" will fail and
-// then that thread will update it.
-if (droppedEventsCounter.compareAndSet(droppedCount, 0)) {
Review comment:
Can we just remove this check and use `droppedEventsCounter.getAndSet()`
instead?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
