karuppayya commented on pull request #28715:
URL: https://github.com/apache/spark/pull/28715#issuecomment-802051267
@viirya Thanks for triggering the tests. @maropu I have handled the comment
and the test are passing now.
--
This is an automated message from the Apache Git Service.
To
karuppayya commented on pull request #28715:
URL: https://github.com/apache/spark/pull/28715#issuecomment-801233015
@cloud-fan @maropu @tanelk PR is ready to merge.
This is an automated message from the Apache Git Service.
karuppayya commented on pull request #28715:
URL: https://github.com/apache/spark/pull/28715#issuecomment-797145478
@tanelk I have added the benchmark results.
This is an automated message from the Apache Git Service.
To
karuppayya commented on pull request #28715:
URL: https://github.com/apache/spark/pull/28715#issuecomment-796278694
Added the benchmark using the benchmark infra. It tests with codegen on and
off .
Since there is no way to disable codegen only for GenerateExec, disabling
codegen will
karuppayya commented on pull request #28715:
URL: https://github.com/apache/spark/pull/28715#issuecomment-670251884
@maropu @cloud-fan @kiszk
Can you please help review this change?
Do you see any issues with the PR
karuppayya commented on pull request #28715:
URL: https://github.com/apache/spark/pull/28715#issuecomment-653599420
@maropu @cloud-fan @HyukjinKwon Do you have any other comments for the PR?
What else can I do in it to be merged?
karuppayya commented on pull request #28715:
URL: https://github.com/apache/spark/pull/28715#issuecomment-647234069
@maropu @cloud-fan Can you please help review the changes.
This is an automated message from the Apache Git
karuppayya commented on pull request #28715:
URL: https://github.com/apache/spark/pull/28715#issuecomment-645572648
Ready for review @maropu @cloud-fan
This is an automated message from the Apache Git Service.
To respond to
karuppayya commented on pull request #28715:
URL: https://github.com/apache/spark/pull/28715#issuecomment-644546701
@maropu Updated the description with benchmarks.
This is an automated message from the Apache Git Service.
karuppayya commented on pull request #28715:
URL: https://github.com/apache/spark/pull/28715#issuecomment-644260009
@cloud-fan @maropu I have fixed the tests. Can you please take a look again.
Thanks
This is an automated
karuppayya commented on pull request #28715:
URL: https://github.com/apache/spark/pull/28715#issuecomment-642439230
The test failure doesnt seem related to this change.
This is an automated message from the Apache Git
karuppayya commented on pull request #28715:
URL: https://github.com/apache/spark/pull/28715#issuecomment-639899181
@viirya @cloud-fan Can you please help review this PR
This is an automated message from the Apache Git
karuppayya commented on pull request #28715:
URL: https://github.com/apache/spark/pull/28715#issuecomment-638637169
@dongjoon-hyun @gatorsmile @cloud-fan can anyone help review this change?
Thanks
This is an automated
karuppayya commented on pull request #28715:
URL: https://github.com/apache/spark/pull/28715#issuecomment-637958350
@rxin The codegen was disabled in
https://github.com/apache/spark/commit/b5c5bd98ea5e8dbfebcf86c5459bdf765f5ceb53.
If you happen to remember the scenario for workload
14 matches
Mail list logo
