mengxr commented on issue #27546: [SPARK-30773][ML]Support NativeBlas for
level-1 routines
URL: https://github.com/apache/spark/pull/27546#issuecomment-600185011
I'm fine with merging into 3.0 too.
This is an automated messag
mengxr commented on issue #27546: [SPARK-30773][ML]Support NativeBlas for
level-1 routines
URL: https://github.com/apache/spark/pull/27546#issuecomment-599577586
jenkins, test this please
This is an automated message from the
mengxr commented on issue #27546: [SPARK-30773][ML]Support NativeBlas for
level-1 routines
URL: https://github.com/apache/spark/pull/27546#issuecomment-599368497
LGTM. Could you add some tests to cover both <256 and >=256 cases?
-
mengxr commented on issue #27546: [SPARK-30773][ML]Support NativeBlas for
level-1 routines
URL: https://github.com/apache/spark/pull/27546#issuecomment-595595323
@yma11 You also need to try old generation CPUs / RAMs to confirm 256 is
absolutely safe. We cannot assume all users are on the
mengxr commented on issue #27546: [SPARK-30773][ML]Support NativeBlas for
level-1 routines
URL: https://github.com/apache/spark/pull/27546#issuecomment-595592042
I'm okay with a hardcoded constant. We are start with a safer one, say 512,
if there are concerns around environment differences
mengxr commented on issue #27546: [SPARK-30773][ML]Support NativeBlas for
level-1 routines
URL: https://github.com/apache/spark/pull/27546#issuecomment-587132383
@yma11 Thanks for re-running the benchmark! Could you confirm whether AVX is
used by MKL/OpenBLAS? I think that is why it is fas
mengxr commented on issue #27546: [SPARK-30773][ML]Support NativeBlas for
level-1 routines
URL: https://github.com/apache/spark/pull/27546#issuecomment-586387070
Please also limit the blas threads to 1 because one core per task is the
common setting.
--
mengxr commented on issue #27546: [SPARK-30773][ML]Support NativeBlas for
level-1 routines
URL: https://github.com/apache/spark/pull/27546#issuecomment-585864274
Could you provide reproducible microbenchmark results for both OpenBLAS and
MKL on arrays of different sizes? Last time we teste
