[GitHub] [spark] ocworld commented on pull request #38828: [SPARK-35084][CORE] Spark 3: supporting --packages in k8s client mode with the driver running inside a POD
ocworld commented on PR #38828: URL: https://github.com/apache/spark/pull/38828#issuecomment-1381749296 > First of all thanks for the fix! There is some tiny things but the code is fine. > > Please also fix the PR title "cluster mode" => "client mode with the driver running inside a POD". Thanks you for your review. Except variable name "isKubernetesClusterModeDriver", every your comments is applied. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] ocworld commented on pull request #38828: [SPARK-35084][CORE] Spark 3: supporting --packages in k8s client mode with the driver running inside a POD
ocworld commented on PR #38828: URL: https://github.com/apache/spark/pull/38828#issuecomment-1381740448 > First of all thanks for the fix! There is some tiny things but the code is fine. > > Please also fix the PR title "cluster mode" => "client mode with the driver running inside a POD". this pr title is fixed now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
