[GitHub] [spark] peter-toth commented on pull request #29737: [SPARK-32864][SQL] Support ORC forced positional evolution

2021-01-15 Thread GitBox


peter-toth commented on pull request #29737:
URL: https://github.com/apache/spark/pull/29737#issuecomment-760807396


   Thanks @dongjoon-hyun and all for the review.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] peter-toth commented on pull request #29737: [SPARK-32864][SQL] Support ORC forced positional evolution

2020-10-09 Thread GitBox


peter-toth commented on pull request #29737:
URL: https://github.com/apache/spark/pull/29737#issuecomment-705340785







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] peter-toth commented on pull request #29737: [SPARK-32864][SQL] Support ORC forced positional evolution

2020-10-08 Thread GitBox


peter-toth commented on pull request #29737:
URL: https://github.com/apache/spark/pull/29737#issuecomment-705421777


   retest this please



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] peter-toth commented on pull request #29737: [SPARK-32864][SQL] Support ORC forced positional evolution

2020-10-07 Thread GitBox


peter-toth commented on pull request #29737:
URL: https://github.com/apache/spark/pull/29737#issuecomment-705346151


   > which ORC version spark is using?
   
   We started to use 1.5.12 recently:
   
https://github.com/apache/spark/commit/aa6657981aefae8067672d2c99ca560b6179b723



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] peter-toth commented on pull request #29737: [SPARK-32864][SQL] Support ORC forced positional evolution

2020-10-07 Thread GitBox


peter-toth commented on pull request #29737:
URL: https://github.com/apache/spark/pull/29737#issuecomment-705340785


   @dongjoon-hyun, @cloud-fan those 2 issues has been solved in ORC 1.5.12. Do 
you think we can resume this PR?
   
   @cloud-fan, I understand that this PR doesn't give a full blown schema 
evolution support natively in Spark, but it would definitely help a few users 
who has been using this flag in Hive and would like to use the same in Spark 
too.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] peter-toth commented on pull request #29737: [SPARK-32864][SQL] Support ORC forced positional evolution

2020-09-21 Thread GitBox


peter-toth commented on pull request #29737:
URL: https://github.com/apache/spark/pull/29737#issuecomment-696277091


   All right, thanks @dongjoon-hyun for the details. I guess I should close 
this PR for now.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] peter-toth commented on pull request #29737: [SPARK-32864][SQL] Support ORC forced positional evolution

2020-09-21 Thread GitBox


peter-toth commented on pull request #29737:
URL: https://github.com/apache/spark/pull/29737#issuecomment-696277091


   All right, thanks @dongjoon-hyun for the details. I guess I should close 
this PR for now.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] peter-toth commented on pull request #29737: [SPARK-32864][SQL] Support ORC forced positional evolution

2020-09-18 Thread GitBox


peter-toth commented on pull request #29737:
URL: https://github.com/apache/spark/pull/29737#issuecomment-694741458


   retest this please



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] peter-toth commented on pull request #29737: [SPARK-32864][SQL] Support ORC forced positional evolution

2020-09-18 Thread GitBox


peter-toth commented on pull request #29737:
URL: https://github.com/apache/spark/pull/29737#issuecomment-694741165


   cc @cloud-fan, @dongjoon-hyun, @maropu, @viirya 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] peter-toth commented on pull request #29737: [SPARK-32864][SQL] Support ORC forced positional evolution

2020-09-14 Thread GitBox


peter-toth commented on pull request #29737:
URL: https://github.com/apache/spark/pull/29737#issuecomment-692043158


   Thanks @HyukjinKwon.
   
   @dongjoon-hyun could you please take a look at this PR?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org