prakharjain09 commented on pull request #28619:
URL: https://github.com/apache/spark/pull/28619#issuecomment-647520238
@holdenk @cloud-fan @Dooyoung-Hwang Please review the changes.
This is an automated message from the
prakharjain09 commented on pull request #28619:
URL: https://github.com/apache/spark/pull/28619#issuecomment-644630254
@holdenk @cloud-fan @Dooyoung-Hwang Please review the changes.
This is an automated message from the
prakharjain09 commented on pull request #28619:
URL: https://github.com/apache/spark/pull/28619#issuecomment-644163889
@attilapiros Thanks for the review.
> One more question: the checkAndSubmitSpeculatableTask checks whether the
number of running copies from the task is one:
prakharjain09 commented on pull request #28619:
URL: https://github.com/apache/spark/pull/28619#issuecomment-641023747
@holdenk @jiangxb1987 Please review the changes.
> LGTM expect 2 minor comments, cc @holdenk @jiangxb1987
prakharjain09 commented on pull request #28619:
URL: https://github.com/apache/spark/pull/28619#issuecomment-639537399
@holdenk @cloud-fan Please review the changes.
This is an automated message from the Apache Git Service.
prakharjain09 commented on pull request #28619:
URL: https://github.com/apache/spark/pull/28619#issuecomment-637406699
@Ngone51 I have addressed all the review comments. Can you please take a
look at this PR?
This is an
prakharjain09 commented on pull request #28619:
URL: https://github.com/apache/spark/pull/28619#issuecomment-634089533
@Ngone51 Thanks for the review.
> BTW, what do we do for those tasks if speculative is disabled? Waiting for
executor lost action?
If speculation is disabled,
