sathiyapk commented on pull request #34729:
URL: https://github.com/apache/spark/pull/34729#issuecomment-1046671444
thanks !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
sathiyapk commented on pull request #34729:
URL: https://github.com/apache/spark/pull/34729#issuecomment-1006166881
@cloud-fan Any idea why we getting
` Failed to execute goal net.alchim31.maven:scala-maven-plugin:4.3.0:doc-jar
(attach-scaladocs) on project spark-catalyst_2.12:
sathiyapk commented on pull request #34729:
URL: https://github.com/apache/spark/pull/34729#issuecomment-1005515564
@cloud-fan Do you have any other comments regarding this PR, please ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
sathiyapk commented on pull request #34729:
URL: https://github.com/apache/spark/pull/34729#issuecomment-995823221
@viirya Thanks for your comments. I've added `ExpressionBuilder` for
`ceil`/`floor` and added enough test cases in `MathFunctionsSuite`. I think we
can add some unit tests to
sathiyapk commented on pull request #34729:
URL: https://github.com/apache/spark/pull/34729#issuecomment-994986136
@cloud-fan @gengliangwang @sarutak @HyukjinKwon Do you have any comments
regarding this PR, please ? I think i need to add few unit-tests regarding the
sql struct-type with 2
sathiyapk commented on pull request #34729:
URL: https://github.com/apache/spark/pull/34729#issuecomment-981165573
```
19:40:16.643 ERROR org.apache.spark.sql.SQLQueryTestSuite: Error using
configs:
[info] - describe-table-column.sql *** FAILED *** (1 second, 385
milliseconds)
